[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

[Bjørn Forsman]

The Buildroot documentation says it's OK to use upper case names for
$(PKG)_SITE_METHOD, but the implementation does not support it. This
patch adds support for both upper and lower case names.

Signed-off-by: Bj?rn Forsman <bjorn.forsman@gmail.com>
---
 package/Makefile.package.in |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/package/Makefile.package.in b/package/Makefile.package.in
index 92ce4e2..9a327c6 100644
--- a/package/Makefile.package.in
+++ b/package/Makefile.package.in
@@ -189,9 +189,9 @@ define DOWNLOAD
 	fi ; \
 	if test -n "$(1)" ; then \
 		case "$($(PKG)_SITE_METHOD)" in \
-			git) $($(DL_MODE)_GIT) && exit ;; \
-			svn) $($(DL_MODE)_SVN) && exit ;; \
-			bzr) $($(DL_MODE)_BZR) && exit ;; \
+			git|GIT) $($(DL_MODE)_GIT) && exit ;; \
+			svn|SVN) $($(DL_MODE)_SVN) && exit ;; \
+			bzr|BZR) $($(DL_MODE)_BZR) && exit ;; \
 			*) $(call $(DL_MODE)_WGET,$(1),$(2)) && exit ;; \
 		esac ; \
 	fi ; \
-- 
1.7.1

[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

[Daniel Nyström]

2011/1/31 Bj?rn Forsman <bjorn.forsman@gmail.com>:
> The Buildroot documentation says it's OK to use upper case names for
> $(PKG)_SITE_METHOD, but the implementation does not support it. This
> patch adds support for both upper and lower case names.

In my opinion changing the documentation is a better way to go since
it would make the mk files uniformed.

[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

[Bjørn Forsman]

On 31 January 2011 23:30, Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:
> 2011/1/31 Bj?rn Forsman <bjorn.forsman@gmail.com>:
>> The Buildroot documentation says it's OK to use upper case names for
>> $(PKG)_SITE_METHOD, but the implementation does not support it. This
>> patch adds support for both upper and lower case names.
>
> In my opinion changing the documentation is a better way to go since
> it would make the mk files uniformed.

I'm not sure I understand what you mean by "uniformed". Can you give an example?

My idea of uniform .mk files would actually be to use upper case, as
there is already lots of upper case in BR. Am I wrong?

[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

[Daniel Nyström]

2011/1/31 Bj?rn Forsman <bjorn.forsman@gmail.com>:
> On 31 January 2011 23:30, Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:
>> 2011/1/31 Bj?rn Forsman <bjorn.forsman@gmail.com>:
>>> The Buildroot documentation says it's OK to use upper case names for
>>> $(PKG)_SITE_METHOD, but the implementation does not support it. This
>>> patch adds support for both upper and lower case names.
>>
>> In my opinion changing the documentation is a better way to go since
>> it would make the mk files uniformed.
>
> I'm not sure I understand what you mean by "uniformed". Can you give an example?
>
> My idea of uniform .mk files would actually be to use upper case, as
> there is already lots of upper case in BR. Am I wrong?

You're absolutely right, upper case seems to be most common. But it
also seems like no other options (for example PKG_INSTALL_STAGING)
handles both upper and lower case which I consider a good thing since
it's what makes the mk files uniformed. :)
See: http://git.buildroot.net/buildroot/tree/package/Makefile.package.in#n454

[Buildroot] [PATCH] Makefile.package.in: accept upper case $(PKG)_SITE_METHOD as well

[Bjørn Forsman]

On 1 February 2011 08:59, Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:
> 2011/1/31 Bj?rn Forsman <bjorn.forsman@gmail.com>:
>> On 31 January 2011 23:30, Daniel Nystr?m <daniel.nystrom@timeterminal.se> wrote:
>>> 2011/1/31 Bj?rn Forsman <bjorn.forsman@gmail.com>:
>>>> The Buildroot documentation says it's OK to use upper case names for
>>>> $(PKG)_SITE_METHOD, but the implementation does not support it. This
>>>> patch adds support for both upper and lower case names.
>>>
>>> In my opinion changing the documentation is a better way to go since
>>> it would make the mk files uniformed.
>>
>> I'm not sure I understand what you mean by "uniformed". Can you give an example?
>>
>> My idea of uniform .mk files would actually be to use upper case, as
>> there is already lots of upper case in BR. Am I wrong?
>
> You're absolutely right, upper case seems to be most common. But it
> also seems like no other options (for example PKG_INSTALL_STAGING)
> handles both upper and lower case which I consider a good thing since
> it's what makes the mk files uniformed. :)
> See: http://git.buildroot.net/buildroot/tree/package/Makefile.package.in#n454

All right, I'll resend. Ignore this patch then.