All of lore.kernel.org
 help / color / mirror / Atom feed
* [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem.
@ 2010-11-30 16:29 Will Newton
  2010-12-07 11:21 ` Will Newton
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2010-11-30 16:29 UTC (permalink / raw)
  To: buildroot

oprofile needs libbfd, but does not require all the binutils tools
installing in the target filesystem. This saves a lot of space
on the target filesystem.

Signed-off-by: Will Newton <will.newton@imgtec.com>
---
 package/oprofile/oprofile.mk   |    2 +-
 toolchain/binutils/binutils.mk |    2 ++
 2 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/package/oprofile/oprofile.mk b/package/oprofile/oprofile.mk
index 3be50f2..7281c8f 100644
--- a/package/oprofile/oprofile.mk
+++ b/package/oprofile/oprofile.mk
@@ -24,7 +24,7 @@ ifeq ($(OPROFILE_ARCH),)
 OPROFILE_ARCH := $(BR2_ARCH)
 endif

-OPROFILE_DEPENDENCIES := popt binutils_target
+OPROFILE_DEPENDENCIES := popt libbfd_target

 define OPROFILE_INSTALL_TARGET_CMDS
 	$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/bin
diff --git a/toolchain/binutils/binutils.mk b/toolchain/binutils/binutils.mk
index ef9f644..de8f865 100644
--- a/toolchain/binutils/binutils.mk
+++ b/toolchain/binutils/binutils.mk
@@ -172,6 +172,8 @@ endif

 binutils_target: $(BINUTILS_TARGET_PREREQ) $(TARGET_DIR)/usr/bin/ld

+libbfd_target: $(BINUTILS_DIR2)/binutils/objdump
+
 binutils_target-clean:
 	-$(MAKE) -C $(BINUTILS_DIR2) clean
 	rm -f $(TARGET_DIR)/bin/$(REAL_GNU_TARGET_NAME)* \
-- 
1.7.2.2
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-oprofile-Don-t-install-binutils-in-the-target-filesy.patch
Type: text/x-patch
Size: 1466 bytes
Desc: not available
URL: <http://lists.busybox.net/pipermail/buildroot/attachments/20101130/fed31fce/attachment.bin>

^ permalink raw reply related	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem.
  2010-11-30 16:29 [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem Will Newton
@ 2010-12-07 11:21 ` Will Newton
  2010-12-07 18:58   ` Thomas Petazzoni
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2010-12-07 11:21 UTC (permalink / raw)
  To: buildroot

On Tue, Nov 30, 2010 at 4:29 PM, Will Newton <will.newton@gmail.com> wrote:
> oprofile needs libbfd, but does not require all the binutils tools
> installing in the target filesystem. This saves a lot of space
> on the target filesystem.
>
> Signed-off-by: Will Newton <will.newton@imgtec.com>

Is this ok for 2011.02?

> ---
> ?package/oprofile/oprofile.mk ? | ? ?2 +-
> ?toolchain/binutils/binutils.mk | ? ?2 ++
> ?2 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/package/oprofile/oprofile.mk b/package/oprofile/oprofile.mk
> index 3be50f2..7281c8f 100644
> --- a/package/oprofile/oprofile.mk
> +++ b/package/oprofile/oprofile.mk
> @@ -24,7 +24,7 @@ ifeq ($(OPROFILE_ARCH),)
> ?OPROFILE_ARCH := $(BR2_ARCH)
> ?endif
>
> -OPROFILE_DEPENDENCIES := popt binutils_target
> +OPROFILE_DEPENDENCIES := popt libbfd_target
>
> ?define OPROFILE_INSTALL_TARGET_CMDS
> ? ? ? ?$(INSTALL) -d -m 755 $(TARGET_DIR)/usr/bin
> diff --git a/toolchain/binutils/binutils.mk b/toolchain/binutils/binutils.mk
> index ef9f644..de8f865 100644
> --- a/toolchain/binutils/binutils.mk
> +++ b/toolchain/binutils/binutils.mk
> @@ -172,6 +172,8 @@ endif
>
> ?binutils_target: $(BINUTILS_TARGET_PREREQ) $(TARGET_DIR)/usr/bin/ld
>
> +libbfd_target: $(BINUTILS_DIR2)/binutils/objdump
> +
> ?binutils_target-clean:
> ? ? ? ?-$(MAKE) -C $(BINUTILS_DIR2) clean
> ? ? ? ?rm -f $(TARGET_DIR)/bin/$(REAL_GNU_TARGET_NAME)* \
> --
> 1.7.2.2
>

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem.
  2010-12-07 11:21 ` Will Newton
@ 2010-12-07 18:58   ` Thomas Petazzoni
  2010-12-07 19:27     ` Will Newton
  0 siblings, 1 reply; 6+ messages in thread
From: Thomas Petazzoni @ 2010-12-07 18:58 UTC (permalink / raw)
  To: buildroot

On Tue, 7 Dec 2010 11:21:59 +0000
Will Newton <will.newton@gmail.com> wrote:

> On Tue, Nov 30, 2010 at 4:29 PM, Will Newton <will.newton@gmail.com>
> wrote:
> > oprofile needs libbfd, but does not require all the binutils tools
> > installing in the target filesystem. This saves a lot of space
> > on the target filesystem.
> >
> > Signed-off-by: Will Newton <will.newton@imgtec.com>
> 
> Is this ok for 2011.02?

Gustavo Zacarias is cleaning up the binutils package, so I'm sure he
will take care of this as well :-)

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem.
  2010-12-07 18:58   ` Thomas Petazzoni
@ 2010-12-07 19:27     ` Will Newton
  2010-12-16 19:07       ` Gustavo Zacarias
  0 siblings, 1 reply; 6+ messages in thread
From: Will Newton @ 2010-12-07 19:27 UTC (permalink / raw)
  To: buildroot

On Tue, Dec 7, 2010 at 6:58 PM, Thomas Petazzoni
<thomas.petazzoni@free-electrons.com> wrote:
> On Tue, 7 Dec 2010 11:21:59 +0000
> Will Newton <will.newton@gmail.com> wrote:
>
>> On Tue, Nov 30, 2010 at 4:29 PM, Will Newton <will.newton@gmail.com>
>> wrote:
>> > oprofile needs libbfd, but does not require all the binutils tools
>> > installing in the target filesystem. This saves a lot of space
>> > on the target filesystem.
>> >
>> > Signed-off-by: Will Newton <will.newton@imgtec.com>
>>
>> Is this ok for 2011.02?
>
> Gustavo Zacarias is cleaning up the binutils package, so I'm sure he
> will take care of this as well :-)

That's good news, thanks for letting me know!

Gustavo: If you need any patches testing I'll be happy to do it.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem.
  2010-12-07 19:27     ` Will Newton
@ 2010-12-16 19:07       ` Gustavo Zacarias
  2010-12-17 11:31         ` Will Newton
  0 siblings, 1 reply; 6+ messages in thread
From: Gustavo Zacarias @ 2010-12-16 19:07 UTC (permalink / raw)
  To: buildroot

On 12/07/10 16:27, Will Newton wrote:

> On Tue, Dec 7, 2010 at 6:58 PM, Thomas Petazzoni
> <thomas.petazzoni@free-electrons.com> wrote:
>> Gustavo Zacarias is cleaning up the binutils package, so I'm sure he
>> will take care of this as well :-)
> 
> That's good news, thanks for letting me know!
> 
> Gustavo: If you need any patches testing I'll be happy to do it.

git://repo.or.cz/buildroot-gz.git toolchain-work
or
http://repo.or.cz/w/buildroot-gz.git/shortlog/refs/heads/toolchain-rework :-)
Give it a spin, i've done basic tests for an ARM target.
Regards.

^ permalink raw reply	[flat|nested] 6+ messages in thread
* [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem.
  2010-12-16 19:07       ` Gustavo Zacarias
@ 2010-12-17 11:31         ` Will Newton
  0 siblings, 0 replies; 6+ messages in thread
From: Will Newton @ 2010-12-17 11:31 UTC (permalink / raw)
  To: buildroot

On Thu, Dec 16, 2010 at 7:07 PM, Gustavo Zacarias
<gustavo@zacarias.com.ar> wrote:
> On 12/07/10 16:27, Will Newton wrote:
>
>> On Tue, Dec 7, 2010 at 6:58 PM, Thomas Petazzoni
>> <thomas.petazzoni@free-electrons.com> wrote:
>>> Gustavo Zacarias is cleaning up the binutils package, so I'm sure he
>>> will take care of this as well :-)
>>
>> That's good news, thanks for letting me know!
>>
>> Gustavo: If you need any patches testing I'll be happy to do it.
>
> git://repo.or.cz/buildroot-gz.git toolchain-work
> or
> http://repo.or.cz/w/buildroot-gz.git/shortlog/refs/heads/toolchain-rework :-)
> Give it a spin, i've done basic tests for an ARM target.

Works for me on Intel and fixes the issue with binutils being
installed alongside oprofile.

Thanks for doing this work!

^ permalink raw reply	[flat|nested] 6+ messages in thread
end of thread, other threads:[~2010-12-17 11:31 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-30 16:29 [Buildroot] [PATCH] oprofile: Don't install binutils in the target filesystem Will Newton
2010-12-07 11:21 ` Will Newton
2010-12-07 18:58   ` Thomas Petazzoni
2010-12-07 19:27     ` Will Newton
2010-12-16 19:07       ` Gustavo Zacarias
2010-12-17 11:31         ` Will Newton

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.