* [PATCH] ath9k_hw: Fix INI fixup
@ 2011-01-26 16:29 Sujith
2011-01-26 17:21 ` Luis R. Rodriguez
0 siblings, 1 reply; 4+ messages in thread
From: Sujith @ 2011-01-26 16:29 UTC (permalink / raw)
To: linville; +Cc: linux-wireless, Sujith.Manoharan
From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
Commit "ath9k_hw: move AR9280 PCI EEPROM fix to eeprom_def.c"
changed the behavior of INI overriding which is needed only
for PCI cards. Revert to the original check.
Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
---
drivers/net/wireless/ath/ath9k/eeprom_def.c | 6 +++---
1 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/wireless/ath/ath9k/eeprom_def.c b/drivers/net/wireless/ath/ath9k/eeprom_def.c
index c9318ff..fccd87d 100644
--- a/drivers/net/wireless/ath/ath9k/eeprom_def.c
+++ b/drivers/net/wireless/ath/ath9k/eeprom_def.c
@@ -247,9 +247,9 @@ static int ath9k_hw_def_check_eeprom(struct ath_hw *ah)
}
/* Enable fixup for AR_AN_TOP2 if necessary */
- if (AR_SREV_9280_20_OR_LATER(ah) &&
- (eep->baseEepHeader.version & 0xff) > 0x0a &&
- eep->baseEepHeader.pwdclkind == 0)
+ if ((ah->hw_version.devid == AR9280_DEVID_PCI) &&
+ ((eep->baseEepHeader.version & 0xff) > 0x0a) &&
+ (eep->baseEepHeader.pwdclkind == 0))
ah->need_an_top2_fixup = 1;
if ((common->bus_ops->ath_bus_type == ATH_USB) &&
--
1.7.3.5
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k_hw: Fix INI fixup
2011-01-26 16:29 [PATCH] ath9k_hw: Fix INI fixup Sujith
@ 2011-01-26 17:21 ` Luis R. Rodriguez
2011-01-26 17:28 ` Sujith
0 siblings, 1 reply; 4+ messages in thread
From: Luis R. Rodriguez @ 2011-01-26 17:21 UTC (permalink / raw)
To: Sujith; +Cc: linville, linux-wireless, Sujith.Manoharan
On Wed, Jan 26, 2011 at 8:29 AM, Sujith <m.sujith@gmail.com> wrote:
> From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>
> Commit "ath9k_hw: move AR9280 PCI EEPROM fix to eeprom_def.c"
> changed the behavior of INI overriding which is needed only
> for PCI cards. Revert to the original check.
>
> Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
You leave me no option but to come out of e-mail reply slumber. What
issues was this causing?
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k_hw: Fix INI fixup
2011-01-26 17:21 ` Luis R. Rodriguez
@ 2011-01-26 17:28 ` Sujith
2011-01-26 17:36 ` Luis R. Rodriguez
0 siblings, 1 reply; 4+ messages in thread
From: Sujith @ 2011-01-26 17:28 UTC (permalink / raw)
To: Luis R. Rodriguez; +Cc: linville, linux-wireless
Luis R. Rodriguez wrote:
> On Wed, Jan 26, 2011 at 8:29 AM, Sujith <m.sujith@gmail.com> wrote:
> > From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
> >
> > Commit "ath9k_hw: move AR9280 PCI EEPROM fix to eeprom_def.c"
> > changed the behavior of INI overriding which is needed only
> > for PCI cards. Revert to the original check.
> >
> > Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>
> You leave me no option but to come out of e-mail reply slumber. What
> issues was this causing?
The INI fixup is required only for AR9280 PCI cards. Changing it to a SREV
check that includes all chipsets above AR9280 would mean changing the initvals
for other cards too. The couple of cards I have did not hit this check,
but that doesn't mean that there are no weirdly configured cards out there...
Sujith
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] ath9k_hw: Fix INI fixup
2011-01-26 17:28 ` Sujith
@ 2011-01-26 17:36 ` Luis R. Rodriguez
0 siblings, 0 replies; 4+ messages in thread
From: Luis R. Rodriguez @ 2011-01-26 17:36 UTC (permalink / raw)
To: Sujith; +Cc: linville, linux-wireless
On Wed, Jan 26, 2011 at 9:28 AM, Sujith <Sujith.Manoharan@atheros.com> wrote:
> Luis R. Rodriguez wrote:
>> On Wed, Jan 26, 2011 at 8:29 AM, Sujith <m.sujith@gmail.com> wrote:
>> > From: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>> >
>> > Commit "ath9k_hw: move AR9280 PCI EEPROM fix to eeprom_def.c"
>> > changed the behavior of INI overriding which is needed only
>> > for PCI cards. Revert to the original check.
>> >
>> > Signed-off-by: Sujith Manoharan <Sujith.Manoharan@atheros.com>
>>
>> You leave me no option but to come out of e-mail reply slumber. What
>> issues was this causing?
>
> The INI fixup is required only for AR9280 PCI cards. Changing it to a SREV
> check that includes all chipsets above AR9280 would mean changing the initvals
> for other cards too. The couple of cards I have did not hit this check,
> but that doesn't mean that there are no weirdly configured cards out there...
Thanks, the reason I ask was to determine if this was a stable fix.
mcgrof@tux ~/linux-2.6-allstable (git::master)$ git describe
--contains 57b98384e5450996300d77ece61739b58325a84f
v2.6.35-rc1~473^2~167^2~208
Luis
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2011-01-26 17:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-01-26 16:29 [PATCH] ath9k_hw: Fix INI fixup Sujith
2011-01-26 17:21 ` Luis R. Rodriguez
2011-01-26 17:28 ` Sujith
2011-01-26 17:36 ` Luis R. Rodriguez
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.