small improvement for epoll_ctl.2

small improvement for epoll_ctl.2

[Yuri Kozlov]

[-- Attachment #1: Type: text/plain, Size: 561 bytes --]

Hello.
--- man-pages-git/man2/epoll_ctl.2      2010-03-26 17:46:41.000000000 +0300
+++ /tmp/epoll_ctl.2    2010-08-14 09:51:09.000000000 +0400
@@ -81,12 +81,12 @@
 typedef union epoll_data {
     void        *ptr;
     int          fd;
-    __uint32_t   u32;
-    __uint64_t   u64;
+    uint32_t   u32;
+    uint64_t   u64;
 } epoll_data_t;
 
 struct epoll_event {
-    __uint32_t   events;      /* Epoll events */
+    uint32_t   events;      /* Epoll events */
     epoll_data_t data;        /* User data variable */
 };
 .fi


-- 
Best Regards,
Yuri Kozlov


[-- Attachment #2: epoll_ctl.2.patch --]
[-- Type: text/x-patch, Size: 513 bytes --]

--- man-pages-git/man2/epoll_ctl.2	2010-03-26 17:46:41.000000000 +0300
+++ /tmp/epoll_ctl.2	2010-08-14 09:51:09.000000000 +0400
@@ -81,12 +81,12 @@
 typedef union epoll_data {
     void        *ptr;
     int          fd;
-    __uint32_t   u32;
-    __uint64_t   u64;
+    uint32_t   u32;
+    uint64_t   u64;
 } epoll_data_t;
 
 struct epoll_event {
-    __uint32_t   events;      /* Epoll events */
+    uint32_t   events;      /* Epoll events */
     epoll_data_t data;        /* User data variable */
 };
 .fi

Re: small improvement for epoll_ctl.2

[Michael Kerrisk]

Hello Yuri,

Thanks. Applied for 3.26.

Cheers,

Michael

On Sat, Aug 14, 2010 at 7:53 AM, Yuri Kozlov <yuray-YPGtXv8QU+00kPtPmH8OGQ@public.gmane.org> wrote:
> Hello.
> --- man-pages-git/man2/epoll_ctl.2      2010-03-26 17:46:41.000000000 +0300
> +++ /tmp/epoll_ctl.2    2010-08-14 09:51:09.000000000 +0400
> @@ -81,12 +81,12 @@
>  typedef union epoll_data {
>     void        *ptr;
>     int          fd;
> -    __uint32_t   u32;
> -    __uint64_t   u64;
> +    uint32_t   u32;
> +    uint64_t   u64;
>  } epoll_data_t;
>
>  struct epoll_event {
> -    __uint32_t   events;      /* Epoll events */
> +    uint32_t   events;      /* Epoll events */
>     epoll_data_t data;        /* User data variable */
>  };
>  .fi
>
>
> --
> Best Regards,
> Yuri Kozlov
>
>



-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface" http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: small improvement for epoll_ctl.2

[Denis Barbier]

On 2010/8/14 Yuri Kozlov wrote:
> Hello.
> --- man-pages-git/man2/epoll_ctl.2      2010-03-26 17:46:41.000000000 +0300
> +++ /tmp/epoll_ctl.2    2010-08-14 09:51:09.000000000 +0400
> @@ -81,12 +81,12 @@
>  typedef union epoll_data {
>     void        *ptr;
>     int          fd;
> -    __uint32_t   u32;
> -    __uint64_t   u64;
> +    uint32_t   u32;
> +    uint64_t   u64;
>  } epoll_data_t;
>
>  struct epoll_event {
> -    __uint32_t   events;      /* Epoll events */
> +    uint32_t   events;      /* Epoll events */
>     epoll_data_t data;        /* User data variable */
>  };
>  .fi

Hello Michael,

This patch (found in e4123e51) breaks alignment of C comments, usually
you align them when describing data structures.

Denis
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: small improvement for epoll_ctl.2

[Michael Kerrisk]

On Sun, Aug 29, 2010 at 11:43 AM, Denis Barbier <bouzim-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org> wrote:
> On 2010/8/14 Yuri Kozlov wrote:
>> Hello.
>> --- man-pages-git/man2/epoll_ctl.2      2010-03-26 17:46:41.000000000 +0300
>> +++ /tmp/epoll_ctl.2    2010-08-14 09:51:09.000000000 +0400
>> @@ -81,12 +81,12 @@
>>  typedef union epoll_data {
>>     void        *ptr;
>>     int          fd;
>> -    __uint32_t   u32;
>> -    __uint64_t   u64;
>> +    uint32_t   u32;
>> +    uint64_t   u64;
>>  } epoll_data_t;
>>
>>  struct epoll_event {
>> -    __uint32_t   events;      /* Epoll events */
>> +    uint32_t   events;      /* Epoll events */
>>     epoll_data_t data;        /* User data variable */
>>  };
>>  .fi
>
> Hello Michael,
>
> This patch (found in e4123e51) breaks alignment of C comments, usually
> you align them when describing data structures.
>
> Denis


Thanks Denis,

Fixed now.

Cheers,

Michael


-- 
Michael Kerrisk
Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/
Author of "The Linux Programming Interface" http://blog.man7.org/
--
To unsubscribe from this list: send the line "unsubscribe linux-man" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html