* [U-Boot] [PATCH V2] mpc83xx:pcie:bugfix for mpc83xx pcie enumeration
@ 2010-11-28 1:06 Baidu Boy
2010-11-28 15:12 ` Kim Phillips
0 siblings, 1 reply; 3+ messages in thread
From: Baidu Boy @ 2010-11-28 1:06 UTC (permalink / raw)
To: u-boot
This patch fix a problem for the pcie enumeration for mpc83xx cpus.Without this
we will not get correct value in hose->regions[...].
The pointer *reg in function mpc83xx_pcie_init_bus() shall not be changed.
Because we will use this pointer as a parameter to call function
mpc83xx_pcie_register_hose().
Signed-off-by: Baidu Boy <liucai.lfn@gmail.com>
---
Changes for v2:
- Add some description for the patch.
arch/powerpc/cpu/mpc83xx/pcie.c | 12 ++++++------
1 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/arch/powerpc/cpu/mpc83xx/pcie.c b/arch/powerpc/cpu/mpc83xx/pcie.c
index 1771c48..46a706d 100644
--- a/arch/powerpc/cpu/mpc83xx/pcie.c
+++ b/arch/powerpc/cpu/mpc83xx/pcie.c
@@ -201,18 +201,18 @@ static void mpc83xx_pcie_init_bus(int bus,
struct pci_region *reg)
out_le32(&out_win->tarl, 0);
out_le32(&out_win->tarh, 0);
- for (i = 0; i < 2; i++, reg++) {
+ for (i = 0; i < 2; i++) {
u32 ar;
- if (reg->size == 0)
+ if (reg[i].size == 0)
break;
out_win = &pex->bridge.pex_outbound_win[i + 1];
- out_le32(&out_win->bar, reg->phys_start);
- out_le32(&out_win->tarl, reg->bus_start);
+ out_le32(&out_win->bar, reg[i].phys_start);
+ out_le32(&out_win->tarl, reg[i].bus_start);
out_le32(&out_win->tarh, 0);
- ar = PEX_OWAR_EN | (reg->size & PEX_OWAR_SIZE);
- if (reg->flags & PCI_REGION_IO)
+ ar = PEX_OWAR_EN | (reg[i].size & PEX_OWAR_SIZE);
+ if (reg[i].flags & PCI_REGION_IO)
ar |= PEX_OWAR_TYPE_IO;
else
ar |= PEX_OWAR_TYPE_MEM;
--
1.7.3.1.msysgit.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH V2] mpc83xx:pcie:bugfix for mpc83xx pcie enumeration
2010-11-28 1:06 [U-Boot] [PATCH V2] mpc83xx:pcie:bugfix for mpc83xx pcie enumeration Baidu Boy
@ 2010-11-28 15:12 ` Kim Phillips
2010-11-29 13:24 ` Baidu Boy
0 siblings, 1 reply; 3+ messages in thread
From: Kim Phillips @ 2010-11-28 15:12 UTC (permalink / raw)
To: u-boot
On Sun, 28 Nov 2010 09:06:37 +0800
Baidu Boy <liucai.lfn@gmail.com> wrote:
> This patch fix a problem for the pcie enumeration for mpc83xx cpus.Without this
> we will not get correct value in hose->regions[...].
>
> The pointer *reg in function mpc83xx_pcie_init_bus() shall not be changed.
> Because we will use this pointer as a parameter to call function
> mpc83xx_pcie_register_hose().
>
> Signed-off-by: Baidu Boy <liucai.lfn@gmail.com>
> ---
doesn't apply:
Applying: mpc83xx:pcie:bugfix for mpc83xx pcie enumeration
fatal: corrupt patch at line 13
please resubmit.
Thanks,
Kim
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH V2] mpc83xx:pcie:bugfix for mpc83xx pcie enumeration
2010-11-28 15:12 ` Kim Phillips
@ 2010-11-29 13:24 ` Baidu Boy
0 siblings, 0 replies; 3+ messages in thread
From: Baidu Boy @ 2010-11-29 13:24 UTC (permalink / raw)
To: u-boot
2010/11/28 Kim Phillips <kim.phillips@freescale.com>:
> doesn't apply:
>
> Applying: mpc83xx:pcie:bugfix for mpc83xx pcie enumeration
> fatal: corrupt patch at line 13
>
> please resubmit.
>
> Thanks,
>
> Kim
>
>
Please use this one http://patchwork.ozlabs.org/patch/73424/
My mailer wrap the long line in the V2 patch.
Thanks
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-11-29 13:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-11-28 1:06 [U-Boot] [PATCH V2] mpc83xx:pcie:bugfix for mpc83xx pcie enumeration Baidu Boy
2010-11-28 15:12 ` Kim Phillips
2010-11-29 13:24 ` Baidu Boy
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.