All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] vmlinux.lds.h: lower init ramfs alignment to 4
@ 2010-06-13  3:33 Mike Frysinger
  2010-10-17  8:19 ` Mike Frysinger
  0 siblings, 1 reply; 2+ messages in thread
From: Mike Frysinger @ 2010-06-13  3:33 UTC (permalink / raw)
  To: linux-kernel, Tim Abbott; +Cc: Milton Miller

The new init ramfs format (cpio based) requires an alignment of 4 (per the
documentation and per the source files themselves).  As for compressed
sources, the decompressors can all deal with unaligned buffers.

The cpio source is also found in the __init sections of the kernel, so
once they are read and expanded into a tmpfs, the source is freed.  That
means there is no need to force page alignment here either.

This has been used on Blackfin systems for many releases without issue.

Signed-off-by: Mike Frysinger <vapier@gentoo.org>
---
 include/asm-generic/vmlinux.lds.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
index 48c5299..14a01b6 100644
--- a/include/asm-generic/vmlinux.lds.h
+++ b/include/asm-generic/vmlinux.lds.h
@@ -620,7 +620,7 @@
 
 #ifdef CONFIG_BLK_DEV_INITRD
 #define INIT_RAM_FS							\
-	. = ALIGN(PAGE_SIZE);						\
+	. = ALIGN(4);							\
 	VMLINUX_SYMBOL(__initramfs_start) = .;				\
 	*(.init.ramfs)							\
 	VMLINUX_SYMBOL(__initramfs_end) = .;
-- 
1.7.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] vmlinux.lds.h: lower init ramfs alignment to 4
  2010-06-13  3:33 [PATCH] vmlinux.lds.h: lower init ramfs alignment to 4 Mike Frysinger
@ 2010-10-17  8:19 ` Mike Frysinger
  0 siblings, 0 replies; 2+ messages in thread
From: Mike Frysinger @ 2010-10-17  8:19 UTC (permalink / raw)
  To: Andrew Morton; +Cc: linux-kernel, Tim Abbott, Milton Miller

Andrew: could you pick this up ?  no feedback after this last version
was posted ...
-mike

On Sat, Jun 12, 2010 at 23:33, Mike Frysinger wrote:
> The new init ramfs format (cpio based) requires an alignment of 4 (per the
> documentation and per the source files themselves).  As for compressed
> sources, the decompressors can all deal with unaligned buffers.
>
> The cpio source is also found in the __init sections of the kernel, so
> once they are read and expanded into a tmpfs, the source is freed.  That
> means there is no need to force page alignment here either.
>
> This has been used on Blackfin systems for many releases without issue.
>
> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
> ---
>  include/asm-generic/vmlinux.lds.h |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/asm-generic/vmlinux.lds.h b/include/asm-generic/vmlinux.lds.h
> index 48c5299..14a01b6 100644
> --- a/include/asm-generic/vmlinux.lds.h
> +++ b/include/asm-generic/vmlinux.lds.h
> @@ -620,7 +620,7 @@
>
>  #ifdef CONFIG_BLK_DEV_INITRD
>  #define INIT_RAM_FS                                                    \
> -       . = ALIGN(PAGE_SIZE);                                           \
> +       . = ALIGN(4);                                                   \
>        VMLINUX_SYMBOL(__initramfs_start) = .;                          \
>        *(.init.ramfs)                                                  \
>        VMLINUX_SYMBOL(__initramfs_end) = .;
> --
> 1.7.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-10-17  8:20 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2010-06-13  3:33 [PATCH] vmlinux.lds.h: lower init ramfs alignment to 4 Mike Frysinger
2010-10-17  8:19 ` Mike Frysinger

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.