From: Matt <jackdachef@gmail.com> To: "Ted Ts'o" <tytso@mit.edu> Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-ext4 <linux-ext4@vger.kernel.org> Subject: Re: ext4: Fix data corruption with multi-block writepages support Date: Mon, 7 Feb 2011 18:56:28 +0000 [thread overview] Message-ID: <AANLkTinybnXVk9WRsvrLLfhWGXm1=jQnTGvE0JT6=RXs@mail.gmail.com> (raw) In-Reply-To: <20110207174552.GC3457@thunk.org> On Mon, Feb 7, 2011 at 5:45 PM, Ted Ts'o <tytso@mit.edu> wrote: > On Fri, Feb 04, 2011 at 10:40:47PM +0000, Matt wrote: >> >> So that means that the file-corruption which existed until 2.6.37-rc6 >> and got triggered (for me) more easily via "dm crypt: scale to >> multiple CPUs" >> is fixed now ? > > Well, a patch exists for it that will be merged into 2.6.38. > >> That should give ext4 a nice speedup for >=2.6.38 :) > > I'm not going to make it be the default for 2.6.38, since it's fairly > late in the -rc features. People who want it can explicitly enable it > using the mount option mblk_io_submit, though. (And let me know your > success stories! :-) I will be enabling it as the default in > 2.6.39-rc1. > Hi Ted, I guess it should be save to enable it with 2.6.37, dm-crypt multi-cpu patch and the following patch ? "ext4: Fix data corruption with multi-block writepages support" (of course that's the minimum - it would be better to pull in the ext4 changes for 2.6.38) For a short time I had it activated (via additional) mblk_io_submit mount-command on my portage-partition (where the portage-ball of my Gentoo system is). I was curious to see what messages I would get and wondered why there was nothing about mballoc mentioned If I recall correctly there were always messages in the past, like: EXT4-fs: delayed allocation enabled EXT4-fs: file extents enabled EXT4-fs: mballoc enabled these are from 2.6.28 - I'm only getting: EXT4-fs (dm-3): mounted filesystem with ordered data mode. or EXT4-fs (dm-3): mounted filesystem with ordered data mode. Opts: commit=60,barrier=1 (I like to set the barriers / flushes explicitly). Sorry if I didn't follow development but these messages were kind of more and more silenced ? Thanks ! >> Reported-by: Matthias Bayer <jackdachef <at> gmail <dot> com > > > Sure! Thanks ! > > - Ted > Regards Matt
WARNING: multiple messages have this Message-ID (diff)
From: Matt <jackdachef@gmail.com> To: "Ted Ts'o" <tytso@mit.edu> Cc: Linux Kernel <linux-kernel@vger.kernel.org>, linux-ext4 <linux-ext4@vger.kernel.org> Subject: Re: ext4: Fix data corruption with multi-block writepages support Date: Mon, 7 Feb 2011 18:56:28 +0000 [thread overview] Message-ID: <AANLkTinybnXVk9WRsvrLLfhWGXm1=jQnTGvE0JT6=RXs@mail.gmail.com> (raw) In-Reply-To: <20110207174552.GC3457@thunk.org> On Mon, Feb 7, 2011 at 5:45 PM, Ted Ts'o <tytso@mit.edu> wrote: > On Fri, Feb 04, 2011 at 10:40:47PM +0000, Matt wrote: >> >> So that means that the file-corruption which existed until 2.6.37-rc6 >> and got triggered (for me) more easily via "dm crypt: scale to >> multiple CPUs" >> is fixed now ? > > Well, a patch exists for it that will be merged into 2.6.38. > >> That should give ext4 a nice speedup for >=2.6.38 :) > > I'm not going to make it be the default for 2.6.38, since it's fairly > late in the -rc features. People who want it can explicitly enable it > using the mount option mblk_io_submit, though. (And let me know your > success stories! :-) I will be enabling it as the default in > 2.6.39-rc1. > Hi Ted, I guess it should be save to enable it with 2.6.37, dm-crypt multi-cpu patch and the following patch ? "ext4: Fix data corruption with multi-block writepages support" (of course that's the minimum - it would be better to pull in the ext4 changes for 2.6.38) For a short time I had it activated (via additional) mblk_io_submit mount-command on my portage-partition (where the portage-ball of my Gentoo system is). I was curious to see what messages I would get and wondered why there was nothing about mballoc mentioned If I recall correctly there were always messages in the past, like: EXT4-fs: delayed allocation enabled EXT4-fs: file extents enabled EXT4-fs: mballoc enabled these are from 2.6.28 - I'm only getting: EXT4-fs (dm-3): mounted filesystem with ordered data mode. or EXT4-fs (dm-3): mounted filesystem with ordered data mode. Opts: commit=60,barrier=1 (I like to set the barriers / flushes explicitly). Sorry if I didn't follow development but these messages were kind of more and more silenced ? Thanks ! >> Reported-by: Matthias Bayer <jackdachef <at> gmail <dot> com > > > Sure! Thanks ! > > - Ted > Regards Matt -- To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2011-02-07 18:56 UTC|newest] Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top 2011-02-04 22:40 ext4: Fix data corruption with multi-block writepages support Matt 2011-02-07 17:45 ` Ted Ts'o 2011-02-07 18:29 ` Milan Broz 2011-02-07 18:44 ` Matt 2011-02-07 20:44 ` Ted Ts'o 2011-02-07 20:51 ` Milan Broz 2011-02-07 18:56 ` Matt [this message] 2011-02-07 18:56 ` Matt -- strict thread matches above, loose matches on Subject: below -- 2011-02-01 17:51 Curt Wohlgemuth 2011-02-03 18:38 ` Ted Ts'o
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to='AANLkTinybnXVk9WRsvrLLfhWGXm1=jQnTGvE0JT6=RXs@mail.gmail.com' \ --to=jackdachef@gmail.com \ --cc=linux-ext4@vger.kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=tytso@mit.edu \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.