[PATCH] genl: Include system header to fix build warning

[PATCH] genl: Include system header to fix build warning

[Mat Martineau]

[-- Attachment #1: Type: text/plain, Size: 624 bytes --]

The l_genl_msg_append_attrv() declaration in genl.h uses struct iovec *,
but there's no guarantee that sys/uio.h has been included already (and
the genl user might not need that header itself). Within the ell code,
uio.h is already included by util.h which prevents build errors in ell
itself.
---
 ell/genl.h | 1 +
 1 file changed, 1 insertion(+)

diff --git a/ell/genl.h b/ell/genl.h
index 5df688b..3a37ed5 100644
--- a/ell/genl.h
+++ b/ell/genl.h
@@ -26,6 +26,7 @@
 #include <stdbool.h>
 #include <stddef.h>
 #include <stdint.h>
+#include <sys/uio.h>
 
 #ifdef __cplusplus
 extern "C" {
-- 
2.23.0

Re: [PATCH] genl: Include system header to fix build warning

[Marcel Holtmann]

[-- Attachment #1: Type: text/plain, Size: 732 bytes --]

Hi Mat,

> The l_genl_msg_append_attrv() declaration in genl.h uses struct iovec *,
> but there's no guarantee that sys/uio.h has been included already (and
> the genl user might not need that header itself). Within the ell code,
> uio.h is already included by util.h which prevents build errors in ell
> itself.
> ---
> ell/genl.h | 1 +
> 1 file changed, 1 insertion(+)
> 
> diff --git a/ell/genl.h b/ell/genl.h
> index 5df688b..3a37ed5 100644
> --- a/ell/genl.h
> +++ b/ell/genl.h
> @@ -26,6 +26,7 @@
> #include <stdbool.h>
> #include <stddef.h>
> #include <stdint.h>
> +#include <sys/uio.h>

I would rather forward declare struct iovec than including a header from a public ELL header.

Regards

Marcel