* [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs
@ 2018-12-04 13:49 Otavio Salvador
2018-12-06 13:46 ` Philipp Tomsich
2018-12-10 0:01 ` [U-Boot] " Philipp Tomsich
0 siblings, 2 replies; 12+ messages in thread
From: Otavio Salvador @ 2018-12-04 13:49 UTC (permalink / raw)
To: u-boot
We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
fdt relocation, so the initramfs works out of box.
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
---
include/configs/rv1108_common.h | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/include/configs/rv1108_common.h b/include/configs/rv1108_common.h
index 16d4e2e355..91a9f9758b 100644
--- a/include/configs/rv1108_common.h
+++ b/include/configs/rv1108_common.h
@@ -34,7 +34,9 @@
"scriptaddr=0x60000000\0" \
"fdt_addr_r=0x61f00000\0" \
"kernel_addr_r=0x62000000\0" \
- "ramdisk_addr_r=0x64000000\0"
+ "ramdisk_addr_r=0x68000000\0" \
+ "initrd_high=0xffffffff\0" \
+ "fdt_high=0xffffffff\0"
#include <config_distro_bootcmd.h>
#define CONFIG_EXTRA_ENV_SETTINGS \
--
2.19.2
^ permalink raw reply related [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-04 13:49 [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs Otavio Salvador
@ 2018-12-06 13:46 ` Philipp Tomsich
2018-12-06 23:00 ` Otavio Salvador
2018-12-10 0:01 ` [U-Boot] " Philipp Tomsich
1 sibling, 1 reply; 12+ messages in thread
From: Philipp Tomsich @ 2018-12-06 13:46 UTC (permalink / raw)
To: u-boot
> On 04.12.2018, at 14:49, Otavio Salvador <otavio@ossystems.com.br> wrote:
>
> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> fdt relocation, so the initramfs works out of box.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-06 13:46 ` Philipp Tomsich
@ 2018-12-06 23:00 ` Otavio Salvador
2018-12-06 23:03 ` Philipp Tomsich
0 siblings, 1 reply; 12+ messages in thread
From: Otavio Salvador @ 2018-12-06 23:00 UTC (permalink / raw)
To: u-boot
Hello Philipp,
On Thu, Dec 6, 2018 at 11:46 AM Philipp Tomsich
<philipp.tomsich@theobroma-systems.com> wrote:
> > On 04.12.2018, at 14:49, Otavio Salvador <otavio@ossystems.com.br> wrote:
> > We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> > fdt relocation, so the initramfs works out of box.
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
As you sent the PR for Rockchip tree, do you mind if Tom applies this
one directly?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-06 23:00 ` Otavio Salvador
@ 2018-12-06 23:03 ` Philipp Tomsich
0 siblings, 0 replies; 12+ messages in thread
From: Philipp Tomsich @ 2018-12-06 23:03 UTC (permalink / raw)
To: u-boot
Otavio,
> On 07.12.2018, at 00:00, Otavio Salvador <otavio.salvador@ossystems.com.br> wrote:
>
> Hello Philipp,
>
> On Thu, Dec 6, 2018 at 11:46 AM Philipp Tomsich
> <philipp.tomsich@theobroma-systems.com> wrote:
>>> On 04.12.2018, at 14:49, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
>>> fdt relocation, so the initramfs works out of box.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>
>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>
> As you sent the PR for Rockchip tree, do you mind if Tom applies this
> one directly?
I am preparing another PR to go out prior to RC2.
There’s a number of bug-fixes that have collected over this week.
Unfortunately, this is not as quick and painless as it could as not everyone
runs their patches through Travis.
Thanks,
Phil.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-04 13:49 [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs Otavio Salvador
2018-12-06 13:46 ` Philipp Tomsich
@ 2018-12-10 0:01 ` Philipp Tomsich
2018-12-10 0:28 ` Tom Rini
1 sibling, 1 reply; 12+ messages in thread
From: Philipp Tomsich @ 2018-12-10 0:01 UTC (permalink / raw)
To: u-boot
> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> fdt relocation, so the initramfs works out of box.
>
> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
>
> include/configs/rv1108_common.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 0:01 ` [U-Boot] " Philipp Tomsich
@ 2018-12-10 0:28 ` Tom Rini
2018-12-10 0:38 ` Philipp Tomsich
2018-12-10 12:01 ` Otavio Salvador
0 siblings, 2 replies; 12+ messages in thread
From: Tom Rini @ 2018-12-10 0:28 UTC (permalink / raw)
To: u-boot
On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> > We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> > fdt relocation, so the initramfs works out of box.
> >
> > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > ---
> >
> > include/configs/rv1108_common.h | 4 +++-
> > 1 file changed, 3 insertions(+), 1 deletion(-)
> >
>
> Applied to u-boot-rockchip, thanks!
Ugh, sorry for not spotting this sooner. Please don't disable
fdt/initrd relocation and instead use bootm_size.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181209/c9146634/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 0:28 ` Tom Rini
@ 2018-12-10 0:38 ` Philipp Tomsich
2018-12-10 0:56 ` Tom Rini
2018-12-10 12:01 ` Otavio Salvador
1 sibling, 1 reply; 12+ messages in thread
From: Philipp Tomsich @ 2018-12-10 0:38 UTC (permalink / raw)
To: u-boot
Tom,
On 10.12.2018, at 01:28, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
>>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
>>> fdt relocation, so the initramfs works out of box.
>>>
>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> ---
>>>
>>> include/configs/rv1108_common.h | 4 +++-
>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>
>>
>> Applied to u-boot-rockchip, thanks!
>
> Ugh, sorry for not spotting this sooner. Please don't disable
> fdt/initrd relocation and instead use bootm_size.
Thanks for spotting this (just in time).
I’ll drop it and rerun Travis for tomorrow’s PR.
Thanks,
Philipp.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 0:38 ` Philipp Tomsich
@ 2018-12-10 0:56 ` Tom Rini
2018-12-10 23:12 ` Philipp Tomsich
0 siblings, 1 reply; 12+ messages in thread
From: Tom Rini @ 2018-12-10 0:56 UTC (permalink / raw)
To: u-boot
On Mon, Dec 10, 2018 at 01:38:36AM +0100, Philipp Tomsich wrote:
> Tom,
>
> On 10.12.2018, at 01:28, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> >>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> >>> fdt relocation, so the initramfs works out of box.
> >>>
> >>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>> ---
> >>>
> >>> include/configs/rv1108_common.h | 4 +++-
> >>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>
> >>
> >> Applied to u-boot-rockchip, thanks!
> >
> > Ugh, sorry for not spotting this sooner. Please don't disable
> > fdt/initrd relocation and instead use bootm_size.
>
> Thanks for spotting this (just in time).
> I’ll drop it and rerun Travis for tomorrow’s PR.
Thanks. And you might want to audit the rest of rockchip (and no, my
own house isn't 100% in order) as it looks like in general at least
you're using fdt_high to (good) set an upper bound but I think
bootm_size is more robust as we can set that and it covers fdt and
initrd if present (which not all rk3xxx_common.h are setting).
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181209/0f6708ee/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 0:28 ` Tom Rini
2018-12-10 0:38 ` Philipp Tomsich
@ 2018-12-10 12:01 ` Otavio Salvador
2018-12-10 12:23 ` Tom Rini
1 sibling, 1 reply; 12+ messages in thread
From: Otavio Salvador @ 2018-12-10 12:01 UTC (permalink / raw)
To: u-boot
On Sun, Dec 9, 2018 at 10:28 PM Tom Rini <trini@konsulko.com> wrote:
> On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> > > We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> > > fdt relocation, so the initramfs works out of box.
> > >
> > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > > ---
> > >
> > > include/configs/rv1108_common.h | 4 +++-
> > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > >
> >
> > Applied to u-boot-rockchip, thanks!
>
> Ugh, sorry for not spotting this sooner. Please don't disable
> fdt/initrd relocation and instead use bootm_size.
I never used it, any reference to look at?
--
Otavio Salvador O.S. Systems
http://www.ossystems.com.br http://code.ossystems.com.br
Mobile: +55 (53) 9 9981-7854 Mobile: +1 (347) 903-9750
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 12:01 ` Otavio Salvador
@ 2018-12-10 12:23 ` Tom Rini
0 siblings, 0 replies; 12+ messages in thread
From: Tom Rini @ 2018-12-10 12:23 UTC (permalink / raw)
To: u-boot
On Mon, Dec 10, 2018 at 10:01:06AM -0200, Otavio Salvador wrote:
> On Sun, Dec 9, 2018 at 10:28 PM Tom Rini <trini@konsulko.com> wrote:
> > On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> > > > We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> > > > fdt relocation, so the initramfs works out of box.
> > > >
> > > > Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> > > > Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> > > > ---
> > > >
> > > > include/configs/rv1108_common.h | 4 +++-
> > > > 1 file changed, 3 insertions(+), 1 deletion(-)
> > > >
> > >
> > > Applied to u-boot-rockchip, thanks!
> >
> > Ugh, sorry for not spotting this sooner. Please don't disable
> > fdt/initrd relocation and instead use bootm_size.
>
> I never used it, any reference to look at?
Specifically? No. There should be a lot of general hits on
$search-engine over it however as not disabling and instead using
bootm_size is how to fix "Kernel suddenly stops booting... oh we're
overwriting fdt/initrd".
This isn't to say that disabling fdt/initrd relocation isn't a useful
production optimization, it is. But it's not a good general best
practice.
--
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20181210/3213115b/attachment.sig>
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 0:56 ` Tom Rini
@ 2018-12-10 23:12 ` Philipp Tomsich
2018-12-11 6:25 ` Heiko Stuebner
0 siblings, 1 reply; 12+ messages in thread
From: Philipp Tomsich @ 2018-12-10 23:12 UTC (permalink / raw)
To: u-boot
+ Heiko
> On 10.12.2018, at 01:56, Tom Rini <trini@konsulko.com> wrote:
>
> On Mon, Dec 10, 2018 at 01:38:36AM +0100, Philipp Tomsich wrote:
>> Tom,
>>
>> On 10.12.2018, at 01:28, Tom Rini <trini@konsulko.com> wrote:
>>>
>>> On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
>>>>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
>>>>> fdt relocation, so the initramfs works out of box.
>>>>>
>>>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
>>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>>>> ---
>>>>>
>>>>> include/configs/rv1108_common.h | 4 +++-
>>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
>>>>>
>>>>
>>>> Applied to u-boot-rockchip, thanks!
>>>
>>> Ugh, sorry for not spotting this sooner. Please don't disable
>>> fdt/initrd relocation and instead use bootm_size.
>>
>> Thanks for spotting this (just in time).
>> I’ll drop it and rerun Travis for tomorrow’s PR.
>
> Thanks. And you might want to audit the rest of rockchip (and no, my
> own house isn't 100% in order) as it looks like in general at least
> you're using fdt_high to (good) set an upper bound but I think
> bootm_size is more robust as we can set that and it covers fdt and
> initrd if present (which not all rk3xxx_common.h are setting).
We may have a problem on rk3188 and rk3288 configurations. While I can
convert these to bootm_size, I would have to do so blindly, as I don’t have
any boards.
@Heiko: you have added the fdt_high and initrd_high in rk3188_common.h,
do you have more info and would you have able to test this changed to
bootm_size instead?
Cheers,
Philipp.
^ permalink raw reply [flat|nested] 12+ messages in thread
* [U-Boot] ARM: rockchip: rv1108: Fix booting with initramfs
2018-12-10 23:12 ` Philipp Tomsich
@ 2018-12-11 6:25 ` Heiko Stuebner
0 siblings, 0 replies; 12+ messages in thread
From: Heiko Stuebner @ 2018-12-11 6:25 UTC (permalink / raw)
To: u-boot
Hi Philipp,
Am Dienstag, 11. Dezember 2018, 00:12:40 CET schrieb Philipp Tomsich:
> + Heiko
>
> > On 10.12.2018, at 01:56, Tom Rini <trini@konsulko.com> wrote:
> >
> > On Mon, Dec 10, 2018 at 01:38:36AM +0100, Philipp Tomsich wrote:
> >> Tom,
> >>
> >> On 10.12.2018, at 01:28, Tom Rini <trini@konsulko.com> wrote:
> >>>
> >>> On Mon, Dec 10, 2018 at 01:01:52AM +0100, Philipp Tomsich wrote:
> >>>>> We move the ramdisk_addr_r to 0x68000000 and disable the initrd and
> >>>>> fdt relocation, so the initramfs works out of box.
> >>>>>
> >>>>> Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
> >>>>> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> >>>>> ---
> >>>>>
> >>>>> include/configs/rv1108_common.h | 4 +++-
> >>>>> 1 file changed, 3 insertions(+), 1 deletion(-)
> >>>>>
> >>>>
> >>>> Applied to u-boot-rockchip, thanks!
> >>>
> >>> Ugh, sorry for not spotting this sooner. Please don't disable
> >>> fdt/initrd relocation and instead use bootm_size.
> >>
> >> Thanks for spotting this (just in time).
> >> I’ll drop it and rerun Travis for tomorrow’s PR.
> >
> > Thanks. And you might want to audit the rest of rockchip (and no, my
> > own house isn't 100% in order) as it looks like in general at least
> > you're using fdt_high to (good) set an upper bound but I think
> > bootm_size is more robust as we can set that and it covers fdt and
> > initrd if present (which not all rk3xxx_common.h are setting).
>
> We may have a problem on rk3188 and rk3288 configurations. While I can
> convert these to bootm_size, I would have to do so blindly, as I don’t have
> any boards.
>
> @Heiko: you have added the fdt_high and initrd_high in rk3188_common.h,
> do you have more info and would you have able to test this changed to
> bootm_size instead?
I think I more or less only copied that from rk3288 (adjusted for actual
ram-location) and I'm of course able to test changes you want to do on
rk3188 [Though only starting from thursday].
Heiko
^ permalink raw reply [flat|nested] 12+ messages in thread
end of thread, other threads:[~2018-12-11 6:25 UTC | newest]
Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-04 13:49 [U-Boot] [PATCH] ARM: rockchip: rv1108: Fix booting with initramfs Otavio Salvador
2018-12-06 13:46 ` Philipp Tomsich
2018-12-06 23:00 ` Otavio Salvador
2018-12-06 23:03 ` Philipp Tomsich
2018-12-10 0:01 ` [U-Boot] " Philipp Tomsich
2018-12-10 0:28 ` Tom Rini
2018-12-10 0:38 ` Philipp Tomsich
2018-12-10 0:56 ` Tom Rini
2018-12-10 23:12 ` Philipp Tomsich
2018-12-11 6:25 ` Heiko Stuebner
2018-12-10 12:01 ` Otavio Salvador
2018-12-10 12:23 ` Tom Rini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.