* [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options
@ 2022-09-20 13:32 Giulio Benetti
2022-09-20 17:01 ` Kris Bahnsen via buildroot
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Giulio Benetti @ 2022-09-20 13:32 UTC (permalink / raw)
To: buildroot; +Cc: Giulio Benetti, Kris Bahnsen
Enable Linux options depending on the bus has been chosen, so:
1) enable by default common Linux options:
CONFIG_NET
CONFIG_WIRELESS
CONFIG_CFG80211
CONFIG_CRC_ITU_T
CONFIG_CRC7
2) enable for SDIO bus:
CONFIG_MMC
3) enable for SPI bus:
CONFIG_SPI
Fixes:
http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/
Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
---
package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++
1 file changed, 16 insertions(+)
diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk
index a89af30e29..a7a902b6db 100644
--- a/package/wilc-driver/wilc-driver.mk
+++ b/package/wilc-driver/wilc-driver.mk
@@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE
ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y)
WILC_DRIVER_MODULE_MAKE_OPTS += \
CONFIG_WILC_SPI=m
+define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS
+ $(call KCONFIG_ENABLE_OPT,CONFIG_SPI)
+endef
endif
ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y)
WILC_DRIVER_MODULE_MAKE_OPTS += \
CONFIG_WILC_SDIO=m
+define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS
+ $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
+endef
endif
ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y)
@@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \
CONFIG_WILC_HW_OOB_INTR=y
endif
+define WILC_DRIVER_LINUX_CONFIG_FIXUPS
+ $(call KCONFIG_ENABLE_OPT,CONFIG_NET)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T)
+ $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7)
+ $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS)
+ $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS)
+endef
+
$(eval $(kernel-module))
$(eval $(generic-package))
--
2.34.1
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options
2022-09-20 13:32 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options Giulio Benetti
@ 2022-09-20 17:01 ` Kris Bahnsen via buildroot
2022-09-20 17:20 ` Giulio Benetti
2022-11-24 21:58 ` Thomas Petazzoni via buildroot
2022-12-05 21:31 ` Peter Korsgaard
2 siblings, 1 reply; 5+ messages in thread
From: Kris Bahnsen via buildroot @ 2022-09-20 17:01 UTC (permalink / raw)
To: Giulio Benetti, buildroot
On Tue, 2022-09-20 at 15:32 +0200, Giulio Benetti wrote:
> Enable Linux options depending on the bus has been chosen, so:
> 1) enable by default common Linux options:
> CONFIG_NET
> CONFIG_WIRELESS
> CONFIG_CFG80211
> CONFIG_CRC_ITU_T
> CONFIG_CRC7
> 2) enable for SDIO bus:
> CONFIG_MMC
> 3) enable for SPI bus:
> CONFIG_SPI
>
> Fixes:
> http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
>
> diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk
> index a89af30e29..a7a902b6db 100644
> --- a/package/wilc-driver/wilc-driver.mk
> +++ b/package/wilc-driver/wilc-driver.mk
> @@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE
> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y)
> WILC_DRIVER_MODULE_MAKE_OPTS += \
> CONFIG_WILC_SPI=m
> +define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_SPI)
> +endef
> endif
>
> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y)
> WILC_DRIVER_MODULE_MAKE_OPTS += \
> CONFIG_WILC_SDIO=m
> +define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
> +endef
> endif
>
> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y)
> @@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \
> CONFIG_WILC_HW_OOB_INTR=y
> endif
>
> +define WILC_DRIVER_LINUX_CONFIG_FIXUPS
> + $(call KCONFIG_ENABLE_OPT,CONFIG_NET)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T)
> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7)
> + $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS)
> + $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS)
> +endef
> +
> $(eval $(kernel-module))
> $(eval $(generic-package))
Reviewed-by: Kris Bahnsen <Kris@embeddedTS.com>
Thanks for that! I was not readily aware of that syntax for kernel config fixups.
I've also added auto-builds to my filter exception rules so I should be able
to more readily look those over in the future.
-Kris
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options
2022-09-20 17:01 ` Kris Bahnsen via buildroot
@ 2022-09-20 17:20 ` Giulio Benetti
0 siblings, 0 replies; 5+ messages in thread
From: Giulio Benetti @ 2022-09-20 17:20 UTC (permalink / raw)
To: kris; +Cc: buildroot
Hi Kris,
> Il giorno 20 set 2022, alle ore 19:10, Kris Bahnsen <kris@embeddedts.com> ha scritto:
>
> On Tue, 2022-09-20 at 15:32 +0200, Giulio Benetti wrote:
>> Enable Linux options depending on the bus has been chosen, so:
>> 1) enable by default common Linux options:
>> CONFIG_NET
>> CONFIG_WIRELESS
>> CONFIG_CFG80211
>> CONFIG_CRC_ITU_T
>> CONFIG_CRC7
>> 2) enable for SDIO bus:
>> CONFIG_MMC
>> 3) enable for SPI bus:
>> CONFIG_SPI
>>
>> Fixes:
>> http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/
>>
>> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
>> ---
>> package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++
>> 1 file changed, 16 insertions(+)
>>
>> diff --git a/package/wilc-driver/wilc-driver.mk b/package/wilc-driver/wilc-driver.mk
>> index a89af30e29..a7a902b6db 100644
>> --- a/package/wilc-driver/wilc-driver.mk
>> +++ b/package/wilc-driver/wilc-driver.mk
>> @@ -13,11 +13,17 @@ WILC_DRIVER_LICENSE_FILES = LICENSE
>> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SPI),y)
>> WILC_DRIVER_MODULE_MAKE_OPTS += \
>> CONFIG_WILC_SPI=m
>> +define WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_SPI)
>> +endef
>> endif
>>
>> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO),y)
>> WILC_DRIVER_MODULE_MAKE_OPTS += \
>> CONFIG_WILC_SDIO=m
>> +define WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_MMC)
>> +endef
>> endif
>>
>> ifeq ($(BR2_PACKAGE_WILC_DRIVER_SDIO_OOB),y)
>> @@ -25,5 +31,15 @@ WILC_DRIVER_MODULE_MAKE_OPTS += \
>> CONFIG_WILC_HW_OOB_INTR=y
>> endif
>>
>> +define WILC_DRIVER_LINUX_CONFIG_FIXUPS
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_NET)
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_WIRELESS)
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_CFG80211)
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC_ITU_T)
>> + $(call KCONFIG_ENABLE_OPT,CONFIG_CRC7)
>> + $(WILC_DRIVER_SPI_LINUX_CONFIG_FIXUPS)
>> + $(WILC_DRIVER_SDIO_LINUX_CONFIG_FIXUPS)
>> +endef
>> +
>> $(eval $(kernel-module))
>> $(eval $(generic-package))
>
> Reviewed-by: Kris Bahnsen <Kris@embeddedTS.com>
>
>
> Thanks for that!
No problem!
> I was not readily aware of that syntax for kernel config fixups.
They are very helpful and easy to use.
> I've also added auto-builds to my filter exception rules so I should be able
> to more readily look those over in the future.
Awesome :-)
Thanks for reviewing and
Kind regards
—
Giulio Benetti
Benetti Engineering sas
>
> -Kris
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options
2022-09-20 13:32 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options Giulio Benetti
2022-09-20 17:01 ` Kris Bahnsen via buildroot
@ 2022-11-24 21:58 ` Thomas Petazzoni via buildroot
2022-12-05 21:31 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Thomas Petazzoni via buildroot @ 2022-11-24 21:58 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Kris Bahnsen, buildroot
On Tue, 20 Sep 2022 15:32:24 +0200
Giulio Benetti <giulio.benetti@benettiengineering.com> wrote:
> Enable Linux options depending on the bus has been chosen, so:
> 1) enable by default common Linux options:
> CONFIG_NET
> CONFIG_WIRELESS
> CONFIG_CFG80211
> CONFIG_CRC_ITU_T
> CONFIG_CRC7
> 2) enable for SDIO bus:
> CONFIG_MMC
> 3) enable for SPI bus:
> CONFIG_SPI
>
> Fixes:
> http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/
>
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
> ---
> package/wilc-driver/wilc-driver.mk | 16 ++++++++++++++++
> 1 file changed, 16 insertions(+)
Applied to master, thanks.
Thomas
--
Thomas Petazzoni, CTO, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options
2022-09-20 13:32 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options Giulio Benetti
2022-09-20 17:01 ` Kris Bahnsen via buildroot
2022-11-24 21:58 ` Thomas Petazzoni via buildroot
@ 2022-12-05 21:31 ` Peter Korsgaard
2 siblings, 0 replies; 5+ messages in thread
From: Peter Korsgaard @ 2022-12-05 21:31 UTC (permalink / raw)
To: Giulio Benetti; +Cc: Kris Bahnsen, buildroot
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
> Enable Linux options depending on the bus has been chosen, so:
> 1) enable by default common Linux options:
> CONFIG_NET
> CONFIG_WIRELESS
> CONFIG_CFG80211
> CONFIG_CRC_ITU_T
> CONFIG_CRC7
> 2) enable for SDIO bus:
> CONFIG_MMC
> 3) enable for SPI bus:
> CONFIG_SPI
> Fixes:
> http://autobuild.buildroot.net/results/d8c4f0f959dd2ec110db8a75980f13172c3c116c/
> Signed-off-by: Giulio Benetti <giulio.benetti@benettiengineering.com>
Committed to 2022.08.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-12-05 21:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-20 13:32 [Buildroot] [PATCH] package/wilc-driver: fix build failure due to missing Linux options Giulio Benetti
2022-09-20 17:01 ` Kris Bahnsen via buildroot
2022-09-20 17:20 ` Giulio Benetti
2022-11-24 21:58 ` Thomas Petazzoni via buildroot
2022-12-05 21:31 ` Peter Korsgaard
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.