All of lore.kernel.org
 help / color / mirror / Atom feed
* [-next] staging/comedi regressions
@ 2013-03-12 22:13 Geert Uytterhoeven
  2013-03-12 22:21 ` Greg Kroah-Hartman
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2013-03-12 22:13 UTC (permalink / raw)
  To: H Hartley Sweeten, Greg Kroah-Hartman
  Cc: driverdevel, linux-kernel, Linux-Next

m68k/allmodconfig:

drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
undeclared (first use in this function)
drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
identifier is reported only once
drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
function it appears in.)
drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
undeclared (first use in this function)
drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
undeclared (first use in this function)

http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/

Seems like the following two commits removed some macros:

commit 6293e35742550320b1720044f9969d9544a5deaa
Author: H Hartley Sweeten <hsweeten@visionengravers.com>
Date:   Tue Mar 5 10:20:41 2013 -0700

    staging: comedi: ni_stc.h: remove boardtype macro

ayla$ git show f5a1d92bf6f4fa063d5ea43613f43494896e333f
commit f5a1d92bf6f4fa063d5ea43613f43494896e333f
Author: H Hartley Sweeten <hsweeten@visionengravers.com>
Date:   Tue Mar 5 10:21:03 2013 -0700

    staging: comedi: ni_stc.h: remove n_ni_boards macro

while they're still used by drivers/staging/comedi/drivers/ni_atmio.c.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [-next] staging/comedi regressions
  2013-03-12 22:13 [-next] staging/comedi regressions Geert Uytterhoeven
@ 2013-03-12 22:21 ` Greg Kroah-Hartman
  2013-03-14 19:33   ` Geert Uytterhoeven
  0 siblings, 1 reply; 5+ messages in thread
From: Greg Kroah-Hartman @ 2013-03-12 22:21 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: H Hartley Sweeten, driverdevel, Linux-Next, linux-kernel

On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
> m68k/allmodconfig:
> 
> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
> undeclared (first use in this function)
> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
> identifier is reported only once
> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
> function it appears in.)
> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
> undeclared (first use in this function)
> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
> undeclared (first use in this function)
> 
> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/

Hartley already fixed it, this will show up in the next linux-next tree
as I commited the fix a few hours ago.

thanks,

greg k-h

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [-next] staging/comedi regressions
  2013-03-12 22:21 ` Greg Kroah-Hartman
@ 2013-03-14 19:33   ` Geert Uytterhoeven
  2013-03-14 20:28       ` H Hartley Sweeten
  0 siblings, 1 reply; 5+ messages in thread
From: Geert Uytterhoeven @ 2013-03-14 19:33 UTC (permalink / raw)
  To: Greg Kroah-Hartman
  Cc: H Hartley Sweeten, driverdevel, Linux-Next, linux-kernel

On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman
<gregkh@linuxfoundation.org> wrote:
> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>> m68k/allmodconfig:
>>
>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
>> undeclared (first use in this function)
>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
>> identifier is reported only once
>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
>> function it appears in.)
>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
>> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
>> undeclared (first use in this function)
>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
>> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
>> undeclared (first use in this function)
>>
>> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/
>
> Hartley already fixed it, this will show up in the next linux-next tree
> as I commited the fix a few hours ago.

Thanks, but now it fails differently:

http://kisskb.ellerman.id.au/kisskb/buildresult/8398995/
drivers/staging/comedi/drivers/ni_atmio.c:472:2: error: expected ';'
before 'printk'

There's a semicolon missing on the previous line.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [-next] staging/comedi regressions
  2013-03-14 19:33   ` Geert Uytterhoeven
@ 2013-03-14 20:28       ` H Hartley Sweeten
  0 siblings, 0 replies; 5+ messages in thread
From: H Hartley Sweeten @ 2013-03-14 20:28 UTC (permalink / raw)
  To: Geert Uytterhoeven, Greg Kroah-Hartman
  Cc: driverdevel, Linux-Next, linux-kernel

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #1: Type: text/plain; charset="utf-8", Size: 1734 bytes --]

On Thursday, March 14, 2013 12:33 PM, Geert Uytterhoeven wrote:
> On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>>> m68k/allmodconfig:
>>>
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
>>> undeclared (first use in this function)
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
>>> identifier is reported only once
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
>>> function it appears in.)
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
>>> undeclared (first use in this function)
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
>>> undeclared (first use in this function)
>>>
>>> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/
>>
>> Hartley already fixed it, this will show up in the next linux-next tree
>> as I commited the fix a few hours ago.
>
> Thanks, but now it fails differently:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/8398995/
> drivers/staging/comedi/drivers/ni_atmio.c:472:2: error: expected ';'
> before 'printk'
>
> There's a semicolon missing on the previous line.

Grrr... Sorry about that.

Patch coming in a minute.

Regards,
Hartley

ÿôèº{.nÇ+‰·Ÿ®‰­†+%ŠËÿ±éݶ\x17¥Šwÿº{.nÇ+‰·¥Š{±þG«éÿŠ{ayº\x1dʇڙë,j\a­¢f£¢·hšïêÿ‘êçz_è®\x03(­éšŽŠÝ¢j"ú\x1a¶^[m§ÿÿ¾\a«þG«éÿ¢¸?™¨è­Ú&£ø§~á¶iO•æ¬z·švØ^\x14\x04\x1a¶^[m§ÿÿÃ\fÿ¶ìÿ¢¸?–I¥

^ permalink raw reply	[flat|nested] 5+ messages in thread
* RE: [-next] staging/comedi regressions
@ 2013-03-14 20:28       ` H Hartley Sweeten
  0 siblings, 0 replies; 5+ messages in thread
From: H Hartley Sweeten @ 2013-03-14 20:28 UTC (permalink / raw)
  To: Geert Uytterhoeven, Greg Kroah-Hartman
  Cc: driverdevel, Linux-Next, linux-kernel

On Thursday, March 14, 2013 12:33 PM, Geert Uytterhoeven wrote:
> On Tue, Mar 12, 2013 at 11:21 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote:
>> On Tue, Mar 12, 2013 at 11:13:50PM +0100, Geert Uytterhoeven wrote:
>>> m68k/allmodconfig:
>>>
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_isapnp_find_board’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: ‘n_ni_boards’
>>> undeclared (first use in this function)
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: (Each undeclared
>>> identifier is reported only once
>>> drivers/staging/comedi/drivers/ni_atmio.c:353: error: for each
>>> function it appears in.)
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_getboardtype’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:391: error: ‘n_ni_boards’
>>> undeclared (first use in this function)
>>> drivers/staging/comedi/drivers/ni_atmio.c: In function ‘ni_atmio_attach’:
>>> drivers/staging/comedi/drivers/ni_atmio.c:470: error: ‘boardtype’
>>> undeclared (first use in this function)
>>>
>>> http://kisskb.ellerman.id.au/kisskb/buildresult/8392062/
>>
>> Hartley already fixed it, this will show up in the next linux-next tree
>> as I commited the fix a few hours ago.
>
> Thanks, but now it fails differently:
>
> http://kisskb.ellerman.id.au/kisskb/buildresult/8398995/
> drivers/staging/comedi/drivers/ni_atmio.c:472:2: error: expected ';'
> before 'printk'
>
> There's a semicolon missing on the previous line.

Grrr... Sorry about that.

Patch coming in a minute.

Regards,
Hartley

_______________________________________________
devel mailing list
devel@linuxdriverproject.org
http://driverdev.linuxdriverproject.org/mailman/listinfo/devel

^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2013-03-14 20:36 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2013-03-12 22:13 [-next] staging/comedi regressions Geert Uytterhoeven
2013-03-12 22:21 ` Greg Kroah-Hartman
2013-03-14 19:33   ` Geert Uytterhoeven
2013-03-14 20:28     ` H Hartley Sweeten
2013-03-14 20:28       ` H Hartley Sweeten

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.