From: Segher Boessenkool <segher@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@lists.ozlabs.org,
devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au, benh@kernel.crashing.org,
sfr@canb.auug.org.au, davem@davemloft.net, monstr@monstr.eu
Subject: Re: [PATCH v2 11/11] of: unify phandle name in struct device_node
Date: Wed, 25 Nov 2009 02:30:45 +0100 [thread overview]
Message-ID: <AE8D50AE-03EE-45FC-80EF-376F0836B5CB@kernel.crashing.org> (raw)
In-Reply-To: <20091124215908.559.23998.stgit@angua>
> In struct device_node, the phandle is named 'linux_phandle' for
> PowerPC
> and MicroBlaze, and 'node' for SPARC. There is no good reason for the
> difference, it is just an artifact of the code diverging over a couple
> of years. This patch renames both to simply .phandle.
>
> Note: the .node also existed in PowerPC/MicroBlaze, but the only user
> seems to be arch/powerpc/platforms/powermac/pfunc_core.c. It doesn't
> look like the assignment between .linux_phandle and .node is
> significantly different enough to warrant the separate code paths
> unless ibm,phandle properties actually appear in Apple device trees.
>
> I think it is safe to eliminate the old .node property and use
> linux_phandle everywhere.
^^^^^^^^^^^^ You forgot to update one :-)
>
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: linuxppc-dev@lists.ozlabs.org,
devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org,
microblaze-uclinux@itee.uq.edu.au, benh@kernel.crashing.org,
sfr@canb.auug.org.au, davem@davemloft.net, monstr@monstr.eu
Subject: Re: [PATCH v2 11/11] of: unify phandle name in struct device_node
Date: Wed, 25 Nov 2009 01:30:45 +0000 [thread overview]
Message-ID: <AE8D50AE-03EE-45FC-80EF-376F0836B5CB@kernel.crashing.org> (raw)
In-Reply-To: <20091124215908.559.23998.stgit@angua>
> In struct device_node, the phandle is named 'linux_phandle' for
> PowerPC
> and MicroBlaze, and 'node' for SPARC. There is no good reason for the
> difference, it is just an artifact of the code diverging over a couple
> of years. This patch renames both to simply .phandle.
>
> Note: the .node also existed in PowerPC/MicroBlaze, but the only user
> seems to be arch/powerpc/platforms/powermac/pfunc_core.c. It doesn't
> look like the assignment between .linux_phandle and .node is
> significantly different enough to warrant the separate code paths
> unless ibm,phandle properties actually appear in Apple device trees.
>
> I think it is safe to eliminate the old .node property and use
> linux_phandle everywhere.
^^^^^^^^^^^^ You forgot to update one :-)
>
Segher
WARNING: multiple messages have this Message-ID (diff)
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Grant Likely <grant.likely@secretlab.ca>
Cc: sfr@canb.auug.org.au, monstr@monstr.eu,
microblaze-uclinux@itee.uq.edu.au,
devicetree-discuss@lists.ozlabs.org, sparclinux@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, davem@davemloft.net
Subject: Re: [PATCH v2 11/11] of: unify phandle name in struct device_node
Date: Wed, 25 Nov 2009 02:30:45 +0100 [thread overview]
Message-ID: <AE8D50AE-03EE-45FC-80EF-376F0836B5CB@kernel.crashing.org> (raw)
In-Reply-To: <20091124215908.559.23998.stgit@angua>
> In struct device_node, the phandle is named 'linux_phandle' for
> PowerPC
> and MicroBlaze, and 'node' for SPARC. There is no good reason for the
> difference, it is just an artifact of the code diverging over a couple
> of years. This patch renames both to simply .phandle.
>
> Note: the .node also existed in PowerPC/MicroBlaze, but the only user
> seems to be arch/powerpc/platforms/powermac/pfunc_core.c. It doesn't
> look like the assignment between .linux_phandle and .node is
> significantly different enough to warrant the separate code paths
> unless ibm,phandle properties actually appear in Apple device trees.
>
> I think it is safe to eliminate the old .node property and use
> linux_phandle everywhere.
^^^^^^^^^^^^ You forgot to update one :-)
>
Segher
next prev parent reply other threads:[~2009-11-25 1:30 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-11-24 22:01 [PATCH v2 11/11] of: unify phandle name in struct device_node Grant Likely
2009-11-24 22:01 ` Grant Likely
2009-11-24 22:01 ` Grant Likely
2009-11-24 22:22 ` David Miller
2009-11-24 22:22 ` David Miller
2009-11-24 22:22 ` David Miller
2009-11-25 1:30 ` Segher Boessenkool [this message]
2009-11-25 1:30 ` Segher Boessenkool
2009-11-25 1:30 ` Segher Boessenkool
2009-11-25 1:33 ` Grant Likely
2009-11-25 1:33 ` Grant Likely
2009-11-25 1:33 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AE8D50AE-03EE-45FC-80EF-376F0836B5CB@kernel.crashing.org \
--to=segher@kernel.crashing.org \
--cc=benh@kernel.crashing.org \
--cc=davem@davemloft.net \
--cc=devicetree-discuss@lists.ozlabs.org \
--cc=grant.likely@secretlab.ca \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=microblaze-uclinux@itee.uq.edu.au \
--cc=monstr@monstr.eu \
--cc=sfr@canb.auug.org.au \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.