* [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs
@ 2018-05-08 10:43 Jonathan Gray
2018-05-09 8:06 ` Kever Yang
` (5 more replies)
0 siblings, 6 replies; 9+ messages in thread
From: Jonathan Gray @ 2018-05-08 10:43 UTC (permalink / raw)
To: u-boot
Add back part of patch send out as
'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
gotten lost when it got merged to set SYS_NS16550_MEM32.
Allows serial output to work on tinker-rk3288 again after
c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
---
include/configs/rockchip-common.h | 2 ++
1 file changed, 2 insertions(+)
diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
index dee82ca99d..68e1105a4b 100644
--- a/include/configs/rockchip-common.h
+++ b/include/configs/rockchip-common.h
@@ -7,6 +7,8 @@
#define _ROCKCHIP_COMMON_H_
#include <linux/sizes.h>
+#define CONFIG_SYS_NS16550_MEM32
+
#ifndef CONFIG_SPL_BUILD
/* First try to boot from SD (index 0), then eMMC (index 1) */
--
2.16.2
^ permalink raw reply related [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
@ 2018-05-09 8:06 ` Kever Yang
2018-05-09 8:12 ` Dr. Philipp Tomsich
2018-05-09 8:14 ` [U-Boot] " Philipp Tomsich
` (4 subsequent siblings)
5 siblings, 1 reply; 9+ messages in thread
From: Kever Yang @ 2018-05-09 8:06 UTC (permalink / raw)
To: u-boot
Hi Jonathan,
Thanks for the patch, and it's interesting how this is missing,
it means all the rockchip socs can not get console output with v2018.05 :(
Thanks,
- Kever
On 05/08/2018 06:43 PM, Jonathan Gray wrote:
> Add back part of patch send out as
> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
> gotten lost when it got merged to set SYS_NS16550_MEM32.
>
> Allows serial output to work on tinker-rk3288 again after
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> include/configs/rockchip-common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index dee82ca99d..68e1105a4b 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -7,6 +7,8 @@
> #define _ROCKCHIP_COMMON_H_
> #include <linux/sizes.h>
>
> +#define CONFIG_SYS_NS16550_MEM32
> +
> #ifndef CONFIG_SPL_BUILD
>
> /* First try to boot from SD (index 0), then eMMC (index 1) */
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-09 8:06 ` Kever Yang
@ 2018-05-09 8:12 ` Dr. Philipp Tomsich
2018-05-09 8:23 ` Dr. Philipp Tomsich
0 siblings, 1 reply; 9+ messages in thread
From: Dr. Philipp Tomsich @ 2018-05-09 8:12 UTC (permalink / raw)
To: u-boot
Kever,
There were a number a merge conflicts with this series and it looks like I missed
one of them. This is the risk when I try to resolve conflicts instead of asking for
a series to be rebased onto master…
Regards,
Philipp.
> On 9 May 2018, at 10:06, Kever Yang <kever.yang@rock-chips.com> wrote:
>
> Hi Jonathan,
>
>
> Thanks for the patch, and it's interesting how this is missing,
>
> it means all the rockchip socs can not get console output with v2018.05 :(
>
>
> Thanks,
> - Kever
> On 05/08/2018 06:43 PM, Jonathan Gray wrote:
>> Add back part of patch send out as
>> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
>> gotten lost when it got merged to set SYS_NS16550_MEM32.
>>
>> Allows serial output to work on tinker-rk3288 again after
>> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>>
>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
>> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>> ---
>> include/configs/rockchip-common.h | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
>> index dee82ca99d..68e1105a4b 100644
>> --- a/include/configs/rockchip-common.h
>> +++ b/include/configs/rockchip-common.h
>> @@ -7,6 +7,8 @@
>> #define _ROCKCHIP_COMMON_H_
>> #include <linux/sizes.h>
>>
>> +#define CONFIG_SYS_NS16550_MEM32
>> +
>> #ifndef CONFIG_SPL_BUILD
>>
>> /* First try to boot from SD (index 0), then eMMC (index 1) */
>
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
2018-05-09 8:06 ` Kever Yang
@ 2018-05-09 8:14 ` Philipp Tomsich
2018-05-09 8:14 ` Philipp Tomsich
` (3 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Philipp Tomsich @ 2018-05-09 8:14 UTC (permalink / raw)
To: u-boot
> Add back part of patch send out as
> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
> gotten lost when it got merged to set SYS_NS16550_MEM32.
>
> Allows serial output to work on tinker-rk3288 again after
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> include/configs/rockchip-common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
2018-05-09 8:06 ` Kever Yang
2018-05-09 8:14 ` [U-Boot] " Philipp Tomsich
@ 2018-05-09 8:14 ` Philipp Tomsich
2018-05-09 8:19 ` Philipp Tomsich
` (2 subsequent siblings)
5 siblings, 0 replies; 9+ messages in thread
From: Philipp Tomsich @ 2018-05-09 8:14 UTC (permalink / raw)
To: u-boot
> Add back part of patch send out as
> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
> gotten lost when it got merged to set SYS_NS16550_MEM32.
>
> Allows serial output to work on tinker-rk3288 again after
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> include/configs/rockchip-common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
` (2 preceding siblings ...)
2018-05-09 8:14 ` Philipp Tomsich
@ 2018-05-09 8:19 ` Philipp Tomsich
2018-05-09 16:47 ` [U-Boot] [PATCH] " Heinrich Schuchardt
2018-05-09 19:10 ` [U-Boot] " Philipp Tomsich
5 siblings, 0 replies; 9+ messages in thread
From: Philipp Tomsich @ 2018-05-09 8:19 UTC (permalink / raw)
To: u-boot
> Add back part of patch send out as
> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
> gotten lost when it got merged to set SYS_NS16550_MEM32.
>
> Allows serial output to work on tinker-rk3288 again after
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> ---
> include/configs/rockchip-common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-09 8:12 ` Dr. Philipp Tomsich
@ 2018-05-09 8:23 ` Dr. Philipp Tomsich
0 siblings, 0 replies; 9+ messages in thread
From: Dr. Philipp Tomsich @ 2018-05-09 8:23 UTC (permalink / raw)
To: u-boot
Kever,
if this affects all SoCs, then apparently nobody tested -rc3 … I had made sure that
all these last-minute changes had gone in before rc3.
Regards,
Philipp.
> On 9 May 2018, at 10:12, Dr. Philipp Tomsich <philipp.tomsich@theobroma-systems.com> wrote:
>
> Kever,
>
> There were a number a merge conflicts with this series and it looks like I missed
> one of them. This is the risk when I try to resolve conflicts instead of asking for
> a series to be rebased onto master…
>
> Regards,
> Philipp.
>
>> On 9 May 2018, at 10:06, Kever Yang <kever.yang@rock-chips.com> wrote:
>>
>> Hi Jonathan,
>>
>>
>> Thanks for the patch, and it's interesting how this is missing,
>>
>> it means all the rockchip socs can not get console output with v2018.05 :(
>>
>>
>> Thanks,
>> - Kever
>> On 05/08/2018 06:43 PM, Jonathan Gray wrote:
>>> Add back part of patch send out as
>>> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
>>> gotten lost when it got merged to set SYS_NS16550_MEM32.
>>>
>>> Allows serial output to work on tinker-rk3288 again after
>>> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>>>
>>> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
>>> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
>>> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
>>> ---
>>> include/configs/rockchip-common.h | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
>>> index dee82ca99d..68e1105a4b 100644
>>> --- a/include/configs/rockchip-common.h
>>> +++ b/include/configs/rockchip-common.h
>>> @@ -7,6 +7,8 @@
>>> #define _ROCKCHIP_COMMON_H_
>>> #include <linux/sizes.h>
>>>
>>> +#define CONFIG_SYS_NS16550_MEM32
>>> +
>>> #ifndef CONFIG_SPL_BUILD
>>>
>>> /* First try to boot from SD (index 0), then eMMC (index 1) */
>>
>>
>
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
` (3 preceding siblings ...)
2018-05-09 8:19 ` Philipp Tomsich
@ 2018-05-09 16:47 ` Heinrich Schuchardt
2018-05-09 19:10 ` [U-Boot] " Philipp Tomsich
5 siblings, 0 replies; 9+ messages in thread
From: Heinrich Schuchardt @ 2018-05-09 16:47 UTC (permalink / raw)
To: u-boot
On 05/08/2018 12:43 PM, Jonathan Gray wrote:
> Add back part of patch send out as
> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
> gotten lost when it got merged to set SYS_NS16550_MEM32.
>
> Allows serial output to work on tinker-rk3288 again after
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>
> Signed-off-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
With the patch I get a serial console on the Asus Tinker-Board (RK3288).
Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/configs/rockchip-common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/include/configs/rockchip-common.h b/include/configs/rockchip-common.h
> index dee82ca99d..68e1105a4b 100644
> --- a/include/configs/rockchip-common.h
> +++ b/include/configs/rockchip-common.h
> @@ -7,6 +7,8 @@
> #define _ROCKCHIP_COMMON_H_
> #include <linux/sizes.h>
>
> +#define CONFIG_SYS_NS16550_MEM32
> +
> #ifndef CONFIG_SPL_BUILD
>
> /* First try to boot from SD (index 0), then eMMC (index 1) */
>
^ permalink raw reply [flat|nested] 9+ messages in thread
* [U-Boot] rockchip: set SYS_NS16550_MEM32 for all SoCs
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
` (4 preceding siblings ...)
2018-05-09 16:47 ` [U-Boot] [PATCH] " Heinrich Schuchardt
@ 2018-05-09 19:10 ` Philipp Tomsich
5 siblings, 0 replies; 9+ messages in thread
From: Philipp Tomsich @ 2018-05-09 19:10 UTC (permalink / raw)
To: u-boot
> Add back part of patch send out as
> 'rockchip: enable SYS_NS16550 for all SoCs by default' that seems to have
> gotten lost when it got merged to set SYS_NS16550_MEM32.
>
> Allows serial output to work on tinker-rk3288 again after
> c3c0331db1fb7b1f4ff41e144fc04353b37c785c.
>
> Signed-off-by: Kever Yang <kever.yang@rock-chips.com>
> Signed-off-by: Jonathan Gray <jsg@jsg.id.au>
> Cc: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Acked-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Reviewed-by: Philipp Tomsich <philipp.tomsich@theobroma-systems.com>
> Tested-by: Heinrich Schuchardt <xypron.glpk@gmx.de>
> ---
> include/configs/rockchip-common.h | 2 ++
> 1 file changed, 2 insertions(+)
>
Applied to u-boot-rockchip, thanks!
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2018-05-09 19:10 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-05-08 10:43 [U-Boot] [PATCH] rockchip: set SYS_NS16550_MEM32 for all SoCs Jonathan Gray
2018-05-09 8:06 ` Kever Yang
2018-05-09 8:12 ` Dr. Philipp Tomsich
2018-05-09 8:23 ` Dr. Philipp Tomsich
2018-05-09 8:14 ` [U-Boot] " Philipp Tomsich
2018-05-09 8:14 ` Philipp Tomsich
2018-05-09 8:19 ` Philipp Tomsich
2018-05-09 16:47 ` [U-Boot] [PATCH] " Heinrich Schuchardt
2018-05-09 19:10 ` [U-Boot] " Philipp Tomsich
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.