All of lore.kernel.org
 help / color / mirror / Atom feed
From: Himanshu Madhani <himanshu.madhani@oracle.com>
To: Nilesh Javali <njavali@marvell.com>
Cc: martin.petersen@oracle.com, linux-scsi@vger.kernel.org,
	GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 2/2] scsi: fc: Update documentation of sysfs nodes for FPIN stats
Date: Wed, 9 Sep 2020 08:51:48 -0500	[thread overview]
Message-ID: <AF2CA7B1-045B-4197-AE6A-D5121A2AC424@oracle.com> (raw)
In-Reply-To: <20200730061116.20111-3-njavali@marvell.com>



> On Jul 30, 2020, at 1:11 AM, Nilesh Javali <njavali@marvell.com> wrote:
> 
> From: Shyam Sundar <ssundar@marvell.com>
> 
> Update documentation for sysfs nodes within,
>       /sys/class/fc_host
>       /sys/class/fc_remote_ports
> 
> Signed-off-by: Shyam Sundar <ssundar@marvell.com>
> Signed-off-by: Nilesh Javali <njavali@marvell.com>
> ---
> Documentation/ABI/testing/sysfs-class-fc_host | 23 +++++++++++++++++++
> .../ABI/testing/sysfs-class-fc_remote_ports   | 23 +++++++++++++++++++
> 2 files changed, 46 insertions(+)
> create mode 100644 Documentation/ABI/testing/sysfs-class-fc_host
> create mode 100644 Documentation/ABI/testing/sysfs-class-fc_remote_ports
> 
> diff --git a/Documentation/ABI/testing/sysfs-class-fc_host b/Documentation/ABI/testing/sysfs-class-fc_host
> new file mode 100644
> index 000000000000..a1e6ab89b86f
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-fc_host
> @@ -0,0 +1,23 @@
> +What:		/sys/class/fc_host/hostX/statistics/fpin_cn_yyy
> +Date:		July 2020
> +Contact:	Shyam Sundar <ssundar@marvell.com>
> +Description:
> +		These files contain the number of Fabric Performance Impact
> +		Notification (FPIN) events generated by the fabric, to indicate
> +		congestion detected on this host.
> +
> +What:		/sys/class/fc_host/hostX/statistics/fpin_li_yyy
> +Date:		July 2020
> +Contact:	Shyam Sundar <ssundar@marvell.com>
> +Description:
> +		These files contain the number of Fabric Performance Impact
> +		Notification (FPIN) events generated by the fabric, to indicate
> +		Link Integrity errors between the fabric and this host.
> +
> +What:		/sys/class/fc_host/hostX/statistics/fpin_dn_yyy
> +Date:		July 2020
> +Contact:	Shyam Sundar <ssundar@marvell.com>
> +Description:
> +		These files contain the number of Fabric Performance Impact
> +		Notification (FPIN) events generated by the fabric, to indicate
> +		Delivery related errors between the fabric and this host.
> diff --git a/Documentation/ABI/testing/sysfs-class-fc_remote_ports b/Documentation/ABI/testing/sysfs-class-fc_remote_ports
> new file mode 100644
> index 000000000000..185db8ec6c05
> --- /dev/null
> +++ b/Documentation/ABI/testing/sysfs-class-fc_remote_ports
> @@ -0,0 +1,23 @@
> +What:		/sys/class/fc_remote_ports/rport-X:Y-Z/statistics/fpin_cn_yyy
> +Date:		July 2020
> +Contact:	Shyam Sundar <ssundar@marvell.com>
> +Description:
> +		These files contain the number of Fabric Performance Impact
> +		Notification (FPIN) events generated by the fabric, to indicate
> +		congestion detected on this rport.
> +
> +What:		/sys/class/fc_remote_ports/rport-X:Y-Z/statistics/fpin_li_yyy
> +Date:		July 2020
> +Contact:	Shyam Sundar <ssundar@marvell.com>
> +Description:
> +		These files contain the number of Fabric Performance Impact
> +		Notification (FPIN) events generated by the fabric, to indicate
> +		Link Integrity errors between the fabric and this rport.
> +
> +What:		/sys/class/fc_remote_ports/rport-X:Y-Z/statistics/fpin_dn_yyy
> +Date:		July 2020
> +Contact:	Shyam Sundar <ssundar@marvell.com>
> +Description:
> +		These files contain the number of Fabric Performance Impact
> +		Notification (FPIN) events generated by the fabric, to indicate
> +		Delivery related errors between the fabric and this rport.
> -- 
> 2.19.0.rc0
> 

Looks Good to me. 

Reviewed-by: Himanshu Madhani <himanshu.madhani@oracle.com>

--
Himanshu Madhani	 Oracle Linux Engineering


  reply	other threads:[~2020-09-09 16:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-07-30  6:11 [PATCH 0/2] SAN Congestion Management (SCM) statistics Nilesh Javali
2020-07-30  6:11 ` [PATCH 1/2] scsi: fc: Update statistics for host and rport on FPIN reception Nilesh Javali
2020-09-09 13:51   ` Himanshu Madhani
2020-09-23  0:01   ` James Smart
2020-09-28 20:07     ` Shyam Sundar
2020-09-29 21:33       ` James Smart
2020-09-30 20:55         ` [EXT] " Shyam Sundar
2021-10-01  1:37   ` kernel test robot
2021-10-01  1:37     ` kernel test robot
2020-07-30  6:11 ` [PATCH 2/2] scsi: fc: Update documentation of sysfs nodes for FPIN stats Nilesh Javali
2020-09-09 13:51   ` Himanshu Madhani [this message]
2020-09-23  0:15   ` James Smart
2020-09-07 10:44 ` [PATCH 0/2] SAN Congestion Management (SCM) statistics Nilesh Javali
2020-09-09  2:57   ` Martin K. Petersen
2020-09-17 16:53     ` [EXT] " Nilesh Javali
2020-09-23  8:38       ` Hannes Reinecke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AF2CA7B1-045B-4197-AE6A-D5121A2AC424@oracle.com \
    --to=himanshu.madhani@oracle.com \
    --cc=GR-QLogic-Storage-Upstream@marvell.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=martin.petersen@oracle.com \
    --cc=njavali@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.