Re: [PATCH 1/2] scsi: fc: Update statistics for host and rport on FPIN reception.

From: kernel test robot <lkp@intel.com>
To: Nilesh Javali <njavali@marvell.com>, martin.petersen@oracle.com
Cc: kbuild-all@lists.01.org, linux-scsi@vger.kernel.org,
	GR-QLogic-Storage-Upstream@marvell.com
Subject: Re: [PATCH 1/2] scsi: fc: Update statistics for host and rport on FPIN reception.
Date: Fri, 1 Oct 2021 09:37:48 +0800	[thread overview]
Message-ID: <202110010926.tZM7VbP2-lkp@intel.com> (raw)
In-Reply-To: <20200730061116.20111-2-njavali@marvell.com>

[-- Attachment #1: Type: text/plain, Size: 2587 bytes --]

Hi Nilesh,

I love your patch! Perhaps something to improve:

[auto build test WARNING on 3c330f187ea84b13a0c66311115c8fd449dd25a1]

url:    https://github.com/0day-ci/linux/commits/Nilesh-Javali/SAN-Congestion-Management-SCM-statistics/20210929-162329
base:   3c330f187ea84b13a0c66311115c8fd449dd25a1
config: powerpc-allyesconfig (attached as .config)
compiler: powerpc64-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/f4af1bddbc082f1719040fce0d592feeb4db84a6
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Nilesh-Javali/SAN-Congestion-Management-SCM-statistics/20210929-162329
        git checkout f4af1bddbc082f1719040fce0d592feeb4db84a6
        # save the attached .config to linux build tree
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross ARCH=powerpc 

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <lkp@intel.com>

All warnings (new ones prefixed by >>):

>> drivers/scsi/scsi_transport_fc.c:645:1: warning: no previous prototype for 'fc_find_rport_by_wwpn' [-Wmissing-prototypes]
     645 | fc_find_rport_by_wwpn(struct Scsi_Host *shost, u64 wwpn)
         | ^~~~~~~~~~~~~~~~~~~~~

vim +/fc_find_rport_by_wwpn +645 drivers/scsi/scsi_transport_fc.c

   635	
   636	/**
   637	 * fc_find_rport_by_wwpn - find the fc_rport pointer for a given wwpn
   638	 * @shost:		host the fc_rport is associated with
   639	 * @wwpn:		wwpn of the fc_rport device
   640	 *
   641	 * Notes:
   642	 *	This routine assumes no locks are held on entry.
   643	 */
   644	struct fc_rport *
 > 645	fc_find_rport_by_wwpn(struct Scsi_Host *shost, u64 wwpn)
   646	{
   647		struct fc_rport *rport, *found = NULL;
   648		unsigned long flags;
   649	
   650		spin_lock_irqsave(shost->host_lock, flags);
   651	
   652		list_for_each_entry(rport, &fc_host_rports(shost), peers) {
   653			if (rport->scsi_target_id == -1)
   654				continue;
   655	
   656			if (rport->port_state != FC_PORTSTATE_ONLINE)
   657				continue;
   658	
   659			if (rport->port_name == wwpn)
   660				found = rport;
   661		}
   662	
   663		spin_unlock_irqrestore(shost->host_lock, flags);
   664		return found;
   665	}
   666	EXPORT_SYMBOL(fc_find_rport_by_wwpn);
   667	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org

[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 69728 bytes --]