* umount.nfs4 is disturbed by /proc/mounts
@ 2011-02-17 23:44 Jan Engelhardt
2011-02-18 17:11 ` Chuck Lever
2011-02-19 22:28 ` Chuck Lever
0 siblings, 2 replies; 6+ messages in thread
From: Jan Engelhardt @ 2011-02-17 23:44 UTC (permalink / raw)
To: linux-nfs; +Cc: kzak
Recent distributions start to have /etc/mtab being a symlink to
/proc/mounts with util-linux 2.19. Subsequently, this annoys umount.nfs4
from nfs-client-1.2.3 and emits a warning:
jng-0:/ # grep nfs4 /proc/mounts
10.10.1.1:/home/ /home nfs4 rw,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=10.10.1.212,minorversion=0,local_lock=none,addr=10.10.1.1 0 0
jng-0:/ # umount /home
umount.nfs4: invalid value for 'port=' option
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: umount.nfs4 is disturbed by /proc/mounts
2011-02-17 23:44 umount.nfs4 is disturbed by /proc/mounts Jan Engelhardt
@ 2011-02-18 17:11 ` Chuck Lever
2011-02-18 19:28 ` Jeff Layton
2011-02-19 22:28 ` Chuck Lever
1 sibling, 1 reply; 6+ messages in thread
From: Chuck Lever @ 2011-02-18 17:11 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linux-nfs, kzak
On Feb 17, 2011, at 3:44 PM, Jan Engelhardt wrote:
>
> Recent distributions start to have /etc/mtab being a symlink to
> /proc/mounts with util-linux 2.19. Subsequently, this annoys umount.nfs4
> from nfs-client-1.2.3 and emits a warning:
>
> jng-0:/ # grep nfs4 /proc/mounts
> 10.10.1.1:/home/ /home nfs4 rw,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=10.10.1.212,minorversion=0,local_lock=none,addr=10.10.1.1 0 0
> jng-0:/ # umount /home
> umount.nfs4: invalid value for 'port=' option
I can take a look at this.
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: umount.nfs4 is disturbed by /proc/mounts
2011-02-18 17:11 ` Chuck Lever
@ 2011-02-18 19:28 ` Jeff Layton
2011-02-18 19:56 ` Karel Zak
0 siblings, 1 reply; 6+ messages in thread
From: Jeff Layton @ 2011-02-18 19:28 UTC (permalink / raw)
To: Chuck Lever; +Cc: Jan Engelhardt, linux-nfs, kzak
On Fri, 18 Feb 2011 09:11:54 -0800
Chuck Lever <chuck.lever@oracle.com> wrote:
>
> On Feb 17, 2011, at 3:44 PM, Jan Engelhardt wrote:
>
> >
> > Recent distributions start to have /etc/mtab being a symlink to
> > /proc/mounts with util-linux 2.19. Subsequently, this annoys umount.nfs4
> > from nfs-client-1.2.3 and emits a warning:
> >
> > jng-0:/ # grep nfs4 /proc/mounts
> > 10.10.1.1:/home/ /home nfs4 rw,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=10.10.1.212,minorversion=0,local_lock=none,addr=10.10.1.1 0 0
> > jng-0:/ # umount /home
> > umount.nfs4: invalid value for 'port=' option
>
> I can take a look at this.
>
FWIW, I just fixed mount.cifs recently based on recommendations from
Karel:
http://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=fba28cfe2f13dd8bdae3cec76178f42b001a40ca
...this is the same approach that /bin/mount uses, so you're probably
safe to use a similar one for mount/umount.nfs.
--
Jeff Layton <jlayton@redhat.com>
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: umount.nfs4 is disturbed by /proc/mounts
2011-02-18 19:28 ` Jeff Layton
@ 2011-02-18 19:56 ` Karel Zak
2011-02-18 21:48 ` Chuck Lever
0 siblings, 1 reply; 6+ messages in thread
From: Karel Zak @ 2011-02-18 19:56 UTC (permalink / raw)
To: Jeff Layton; +Cc: Chuck Lever, Jan Engelhardt, linux-nfs
On Fri, Feb 18, 2011 at 02:28:28PM -0500, Jeff Layton wrote:
> On Fri, 18 Feb 2011 09:11:54 -0800
> Chuck Lever <chuck.lever@oracle.com> wrote:
>
> >
> > On Feb 17, 2011, at 3:44 PM, Jan Engelhardt wrote:
> >
> > >
> > > Recent distributions start to have /etc/mtab being a symlink to
> > > /proc/mounts with util-linux 2.19. Subsequently, this annoys umount.nfs4
> > > from nfs-client-1.2.3 and emits a warning:
> > >
> > > jng-0:/ # grep nfs4 /proc/mounts
> > > 10.10.1.1:/home/ /home nfs4 rw,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=10.10.1.212,minorversion=0,local_lock=none,addr=10.10.1.1 0 0
> > > jng-0:/ # umount /home
> > > umount.nfs4: invalid value for 'port=' option
> >
> > I can take a look at this.
> >
>
> FWIW, I just fixed mount.cifs recently based on recommendations from
> Karel:
>
> http://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=fba28cfe2f13dd8bdae3cec76178f42b001a40ca
>
> ...this is the same approach that /bin/mount uses, so you're probably
> safe to use a similar one for mount/umount.nfs.
This is not the same problem. The NFS umount/remount depends on
(userspace) values from /etc/mtab.
The solution is to link mount.nfs with libmount. I'm working on this
change... http://www.spinics.net/lists/linux-nfs/msg19165.html
I have already talked about mtab issues at fedora-devel list, see
http://lists.fedoraproject.org/pipermail/devel/2011-January/147995.html
The mount.nfs and pam_mount are on my TODO list for the next weeks.
If the changes in mount.nfs will be successful then I'd like to link
mount.cifs with libmount too.
Note that mount(8) in Fedora still supports regular mtab too, and
the regular mtab is still util-linux upstream default.
Karel
--
Karel Zak <kzak@redhat.com>
http://karelzak.blogspot.com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: umount.nfs4 is disturbed by /proc/mounts
2011-02-18 19:56 ` Karel Zak
@ 2011-02-18 21:48 ` Chuck Lever
0 siblings, 0 replies; 6+ messages in thread
From: Chuck Lever @ 2011-02-18 21:48 UTC (permalink / raw)
To: Karel Zak; +Cc: Jeff Layton, Jan Engelhardt, linux-nfs
On Feb 18, 2011, at 11:56 AM, Karel Zak wrote:
> On Fri, Feb 18, 2011 at 02:28:28PM -0500, Jeff Layton wrote:
>> On Fri, 18 Feb 2011 09:11:54 -0800
>> Chuck Lever <chuck.lever@oracle.com> wrote:
>>
>>>
>>> On Feb 17, 2011, at 3:44 PM, Jan Engelhardt wrote:
>>>
>>>>
>>>> Recent distributions start to have /etc/mtab being a symlink to
>>>> /proc/mounts with util-linux 2.19. Subsequently, this annoys umount.nfs4
>>>> from nfs-client-1.2.3 and emits a warning:
>>>>
>>>> jng-0:/ # grep nfs4 /proc/mounts
>>>> 10.10.1.1:/home/ /home nfs4 rw,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=10.10.1.212,minorversion=0,local_lock=none,addr=10.10.1.1 0 0
>>>> jng-0:/ # umount /home
>>>> umount.nfs4: invalid value for 'port=' option
>>>
>>> I can take a look at this.
>>>
>>
>> FWIW, I just fixed mount.cifs recently based on recommendations from
>> Karel:
>>
>> http://git.samba.org/?p=cifs-utils.git;a=commitdiff;h=fba28cfe2f13dd8bdae3cec76178f42b001a40ca
>>
>> ...this is the same approach that /bin/mount uses, so you're probably
>> safe to use a similar one for mount/umount.nfs.
>
> This is not the same problem. The NFS umount/remount depends on
> (userspace) values from /etc/mtab.
Right, this problem is not dependent on the existence of mtab. There is a real bug here, I suggest. port=0 is a valid specification, and the mount option parser in mount.nfs and umount.nfs should accept it. That's not dependent on whether /etc/mtab is a link or whether we are using libmount to do the work.
I have a very simple patch to fix this now, just needs testing.
> The solution is to link mount.nfs with libmount. I'm working on this
> change... http://www.spinics.net/lists/linux-nfs/msg19165.html
>
>
> I have already talked about mtab issues at fedora-devel list, see
> http://lists.fedoraproject.org/pipermail/devel/2011-January/147995.html
>
> The mount.nfs and pam_mount are on my TODO list for the next weeks.
> If the changes in mount.nfs will be successful then I'd like to link
> mount.cifs with libmount too.
>
> Note that mount(8) in Fedora still supports regular mtab too, and
> the regular mtab is still util-linux upstream default.
>
> Karel
>
> --
> Karel Zak <kzak@redhat.com>
> http://karelzak.blogspot.com
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: umount.nfs4 is disturbed by /proc/mounts
2011-02-17 23:44 umount.nfs4 is disturbed by /proc/mounts Jan Engelhardt
2011-02-18 17:11 ` Chuck Lever
@ 2011-02-19 22:28 ` Chuck Lever
1 sibling, 0 replies; 6+ messages in thread
From: Chuck Lever @ 2011-02-19 22:28 UTC (permalink / raw)
To: Jan Engelhardt; +Cc: linux-nfs, kzak
On Feb 17, 2011, at 3:44 PM, Jan Engelhardt wrote:
>
> Recent distributions start to have /etc/mtab being a symlink to
> /proc/mounts with util-linux 2.19. Subsequently, this annoys umount.nfs4
> from nfs-client-1.2.3 and emits a warning:
>
> jng-0:/ # grep nfs4 /proc/mounts
> 10.10.1.1:/home/ /home nfs4 rw,relatime,vers=4,rsize=1048576,wsize=1048576,namlen=255,hard,proto=tcp,port=0,timeo=600,retrans=2,sec=sys,clientaddr=10.10.1.212,minorversion=0,local_lock=none,addr=10.10.1.1 0 0
> jng-0:/ # umount /home
> umount.nfs4: invalid value for 'port=' option
With the latest nfs-utils (post 1.2.3) I can't reproduce this on my Fedora 13 client after replacing /etc/mtab with a symlink to /proc/mounts. I think we may have an upstream fix for this already:
commit dc08c702a6c7f824f317af561f491635ee898a71
Author: Chuck Lever <chuck.lever@oracle.com>
Date: Wed Oct 13 13:55:10 2010 -0400
umount.nfs: Distinguish between nfs4 and nfs mounts
--
Chuck Lever
chuck[dot]lever[at]oracle[dot]com
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-02-19 22:30 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2011-02-17 23:44 umount.nfs4 is disturbed by /proc/mounts Jan Engelhardt
2011-02-18 17:11 ` Chuck Lever
2011-02-18 19:28 ` Jeff Layton
2011-02-18 19:56 ` Karel Zak
2011-02-18 21:48 ` Chuck Lever
2011-02-19 22:28 ` Chuck Lever
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.