From: Stefan Agner <stefan@agner.ch>
To: Bhhuvanchandra DV <bhuvanchandra.dv@toradex.com>,
Shawn Guo <shawnguo@kernel.org>
Cc: gregkh@linuxfoundation.org, linux-serial@vger.kernel.org,
mturquette@baylibre.com, sboyd@codeaurora.org,
linux-kernel@vger.kernel.org, kernel@pengutronix.de,
jslaby@suse.com, linux-clk@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume
Date: Mon, 13 Jun 2016 19:42:10 -0700 [thread overview]
Message-ID: <AF70EE92-9B41-4ECE-AB5F-E829E611B7C6@agner.ch> (raw)
In-Reply-To: <cdeb3e9b-92c5-77d9-78ec-3af3954e8e16@toradex.com>
On June 13, 2016 5:18:19 PM PDT, Bhhuvanchandra DV <bhuvanchandra.dv@toradex.com> wrote:
>Hi Shawn,
>
>On 06/11/2016 02:03 PM, Shawn Guo wrote:
>
>> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote:
>>> From: Stefan Agner <stefan@agner.ch>
>>>
>>> In order to allow wake support in STOP sleep mode, clocks are
>>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating
>>> in low power mode STOP. This allows to enable wake by UART using:
>>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup
>>>
>>> However, if wake is not enabled, the driver should disable the
>>> clocks explicitly to save power.
>>>
>>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>>> ---
>>> drivers/clk/imx/clk-vf610.c | 12 ++++++------
>> Please send clock driver changes in a separate patch.
The changes are dependet on each other, hence I put it in a single patch. But since it is a new feature it shouldn't really matter...
>
>How about splitting this patchset to two? few patches are having minor
>fixes and the few patches might need some review and discussions.
>May be some thing like DMA fixes and the other minor fixes.
I don't think that splitting up the patchset is necessary, with the current order it is possible to pick up the fixes independently...
--
Stefan
>
>--
>Bhuvan
>
>>
>> Shawn
>>
>>> drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++--
>>> 2 files changed, 20 insertions(+), 8 deletions(-)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
WARNING: multiple messages have this Message-ID (diff)
From: Stefan Agner <stefan@agner.ch>
To: Bhhuvanchandra DV <bhuvanchandra.dv@toradex.com>,Shawn Guo
<shawnguo@kernel.org>
Cc: gregkh@linuxfoundation.org,linux-serial@vger.kernel.org,mturquette@baylibre.com,sboyd@codeaurora.org,linux-kernel@vger.kernel.org,kernel@pengutronix.de,jslaby@suse.com,linux-clk@vger.kernel.org,linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume
Date: Mon, 13 Jun 2016 19:42:10 -0700 [thread overview]
Message-ID: <AF70EE92-9B41-4ECE-AB5F-E829E611B7C6@agner.ch> (raw)
In-Reply-To: <cdeb3e9b-92c5-77d9-78ec-3af3954e8e16@toradex.com>
On June 13, 2016 5:18:19 PM PDT, Bhhuvanchandra DV <bhuvanchandra.dv@toradex.com> wrote:
>Hi Shawn,
>
>On 06/11/2016 02:03 PM, Shawn Guo wrote:
>
>> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote:
>>> From: Stefan Agner <stefan@agner.ch>
>>>
>>> In order to allow wake support in STOP sleep mode, clocks are
>>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating
>>> in low power mode STOP. This allows to enable wake by UART using:
>>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup
>>>
>>> However, if wake is not enabled, the driver should disable the
>>> clocks explicitly to save power.
>>>
>>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>>> ---
>>> drivers/clk/imx/clk-vf610.c | 12 ++++++------
>> Please send clock driver changes in a separate patch.
The changes are dependet on each other, hence I put it in a single patch. But since it is a new feature it shouldn't really matter...
>
>How about splitting this patchset to two? few patches are having minor
>fixes and the few patches might need some review and discussions.
>May be some thing like DMA fixes and the other minor fixes.
I don't think that splitting up the patchset is necessary, with the current order it is possible to pick up the fixes independently...
--
Stefan
>
>--
>Bhuvan
>
>>
>> Shawn
>>
>>> drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++--
>>> 2 files changed, 20 insertions(+), 8 deletions(-)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
WARNING: multiple messages have this Message-ID (diff)
From: stefan@agner.ch (Stefan Agner)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume
Date: Mon, 13 Jun 2016 19:42:10 -0700 [thread overview]
Message-ID: <AF70EE92-9B41-4ECE-AB5F-E829E611B7C6@agner.ch> (raw)
In-Reply-To: <cdeb3e9b-92c5-77d9-78ec-3af3954e8e16@toradex.com>
On June 13, 2016 5:18:19 PM PDT, Bhhuvanchandra DV <bhuvanchandra.dv@toradex.com> wrote:
>Hi Shawn,
>
>On 06/11/2016 02:03 PM, Shawn Guo wrote:
>
>> On Thu, Jun 09, 2016 at 08:40:33PM +0530, Bhuvanchandra DV wrote:
>>> From: Stefan Agner <stefan@agner.ch>
>>>
>>> In order to allow wake support in STOP sleep mode, clocks are
>>> needed. Use imx_clk_gate2_cgr to disable automatic clock gating
>>> in low power mode STOP. This allows to enable wake by UART using:
>>> echo enabled > /sys/class/tty/ttyLP0/power/wakeup
>>>
>>> However, if wake is not enabled, the driver should disable the
>>> clocks explicitly to save power.
>>>
>>> Signed-off-by: Stefan Agner <stefan@agner.ch>
>>> ---
>>> drivers/clk/imx/clk-vf610.c | 12 ++++++------
>> Please send clock driver changes in a separate patch.
The changes are dependet on each other, hence I put it in a single patch. But since it is a new feature it shouldn't really matter...
>
>How about splitting this patchset to two? few patches are having minor
>fixes and the few patches might need some review and discussions.
>May be some thing like DMA fixes and the other minor fixes.
I don't think that splitting up the patchset is necessary, with the current order it is possible to pick up the fixes independently...
--
Stefan
>
>--
>Bhuvan
>
>>
>> Shawn
>>
>>> drivers/tty/serial/fsl_lpuart.c | 16 ++++++++++++++--
>>> 2 files changed, 20 insertions(+), 8 deletions(-)
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
next prev parent reply other threads:[~2016-06-14 2:42 UTC|newest]
Thread overview: 43+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-09 15:10 [PATCH 0/8] Improve Rx/Tx DMA implementation Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 1/8] tty: serial: fsl_lpuart: consider TX FIFO too in tx_empty Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-25 21:26 ` Greg KH
2016-06-25 21:26 ` Greg KH
2016-06-28 3:54 ` Bhuvanchandra DV
2016-06-28 3:54 ` Bhuvanchandra DV
2016-06-28 3:54 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 2/8] tty: serial: fsl_lpuart: support suspend/resume Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-11 14:03 ` Shawn Guo
2016-06-11 14:03 ` Shawn Guo
2016-06-14 0:18 ` Bhhuvanchandra DV
2016-06-14 0:18 ` Bhhuvanchandra DV
2016-06-14 0:18 ` Bhhuvanchandra DV
2016-06-14 2:42 ` Stefan Agner [this message]
2016-06-14 2:42 ` Stefan Agner
2016-06-14 2:42 ` Stefan Agner
2016-06-21 0:11 ` Stephen Boyd
2016-06-21 0:11 ` Stephen Boyd
2016-06-21 0:11 ` Stephen Boyd
2016-06-09 15:10 ` [PATCH 3/8] tty: serial: fsl_lpuart: fix clearing of receive flag Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 4/8] tty: serial: fsl_lpuart: Fix broken 8m/s1 support Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 5/8] tty: serial: fsl-lpuart: Use cyclic DMA for Rx Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 6/8] tty: serial: fsl-lpuart: Use scatter/gather DMA for Tx Drop PIO to DMA switching and use scatter/gather DMA for Tx path to improve performance Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 7/8] tty: serial: fsl-lpuart: Update suspend/resume for DMA mode Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` [PATCH 8/8] tty: serial: fsl_lpuart: Add support for RS-485 Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
2016-06-09 15:10 ` Bhuvanchandra DV
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AF70EE92-9B41-4ECE-AB5F-E829E611B7C6@agner.ch \
--to=stefan@agner.ch \
--cc=bhuvanchandra.dv@toradex.com \
--cc=gregkh@linuxfoundation.org \
--cc=jslaby@suse.com \
--cc=kernel@pengutronix.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=sboyd@codeaurora.org \
--cc=shawnguo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.