From: "A.s. Dong" <aisheng.dong@nxp.com> To: Jassi Brar <jassisinghbrar@gmail.com> Cc: Sascha Hauer <s.hauer@pengutronix.de>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "dongas86@gmail.com" <dongas86@gmail.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Oleksij Rempel <o.rempel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, Fabio Estevam <fabio.estevam@nxp.com>, "shawnguo@kernel.org" <shawnguo@kernel.org> Subject: RE: [PATCH V4 3/5] mailbox: imx: add imx mu support Date: Wed, 11 Jul 2018 12:58:39 +0000 [thread overview] Message-ID: <AM0PR04MB4211AD523CFB8DA99AB05EFC805A0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CABb+yY1kH8mr3=nazsLXrLaNWT0x6j9MizVaE+bZaHmrsKn-Wg@mail.gmail.com> Hi Jassi, > -----Original Message----- > From: Jassi Brar [mailto:jassisinghbrar@gmail.com] > Sent: Wednesday, July 11, 2018 6:44 PM > To: A.s. Dong <aisheng.dong@nxp.com> > Cc: Sascha Hauer <s.hauer@pengutronix.de>; linux-arm- > kernel@lists.infradead.org; dongas86@gmail.com; linux- > kernel@vger.kernel.org; Oleksij Rempel <o.rempel@pengutronix.de>; dl- > linux-imx <linux-imx@nxp.com>; kernel@pengutronix.de; Fabio Estevam > <fabio.estevam@nxp.com>; shawnguo@kernel.org > Subject: Re: [PATCH V4 3/5] mailbox: imx: add imx mu support > > On Wed, Jul 11, 2018 at 4:07 PM, A.s. Dong <aisheng.dong@nxp.com> wrote: > > > > > -----Original Message----- > > > From: Sascha Hauer [mailto:s.hauer@pengutronix.de] > > > Sent: Wednesday, July 11, 2018 3:55 PM > > > To: A.s. Dong <aisheng.dong@nxp.com> > > > Cc: linux-arm-kernel@lists.infradead.org; dongas86@gmail.com; Jassi > > > Brar <jassisinghbrar@gmail.com>; linux-kernel@vger.kernel.org; > > > Oleksij Rempel <o.rempel@pengutronix.de>; dl-linux-imx > > > <linux-imx@nxp.com>; kernel@pengutronix.de; Fabio Estevam > > > <fabio.estevam@nxp.com>; shawnguo@kernel.org > > > Subject: Re: [PATCH V4 3/5] mailbox: imx: add imx mu support > > > > > > On Wed, Jul 11, 2018 at 07:29:38AM +0000, A.s. Dong wrote: > > > > Hi Sascha, > > > > > > > > > -----Original Message----- > > > > > From: Sascha Hauer [mailto:s.hauer@pengutronix.de] > > > > > Sent: Tuesday, July 10, 2018 10:20 PM > > > > > To: A.s. Dong <aisheng.dong@nxp.com> > > > > > Cc: linux-arm-kernel@lists.infradead.org; dongas86@gmail.com; > > > > > Jassi Brar <jassisinghbrar@gmail.com>; > > > > > linux-kernel@vger.kernel.org; Oleksij Rempel > > > > > <o.rempel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; > > > > > kernel@pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>; > > > > > shawnguo@kernel.org > > > > > Subject: Re: [PATCH V4 3/5] mailbox: imx: add imx mu support > > > > > > > > > > Hi, > > > > > > > > > > On Sun, Jul 08, 2018 at 10:56:55PM +0800, Dong Aisheng wrote: > > > > > > This is used for i.MX multi core communication. > > > > > > e.g. A core to SCU firmware(M core) on MX8. > > > > > > > > > > > > Tx is using polling mode while Rx is interrupt driven and > > > > > > schedule a hrtimer to receive remain words if have more than > > > > > > 4 words. > > > > > > > > > > You told us that using interrupts is not possible due to > > > > > miserable performance, we then provided you a way with which you > could poll. > > > > > Why are you using interrupts now? > > > > > > > > > > > > > Because mailbox framework does not support sync rx now, I think we > > > > do not need to wait for that feature done first as it's > > > > independent and separate features of framework. > > > > > > You can wait forever for this feature, nobody will add it for you. > > > It's up to you to add support for that feature. Who else should add this > feature if not you? > > > And when will you add that feature if not now when you actually need it? > > > It is common practice that you adjust the frameworks to your needs > > > rather than working around them. > > > > > > > I'm willing to add it. Just because you said Jassi already had the > > idea on how to Implement it and does not add much complexity. So I just > want to see his patches. > > But if he did not work on it, I can also help on it. > > > I am not much aware of the history of this conversation... but it seems you > need to make use of mbox_chan_ops.peek_data(). > > If not that, please let me know the requirement. > Thanks for the suggestion. It looks to me may work. From the definition, it seems it's used to pull data from remote side. /** * mbox_client_peek_data - A way for client driver to pull data * received from remote by the controller. * @chan: Mailbox channel assigned to this client. * * A poke to controller driver for any received data. * The data is actually passed onto client via the * mbox_chan_received_data() * The call can be made from atomic context, so the controller's * implementation of peek_data() must not sleep. * * Return: True, if controller has, and is going to push after this, * some data. * False, if controller doesn't have any data to be read. */ bool mbox_client_peek_data(struct mbox_chan *chan) { if (chan->mbox->ops->peek_data) return chan->mbox->ops->peek_data(chan); return false; } EXPORT_SYMBOL_GPL(mbox_client_peek_data); But it seems most users in kernel simply implement it as a data available Checking rather than receiving it. See: drivers/mailbox/ti-msgmgr.c drivers/mailbox/mailbox-altera.c Only bcm uses it to receive data. drivers/mailbox/bcm-flexrm-mailbox.c For our requirement, we want to implement sync receiving protocol like: Sc_call_rpc() { mbox_send_message(chan, msg) If (!no_resp) // rx also stored in msg mbox_receive_msg_in_polling(chan, msg); mbox_client_txdone(); } If using peek_data, it can be: Sc_call_rpc() { mbox_send_message(chan, msg) If (!no_resp) // rx also stored in msg Mbox_client_peek_data(chan); mbox_client_txdone(); } And for mu controller driver .peek_data(): imx_mu_peek_data(chan) { // get first word and parse data size imx_mu_receive_msg(&mu->chans, 0, mu->msg); raw_data = (u8 *)mu->msg; size = raw_data[1]; // receive rest of them for (i = 1; i < size; i++) { ret = imx_mu_receive_msg(&mu->chans, i % 4, mu->msg + i); if (ret) return false; } mbox_chan_received_data(&mu->chans, (void *)mu->msg); return true; } It is much specific to SCU. Do you think such peek_data using for sync receiving mode is ok? Regards Dong Aisheng > Cheers!
WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@nxp.com (A.s. Dong) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 3/5] mailbox: imx: add imx mu support Date: Wed, 11 Jul 2018 12:58:39 +0000 [thread overview] Message-ID: <AM0PR04MB4211AD523CFB8DA99AB05EFC805A0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <CABb+yY1kH8mr3=nazsLXrLaNWT0x6j9MizVaE+bZaHmrsKn-Wg@mail.gmail.com> Hi Jassi, > -----Original Message----- > From: Jassi Brar [mailto:jassisinghbrar at gmail.com] > Sent: Wednesday, July 11, 2018 6:44 PM > To: A.s. Dong <aisheng.dong@nxp.com> > Cc: Sascha Hauer <s.hauer@pengutronix.de>; linux-arm- > kernel at lists.infradead.org; dongas86 at gmail.com; linux- > kernel at vger.kernel.org; Oleksij Rempel <o.rempel@pengutronix.de>; dl- > linux-imx <linux-imx@nxp.com>; kernel at pengutronix.de; Fabio Estevam > <fabio.estevam@nxp.com>; shawnguo at kernel.org > Subject: Re: [PATCH V4 3/5] mailbox: imx: add imx mu support > > On Wed, Jul 11, 2018 at 4:07 PM, A.s. Dong <aisheng.dong@nxp.com> wrote: > > > > > -----Original Message----- > > > From: Sascha Hauer [mailto:s.hauer at pengutronix.de] > > > Sent: Wednesday, July 11, 2018 3:55 PM > > > To: A.s. Dong <aisheng.dong@nxp.com> > > > Cc: linux-arm-kernel at lists.infradead.org; dongas86 at gmail.com; Jassi > > > Brar <jassisinghbrar@gmail.com>; linux-kernel at vger.kernel.org; > > > Oleksij Rempel <o.rempel@pengutronix.de>; dl-linux-imx > > > <linux-imx@nxp.com>; kernel at pengutronix.de; Fabio Estevam > > > <fabio.estevam@nxp.com>; shawnguo at kernel.org > > > Subject: Re: [PATCH V4 3/5] mailbox: imx: add imx mu support > > > > > > On Wed, Jul 11, 2018 at 07:29:38AM +0000, A.s. Dong wrote: > > > > Hi Sascha, > > > > > > > > > -----Original Message----- > > > > > From: Sascha Hauer [mailto:s.hauer at pengutronix.de] > > > > > Sent: Tuesday, July 10, 2018 10:20 PM > > > > > To: A.s. Dong <aisheng.dong@nxp.com> > > > > > Cc: linux-arm-kernel at lists.infradead.org; dongas86 at gmail.com; > > > > > Jassi Brar <jassisinghbrar@gmail.com>; > > > > > linux-kernel at vger.kernel.org; Oleksij Rempel > > > > > <o.rempel@pengutronix.de>; dl-linux-imx <linux-imx@nxp.com>; > > > > > kernel at pengutronix.de; Fabio Estevam <fabio.estevam@nxp.com>; > > > > > shawnguo at kernel.org > > > > > Subject: Re: [PATCH V4 3/5] mailbox: imx: add imx mu support > > > > > > > > > > Hi, > > > > > > > > > > On Sun, Jul 08, 2018 at 10:56:55PM +0800, Dong Aisheng wrote: > > > > > > This is used for i.MX multi core communication. > > > > > > e.g. A core to SCU firmware(M core) on MX8. > > > > > > > > > > > > Tx is using polling mode while Rx is interrupt driven and > > > > > > schedule a hrtimer to receive remain words if have more than > > > > > > 4 words. > > > > > > > > > > You told us that using interrupts is not possible due to > > > > > miserable performance, we then provided you a way with which you > could poll. > > > > > Why are you using interrupts now? > > > > > > > > > > > > > Because mailbox framework does not support sync rx now, I think we > > > > do not need to wait for that feature done first as it's > > > > independent and separate features of framework. > > > > > > You can wait forever for this feature, nobody will add it for you. > > > It's up to you to add support for that feature. Who else should add this > feature if not you? > > > And when will you add that feature if not now when you actually need it? > > > It is common practice that you adjust the frameworks to your needs > > > rather than working around them. > > > > > > > I'm willing to add it. Just because you said Jassi already had the > > idea on how to Implement it and does not add much complexity. So I just > want to see his patches. > > But if he did not work on it, I can also help on it. > > > I am not much aware of the history of this conversation... but it seems you > need to make use of mbox_chan_ops.peek_data(). > > If not that, please let me know the requirement. > Thanks for the suggestion. It looks to me may work. >From the definition, it seems it's used to pull data from remote side. /** * mbox_client_peek_data - A way for client driver to pull data * received from remote by the controller. * @chan: Mailbox channel assigned to this client. * * A poke to controller driver for any received data. * The data is actually passed onto client via the * mbox_chan_received_data() * The call can be made from atomic context, so the controller's * implementation of peek_data() must not sleep. * * Return: True, if controller has, and is going to push after this, * some data. * False, if controller doesn't have any data to be read. */ bool mbox_client_peek_data(struct mbox_chan *chan) { if (chan->mbox->ops->peek_data) return chan->mbox->ops->peek_data(chan); return false; } EXPORT_SYMBOL_GPL(mbox_client_peek_data); But it seems most users in kernel simply implement it as a data available Checking rather than receiving it. See: drivers/mailbox/ti-msgmgr.c drivers/mailbox/mailbox-altera.c Only bcm uses it to receive data. drivers/mailbox/bcm-flexrm-mailbox.c For our requirement, we want to implement sync receiving protocol like: Sc_call_rpc() { mbox_send_message(chan, msg) If (!no_resp) // rx also stored in msg mbox_receive_msg_in_polling(chan, msg); mbox_client_txdone(); } If using peek_data, it can be: Sc_call_rpc() { mbox_send_message(chan, msg) If (!no_resp) // rx also stored in msg Mbox_client_peek_data(chan); mbox_client_txdone(); } And for mu controller driver .peek_data(): imx_mu_peek_data(chan) { // get first word and parse data size imx_mu_receive_msg(&mu->chans, 0, mu->msg); raw_data = (u8 *)mu->msg; size = raw_data[1]; // receive rest of them for (i = 1; i < size; i++) { ret = imx_mu_receive_msg(&mu->chans, i % 4, mu->msg + i); if (ret) return false; } mbox_chan_received_data(&mu->chans, (void *)mu->msg); return true; } It is much specific to SCU. Do you think such peek_data using for sync receiving mode is ok? Regards Dong Aisheng > Cheers!
next prev parent reply other threads:[~2018-07-11 12:58 UTC|newest] Thread overview: 46+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-07-08 14:56 [PATCH V4 0/5] soc: imx: add scu firmware api support Dong Aisheng 2018-07-08 14:56 ` [PATCH V4 1/5] dt-bindings: mailbox: allow mbox-cells to be equal to 0 Dong Aisheng 2018-07-08 14:56 ` Dong Aisheng 2018-07-08 14:56 ` [PATCH V4 2/5] dt-bindings: arm: fsl: add mu binding doc Dong Aisheng 2018-07-08 14:56 ` Dong Aisheng 2018-07-11 15:09 ` Rob Herring 2018-07-11 15:09 ` Rob Herring 2018-07-08 14:56 ` [PATCH V4 3/5] mailbox: imx: add imx mu support Dong Aisheng 2018-07-08 14:56 ` Dong Aisheng 2018-07-10 14:19 ` Sascha Hauer 2018-07-10 14:19 ` Sascha Hauer 2018-07-11 7:29 ` A.s. Dong 2018-07-11 7:29 ` A.s. Dong 2018-07-11 7:54 ` Sascha Hauer 2018-07-11 7:54 ` Sascha Hauer 2018-07-11 10:37 ` A.s. Dong 2018-07-11 10:37 ` A.s. Dong 2018-07-11 10:44 ` Jassi Brar 2018-07-11 10:44 ` Jassi Brar 2018-07-11 12:58 ` A.s. Dong [this message] 2018-07-11 12:58 ` A.s. Dong 2018-07-11 16:31 ` Jassi Brar 2018-07-11 16:31 ` Jassi Brar 2018-07-11 16:41 ` A.s. Dong 2018-07-11 16:41 ` A.s. Dong 2018-07-11 17:00 ` Jassi Brar 2018-07-11 17:00 ` Jassi Brar 2018-07-12 4:06 ` A.s. Dong 2018-07-12 4:06 ` A.s. Dong 2018-07-11 13:30 ` Peng Fan 2018-07-11 13:30 ` Peng Fan 2018-07-08 14:56 ` [PATCH V4 4/5] dt-bindings: arm: fsl: add scu binding doc Dong Aisheng 2018-07-08 14:56 ` Dong Aisheng 2018-07-11 15:08 ` Rob Herring 2018-07-11 15:08 ` Rob Herring 2018-07-12 11:04 ` A.s. Dong 2018-07-12 11:04 ` A.s. Dong 2018-07-08 14:56 ` [PATCH V4 5/5] soc: imx: add SC firmware IPC and APIs Dong Aisheng 2018-07-10 14:44 ` Sascha Hauer 2018-07-11 9:18 ` A.s. Dong 2018-07-11 10:31 ` Sascha Hauer 2018-07-11 11:27 ` A.s. Dong 2018-07-11 16:49 ` [PATCH V4 0/5] soc: imx: add scu firmware api support Sudeep Holla 2018-07-12 3:46 ` A.s. Dong 2018-07-12 10:32 ` Sudeep Holla 2018-07-12 12:29 ` Leonard Crestez
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB4211AD523CFB8DA99AB05EFC805A0@AM0PR04MB4211.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=dongas86@gmail.com \ --cc=fabio.estevam@nxp.com \ --cc=jassisinghbrar@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=o.rempel@pengutronix.de \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.