From: Aisheng Dong <aisheng.dong@nxp.com> To: Anson Huang <anson.huang@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "a.zummo@towertech.it" <a.zummo@towertech.it>, "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, Daniel Baluta <daniel.baluta@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org> Cc: dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH V5 4/4] rtc: imx-sc: add rtc alarm support Date: Tue, 9 Apr 2019 03:08:37 +0000 [thread overview] Message-ID: <AM0PR04MB4211C3DA99287071FD102EDB802D0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <DB3PR0402MB39164EEA38E9A3C239CCA221F52D0@DB3PR0402MB3916.eurprd04.prod.outlook.com> [...] > so I will add another API in imx-scu-irq > driver to provide function of enabling/disabling irq, each driver can just call the > API to enable/disable its own IRQ, ONLY need to pass the corresponding > arguments: > That's exactly what I mean. > > > > > + msg.group = SC_IRQ_GROUP_RTC; > > > + msg.mask = SC_IRQ_RTC; > > > + msg.enable = enable; > > > + > > > + ret = imx_scu_call_rpc(rtc_ipc_handle, &msg, true); > > > + if (ret) { > > > + dev_err(dev, "enable rtc irq failed, ret %d\n", ret); > > > + return ret; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int imx_sc_rtc_read_alarm(struct device *dev, struct > > > +rtc_wkalrm > > > +*alrm) { > > > + return 0; > > > +} > > > > Can't avoid define NULL function? > > We have to implement it as NULL function, as SCFW does NOT provide such > feature, But rtc alarm ONLY available when .read_alarm ops is implemented: > If the framework mandantorily requires it, then we'd probably better to add doc before this function and explain why it's safe to be NULL. > 147 static ssize_t > 148 wakealarm_store(struct device *dev, struct device_attribute *attr, > 149 const char *buf, size_t n) > 150 { > > ... > > 187 retval = rtc_read_alarm(rtc, &alm); > 188 if (retval < 0) > 189 return retval; > > > > > > > + > > > +static int imx_sc_rtc_set_alarm(struct device *dev, struct > > > +rtc_wkalrm > > > +*alrm) { > > > + struct imx_sc_msg_timer_rtc_set_alarm msg; > > > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > > > + int ret; > > > + struct rtc_time *alrm_tm = &alrm->time; > > > + > > > + hdr->ver = IMX_SC_RPC_VERSION; > > > + hdr->svc = IMX_SC_RPC_SVC_TIMER; > > > + hdr->func = IMX_SC_TIMER_FUNC_SET_RTC_ALARM; > > > + hdr->size = 3; > > > + > > > + msg.year = alrm_tm->tm_year + 1900; > > > + msg.mon = alrm_tm->tm_mon + 1; > > > + msg.day = alrm_tm->tm_mday; > > > + msg.hour = alrm_tm->tm_hour; > > > + msg.min = alrm_tm->tm_min; > > > + msg.sec = alrm_tm->tm_sec; > > > + > > > + ret = imx_scu_call_rpc(rtc_ipc_handle, &msg, true); > > > + if (ret) { > > > + dev_err(dev, "set rtc alarm failed, ret %d\n", ret); > > > + return ret; > > > + } > > > + > > > + ret = imx_sc_rtc_alarm_irq_enable(dev, alrm->enabled); > > > > Just curious we already have .alarm_irq_enable(). > > Why do we need call it again here? > > That is because the set_alarm function pass alarm time and alarm->enabled > argument, it could be to enable alarm or to disable alarm, so we have to > control the alarm function here, all other rtc drivers also do it this way. > The .alarm_irq_enable() callback is for just enable or disable alarm. > Got it, thanks for the explanation. Regards Dong Aisheng > Thanks, > Anson > > > > > > Regards > > Dong Aisheng > > > > > + if (ret) { > > > + dev_err(dev, "enable rtc alarm failed, ret %d\n", ret); > > > + return ret; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > static const struct rtc_class_ops imx_sc_rtc_ops = { > > > .read_time = imx_sc_rtc_read_time, > > > .set_time = imx_sc_rtc_set_time, > > > + .read_alarm = imx_sc_rtc_read_alarm, > > > + .set_alarm = imx_sc_rtc_set_alarm, > > > + .alarm_irq_enable = imx_sc_rtc_alarm_irq_enable, }; > > > + > > > +static int imx_sc_rtc_alarm_sc_notify(struct notifier_block *nb, > > > + unsigned long event, void *group) { > > > + /* ignore non-rtc irq */ > > > + if (!((event & SC_IRQ_RTC) && (*(u8 *)group == > > SC_IRQ_GROUP_RTC))) > > > + return 0; > > > + > > > + rtc_update_irq(imx_sc_rtc, 1, RTC_IRQF | RTC_AF); > > > + > > > + return 0; > > > +} > > > + > > > +static struct notifier_block imx_sc_rtc_alarm_sc_notifier = { > > > + .notifier_call = imx_sc_rtc_alarm_sc_notify, > > > }; > > > > > > static int imx_sc_rtc_probe(struct platform_device *pdev) @@ -73,6 > > > +181,8 @@ static int imx_sc_rtc_probe(struct platform_device *pdev) > > > if (ret) > > > return ret; > > > > > > + device_init_wakeup(&pdev->dev, true); > > > + > > > imx_sc_rtc = devm_rtc_allocate_device(&pdev->dev); > > > if (IS_ERR(imx_sc_rtc)) > > > return PTR_ERR(imx_sc_rtc); > > > @@ -87,6 +197,8 @@ static int imx_sc_rtc_probe(struct > > > platform_device > > > *pdev) > > > return ret; > > > } > > > > > > + imx_scu_irq_register_notifier(&imx_sc_rtc_alarm_sc_notifier); > > > + > > > return 0; > > > } > > > > > > -- > > > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com> To: Anson Huang <anson.huang@nxp.com>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "mark.rutland@arm.com" <mark.rutland@arm.com>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "a.zummo@towertech.it" <a.zummo@towertech.it>, "alexandre.belloni@bootlin.com" <alexandre.belloni@bootlin.com>, "ulf.hansson@linaro.org" <ulf.hansson@linaro.org>, Daniel Baluta <daniel.baluta@nxp.com>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-rtc@vger.kernel.org" <linux-rtc@vger.kernel.org> Cc: dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH V5 4/4] rtc: imx-sc: add rtc alarm support Date: Tue, 9 Apr 2019 03:08:37 +0000 [thread overview] Message-ID: <AM0PR04MB4211C3DA99287071FD102EDB802D0@AM0PR04MB4211.eurprd04.prod.outlook.com> (raw) In-Reply-To: <DB3PR0402MB39164EEA38E9A3C239CCA221F52D0@DB3PR0402MB3916.eurprd04.prod.outlook.com> [...] > so I will add another API in imx-scu-irq > driver to provide function of enabling/disabling irq, each driver can just call the > API to enable/disable its own IRQ, ONLY need to pass the corresponding > arguments: > That's exactly what I mean. > > > > > + msg.group = SC_IRQ_GROUP_RTC; > > > + msg.mask = SC_IRQ_RTC; > > > + msg.enable = enable; > > > + > > > + ret = imx_scu_call_rpc(rtc_ipc_handle, &msg, true); > > > + if (ret) { > > > + dev_err(dev, "enable rtc irq failed, ret %d\n", ret); > > > + return ret; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > +static int imx_sc_rtc_read_alarm(struct device *dev, struct > > > +rtc_wkalrm > > > +*alrm) { > > > + return 0; > > > +} > > > > Can't avoid define NULL function? > > We have to implement it as NULL function, as SCFW does NOT provide such > feature, But rtc alarm ONLY available when .read_alarm ops is implemented: > If the framework mandantorily requires it, then we'd probably better to add doc before this function and explain why it's safe to be NULL. > 147 static ssize_t > 148 wakealarm_store(struct device *dev, struct device_attribute *attr, > 149 const char *buf, size_t n) > 150 { > > ... > > 187 retval = rtc_read_alarm(rtc, &alm); > 188 if (retval < 0) > 189 return retval; > > > > > > > + > > > +static int imx_sc_rtc_set_alarm(struct device *dev, struct > > > +rtc_wkalrm > > > +*alrm) { > > > + struct imx_sc_msg_timer_rtc_set_alarm msg; > > > + struct imx_sc_rpc_msg *hdr = &msg.hdr; > > > + int ret; > > > + struct rtc_time *alrm_tm = &alrm->time; > > > + > > > + hdr->ver = IMX_SC_RPC_VERSION; > > > + hdr->svc = IMX_SC_RPC_SVC_TIMER; > > > + hdr->func = IMX_SC_TIMER_FUNC_SET_RTC_ALARM; > > > + hdr->size = 3; > > > + > > > + msg.year = alrm_tm->tm_year + 1900; > > > + msg.mon = alrm_tm->tm_mon + 1; > > > + msg.day = alrm_tm->tm_mday; > > > + msg.hour = alrm_tm->tm_hour; > > > + msg.min = alrm_tm->tm_min; > > > + msg.sec = alrm_tm->tm_sec; > > > + > > > + ret = imx_scu_call_rpc(rtc_ipc_handle, &msg, true); > > > + if (ret) { > > > + dev_err(dev, "set rtc alarm failed, ret %d\n", ret); > > > + return ret; > > > + } > > > + > > > + ret = imx_sc_rtc_alarm_irq_enable(dev, alrm->enabled); > > > > Just curious we already have .alarm_irq_enable(). > > Why do we need call it again here? > > That is because the set_alarm function pass alarm time and alarm->enabled > argument, it could be to enable alarm or to disable alarm, so we have to > control the alarm function here, all other rtc drivers also do it this way. > The .alarm_irq_enable() callback is for just enable or disable alarm. > Got it, thanks for the explanation. Regards Dong Aisheng > Thanks, > Anson > > > > > > Regards > > Dong Aisheng > > > > > + if (ret) { > > > + dev_err(dev, "enable rtc alarm failed, ret %d\n", ret); > > > + return ret; > > > + } > > > + > > > + return 0; > > > +} > > > + > > > static const struct rtc_class_ops imx_sc_rtc_ops = { > > > .read_time = imx_sc_rtc_read_time, > > > .set_time = imx_sc_rtc_set_time, > > > + .read_alarm = imx_sc_rtc_read_alarm, > > > + .set_alarm = imx_sc_rtc_set_alarm, > > > + .alarm_irq_enable = imx_sc_rtc_alarm_irq_enable, }; > > > + > > > +static int imx_sc_rtc_alarm_sc_notify(struct notifier_block *nb, > > > + unsigned long event, void *group) { > > > + /* ignore non-rtc irq */ > > > + if (!((event & SC_IRQ_RTC) && (*(u8 *)group == > > SC_IRQ_GROUP_RTC))) > > > + return 0; > > > + > > > + rtc_update_irq(imx_sc_rtc, 1, RTC_IRQF | RTC_AF); > > > + > > > + return 0; > > > +} > > > + > > > +static struct notifier_block imx_sc_rtc_alarm_sc_notifier = { > > > + .notifier_call = imx_sc_rtc_alarm_sc_notify, > > > }; > > > > > > static int imx_sc_rtc_probe(struct platform_device *pdev) @@ -73,6 > > > +181,8 @@ static int imx_sc_rtc_probe(struct platform_device *pdev) > > > if (ret) > > > return ret; > > > > > > + device_init_wakeup(&pdev->dev, true); > > > + > > > imx_sc_rtc = devm_rtc_allocate_device(&pdev->dev); > > > if (IS_ERR(imx_sc_rtc)) > > > return PTR_ERR(imx_sc_rtc); > > > @@ -87,6 +197,8 @@ static int imx_sc_rtc_probe(struct > > > platform_device > > > *pdev) > > > return ret; > > > } > > > > > > + imx_scu_irq_register_notifier(&imx_sc_rtc_alarm_sc_notifier); > > > + > > > return 0; > > > } > > > > > > -- > > > 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2019-04-09 3:08 UTC|newest] Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top 2019-03-18 3:09 [PATCH V5 1/4] dt-bindings: fsl: scu: add general interrupt support Anson Huang 2019-03-18 3:09 ` Anson Huang 2019-03-18 3:09 ` Anson Huang 2019-03-18 3:09 ` [PATCH V5 2/4] firmware: imx: enable imx scu general irq function Anson Huang 2019-03-18 3:09 ` Anson Huang 2019-03-18 3:09 ` Anson Huang 2019-04-03 8:47 ` Shawn Guo 2019-04-03 8:47 ` Shawn Guo 2019-04-03 8:47 ` Shawn Guo 2019-04-08 10:35 ` Aisheng Dong 2019-04-08 10:35 ` Aisheng Dong 2019-04-08 10:35 ` Aisheng Dong 2019-04-08 13:05 ` Anson Huang 2019-04-08 13:05 ` Anson Huang 2019-04-08 13:05 ` Anson Huang 2019-03-18 3:10 ` [PATCH V5 3/4] arm64: dts: freescale: imx8qxp: enable scu general irq channel Anson Huang 2019-03-18 3:10 ` Anson Huang 2019-03-18 3:10 ` Anson Huang 2019-03-18 3:10 ` [PATCH V5 4/4] rtc: imx-sc: add rtc alarm support Anson Huang 2019-03-18 3:10 ` Anson Huang 2019-03-18 3:10 ` Anson Huang 2019-04-01 13:11 ` Alexandre Belloni 2019-04-01 13:11 ` Alexandre Belloni 2019-04-01 13:11 ` Alexandre Belloni 2019-04-01 15:26 ` Alexandre Belloni 2019-04-01 15:26 ` Alexandre Belloni 2019-04-01 15:26 ` Alexandre Belloni 2019-04-01 15:28 ` Alexandre Belloni 2019-04-01 15:28 ` Alexandre Belloni 2019-04-01 15:28 ` Alexandre Belloni 2019-04-08 11:08 ` Aisheng Dong 2019-04-08 11:08 ` Aisheng Dong 2019-04-08 11:08 ` Aisheng Dong 2019-04-09 1:59 ` Anson Huang 2019-04-09 1:59 ` Anson Huang 2019-04-09 3:08 ` Aisheng Dong [this message] 2019-04-09 3:08 ` Aisheng Dong 2019-04-09 3:08 ` Aisheng Dong 2019-04-01 2:38 ` [PATCH V5 1/4] dt-bindings: fsl: scu: add general interrupt support Anson Huang 2019-04-01 2:38 ` Anson Huang
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB4211C3DA99287071FD102EDB802D0@AM0PR04MB4211.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=a.zummo@towertech.it \ --cc=alexandre.belloni@bootlin.com \ --cc=anson.huang@nxp.com \ --cc=daniel.baluta@nxp.com \ --cc=devicetree@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=linux-rtc@vger.kernel.org \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=ulf.hansson@linaro.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.