From: Leonard Crestez <leonard.crestez@nxp.com> To: Fabio Estevam <festevam@gmail.com>, "David S. Miller" <davem@davemloft.net>, Herbert Xu <herbert@gondor.apana.org.au> Cc: dl-linux-imx <linux-imx@nxp.com>, linux-kernel <linux-kernel@vger.kernel.org>, Rob Herring <robh+dt@kernel.org>, "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" <devicetree@vger.kernel.org>, Fabio Estevam <fabio.estevam@nxp.com>, Aymen Sghaier <aymen.sghaier@nxp.com>, Franck Lenormand <franck.lenormand@nxp.com>, Mark Rutland <mark.rutland@arm.com>, Shawn Guo <shawnguo@kernel.org>, "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" <linux-arm-kernel@lists.infradead.org>, Horia Geanta <horia.geanta@nxp.com>, Sascha Hauer <kernel@pengutronix.de>, Marek Vasut <marek.vasut@gmail.com>, "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" <linux-crypto@vger.kernel.org> Subject: Re: [PATCH v4 2/4] crypto: mxs-dcp - Add support for dcp clk Date: Wed, 31 Oct 2018 10:46:52 +0000 [thread overview] Message-ID: <AM0PR04MB4290A361A92B782DC5A9F8BDEECD0@AM0PR04MB4290.eurprd04.prod.outlook.com> (raw) In-Reply-To: CAOMZO5DCzM_NnqD4tHTAn4pAaUdQGo38Ami1h3pu9SzgyQ7GnQ@mail.gmail.com On 10/17/2018 4:02 PM, Fabio Estevam wrote: > On Wed, Oct 17, 2018 at 9:59 AM Leonard Crestez <leonard.crestez@nxp.com> wrote: > >> There is a changelog in the cover letter. > > It did not show up: > https://lkml.org/lkml/2018/10/17/673 Sorry, I forgot to copy the changelog for v4. The only change is the one we discussed earlier in this thread. >> This only looks slightly odd in git diff but it's not unrelated. >> >> I placed clk get/prepare/enable just before stmp_reset_block and made >> stmp_reset_block print a message and goto err_disable_unprepare_clk on >> failure instead of just "if (ret) return ret;" > > Got it! Then it looks fine, thanks: > > Reviewed-by: Fabio Estevam <festevam@gmail.com> Thanks for looking at this series. Shawn already applied patches 3/4, I guess parts 1/2 should go through the crypto tree? I don't know how crypto treats patches in the merge window, I can resend with all the ack/review tags after rc1 is out.
WARNING: multiple messages have this Message-ID (diff)
From: leonard.crestez@nxp.com (Leonard Crestez) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH v4 2/4] crypto: mxs-dcp - Add support for dcp clk Date: Wed, 31 Oct 2018 10:46:52 +0000 [thread overview] Message-ID: <AM0PR04MB4290A361A92B782DC5A9F8BDEECD0@AM0PR04MB4290.eurprd04.prod.outlook.com> (raw) In-Reply-To: CAOMZO5DCzM_NnqD4tHTAn4pAaUdQGo38Ami1h3pu9SzgyQ7GnQ@mail.gmail.com On 10/17/2018 4:02 PM, Fabio Estevam wrote: > On Wed, Oct 17, 2018 at 9:59 AM Leonard Crestez <leonard.crestez@nxp.com> wrote: > >> There is a changelog in the cover letter. > > It did not show up: > https://lkml.org/lkml/2018/10/17/673 Sorry, I forgot to copy the changelog for v4. The only change is the one we discussed earlier in this thread. >> This only looks slightly odd in git diff but it's not unrelated. >> >> I placed clk get/prepare/enable just before stmp_reset_block and made >> stmp_reset_block print a message and goto err_disable_unprepare_clk on >> failure instead of just "if (ret) return ret;" > > Got it! Then it looks fine, thanks: > > Reviewed-by: Fabio Estevam <festevam@gmail.com> Thanks for looking at this series. Shawn already applied patches 3/4, I guess parts 1/2 should go through the crypto tree? I don't know how crypto treats patches in the merge window, I can resend with all the ack/review tags after rc1 is out.
next prev parent reply other threads:[~2018-10-31 19:44 UTC|newest] Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-10-17 12:37 [PATCH v4 0/4] Port mxs-dcp to imx6ull and imx6sll Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:37 ` [PATCH v4 1/4] dt-bindings: crypto: Mention clocks for mxs-dcp Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-18 18:25 ` Rob Herring 2018-10-18 18:25 ` Rob Herring 2018-10-18 18:25 ` Rob Herring 2018-10-17 12:37 ` [PATCH v4 2/4] crypto: mxs-dcp - Add support for dcp clk Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:48 ` Fabio Estevam 2018-10-17 12:48 ` Fabio Estevam 2018-10-17 12:48 ` Fabio Estevam 2018-10-17 12:48 ` Fabio Estevam 2018-10-17 12:59 ` Leonard Crestez 2018-10-17 12:59 ` Leonard Crestez 2018-10-17 12:59 ` Leonard Crestez 2018-10-17 12:59 ` Leonard Crestez 2018-10-17 13:02 ` Fabio Estevam 2018-10-17 13:02 ` Fabio Estevam 2018-10-17 13:02 ` Fabio Estevam 2018-10-17 13:02 ` Fabio Estevam 2018-10-31 10:46 ` Leonard Crestez [this message] 2018-10-31 10:46 ` Leonard Crestez 2018-10-31 10:46 ` Leonard Crestez 2018-10-17 12:37 ` [PATCH v4 3/4] ARM: dts: imx6ull: Add dcp node Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-31 7:26 ` Shawn Guo 2018-10-31 7:26 ` Shawn Guo 2018-10-31 7:26 ` Shawn Guo 2018-10-17 12:37 ` [PATCH v4 4/4] ARM: imx_v6_v7_defconfig: Enable CRYPTO_DEV_MXS_DCP Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-17 12:37 ` Leonard Crestez 2018-10-31 7:27 ` Shawn Guo 2018-10-31 7:27 ` Shawn Guo 2018-10-31 7:27 ` Shawn Guo
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB4290A361A92B782DC5A9F8BDEECD0@AM0PR04MB4290.eurprd04.prod.outlook.com \ --to=leonard.crestez@nxp.com \ --cc=aymen.sghaier@nxp.com \ --cc=davem@davemloft.net \ --cc=devicetree@vger.kernel.org \ --cc=fabio.estevam@nxp.com \ --cc=festevam@gmail.com \ --cc=franck.lenormand@nxp.com \ --cc=herbert@gondor.apana.org.au \ --cc=horia.geanta@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-crypto@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=marek.vasut@gmail.com \ --cc=mark.rutland@arm.com \ --cc=robh+dt@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.