All of lore.kernel.org
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
@ 2019-08-21 17:29 Sudeep Holla
  2019-08-21 17:29 ` [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1 Sudeep Holla
                   ` (3 more replies)
  0 siblings, 4 replies; 11+ messages in thread
From: Sudeep Holla @ 2019-08-21 17:29 UTC (permalink / raw)
  To: u-boot

earlyprintk no longer works on arm64 platforms. Replace it with earlycon
which works fine.

Cc: Ryan Harkin <ryan.harkin@linaro.org>
Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 configs/vexpress_aemv8a_dram_defconfig | 2 +-
 configs/vexpress_aemv8a_juno_defconfig | 2 +-
 configs/vexpress_aemv8a_semi_defconfig | 2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/configs/vexpress_aemv8a_dram_defconfig b/configs/vexpress_aemv8a_dram_defconfig
index 2ff9e4b9f291..51860da387da 100644
--- a/configs/vexpress_aemv8a_dram_defconfig
+++ b/configs/vexpress_aemv8a_dram_defconfig
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait loglevel=9"
 # CONFIG_USE_BOOTCOMMAND is not set
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
diff --git a/configs/vexpress_aemv8a_juno_defconfig b/configs/vexpress_aemv8a_juno_defconfig
index fd306f9f6bf0..0823d17c1158 100644
--- a/configs/vexpress_aemv8a_juno_defconfig
+++ b/configs/vexpress_aemv8a_juno_defconfig
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw rootwait earlycon=pl011,0x7ff80000 debug user_debug=31 androidboot.hardware=juno loglevel=9"
 # CONFIG_USE_BOOTCOMMAND is not set
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
diff --git a/configs/vexpress_aemv8a_semi_defconfig b/configs/vexpress_aemv8a_semi_defconfig
index bff52f703836..db5ad3dfa5a4 100644
--- a/configs/vexpress_aemv8a_semi_defconfig
+++ b/configs/vexpress_aemv8a_semi_defconfig
@@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
 CONFIG_DISTRO_DEFAULTS=y
 CONFIG_BOOTDELAY=1
 CONFIG_USE_BOOTARGS=y
-CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000 debug user_debug=31 loglevel=9"
+CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug user_debug=31 loglevel=9"
 # CONFIG_USE_BOOTCOMMAND is not set
 # CONFIG_DISPLAY_CPUINFO is not set
 # CONFIG_DISPLAY_BOARDINFO is not set
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1
  2019-08-21 17:29 [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Sudeep Holla
@ 2019-08-21 17:29 ` Sudeep Holla
  2019-08-22  1:24   ` Peng Fan
  2019-08-27  0:18   ` Tom Rini
  2019-08-22  1:25 ` [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Peng Fan
                   ` (2 subsequent siblings)
  3 siblings, 2 replies; 11+ messages in thread
From: Sudeep Holla @ 2019-08-21 17:29 UTC (permalink / raw)
  To: u-boot

To support KVM, we need to drop at EL2 and not EL1 before we boot Linux
kernel. This causes issues on platform with VHE and secondaries booting
at EL2 via TF-A PSCI CPU_ON call.

Cc: Ryan Harkin <ryan.harkin@linaro.org>
Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: David Feng <fenghua@phytium.com.cn>
Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
---
 include/configs/vexpress_aemv8a.h | 1 -
 1 file changed, 1 deletion(-)

diff --git a/include/configs/vexpress_aemv8a.h b/include/configs/vexpress_aemv8a.h
index 89cd8b550ae6..974647055221 100644
--- a/include/configs/vexpress_aemv8a.h
+++ b/include/configs/vexpress_aemv8a.h
@@ -11,7 +11,6 @@
 #ifndef CONFIG_SEMIHOSTING
 #error CONFIG_TARGET_VEXPRESS64_BASE_FVP requires CONFIG_SEMIHOSTING
 #endif
-#define CONFIG_ARMV8_SWITCH_TO_EL1
 #endif
 
 #define CONFIG_REMAKE_ELF
-- 
2.17.1

^ permalink raw reply related	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1
  2019-08-21 17:29 ` [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1 Sudeep Holla
@ 2019-08-22  1:24   ` Peng Fan
  2019-08-27  0:18   ` Tom Rini
  1 sibling, 0 replies; 11+ messages in thread
From: Peng Fan @ 2019-08-22  1:24 UTC (permalink / raw)
  To: u-boot

> Subject: [U-Boot] [PATCH] vexpress/aemv8a: drop
> CONFIG_ARMV8_SWITCH_TO_EL1
> 
> To support KVM, we need to drop at EL2 and not EL1 before we boot Linux
> kernel. This causes issues on platform with VHE and secondaries booting at
> EL2 via TF-A PSCI CPU_ON call.
> 
> Cc: Ryan Harkin <ryan.harkin@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: David Feng <fenghua@phytium.com.cn>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  include/configs/vexpress_aemv8a.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/configs/vexpress_aemv8a.h
> b/include/configs/vexpress_aemv8a.h
> index 89cd8b550ae6..974647055221 100644
> --- a/include/configs/vexpress_aemv8a.h
> +++ b/include/configs/vexpress_aemv8a.h
> @@ -11,7 +11,6 @@
>  #ifndef CONFIG_SEMIHOSTING
>  #error CONFIG_TARGET_VEXPRESS64_BASE_FVP requires
> CONFIG_SEMIHOSTING  #endif -#define CONFIG_ARMV8_SWITCH_TO_EL1
> #endif
> 
>  #define CONFIG_REMAKE_ELF

Reviewed-by: Peng Fan <peng.fan@nxp.com>

> --
> 2.17.1
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> enx.de%2Flistinfo%2Fu-boot&amp;data=02%7C01%7CPeng.Fan%40nxp.com
> %7C68ad94406f6942be9d5408d7265d3489%7C686ea1d3bc2b4c6fa92cd99c
> 5c301635%7C0%7C0%7C637020054108251189&amp;sdata=k%2B4Fod6oxv
> 01%2BrKzUmUCR8I5WSVXmiyptJ%2B%2FIzRmlYg%3D&amp;reserved=0

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-21 17:29 [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Sudeep Holla
  2019-08-21 17:29 ` [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1 Sudeep Holla
@ 2019-08-22  1:25 ` Peng Fan
  2019-08-22 11:38   ` Ryan Harkin
  2019-08-22 12:11   ` Sudeep Holla
  2019-08-22 15:00 ` Linus Walleij
  2019-08-27  0:18 ` Tom Rini
  3 siblings, 2 replies; 11+ messages in thread
From: Peng Fan @ 2019-08-22  1:25 UTC (permalink / raw)
  To: u-boot

> Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk
> with earlycon
> 
> earlyprintk no longer works on arm64 platforms. Replace it with earlycon
> which works fine.
> 
> Cc: Ryan Harkin <ryan.harkin@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> ---
>  configs/vexpress_aemv8a_dram_defconfig | 2 +-
> configs/vexpress_aemv8a_juno_defconfig | 2 +-
> configs/vexpress_aemv8a_semi_defconfig | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/configs/vexpress_aemv8a_dram_defconfig
> b/configs/vexpress_aemv8a_dram_defconfig
> index 2ff9e4b9f291..51860da387da 100644
> --- a/configs/vexpress_aemv8a_dram_defconfig
> +++ b/configs/vexpress_aemv8a_dram_defconfig
> @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_BOOTDELAY=1
>  CONFIG_USE_BOOTARGS=y
> -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw
> rootwait loglevel=9"
> +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait
> loglevel=9"
>  # CONFIG_USE_BOOTCOMMAND is not set
>  # CONFIG_DISPLAY_CPUINFO is not set
>  # CONFIG_DISPLAY_BOARDINFO is not set
> diff --git a/configs/vexpress_aemv8a_juno_defconfig
> b/configs/vexpress_aemv8a_juno_defconfig
> index fd306f9f6bf0..0823d17c1158 100644
> --- a/configs/vexpress_aemv8a_juno_defconfig
> +++ b/configs/vexpress_aemv8a_juno_defconfig
> @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_BOOTDELAY=1
>  CONFIG_USE_BOOTARGS=y
> -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31
> androidboot.hardware=juno loglevel=9"
> +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> rootwait earlycon=pl011,0x7ff80000 debug user_debug=31
> androidboot.hardware=juno loglevel=9"
>  # CONFIG_USE_BOOTCOMMAND is not set
>  # CONFIG_DISPLAY_CPUINFO is not set
>  # CONFIG_DISPLAY_BOARDINFO is not set
> diff --git a/configs/vexpress_aemv8a_semi_defconfig
> b/configs/vexpress_aemv8a_semi_defconfig
> index bff52f703836..db5ad3dfa5a4 100644
> --- a/configs/vexpress_aemv8a_semi_defconfig
> +++ b/configs/vexpress_aemv8a_semi_defconfig
> @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
>  CONFIG_DISTRO_DEFAULTS=y
>  CONFIG_BOOTDELAY=1
>  CONFIG_USE_BOOTARGS=y
> -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> debug user_debug=31 loglevel=9"
> +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> user_debug=31 loglevel=9"
>  # CONFIG_USE_BOOTCOMMAND is not set
>  # CONFIG_DISPLAY_CPUINFO is not set
>  # CONFIG_DISPLAY_BOARDINFO is not set

Reviewed-by: Peng Fan <peng.fan@nxp.com>

Nitpick: this will be no early print when booting older version kernel.

> --
> 2.17.1
> 
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> enx.de%2Flistinfo%2Fu-boot&amp;data=02%7C01%7CPeng.Fan%40nxp.com
> %7C527db1f88898493ad3a708d7265d2df8%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C637020053985296717&amp;sdata=eTWujuzFpTwWil
> xc%2F7W7I7t8UQirTZ%2BE8MWkFGsdzrk%3D&amp;reserved=0

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-22  1:25 ` [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Peng Fan
@ 2019-08-22 11:38   ` Ryan Harkin
  2019-08-22 12:10     ` Sudeep Holla
  2019-08-22 12:11   ` Sudeep Holla
  1 sibling, 1 reply; 11+ messages in thread
From: Ryan Harkin @ 2019-08-22 11:38 UTC (permalink / raw)
  To: u-boot

On Thu, 22 Aug 2019 at 02:25, Peng Fan <peng.fan@nxp.com> wrote:

> > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk
> > with earlycon
> >
> > earlyprintk no longer works on arm64 platforms. Replace it with earlycon
> > which works fine.
> >
> > Cc: Ryan Harkin <ryan.harkin@linaro.org>
> > Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> >  configs/vexpress_aemv8a_dram_defconfig | 2 +-
> > configs/vexpress_aemv8a_juno_defconfig | 2 +-
> > configs/vexpress_aemv8a_semi_defconfig | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/configs/vexpress_aemv8a_dram_defconfig
> > b/configs/vexpress_aemv8a_dram_defconfig
> > index 2ff9e4b9f291..51860da387da 100644
> > --- a/configs/vexpress_aemv8a_dram_defconfig
> > +++ b/configs/vexpress_aemv8a_dram_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_BOOTDELAY=1
> >  CONFIG_USE_BOOTARGS=y
> > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw
> > rootwait loglevel=9"
> > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait
> > loglevel=9"
> >  # CONFIG_USE_BOOTCOMMAND is not set
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> > diff --git a/configs/vexpress_aemv8a_juno_defconfig
> > b/configs/vexpress_aemv8a_juno_defconfig
> > index fd306f9f6bf0..0823d17c1158 100644
> > --- a/configs/vexpress_aemv8a_juno_defconfig
> > +++ b/configs/vexpress_aemv8a_juno_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_BOOTDELAY=1
> >  CONFIG_USE_BOOTARGS=y
> > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31
> > androidboot.hardware=juno loglevel=9"
> > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31
> > androidboot.hardware=juno loglevel=9"
> >  # CONFIG_USE_BOOTCOMMAND is not set
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> > diff --git a/configs/vexpress_aemv8a_semi_defconfig
> > b/configs/vexpress_aemv8a_semi_defconfig
> > index bff52f703836..db5ad3dfa5a4 100644
> > --- a/configs/vexpress_aemv8a_semi_defconfig
> > +++ b/configs/vexpress_aemv8a_semi_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_BOOTDELAY=1
> >  CONFIG_USE_BOOTARGS=y
> > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > debug user_debug=31 loglevel=9"
> > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > user_debug=31 loglevel=9"
> >  # CONFIG_USE_BOOTCOMMAND is not set
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_DISPLAY_BOARDINFO is not set
>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
>
Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>


>
> Nitpick: this will be no early print when booting older version kernel.
>

Note also that the -dram platform is no longer used or tested. I'll send a
patch to remove it.


> > --
> > 2.17.1
> >
> > _______________________________________________
> > U-Boot mailing list
> > U-Boot at lists.denx.de
> >
> https://eur01.safelinks.protection.outlook.com/?url=https%3A%2F%2Flists.d
> > enx.de%2Flistinfo%2Fu-boot&amp;data=02%7C01%7CPeng.Fan%40nxp.com
> > %7C527db1f88898493ad3a708d7265d2df8%7C686ea1d3bc2b4c6fa92cd99c5
> > c301635%7C0%7C0%7C637020053985296717&amp;sdata=eTWujuzFpTwWil
> > xc%2F7W7I7t8UQirTZ%2BE8MWkFGsdzrk%3D&amp;reserved=0
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> https://lists.denx.de/listinfo/u-boot
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-22 11:38   ` Ryan Harkin
@ 2019-08-22 12:10     ` Sudeep Holla
  2019-08-22 12:14       ` Ryan Harkin
  0 siblings, 1 reply; 11+ messages in thread
From: Sudeep Holla @ 2019-08-22 12:10 UTC (permalink / raw)
  To: u-boot

On Thu, Aug 22, 2019 at 12:38:31PM +0100, Ryan Harkin wrote:
> On Thu, 22 Aug 2019 at 02:25, Peng Fan <peng.fan@nxp.com> wrote:
>
> > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk
> > > with earlycon
> > >
> > > earlyprintk no longer works on arm64 platforms. Replace it with earlycon
> > > which works fine.
> > >
> > > Cc: Ryan Harkin <ryan.harkin@linaro.org>
> > > Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > > ---
> > >  configs/vexpress_aemv8a_dram_defconfig | 2 +-
> > > configs/vexpress_aemv8a_juno_defconfig | 2 +-
> > > configs/vexpress_aemv8a_semi_defconfig | 2 +-
> > >  3 files changed, 3 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/configs/vexpress_aemv8a_dram_defconfig
> > > b/configs/vexpress_aemv8a_dram_defconfig
> > > index 2ff9e4b9f291..51860da387da 100644
> > > --- a/configs/vexpress_aemv8a_dram_defconfig
> > > +++ b/configs/vexpress_aemv8a_dram_defconfig
> > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> > >  CONFIG_DISTRO_DEFAULTS=y
> > >  CONFIG_BOOTDELAY=1
> > >  CONFIG_USE_BOOTARGS=y
> > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw
> > > rootwait loglevel=9"
> > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait
> > > loglevel=9"
> > >  # CONFIG_USE_BOOTCOMMAND is not set
> > >  # CONFIG_DISPLAY_CPUINFO is not set
> > >  # CONFIG_DISPLAY_BOARDINFO is not set
> > > diff --git a/configs/vexpress_aemv8a_juno_defconfig
> > > b/configs/vexpress_aemv8a_juno_defconfig
> > > index fd306f9f6bf0..0823d17c1158 100644
> > > --- a/configs/vexpress_aemv8a_juno_defconfig
> > > +++ b/configs/vexpress_aemv8a_juno_defconfig
> > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> > >  CONFIG_DISTRO_DEFAULTS=y
> > >  CONFIG_BOOTDELAY=1
> > >  CONFIG_USE_BOOTARGS=y
> > > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31
> > > androidboot.hardware=juno loglevel=9"
> > > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31
> > > androidboot.hardware=juno loglevel=9"
> > >  # CONFIG_USE_BOOTCOMMAND is not set
> > >  # CONFIG_DISPLAY_CPUINFO is not set
> > >  # CONFIG_DISPLAY_BOARDINFO is not set
> > > diff --git a/configs/vexpress_aemv8a_semi_defconfig
> > > b/configs/vexpress_aemv8a_semi_defconfig
> > > index bff52f703836..db5ad3dfa5a4 100644
> > > --- a/configs/vexpress_aemv8a_semi_defconfig
> > > +++ b/configs/vexpress_aemv8a_semi_defconfig
> > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> > >  CONFIG_DISTRO_DEFAULTS=y
> > >  CONFIG_BOOTDELAY=1
> > >  CONFIG_USE_BOOTARGS=y
> > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > > debug user_debug=31 loglevel=9"
> > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > > user_debug=31 loglevel=9"
> > >  # CONFIG_USE_BOOTCOMMAND is not set
> > >  # CONFIG_DISPLAY_CPUINFO is not set
> > >  # CONFIG_DISPLAY_BOARDINFO is not set
> >
> > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> >
> Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
>
> >
> > Nitpick: this will be no early print when booting older version kernel.
> >
>
> Note also that the -dram platform is no longer used or tested. I'll send a
> patch to remove it.
>

Ah OK, I was about to try that on FVP but then saw -semihosting one.
Thanks for the review. I assume you will post on top of my patch or do
you need me to drop changes in -dram defconfig and post v2 ?

--
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-22  1:25 ` [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Peng Fan
  2019-08-22 11:38   ` Ryan Harkin
@ 2019-08-22 12:11   ` Sudeep Holla
  1 sibling, 0 replies; 11+ messages in thread
From: Sudeep Holla @ 2019-08-22 12:11 UTC (permalink / raw)
  To: u-boot

On Thu, Aug 22, 2019 at 01:25:46AM +0000, Peng Fan wrote:
> > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk
> > with earlycon
> > 
> > earlyprintk no longer works on arm64 platforms. Replace it with earlycon
> > which works fine.
> > 
> > Cc: Ryan Harkin <ryan.harkin@linaro.org>
> > Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > ---
> >  configs/vexpress_aemv8a_dram_defconfig | 2 +-
> > configs/vexpress_aemv8a_juno_defconfig | 2 +-
> > configs/vexpress_aemv8a_semi_defconfig | 2 +-
> >  3 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/configs/vexpress_aemv8a_dram_defconfig
> > b/configs/vexpress_aemv8a_dram_defconfig
> > index 2ff9e4b9f291..51860da387da 100644
> > --- a/configs/vexpress_aemv8a_dram_defconfig
> > +++ b/configs/vexpress_aemv8a_dram_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_BOOTDELAY=1
> >  CONFIG_USE_BOOTARGS=y
> > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw
> > rootwait loglevel=9"
> > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait
> > loglevel=9"
> >  # CONFIG_USE_BOOTCOMMAND is not set
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> > diff --git a/configs/vexpress_aemv8a_juno_defconfig
> > b/configs/vexpress_aemv8a_juno_defconfig
> > index fd306f9f6bf0..0823d17c1158 100644
> > --- a/configs/vexpress_aemv8a_juno_defconfig
> > +++ b/configs/vexpress_aemv8a_juno_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_BOOTDELAY=1
> >  CONFIG_USE_BOOTARGS=y
> > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31
> > androidboot.hardware=juno loglevel=9"
> > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31
> > androidboot.hardware=juno loglevel=9"
> >  # CONFIG_USE_BOOTCOMMAND is not set
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> > diff --git a/configs/vexpress_aemv8a_semi_defconfig
> > b/configs/vexpress_aemv8a_semi_defconfig
> > index bff52f703836..db5ad3dfa5a4 100644
> > --- a/configs/vexpress_aemv8a_semi_defconfig
> > +++ b/configs/vexpress_aemv8a_semi_defconfig
> > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> >  CONFIG_DISTRO_DEFAULTS=y
> >  CONFIG_BOOTDELAY=1
> >  CONFIG_USE_BOOTARGS=y
> > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > debug user_debug=31 loglevel=9"
> > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > user_debug=31 loglevel=9"
> >  # CONFIG_USE_BOOTCOMMAND is not set
> >  # CONFIG_DISPLAY_CPUINFO is not set
> >  # CONFIG_DISPLAY_BOARDINFO is not set
> 
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> 
> Nitpick: this will be no early print when booting older version kernel.

Indeed, thanks for the review.

--
Regards,
Sudeep

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-22 12:10     ` Sudeep Holla
@ 2019-08-22 12:14       ` Ryan Harkin
  0 siblings, 0 replies; 11+ messages in thread
From: Ryan Harkin @ 2019-08-22 12:14 UTC (permalink / raw)
  To: u-boot

On Thu, 22 Aug 2019 at 13:10, Sudeep Holla <sudeep.holla@arm.com> wrote:

> On Thu, Aug 22, 2019 at 12:38:31PM +0100, Ryan Harkin wrote:
> > On Thu, 22 Aug 2019 at 02:25, Peng Fan <peng.fan@nxp.com> wrote:
> >
> > > > Subject: [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace
> earlyprintk
> > > > with earlycon
> > > >
> > > > earlyprintk no longer works on arm64 platforms. Replace it with
> earlycon
> > > > which works fine.
> > > >
> > > > Cc: Ryan Harkin <ryan.harkin@linaro.org>
> > > > Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> > > > Cc: Linus Walleij <linus.walleij@linaro.org>
> > > > Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> > > > ---
> > > >  configs/vexpress_aemv8a_dram_defconfig | 2 +-
> > > > configs/vexpress_aemv8a_juno_defconfig | 2 +-
> > > > configs/vexpress_aemv8a_semi_defconfig | 2 +-
> > > >  3 files changed, 3 insertions(+), 3 deletions(-)
> > > >
> > > > diff --git a/configs/vexpress_aemv8a_dram_defconfig
> > > > b/configs/vexpress_aemv8a_dram_defconfig
> > > > index 2ff9e4b9f291..51860da387da 100644
> > > > --- a/configs/vexpress_aemv8a_dram_defconfig
> > > > +++ b/configs/vexpress_aemv8a_dram_defconfig
> > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> > > >  CONFIG_DISTRO_DEFAULTS=y
> > > >  CONFIG_BOOTDELAY=1
> > > >  CONFIG_USE_BOOTARGS=y
> > > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > > > debug user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw
> > > > rootwait loglevel=9"
> > > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > > > user_debug=31 androidboot.hardware=fvpbase root=/dev/vda2 rw rootwait
> > > > loglevel=9"
> > > >  # CONFIG_USE_BOOTCOMMAND is not set
> > > >  # CONFIG_DISPLAY_CPUINFO is not set
> > > >  # CONFIG_DISPLAY_BOARDINFO is not set
> > > > diff --git a/configs/vexpress_aemv8a_juno_defconfig
> > > > b/configs/vexpress_aemv8a_juno_defconfig
> > > > index fd306f9f6bf0..0823d17c1158 100644
> > > > --- a/configs/vexpress_aemv8a_juno_defconfig
> > > > +++ b/configs/vexpress_aemv8a_juno_defconfig
> > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> > > >  CONFIG_DISTRO_DEFAULTS=y
> > > >  CONFIG_BOOTDELAY=1
> > > >  CONFIG_USE_BOOTARGS=y
> > > > -CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > > > rootwait earlyprintk=pl011,0x7ff80000 debug user_debug=31
> > > > androidboot.hardware=juno loglevel=9"
> > > > +CONFIG_BOOTARGS="console=ttyAMA0,115200n8 root=/dev/sda2 rw
> > > > rootwait earlycon=pl011,0x7ff80000 debug user_debug=31
> > > > androidboot.hardware=juno loglevel=9"
> > > >  # CONFIG_USE_BOOTCOMMAND is not set
> > > >  # CONFIG_DISPLAY_CPUINFO is not set
> > > >  # CONFIG_DISPLAY_BOARDINFO is not set
> > > > diff --git a/configs/vexpress_aemv8a_semi_defconfig
> > > > b/configs/vexpress_aemv8a_semi_defconfig
> > > > index bff52f703836..db5ad3dfa5a4 100644
> > > > --- a/configs/vexpress_aemv8a_semi_defconfig
> > > > +++ b/configs/vexpress_aemv8a_semi_defconfig
> > > > @@ -7,7 +7,7 @@ CONFIG_IDENT_STRING=" vexpress_aemv8a"
> > > >  CONFIG_DISTRO_DEFAULTS=y
> > > >  CONFIG_BOOTDELAY=1
> > > >  CONFIG_USE_BOOTARGS=y
> > > > -CONFIG_BOOTARGS="console=ttyAMA0 earlyprintk=pl011,0x1c090000
> > > > debug user_debug=31 loglevel=9"
> > > > +CONFIG_BOOTARGS="console=ttyAMA0 earlycon=pl011,0x1c090000 debug
> > > > user_debug=31 loglevel=9"
> > > >  # CONFIG_USE_BOOTCOMMAND is not set
> > > >  # CONFIG_DISPLAY_CPUINFO is not set
> > > >  # CONFIG_DISPLAY_BOARDINFO is not set
> > >
> > > Reviewed-by: Peng Fan <peng.fan@nxp.com>
> > >
> > Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
> >
> > >
> > > Nitpick: this will be no early print when booting older version kernel.
> > >
> >
> > Note also that the -dram platform is no longer used or tested. I'll send
> a
> > patch to remove it.
> >
>
> Ah OK, I was about to try that on FVP but then saw -semihosting one.
> Thanks for the review. I assume you will post on top of my patch or do
> you need me to drop changes in -dram defconfig and post v2 ?
>

It's OK, go ahead with your patch and I'll send mine after it's merged.


>
> --
> Regards,
> Sudeep
>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-21 17:29 [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Sudeep Holla
  2019-08-21 17:29 ` [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1 Sudeep Holla
  2019-08-22  1:25 ` [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Peng Fan
@ 2019-08-22 15:00 ` Linus Walleij
  2019-08-27  0:18 ` Tom Rini
  3 siblings, 0 replies; 11+ messages in thread
From: Linus Walleij @ 2019-08-22 15:00 UTC (permalink / raw)
  To: u-boot

On Wed, Aug 21, 2019 at 7:29 PM Sudeep Holla <sudeep.holla@arm.com> wrote:

> earlyprintk no longer works on arm64 platforms. Replace it with earlycon
> which works fine.
>
> Cc: Ryan Harkin <ryan.harkin@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>

Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Yours,
Linus Walleij

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon
  2019-08-21 17:29 [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Sudeep Holla
                   ` (2 preceding siblings ...)
  2019-08-22 15:00 ` Linus Walleij
@ 2019-08-27  0:18 ` Tom Rini
  3 siblings, 0 replies; 11+ messages in thread
From: Tom Rini @ 2019-08-27  0:18 UTC (permalink / raw)
  To: u-boot

On Wed, Aug 21, 2019 at 06:29:09PM +0100, Sudeep Holla wrote:

> earlyprintk no longer works on arm64 platforms. Replace it with earlycon
> which works fine.
> 
> Cc: Ryan Harkin <ryan.harkin@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>
> Reviewed-by: Ryan Harkin <ryan.harkin@linaro.org>
> Reviewed-by: Linus Walleij <linus.walleij@linaro.org>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190826/d566c194/attachment.sig>

^ permalink raw reply	[flat|nested] 11+ messages in thread
* [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1
  2019-08-21 17:29 ` [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1 Sudeep Holla
  2019-08-22  1:24   ` Peng Fan
@ 2019-08-27  0:18   ` Tom Rini
  1 sibling, 0 replies; 11+ messages in thread
From: Tom Rini @ 2019-08-27  0:18 UTC (permalink / raw)
  To: u-boot

On Wed, Aug 21, 2019 at 06:29:10PM +0100, Sudeep Holla wrote:

> To support KVM, we need to drop at EL2 and not EL1 before we boot Linux
> kernel. This causes issues on platform with VHE and secondaries booting
> at EL2 via TF-A PSCI CPU_ON call.
> 
> Cc: Ryan Harkin <ryan.harkin@linaro.org>
> Cc: Liviu Dudau <liviu.dudau@foss.arm.com>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: David Feng <fenghua@phytium.com.cn>
> Signed-off-by: Sudeep Holla <sudeep.holla@arm.com>
> Reviewed-by: Peng Fan <peng.fan@nxp.com>

Applied to u-boot/master, thanks!

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: not available
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20190826/f61a3f21/attachment.sig>

^ permalink raw reply	[flat|nested] 11+ messages in thread
end of thread, other threads:[~2019-08-27  0:18 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-08-21 17:29 [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Sudeep Holla
2019-08-21 17:29 ` [U-Boot] [PATCH] vexpress/aemv8a: drop CONFIG_ARMV8_SWITCH_TO_EL1 Sudeep Holla
2019-08-22  1:24   ` Peng Fan
2019-08-27  0:18   ` Tom Rini
2019-08-22  1:25 ` [U-Boot] [PATCH] ARM: vexpress_*_defconfig: replace earlyprintk with earlycon Peng Fan
2019-08-22 11:38   ` Ryan Harkin
2019-08-22 12:10     ` Sudeep Holla
2019-08-22 12:14       ` Ryan Harkin
2019-08-22 12:11   ` Sudeep Holla
2019-08-22 15:00 ` Linus Walleij
2019-08-27  0:18 ` Tom Rini

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.