From: Peng Fan <peng.fan@nxp.com> To: Shawn Guo <shawnguo@kernel.org>, Leonard Crestez <leonard.crestez@nxp.com> Cc: Lucas Stach <l.stach@pengutronix.de>, "sboyd@kernel.org" <sboyd@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, Abel Vesa <abel.vesa@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, dl-linux-imx <linux-imx@nxp.com>, Aisheng Dong <aisheng.dong@nxp.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Anson Huang <anson.huang@nxp.com>, Jacky Bai <ping.bai@nxp.com> Subject: RE: [PATCH V2 2/4] clk: imx: imx8mq: use imx8m_clk_hw_composite_core Date: Thu, 16 Jan 2020 01:48:14 +0000 [thread overview] Message-ID: <AM0PR04MB44816FCE748476F818719E9088360@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200115111205.GB29329@T480> > Subject: Re: [PATCH V2 2/4] clk: imx: imx8mq: use > imx8m_clk_hw_composite_core > > On Tue, Jan 14, 2020 at 04:49:20PM +0000, Leonard Crestez wrote: > > On 10.01.2020 09:17, Peng Fan wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Use imx8m_clk_hw_composite_core to simplify code. > > > > > > Reviewed-by: Abel Vesa <abel.vesa@nxp.com> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > drivers/clk/imx/clk-imx8mq.c | 19 +++++-------------- > > > 1 file changed, 5 insertions(+), 14 deletions(-) > > > > > > diff --git a/drivers/clk/imx/clk-imx8mq.c > > > b/drivers/clk/imx/clk-imx8mq.c index 4c0edca1a6d0..b031183ff427 > > > 100644 > > > --- a/drivers/clk/imx/clk-imx8mq.c > > > +++ b/drivers/clk/imx/clk-imx8mq.c > > > @@ -403,22 +403,13 @@ static int imx8mq_clocks_probe(struct > > > platform_device *pdev) > > > > > > /* CORE */ > > > hws[IMX8MQ_CLK_A53_SRC] = imx_clk_hw_mux2("arm_a53_src", > base + 0x8000, 24, 3, imx8mq_a53_sels, ARRAY_SIZE(imx8mq_a53_sels)); > > > - hws[IMX8MQ_CLK_M4_SRC] = imx_clk_hw_mux2("arm_m4_src", base > + 0x8080, 24, 3, imx8mq_arm_m4_sels, ARRAY_SIZE(imx8mq_arm_m4_sels)); > > > - hws[IMX8MQ_CLK_VPU_SRC] = imx_clk_hw_mux2("vpu_src", base + > 0x8100, 24, 3, imx8mq_vpu_sels, ARRAY_SIZE(imx8mq_vpu_sels)); > > > - hws[IMX8MQ_CLK_GPU_CORE_SRC] = > imx_clk_hw_mux2("gpu_core_src", base + 0x8180, 24, 3, > imx8mq_gpu_core_sels, ARRAY_SIZE(imx8mq_gpu_core_sels)); > > > - hws[IMX8MQ_CLK_GPU_SHADER_SRC] = > imx_clk_hw_mux2("gpu_shader_src", base + 0x8200, 24, 3, > imx8mq_gpu_shader_sels, ARRAY_SIZE(imx8mq_gpu_shader_sels)); > > > - > > > hws[IMX8MQ_CLK_A53_CG] = > imx_clk_hw_gate3_flags("arm_a53_cg", "arm_a53_src", base + 0x8000, 28, > CLK_IS_CRITICAL); > > > - hws[IMX8MQ_CLK_M4_CG] = imx_clk_hw_gate3("arm_m4_cg", > "arm_m4_src", base + 0x8080, 28); > > > - hws[IMX8MQ_CLK_VPU_CG] = imx_clk_hw_gate3("vpu_cg", "vpu_src", > base + 0x8100, 28); > > > - hws[IMX8MQ_CLK_GPU_CORE_CG] = imx_clk_hw_gate3("gpu_core_cg", > "gpu_core_src", base + 0x8180, 28); > > > - hws[IMX8MQ_CLK_GPU_SHADER_CG] = > imx_clk_hw_gate3("gpu_shader_cg", "gpu_shader_src", base + 0x8200, 28); > > > - > > > hws[IMX8MQ_CLK_A53_DIV] = > imx_clk_hw_divider2("arm_a53_div", "arm_a53_cg", base + 0x8000, 0, 3); > > > - hws[IMX8MQ_CLK_M4_DIV] = imx_clk_hw_divider2("arm_m4_div", > "arm_m4_cg", base + 0x8080, 0, 3); > > > - hws[IMX8MQ_CLK_VPU_DIV] = imx_clk_hw_divider2("vpu_div", > "vpu_cg", base + 0x8100, 0, 3); > > > - hws[IMX8MQ_CLK_GPU_CORE_DIV] = > imx_clk_hw_divider2("gpu_core_div", "gpu_core_cg", base + 0x8180, 0, 3); > > > - hws[IMX8MQ_CLK_GPU_SHADER_DIV] = > imx_clk_hw_divider2("gpu_shader_div", "gpu_shader_cg", base + 0x8200, 0, > 3); > > > + > > > + hws[IMX8MQ_CLK_M4_DIV] = > imx8m_clk_hw_composite_core("arm_m4_div", imx8mq_arm_m4_sels, base > + 0x8080); > > > + hws[IMX8MQ_CLK_VPU_DIV] = > imx8m_clk_hw_composite_core("vpu_div", imx8mq_vpu_sels, base + > 0x8100); > > > + hws[IMX8MQ_CLK_GPU_CORE_DIV] = > imx8m_clk_hw_composite_core("gpu_core_div", imx8mq_gpu_core_sels, > base + 0x8180); > > > + hws[IMX8MQ_CLK_GPU_SHADER_DIV] = > > > +imx8m_clk_hw_composite("gpu_shader_div", imx8mq_gpu_shader_sels, > > > +base + 0x8200); > > > > > > /* BUS */ > > > hws[IMX8MQ_CLK_MAIN_AXI] = > > > imx8m_clk_hw_composite_critical("main_axi", imx8mq_main_axi_sels, > > > base + 0x8800); > > > > Collapsing _SRC _CG into _DIV is an useful simplification but it > > technically breaks DT compatibility rules. > > > > Inside imx8mq.dtsi there are clock assignments for > > IMX8MQ_CLK_GPU_CORE_SRC and IMX8MQ_CLK_GPU_SHADER_SRC > which no longer > > exist so those assignments don't take effect. > > We do not want to break existing DTBs for this case. Patches dropped. I'll send a v3 to address the issues. Sorry. Thanks, Peng. > > Shawn
WARNING: multiple messages have this Message-ID (diff)
From: Peng Fan <peng.fan@nxp.com> To: Shawn Guo <shawnguo@kernel.org>, Leonard Crestez <leonard.crestez@nxp.com> Cc: Aisheng Dong <aisheng.dong@nxp.com>, Abel Vesa <abel.vesa@nxp.com>, Anson Huang <anson.huang@nxp.com>, "sboyd@kernel.org" <sboyd@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, Jacky Bai <ping.bai@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com>, "linux-clk@vger.kernel.org" <linux-clk@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, Lucas Stach <l.stach@pengutronix.de> Subject: RE: [PATCH V2 2/4] clk: imx: imx8mq: use imx8m_clk_hw_composite_core Date: Thu, 16 Jan 2020 01:48:14 +0000 [thread overview] Message-ID: <AM0PR04MB44816FCE748476F818719E9088360@AM0PR04MB4481.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200115111205.GB29329@T480> > Subject: Re: [PATCH V2 2/4] clk: imx: imx8mq: use > imx8m_clk_hw_composite_core > > On Tue, Jan 14, 2020 at 04:49:20PM +0000, Leonard Crestez wrote: > > On 10.01.2020 09:17, Peng Fan wrote: > > > From: Peng Fan <peng.fan@nxp.com> > > > > > > Use imx8m_clk_hw_composite_core to simplify code. > > > > > > Reviewed-by: Abel Vesa <abel.vesa@nxp.com> > > > Signed-off-by: Peng Fan <peng.fan@nxp.com> > > > --- > > > drivers/clk/imx/clk-imx8mq.c | 19 +++++-------------- > > > 1 file changed, 5 insertions(+), 14 deletions(-) > > > > > > diff --git a/drivers/clk/imx/clk-imx8mq.c > > > b/drivers/clk/imx/clk-imx8mq.c index 4c0edca1a6d0..b031183ff427 > > > 100644 > > > --- a/drivers/clk/imx/clk-imx8mq.c > > > +++ b/drivers/clk/imx/clk-imx8mq.c > > > @@ -403,22 +403,13 @@ static int imx8mq_clocks_probe(struct > > > platform_device *pdev) > > > > > > /* CORE */ > > > hws[IMX8MQ_CLK_A53_SRC] = imx_clk_hw_mux2("arm_a53_src", > base + 0x8000, 24, 3, imx8mq_a53_sels, ARRAY_SIZE(imx8mq_a53_sels)); > > > - hws[IMX8MQ_CLK_M4_SRC] = imx_clk_hw_mux2("arm_m4_src", base > + 0x8080, 24, 3, imx8mq_arm_m4_sels, ARRAY_SIZE(imx8mq_arm_m4_sels)); > > > - hws[IMX8MQ_CLK_VPU_SRC] = imx_clk_hw_mux2("vpu_src", base + > 0x8100, 24, 3, imx8mq_vpu_sels, ARRAY_SIZE(imx8mq_vpu_sels)); > > > - hws[IMX8MQ_CLK_GPU_CORE_SRC] = > imx_clk_hw_mux2("gpu_core_src", base + 0x8180, 24, 3, > imx8mq_gpu_core_sels, ARRAY_SIZE(imx8mq_gpu_core_sels)); > > > - hws[IMX8MQ_CLK_GPU_SHADER_SRC] = > imx_clk_hw_mux2("gpu_shader_src", base + 0x8200, 24, 3, > imx8mq_gpu_shader_sels, ARRAY_SIZE(imx8mq_gpu_shader_sels)); > > > - > > > hws[IMX8MQ_CLK_A53_CG] = > imx_clk_hw_gate3_flags("arm_a53_cg", "arm_a53_src", base + 0x8000, 28, > CLK_IS_CRITICAL); > > > - hws[IMX8MQ_CLK_M4_CG] = imx_clk_hw_gate3("arm_m4_cg", > "arm_m4_src", base + 0x8080, 28); > > > - hws[IMX8MQ_CLK_VPU_CG] = imx_clk_hw_gate3("vpu_cg", "vpu_src", > base + 0x8100, 28); > > > - hws[IMX8MQ_CLK_GPU_CORE_CG] = imx_clk_hw_gate3("gpu_core_cg", > "gpu_core_src", base + 0x8180, 28); > > > - hws[IMX8MQ_CLK_GPU_SHADER_CG] = > imx_clk_hw_gate3("gpu_shader_cg", "gpu_shader_src", base + 0x8200, 28); > > > - > > > hws[IMX8MQ_CLK_A53_DIV] = > imx_clk_hw_divider2("arm_a53_div", "arm_a53_cg", base + 0x8000, 0, 3); > > > - hws[IMX8MQ_CLK_M4_DIV] = imx_clk_hw_divider2("arm_m4_div", > "arm_m4_cg", base + 0x8080, 0, 3); > > > - hws[IMX8MQ_CLK_VPU_DIV] = imx_clk_hw_divider2("vpu_div", > "vpu_cg", base + 0x8100, 0, 3); > > > - hws[IMX8MQ_CLK_GPU_CORE_DIV] = > imx_clk_hw_divider2("gpu_core_div", "gpu_core_cg", base + 0x8180, 0, 3); > > > - hws[IMX8MQ_CLK_GPU_SHADER_DIV] = > imx_clk_hw_divider2("gpu_shader_div", "gpu_shader_cg", base + 0x8200, 0, > 3); > > > + > > > + hws[IMX8MQ_CLK_M4_DIV] = > imx8m_clk_hw_composite_core("arm_m4_div", imx8mq_arm_m4_sels, base > + 0x8080); > > > + hws[IMX8MQ_CLK_VPU_DIV] = > imx8m_clk_hw_composite_core("vpu_div", imx8mq_vpu_sels, base + > 0x8100); > > > + hws[IMX8MQ_CLK_GPU_CORE_DIV] = > imx8m_clk_hw_composite_core("gpu_core_div", imx8mq_gpu_core_sels, > base + 0x8180); > > > + hws[IMX8MQ_CLK_GPU_SHADER_DIV] = > > > +imx8m_clk_hw_composite("gpu_shader_div", imx8mq_gpu_shader_sels, > > > +base + 0x8200); > > > > > > /* BUS */ > > > hws[IMX8MQ_CLK_MAIN_AXI] = > > > imx8m_clk_hw_composite_critical("main_axi", imx8mq_main_axi_sels, > > > base + 0x8800); > > > > Collapsing _SRC _CG into _DIV is an useful simplification but it > > technically breaks DT compatibility rules. > > > > Inside imx8mq.dtsi there are clock assignments for > > IMX8MQ_CLK_GPU_CORE_SRC and IMX8MQ_CLK_GPU_SHADER_SRC > which no longer > > exist so those assignments don't take effect. > > We do not want to break existing DTBs for this case. Patches dropped. I'll send a v3 to address the issues. Sorry. Thanks, Peng. > > Shawn _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-01-16 1:48 UTC|newest] Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-01-10 7:17 [PATCH V2 0/4] clk: imx: imx8m: introduce imx8m_clk_hw_composite_core Peng Fan 2020-01-10 7:17 ` Peng Fan 2020-01-10 7:17 ` [PATCH V2 1/4] clk: imx: composite-8m: add imx8m_clk_hw_composite_core Peng Fan 2020-01-10 7:17 ` Peng Fan 2020-01-10 7:17 ` [PATCH V2 2/4] clk: imx: imx8mq: use imx8m_clk_hw_composite_core Peng Fan 2020-01-10 7:17 ` Peng Fan 2020-01-14 16:49 ` Leonard Crestez 2020-01-14 16:49 ` Leonard Crestez 2020-01-15 11:12 ` Shawn Guo 2020-01-15 11:12 ` Shawn Guo 2020-01-15 11:48 ` Leonard Crestez 2020-01-15 11:48 ` Leonard Crestez 2020-01-16 1:48 ` Peng Fan [this message] 2020-01-16 1:48 ` Peng Fan 2020-01-10 7:18 ` [PATCH V2 3/4] clk: imx: imx8mm: " Peng Fan 2020-01-10 7:18 ` Peng Fan 2020-01-13 21:48 ` Leonard Crestez 2020-01-13 21:48 ` Leonard Crestez 2020-01-10 7:18 ` [PATCH V2 4/4] clk: imx: imx8mn: " Peng Fan 2020-01-10 7:18 ` Peng Fan
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM0PR04MB44816FCE748476F818719E9088360@AM0PR04MB4481.eurprd04.prod.outlook.com \ --to=peng.fan@nxp.com \ --cc=abel.vesa@nxp.com \ --cc=aisheng.dong@nxp.com \ --cc=anson.huang@nxp.com \ --cc=festevam@gmail.com \ --cc=kernel@pengutronix.de \ --cc=l.stach@pengutronix.de \ --cc=leonard.crestez@nxp.com \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-clk@vger.kernel.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=ping.bai@nxp.com \ --cc=s.hauer@pengutronix.de \ --cc=sboyd@kernel.org \ --cc=shawnguo@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.