* [U-Boot] [PATCH] mmc: sdhci: fix chip detect gpio property name
@ 2019-07-22 16:14 Baruch Siach
2019-07-23 8:01 ` Peng Fan
2019-07-24 2:28 ` Peng Fan
0 siblings, 2 replies; 3+ messages in thread
From: Baruch Siach @ 2019-07-22 16:14 UTC (permalink / raw)
To: u-boot
The standard property name for chip-detect gpio is "cd-gpios". All
in-tree DT files use only this name.
Fixes: 451931ea700 ("mmc: sdhci: Read cd-gpio from devicetree")
Cc: T Karthik Reddy <t.karthik.reddy@xilinx.com>
Cc: Michal Simek <michal.simek@xilinx.com>
Signed-off-by: Baruch Siach <baruch@tkos.co.il>
---
drivers/mmc/sdhci.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c
index 0a0770cc2035..2779bca93f08 100644
--- a/drivers/mmc/sdhci.c
+++ b/drivers/mmc/sdhci.c
@@ -623,7 +623,7 @@ static int sdhci_init(struct mmc *mmc)
#if CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_GPIO)
struct udevice *dev = mmc->dev;
- gpio_request_by_name(dev, "cd-gpio", 0,
+ gpio_request_by_name(dev, "cd-gpios", 0,
&host->cd_gpio, GPIOD_IS_IN);
#endif
--
2.20.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: sdhci: fix chip detect gpio property name
2019-07-22 16:14 [U-Boot] [PATCH] mmc: sdhci: fix chip detect gpio property name Baruch Siach
@ 2019-07-23 8:01 ` Peng Fan
2019-07-24 2:28 ` Peng Fan
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-07-23 8:01 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH] mmc: sdhci: fix chip detect gpio property name
>
> The standard property name for chip-detect gpio is "cd-gpios". All in-tree DT
> files use only this name.
>
> Fixes: 451931ea700 ("mmc: sdhci: Read cd-gpio from devicetree")
> Cc: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/mmc/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index
> 0a0770cc2035..2779bca93f08 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -623,7 +623,7 @@ static int sdhci_init(struct mmc *mmc) #if
> CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_GPIO)
> struct udevice *dev = mmc->dev;
>
> - gpio_request_by_name(dev, "cd-gpio", 0,
> + gpio_request_by_name(dev, "cd-gpios", 0,
> &host->cd_gpio, GPIOD_IS_IN);
> #endif
>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
* [U-Boot] [PATCH] mmc: sdhci: fix chip detect gpio property name
2019-07-22 16:14 [U-Boot] [PATCH] mmc: sdhci: fix chip detect gpio property name Baruch Siach
2019-07-23 8:01 ` Peng Fan
@ 2019-07-24 2:28 ` Peng Fan
1 sibling, 0 replies; 3+ messages in thread
From: Peng Fan @ 2019-07-24 2:28 UTC (permalink / raw)
To: u-boot
> Subject: [PATCH] mmc: sdhci: fix chip detect gpio property name
>
> The standard property name for chip-detect gpio is "cd-gpios". All in-tree DT
> files use only this name.
>
> Fixes: 451931ea700 ("mmc: sdhci: Read cd-gpio from devicetree")
> Cc: T Karthik Reddy <t.karthik.reddy@xilinx.com>
> Cc: Michal Simek <michal.simek@xilinx.com>
> Signed-off-by: Baruch Siach <baruch@tkos.co.il>
> ---
> drivers/mmc/sdhci.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/mmc/sdhci.c b/drivers/mmc/sdhci.c index
> 0a0770cc2035..2779bca93f08 100644
> --- a/drivers/mmc/sdhci.c
> +++ b/drivers/mmc/sdhci.c
> @@ -623,7 +623,7 @@ static int sdhci_init(struct mmc *mmc) #if
> CONFIG_IS_ENABLED(DM_MMC) && CONFIG_IS_ENABLED(DM_GPIO)
> struct udevice *dev = mmc->dev;
>
> - gpio_request_by_name(dev, "cd-gpio", 0,
> + gpio_request_by_name(dev, "cd-gpios", 0,
> &host->cd_gpio, GPIOD_IS_IN);
Applied to mmc/master.
Thanks,
Peng
> #endif
>
> --
> 2.20.1
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-24 2:28 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-22 16:14 [U-Boot] [PATCH] mmc: sdhci: fix chip detect gpio property name Baruch Siach
2019-07-23 8:01 ` Peng Fan
2019-07-24 2:28 ` Peng Fan
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.