* [PATCH] trusted-firmware-a: re-enable generation of packages
@ 2020-05-19 6:34 Denys Dmytriyenko
2020-05-19 9:12 ` [meta-arm] " Diego Sueiro
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-05-19 6:34 UTC (permalink / raw)
To: meta-arm; +Cc: Denys Dmytriyenko
From: Denys Dmytriyenko <denys@ti.com>
There is no need to inherit nopackages. Even when the output binaries are being
consumed from deploy or sysroot, and the main binary package is not meant to be
installed in the rootfs, package generation is still useful for SDK use cases
and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.
Signed-off-by: Denys Dmytriyenko <denys@ti.com>
---
meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
index c9c5710..fe9a4e0 100644
--- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
+++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
@@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
PACKAGE_ARCH = "${MACHINE_ARCH}"
-inherit deploy nopackages
+inherit deploy
COMPATIBLE_MACHINE ?= "invalid"
@@ -158,7 +158,10 @@ do_install() {
done
}
+FILES_${PN} = "/firmware"
SYSROOT_DIRS += "/firmware"
+# Skip QA check for relocations in .text of elf binaries
+INSANE_SKIP_${PN} = "textrel"
do_deploy() {
cp -rf ${D}/firmware/* ${DEPLOYDIR}/
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages
2020-05-19 6:34 [PATCH] trusted-firmware-a: re-enable generation of packages Denys Dmytriyenko
@ 2020-05-19 9:12 ` Diego Sueiro
2020-05-19 15:17 ` Jon Mason
0 siblings, 1 reply; 5+ messages in thread
From: Diego Sueiro @ 2020-05-19 9:12 UTC (permalink / raw)
To: denis, meta-arm; +Cc: Denys Dmytriyenko, nd
> -----Original Message-----
> From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> Sent: 19 May 2020 07:35
> To: meta-arm@lists.yoctoproject.org
> Cc: Denys Dmytriyenko <denys@ti.com>
> Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of
> packages
>
> From: Denys Dmytriyenko <denys@ti.com>
>
> There is no need to inherit nopackages. Even when the output binaries are
> being consumed from deploy or sysroot, and the main binary package is not
> meant to be installed in the rootfs, package generation is still useful for SDK
> use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.
>
> Signed-off-by: Denys Dmytriyenko <denys@ti.com>
Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> ---
> meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> index c9c5710..fe9a4e0 100644
> --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> @@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
>
> PACKAGE_ARCH = "${MACHINE_ARCH}"
>
> -inherit deploy nopackages
> +inherit deploy
>
> COMPATIBLE_MACHINE ?= "invalid"
>
> @@ -158,7 +158,10 @@ do_install() {
> done
> }
>
> +FILES_${PN} = "/firmware"
> SYSROOT_DIRS += "/firmware"
> +# Skip QA check for relocations in .text of elf binaries
> +INSANE_SKIP_${PN} = "textrel"
>
> do_deploy() {
> cp -rf ${D}/firmware/* ${DEPLOYDIR}/
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages
2020-05-19 9:12 ` [meta-arm] " Diego Sueiro
@ 2020-05-19 15:17 ` Jon Mason
2020-05-19 16:26 ` Denys Dmytriyenko
0 siblings, 1 reply; 5+ messages in thread
From: Jon Mason @ 2020-05-19 15:17 UTC (permalink / raw)
To: Diego Sueiro; +Cc: denis, meta-arm, Denys Dmytriyenko, nd
On Tue, May 19, 2020 at 09:12:41AM +0000, Diego Sueiro wrote:
> > -----Original Message-----
> > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> > On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> > Sent: 19 May 2020 07:35
> > To: meta-arm@lists.yoctoproject.org
> > Cc: Denys Dmytriyenko <denys@ti.com>
> > Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of
> > packages
> >
> > From: Denys Dmytriyenko <denys@ti.com>
> >
> > There is no need to inherit nopackages. Even when the output binaries are
> > being consumed from deploy or sysroot, and the main binary package is not
> > meant to be installed in the rootfs, package generation is still useful for SDK
> > use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.
> >
> > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
>
> Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
Pulled into the master branch.
Thanks,
Jon
>
> > ---
> > meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > index c9c5710..fe9a4e0 100644
> > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > @@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
> >
> > PACKAGE_ARCH = "${MACHINE_ARCH}"
> >
> > -inherit deploy nopackages
> > +inherit deploy
> >
> > COMPATIBLE_MACHINE ?= "invalid"
> >
> > @@ -158,7 +158,10 @@ do_install() {
> > done
> > }
> >
> > +FILES_${PN} = "/firmware"
> > SYSROOT_DIRS += "/firmware"
> > +# Skip QA check for relocations in .text of elf binaries
> > +INSANE_SKIP_${PN} = "textrel"
> >
> > do_deploy() {
> > cp -rf ${D}/firmware/* ${DEPLOYDIR}/
> > --
> > 2.7.4
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages
2020-05-19 15:17 ` Jon Mason
@ 2020-05-19 16:26 ` Denys Dmytriyenko
2020-05-21 14:13 ` Jon Mason
0 siblings, 1 reply; 5+ messages in thread
From: Denys Dmytriyenko @ 2020-05-19 16:26 UTC (permalink / raw)
To: Jon Mason; +Cc: Diego Sueiro, meta-arm, Denys Dmytriyenko, nd
On Tue, May 19, 2020 at 11:17:55AM -0400, Jon Mason wrote:
> On Tue, May 19, 2020 at 09:12:41AM +0000, Diego Sueiro wrote:
> > > -----Original Message-----
> > > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> > > On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> > > Sent: 19 May 2020 07:35
> > > To: meta-arm@lists.yoctoproject.org
> > > Cc: Denys Dmytriyenko <denys@ti.com>
> > > Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of
> > > packages
> > >
> > > From: Denys Dmytriyenko <denys@ti.com>
> > >
> > > There is no need to inherit nopackages. Even when the output binaries are
> > > being consumed from deploy or sysroot, and the main binary package is not
> > > meant to be installed in the rootfs, package generation is still useful for SDK
> > > use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.
> > >
> > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> >
> > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
>
> Pulled into the master branch.
Can this be backported to dunfell, please?
Unfortunately, I missed this earlier, but it's required for out whole product,
which is beyond just rootfs and there is no easy way to un-inherit nopackages
from bbappend... Thanks.
> Thanks,
> Jon
>
> >
> > > ---
> > > meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
> > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > >
> > > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > index c9c5710..fe9a4e0 100644
> > > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > @@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
> > >
> > > PACKAGE_ARCH = "${MACHINE_ARCH}"
> > >
> > > -inherit deploy nopackages
> > > +inherit deploy
> > >
> > > COMPATIBLE_MACHINE ?= "invalid"
> > >
> > > @@ -158,7 +158,10 @@ do_install() {
> > > done
> > > }
> > >
> > > +FILES_${PN} = "/firmware"
> > > SYSROOT_DIRS += "/firmware"
> > > +# Skip QA check for relocations in .text of elf binaries
> > > +INSANE_SKIP_${PN} = "textrel"
> > >
> > > do_deploy() {
> > > cp -rf ${D}/firmware/* ${DEPLOYDIR}/
> > > --
> > > 2.7.4
> >
>
> >
>
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of packages
2020-05-19 16:26 ` Denys Dmytriyenko
@ 2020-05-21 14:13 ` Jon Mason
0 siblings, 0 replies; 5+ messages in thread
From: Jon Mason @ 2020-05-21 14:13 UTC (permalink / raw)
To: Denys Dmytriyenko; +Cc: Diego Sueiro, meta-arm, Denys Dmytriyenko, nd
On Tue, May 19, 2020 at 12:26:53PM -0400, Denys Dmytriyenko wrote:
> On Tue, May 19, 2020 at 11:17:55AM -0400, Jon Mason wrote:
> > On Tue, May 19, 2020 at 09:12:41AM +0000, Diego Sueiro wrote:
> > > > -----Original Message-----
> > > > From: meta-arm@lists.yoctoproject.org <meta-arm@lists.yoctoproject.org>
> > > > On Behalf Of Denys Dmytriyenko via lists.yoctoproject.org
> > > > Sent: 19 May 2020 07:35
> > > > To: meta-arm@lists.yoctoproject.org
> > > > Cc: Denys Dmytriyenko <denys@ti.com>
> > > > Subject: [meta-arm] [PATCH] trusted-firmware-a: re-enable generation of
> > > > packages
> > > >
> > > > From: Denys Dmytriyenko <denys@ti.com>
> > > >
> > > > There is no need to inherit nopackages. Even when the output binaries are
> > > > being consumed from deploy or sysroot, and the main binary package is not
> > > > meant to be installed in the rootfs, package generation is still useful for SDK
> > > > use cases and as a way to distribute sources (e.g. src.rpm/SRPM) in Distros.
> > > >
> > > > Signed-off-by: Denys Dmytriyenko <denys@ti.com>
> > >
> > > Reviewed-by: Diego Sueiro <diego.sueiro@arm.com>
> >
> > Pulled into the master branch.
>
> Can this be backported to dunfell, please?
> Unfortunately, I missed this earlier, but it's required for out whole product,
> which is beyond just rootfs and there is no easy way to un-inherit nopackages
> from bbappend... Thanks.
Done.
Thanks,
Jon
>
>
> > Thanks,
> > Jon
> >
> > >
> > > > ---
> > > > meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc | 5 ++++-
> > > > 1 file changed, 4 insertions(+), 1 deletion(-)
> > > >
> > > > diff --git a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > > b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > > index c9c5710..fe9a4e0 100644
> > > > --- a/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > > +++ b/meta-arm/recipes-bsp/trusted-firmware-a/trusted-firmware-a.inc
> > > > @@ -5,7 +5,7 @@ PROVIDES = "virtual/trusted-firmware-a"
> > > >
> > > > PACKAGE_ARCH = "${MACHINE_ARCH}"
> > > >
> > > > -inherit deploy nopackages
> > > > +inherit deploy
> > > >
> > > > COMPATIBLE_MACHINE ?= "invalid"
> > > >
> > > > @@ -158,7 +158,10 @@ do_install() {
> > > > done
> > > > }
> > > >
> > > > +FILES_${PN} = "/firmware"
> > > > SYSROOT_DIRS += "/firmware"
> > > > +# Skip QA check for relocations in .text of elf binaries
> > > > +INSANE_SKIP_${PN} = "textrel"
> > > >
> > > > do_deploy() {
> > > > cp -rf ${D}/firmware/* ${DEPLOYDIR}/
> > > > --
> > > > 2.7.4
> > >
> >
> > >
> >
>
> >
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-21 14:13 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-05-19 6:34 [PATCH] trusted-firmware-a: re-enable generation of packages Denys Dmytriyenko
2020-05-19 9:12 ` [meta-arm] " Diego Sueiro
2020-05-19 15:17 ` Jon Mason
2020-05-19 16:26 ` Denys Dmytriyenko
2020-05-21 14:13 ` Jon Mason
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.