From: Qianyu Gong <qianyu.gong@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] pci: gate print info of reading vender id with CONFIG_DM_PCI
Date: Thu, 28 Jan 2016 08:55:34 +0000 [thread overview]
Message-ID: <AM2PR04MB096406C0C6652D50662C3E95E7DA0@AM2PR04MB0964.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <CAEUhbmVGWMUHLPRRJE3OVoh0mt=5Nattd3hdKfZzpryEMXiWEg@mail.gmail.com>
> -----Original Message-----
> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> Sent: Thursday, January 28, 2016 4:02 PM
> To: Qianyu Gong <qianyu.gong@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] pci: gate print info of reading vender id with
> CONFIG_DM_PCI
>
> On Thu, Jan 28, 2016 at 3:43 PM, Qianyu Gong <qianyu.gong@nxp.com> wrote:
> > Hi,
> >
> >> -----Original Message-----
> >> From: Bin Meng [mailto:bmeng.cn at gmail.com]
> >> Sent: Thursday, January 28, 2016 3:30 PM
> >> To: Qianyu Gong <qianyu.gong@nxp.com>
> >> Cc: U-Boot Mailing List <u-boot@lists.denx.de>
> >> Subject: Re: [U-Boot] [PATCH] pci: gate print info of reading vender
> >> id with CONFIG_DM_PCI
> >>
> >> On Thu, Jan 28, 2016 at 3:15 PM, Gong Qianyu <Qianyu.Gong@nxp.com> wrote:
> >> > From: Mingkai Hu <Mingkai.Hu@freescale.com>
> >> >
> >> > Referring to 'commit ff3e077bd23c ("dm: pci: Add a uclass for PCI")'.
> >> >
> >> > For legacy PCIe driver, it needs loop to read the vender_id from
> >> > devie
> >> > 0 to devie 255 to check if there is device available.
> >> > Reading non-existen device will trigger the "Cannot read bus
> >> > configuration: -1" information.
> >> >
> >> > Signed-off-by: Mingkai Hu <Mingkai.Hu@freescale.com>
> >> > Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
> >> > ---
> >>
> >> Which pci controller are you testing?
> >>
> >> [snip]
> >>
> >> Regards,
> >> Bin
> >
> > Designware PCIe controller on LS2085A.
> >
>
> Please check commit 7ba34ff09f1ef105521f914e4ad4e4ac19975bac "pci:
> layerscape: Adjust the return value when ls_pcie_addr_valid() fails"
> which is already in mainline.
>
> Regards,
> Bin
Ok. That's nice of you.
And we also find another commit cab24b3407189a12 "dm: pci: Convert 'pci'
command to driver model" submitted by Simon has fixed the issue. So no
need of this patch.
Thanks a lot.
Regards,
Qianyu
prev parent reply other threads:[~2016-01-28 8:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-28 7:15 [U-Boot] [PATCH] pci: gate print info of reading vender id with CONFIG_DM_PCI Gong Qianyu
2016-01-28 7:29 ` Bin Meng
2016-01-28 7:43 ` Qianyu Gong
2016-01-28 8:02 ` Bin Meng
2016-01-28 8:55 ` Qianyu Gong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM2PR04MB096406C0C6652D50662C3E95E7DA0@AM2PR04MB0964.eurprd04.prod.outlook.com \
--to=qianyu.gong@nxp.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.