All of lore.kernel.org
 help / color / mirror / Atom feed
From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] armv8/fsl-layerscape: add IFC fixup for LS1043A	with QSPI enabled
Date: Mon, 22 Feb 2016 11:51:12 +0000	[thread overview]
Message-ID: <AM2PR04MB1121D92E47724F45A8E5427497A30@AM2PR04MB1121.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <1456135520-48373-1-git-send-email-Qianyu.Gong@nxp.com>


> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Gong
> Qianyu
> Sent: Monday, February 22, 2016 3:35 PM
> To: u-boot at lists.denx.de; york sun <york.sun@nxp.com>; oss at buserror.net
> Cc: Qianyu Gong <qianyu.gong@nxp.com>; Mingkai Hu
> <mingkai.hu@nxp.com>
> Subject: [U-Boot] [PATCH] armv8/fsl-layerscape: add IFC fixup for LS1043A
> with QSPI enabled
> 
> QSPI and IFC are pin-multiplexed on LS1043A. So if QSPI is enabled, IFC
> should be disabled.
> But just disable IFC driver in LS1043A Linux is not enough because mdio-mux
> will access IFC address space -- actually it accesses FPGA which is connected
> to IFC CS3. So disable the whole IFC node in Linux device tree.
> 

FPGA and NAND access are valid use-case during QSPI boot

So why IFC controller is being disabled from device tree. 

> Signed-off-by: Gong Qianyu <Qianyu.Gong@nxp.com>
> 
> diff --git a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> b/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> index 4e4861d..5bb3048 100644
> --- a/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> +++ b/arch/arm/cpu/armv8/fsl-layerscape/fdt.c
> @@ -204,4 +204,11 @@ void ft_cpu_setup(void *blob, bd_t *bd)  #ifdef
> CONFIG_FSL_LSCH3
>  	fdt_fixup_smmu(blob);
>  #endif
> +
> +#ifdef CONFIG_LS1043A

I will suggest to avoid SoC specific defines

--prabhakar

  reply	other threads:[~2016-02-22 11:51 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-22 10:05 [U-Boot] [PATCH] armv8/fsl-layerscape: add IFC fixup for LS1043A with QSPI enabled Gong Qianyu
2016-02-22 11:51 ` Prabhakar Kushwaha [this message]
2016-03-11 10:32   ` Qianyu Gong
2016-02-23  0:11 ` Scott Wood
2016-03-11 10:18   ` Qianyu Gong
2016-03-28  8:51     ` Prabhakar Kushwaha
2016-03-28  9:43       ` Qianyu Gong
2016-03-29 20:44     ` Scott Wood
2016-03-30  6:20       ` Qianyu Gong
2016-03-31  2:38         ` Scott Wood
2016-07-19 21:57           ` york sun
2016-07-20  6:39             ` Qianyu Gong
2016-07-20 21:25               ` york sun
2016-07-21  3:51                 ` Qianyu Gong
2016-03-28  8:11 ` Qianyu Gong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM2PR04MB1121D92E47724F45A8E5427497A30@AM2PR04MB1121.eurprd04.prod.outlook.com \
    --to=prabhakar.kushwaha@nxp.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.