* [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
@ 2019-02-20 7:52 ` Jonas Karlman
0 siblings, 0 replies; 8+ messages in thread
From: Jonas Karlman @ 2019-02-20 7:52 UTC (permalink / raw)
To: dri-devel, linux-rockchip
Cc: Archit Taneja, Andrzej Hajda, Laurent Pinchart, David Airlie,
Daniel Vetter, Sean Paul, Neil Armstrong, Heiko Stuebner,
linux-kernel, Jonas Karlman
The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
also been identified as needing this workaround with a single iteration.
Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 64c3cf027518..14223c0ee784 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
* iteration for others.
* The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
* the workaround with a single iteration.
+ * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
+ * been identified as needing the workaround with a single iteration.
*/
switch (hdmi->version) {
@@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
break;
case 0x131a:
case 0x132a:
+ case 0x200a:
case 0x201a:
+ case 0x211a:
case 0x212a:
count = 1;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
@ 2019-02-20 7:52 ` Jonas Karlman
0 siblings, 0 replies; 8+ messages in thread
From: Jonas Karlman @ 2019-02-20 7:52 UTC (permalink / raw)
To: dri-devel, linux-rockchip
Cc: Archit Taneja, Andrzej Hajda, Laurent Pinchart, David Airlie,
Daniel Vetter, Sean Paul, Neil Armstrong, Heiko Stuebner,
linux-kernel, Jonas Karlman
The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
also been identified as needing this workaround with a single iteration.
Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
---
drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
index 64c3cf027518..14223c0ee784 100644
--- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
+++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
@@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
* iteration for others.
* The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
* the workaround with a single iteration.
+ * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
+ * been identified as needing the workaround with a single iteration.
*/
switch (hdmi->version) {
@@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
break;
case 0x131a:
case 0x132a:
+ case 0x200a:
case 0x201a:
+ case 0x211a:
case 0x212a:
count = 1;
break;
--
2.17.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
2019-02-20 7:52 ` Jonas Karlman
@ 2019-02-22 12:28 ` Laurent Pinchart
-1 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2019-02-22 12:28 UTC (permalink / raw)
To: Jonas Karlman
Cc: dri-devel, linux-rockchip, Archit Taneja, Andrzej Hajda,
David Airlie, Daniel Vetter, Sean Paul, Neil Armstrong,
Heiko Stuebner, linux-kernel
Hi Jonas,
Thank you for the patch.
On Wed, Feb 20, 2019 at 07:52:31AM +0000, Jonas Karlman wrote:
> The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> also been identified as needing this workaround with a single iteration.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
This makes me wonder if we have any device at all that doesn't need the
workaround... The HDMI encoder in R-Car SoCs doesn't seem to require it,
but it reports the same version number as on other SoCs that require the
workaround, and enabling it doesn't seem to affect R-Car adversely.
Should we thus enable it unconditionally ? Input from Synopsys would be
useful.
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 64c3cf027518..14223c0ee784 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> * iteration for others.
> * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
> * the workaround with a single iteration.
> + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> + * been identified as needing the workaround with a single iteration.
> */
>
> switch (hdmi->version) {
> @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> break;
> case 0x131a:
> case 0x132a:
> + case 0x200a:
> case 0x201a:
> + case 0x211a:
> case 0x212a:
> count = 1;
> break;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
@ 2019-02-22 12:28 ` Laurent Pinchart
0 siblings, 0 replies; 8+ messages in thread
From: Laurent Pinchart @ 2019-02-22 12:28 UTC (permalink / raw)
To: Jonas Karlman
Cc: dri-devel, linux-rockchip, Archit Taneja, Andrzej Hajda,
David Airlie, Daniel Vetter, Sean Paul, Neil Armstrong,
Heiko Stuebner, linux-kernel
Hi Jonas,
Thank you for the patch.
On Wed, Feb 20, 2019 at 07:52:31AM +0000, Jonas Karlman wrote:
> The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> also been identified as needing this workaround with a single iteration.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
This makes me wonder if we have any device at all that doesn't need the
workaround... The HDMI encoder in R-Car SoCs doesn't seem to require it,
but it reports the same version number as on other SoCs that require the
workaround, and enabling it doesn't seem to affect R-Car adversely.
Should we thus enable it unconditionally ? Input from Synopsys would be
useful.
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 64c3cf027518..14223c0ee784 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> * iteration for others.
> * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
> * the workaround with a single iteration.
> + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> + * been identified as needing the workaround with a single iteration.
> */
>
> switch (hdmi->version) {
> @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> break;
> case 0x131a:
> case 0x132a:
> + case 0x200a:
> case 0x201a:
> + case 0x211a:
> case 0x212a:
> count = 1;
> break;
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
2019-02-20 7:52 ` Jonas Karlman
@ 2019-03-30 9:24 ` Heiko Stuebner
-1 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2019-03-30 9:24 UTC (permalink / raw)
To: Jonas Karlman
Cc: dri-devel, linux-rockchip, Archit Taneja, Andrzej Hajda,
Laurent Pinchart, David Airlie, Daniel Vetter, Sean Paul,
Neil Armstrong, linux-kernel
Am Mittwoch, 20. Februar 2019, 08:52:31 CET schrieb Jonas Karlman:
> The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> also been identified as needing this workaround with a single iteration.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
On rk3328 and rk3288
Tested-by: Heiko Stueber <heiko@sntech.de>
If I remember correctly, this should remove the pink line that shows up
sometimes. With this patch I couldn't see it anymore during multiple
reboots.
Heiko
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 64c3cf027518..14223c0ee784 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> * iteration for others.
> * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
> * the workaround with a single iteration.
> + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> + * been identified as needing the workaround with a single iteration.
> */
>
> switch (hdmi->version) {
> @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> break;
> case 0x131a:
> case 0x132a:
> + case 0x200a:
> case 0x201a:
> + case 0x211a:
> case 0x212a:
> count = 1;
> break;
>
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
@ 2019-03-30 9:24 ` Heiko Stuebner
0 siblings, 0 replies; 8+ messages in thread
From: Heiko Stuebner @ 2019-03-30 9:24 UTC (permalink / raw)
To: Jonas Karlman
Cc: David Airlie, Neil Armstrong, linux-kernel, dri-devel,
linux-rockchip, Sean Paul, Laurent Pinchart
Am Mittwoch, 20. Februar 2019, 08:52:31 CET schrieb Jonas Karlman:
> The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> also been identified as needing this workaround with a single iteration.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
On rk3328 and rk3288
Tested-by: Heiko Stueber <heiko@sntech.de>
If I remember correctly, this should remove the pink line that shows up
sometimes. With this patch I couldn't see it anymore during multiple
reboots.
Heiko
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 64c3cf027518..14223c0ee784 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> * iteration for others.
> * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
> * the workaround with a single iteration.
> + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> + * been identified as needing the workaround with a single iteration.
> */
>
> switch (hdmi->version) {
> @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> break;
> case 0x131a:
> case 0x132a:
> + case 0x200a:
> case 0x201a:
> + case 0x211a:
> case 0x212a:
> count = 1;
> break;
>
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
2019-02-20 7:52 ` Jonas Karlman
@ 2019-04-12 6:26 ` Andrzej Hajda
-1 siblings, 0 replies; 8+ messages in thread
From: Andrzej Hajda @ 2019-04-12 6:26 UTC (permalink / raw)
To: Jonas Karlman, dri-devel, linux-rockchip
Cc: Archit Taneja, Laurent Pinchart, David Airlie, Daniel Vetter,
Sean Paul, Neil Armstrong, Heiko Stuebner, linux-kernel
On 20.02.2019 08:52, Jonas Karlman wrote:
> The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> also been identified as needing this workaround with a single iteration.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Queued to drm-misc-fixes.
--
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 64c3cf027518..14223c0ee784 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> * iteration for others.
> * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
> * the workaround with a single iteration.
> + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> + * been identified as needing the workaround with a single iteration.
> */
>
> switch (hdmi->version) {
> @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> break;
> case 0x131a:
> case 0x132a:
> + case 0x200a:
> case 0x201a:
> + case 0x211a:
> case 0x212a:
> count = 1;
> break;
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs
@ 2019-04-12 6:26 ` Andrzej Hajda
0 siblings, 0 replies; 8+ messages in thread
From: Andrzej Hajda @ 2019-04-12 6:26 UTC (permalink / raw)
To: Jonas Karlman, dri-devel, linux-rockchip
Cc: Archit Taneja, Laurent Pinchart, David Airlie, Daniel Vetter,
Sean Paul, Neil Armstrong, Heiko Stuebner, linux-kernel
On 20.02.2019 08:52, Jonas Karlman wrote:
> The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> also been identified as needing this workaround with a single iteration.
>
> Fixes: be41fc55f1aa ("drm: bridge: dw-hdmi: Handle overflow workaround based on device version")
> Signed-off-by: Jonas Karlman <jonas@kwiboo.se>
Queued to drm-misc-fixes.
--
Regards
Andrzej
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 64c3cf027518..14223c0ee784 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -1655,6 +1655,8 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> * iteration for others.
> * The Amlogic Meson GX SoCs (v2.01a) have been identified as needing
> * the workaround with a single iteration.
> + * The Rockchip RK3288 SoC (v2.00a) and RK3328/RK3399 SoCs (v2.11a) have
> + * been identified as needing the workaround with a single iteration.
> */
>
> switch (hdmi->version) {
> @@ -1663,7 +1665,9 @@ static void dw_hdmi_clear_overflow(struct dw_hdmi *hdmi)
> break;
> case 0x131a:
> case 0x132a:
> + case 0x200a:
> case 0x201a:
> + case 0x211a:
> case 0x212a:
> count = 1;
> break;
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-04-12 6:26 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20190220075334epcas3p16f66503f11d0bacdcf316b232f441fd0@epcas3p1.samsung.com>
2019-02-20 7:52 ` [PATCH] drm: bridge: dw-hdmi: Fix overflow workaround for Rockchip SoCs Jonas Karlman
2019-02-20 7:52 ` Jonas Karlman
2019-02-22 12:28 ` Laurent Pinchart
2019-02-22 12:28 ` Laurent Pinchart
2019-03-30 9:24 ` Heiko Stuebner
2019-03-30 9:24 ` Heiko Stuebner
2019-04-12 6:26 ` Andrzej Hajda
2019-04-12 6:26 ` Andrzej Hajda
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.