From: "A.s. Dong" <aisheng.dong@nxp.com> To: "A.s. Dong" <aisheng.dong@nxp.com>, "linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org> Cc: "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linus.walleij@linaro.org" <linus.walleij@linaro.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "stefan@agner.ch" <stefan@agner.ch>, Jacky Bai <ping.bai@nxp.com>, Andy Duan <fugang.duan@nxp.com>, "kernel@pengutronix.de" <kernel@pengutronix.de> Subject: RE: [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux property Date: Wed, 12 Jul 2017 13:57:25 +0000 [thread overview] Message-ID: <AM3PR04MB3068BC904003E560AF4F62280AF0@AM3PR04MB306.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1498046395-30001-4-git-send-email-aisheng.dong@nxp.com> Hi Shawn, > -----Original Message----- > From: Dong Aisheng [mailto:aisheng.dong@nxp.com] > Sent: Wednesday, June 21, 2017 8:00 PM > To: linux-gpio@vger.kernel.org > Cc: linux-arm-kernel@lists.infradead.org; linus.walleij@linaro.org; > shawnguo@kernel.org; stefan@agner.ch; Jacky Bai; Andy Duan; > kernel@pengutronix.de; A.s. Dong > Subject: [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux > property > > The generic pinmux property seems to be more suitable for IMX. > So we change to use 'pinmux' instead of 'pins'. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Bai Ping <ping.bai@nxp.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > Would you help review this minor change? I will collect your ACKs and resent based on 4.13 RC1. Regards Dong Aisheng > --- > ChangeLog: > * new patch > --- > drivers/pinctrl/freescale/pinctrl-imx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c > b/drivers/pinctrl/freescale/pinctrl-imx.c > index 72aca75..fc1ba3c 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > @@ -563,14 +563,14 @@ static int imx_pinctrl_parse_groups(struct > device_node *np, > * do sanity check and calculate pins number > * > * First try legacy 'fsl,pins' property, then fall back to the > - * generic 'pins'. > + * generic 'pinmux'. > * > - * Note: for generic 'pins' case, there's no CONFIG part in > + * Note: for generic 'pinmux' case, there's no CONFIG part in > * the binding format. > */ > list = of_get_property(np, "fsl,pins", &size); > if (!list) { > - list = of_get_property(np, "pins", &size); > + list = of_get_property(np, "pinmux", &size); > if (!list) { > dev_err(info->dev, > "no fsl,pins and pins property in node %s\n", > -- > 2.7.4
WARNING: multiple messages have this Message-ID (diff)
From: aisheng.dong@nxp.com (A.s. Dong) To: linux-arm-kernel@lists.infradead.org Subject: [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux property Date: Wed, 12 Jul 2017 13:57:25 +0000 [thread overview] Message-ID: <AM3PR04MB3068BC904003E560AF4F62280AF0@AM3PR04MB306.eurprd04.prod.outlook.com> (raw) In-Reply-To: <1498046395-30001-4-git-send-email-aisheng.dong@nxp.com> Hi Shawn, > -----Original Message----- > From: Dong Aisheng [mailto:aisheng.dong at nxp.com] > Sent: Wednesday, June 21, 2017 8:00 PM > To: linux-gpio at vger.kernel.org > Cc: linux-arm-kernel at lists.infradead.org; linus.walleij at linaro.org; > shawnguo at kernel.org; stefan at agner.ch; Jacky Bai; Andy Duan; > kernel at pengutronix.de; A.s. Dong > Subject: [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux > property > > The generic pinmux property seems to be more suitable for IMX. > So we change to use 'pinmux' instead of 'pins'. > > Cc: Linus Walleij <linus.walleij@linaro.org> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Bai Ping <ping.bai@nxp.com> > Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com> > Would you help review this minor change? I will collect your ACKs and resent based on 4.13 RC1. Regards Dong Aisheng > --- > ChangeLog: > * new patch > --- > drivers/pinctrl/freescale/pinctrl-imx.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/pinctrl/freescale/pinctrl-imx.c > b/drivers/pinctrl/freescale/pinctrl-imx.c > index 72aca75..fc1ba3c 100644 > --- a/drivers/pinctrl/freescale/pinctrl-imx.c > +++ b/drivers/pinctrl/freescale/pinctrl-imx.c > @@ -563,14 +563,14 @@ static int imx_pinctrl_parse_groups(struct > device_node *np, > * do sanity check and calculate pins number > * > * First try legacy 'fsl,pins' property, then fall back to the > - * generic 'pins'. > + * generic 'pinmux'. > * > - * Note: for generic 'pins' case, there's no CONFIG part in > + * Note: for generic 'pinmux' case, there's no CONFIG part in > * the binding format. > */ > list = of_get_property(np, "fsl,pins", &size); > if (!list) { > - list = of_get_property(np, "pins", &size); > + list = of_get_property(np, "pinmux", &size); > if (!list) { > dev_err(info->dev, > "no fsl,pins and pins property in node %s\n", > -- > 2.7.4
next prev parent reply other threads:[~2017-07-12 13:57 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-21 11:59 [PATCH V4 0/7] pinctrl: imx: add imx7ulp pinctrl support Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng [not found] ` <1498046395-30001-1-git-send-email-aisheng.dong-3arQi8VN3Tc@public.gmane.org> 2017-06-21 11:59 ` [PATCH V4 1/7] dt-bindings: pinctrl: extend the pinmux property to support integers array Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng [not found] ` <1498046395-30001-2-git-send-email-aisheng.dong-3arQi8VN3Tc@public.gmane.org> 2017-06-21 21:50 ` jmondi 2017-06-21 21:50 ` jmondi 2017-06-22 14:35 ` A.s. Dong 2017-06-22 14:35 ` A.s. Dong 2017-06-22 14:49 ` [PATCH V5 1/1] " Dong Aisheng 2017-06-22 14:49 ` Dong Aisheng [not found] ` <1498142940-7982-1-git-send-email-aisheng.dong-3arQi8VN3Tc@public.gmane.org> 2017-06-26 18:49 ` Rob Herring 2017-06-26 18:49 ` Rob Herring 2017-06-29 12:35 ` Linus Walleij 2017-06-29 12:35 ` Linus Walleij 2017-06-21 11:59 ` [PATCH V4 2/7] dt-bindings: pinctrl: add imx7ulp pinctrl binding doc Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng [not found] ` <1498046395-30001-3-git-send-email-aisheng.dong-3arQi8VN3Tc@public.gmane.org> 2017-06-26 18:02 ` Rob Herring 2017-06-26 18:02 ` Rob Herring 2017-06-21 11:59 ` [PATCH V4 3/7] pinctrl: imx: switch to use the generic pinmux property Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng 2017-07-12 13:57 ` A.s. Dong [this message] 2017-07-12 13:57 ` A.s. Dong 2017-07-13 8:43 ` Shawn Guo 2017-07-13 8:43 ` Shawn Guo 2017-06-21 11:59 ` [PATCH V4 4/7] pinctrl: imx: add imx7ulp driver Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng 2017-06-21 11:59 ` [PATCH V4 5/7] pinctrl: imx: remove gpio_request_enable and gpio_disable_free Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng 2017-06-27 3:47 ` Stefan Agner 2017-06-27 3:47 ` Stefan Agner 2017-06-27 5:27 ` A.s. Dong 2017-06-27 5:27 ` A.s. Dong 2017-06-21 11:59 ` [PATCH V4 6/7] pinctrl: imx: make imx_pmx_ops.gpio_set_direction platform specific callbacks Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng 2017-06-27 3:53 ` Stefan Agner 2017-06-27 3:53 ` Stefan Agner 2017-06-21 11:59 ` [PATCH V4 7/7] pinctrl: pinctrl-imx7ulp: add gpio_set_direction support Dong Aisheng 2017-06-21 11:59 ` Dong Aisheng 2017-07-12 13:59 ` A.s. Dong 2017-07-12 13:59 ` A.s. Dong 2017-07-13 8:46 ` Shawn Guo 2017-07-13 8:46 ` Shawn Guo 2017-07-03 10:36 ` [PATCH V4 0/7] pinctrl: imx: add imx7ulp pinctrl support A.s. Dong 2017-07-03 10:36 ` A.s. Dong 2017-07-12 11:59 ` Linus Walleij 2017-07-12 11:59 ` Linus Walleij 2017-07-12 13:54 ` A.s. Dong 2017-07-12 13:54 ` A.s. Dong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM3PR04MB3068BC904003E560AF4F62280AF0@AM3PR04MB306.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=fugang.duan@nxp.com \ --cc=kernel@pengutronix.de \ --cc=linus.walleij@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-gpio@vger.kernel.org \ --cc=ping.bai@nxp.com \ --cc=shawnguo@kernel.org \ --cc=stefan@agner.ch \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.