[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[Ashish Kumar]

 * Increase default hugepage count to 256 from 16
 * Note: default env variables are stored at 0x580200000/0x584200000
    of size 0x2000

Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
---
 include/configs/ls2080a_common.h |    2 +-
 include/configs/ls2080ardb.h     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h
index 4ae7d11..a503934 100644
--- a/include/configs/ls2080a_common.h
+++ b/include/configs/ls2080a_common.h
@@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void);
 #define CONFIG_BOOTARGS		"console=ttyS0,115200 root=/dev/ram0 " \
 				"earlycon=uart8250,mmio,0x21c0500" \
 				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
-				" hugepagesz=2m hugepages=16"
+				" hugepagesz=2m hugepages=256"
 #define CONFIG_BOOTCOMMAND		"cp.b $kernel_start $kernel_load "     \
 					"$kernel_size && bootm $kernel_load"
 #define CONFIG_BOOTDELAY		10
diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h
index 116dbcd..356d254 100644
--- a/include/configs/ls2080ardb.h
+++ b/include/configs/ls2080ardb.h
@@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void);
 #define CONFIG_BOOTARGS		"console=ttyS1,115200 root=/dev/ram0 " \
 				"earlycon=uart8250,mmio,0x21c0600" \
 				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
-				" hugepagesz=2m hugepages=16"
+				" hugepagesz=2m hugepages=256"
 
 /* MAC/PHY configuration */
 #ifdef CONFIG_FSL_MC_ENET
-- 
1.7.6.GIT

[U-Boot] [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb

[Ashish Kumar]

Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
---
 arch/arm/dts/fsl-ls2080a-rdb.dts |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/arch/arm/dts/fsl-ls2080a-rdb.dts b/arch/arm/dts/fsl-ls2080a-rdb.dts
index 1a1813b..71d1969 100644
--- a/arch/arm/dts/fsl-ls2080a-rdb.dts
+++ b/arch/arm/dts/fsl-ls2080a-rdb.dts
@@ -11,7 +11,7 @@
 #include "fsl-ls2080a.dtsi"
 
 / {
-	model = "Freescale Layerscape 2080a RDB Board";
+	model = "Freescale Layerscape 2085a RDB Board";
 	compatible = "fsl,ls2080a-rdb", "fsl,ls2080a";
 
 	aliases {
-- 
1.7.6.GIT

[U-Boot] [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb

[york sun]

On 01/14/2016 04:42 AM, Ashish Kumar wrote:
> Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
> ---
>  arch/arm/dts/fsl-ls2080a-rdb.dts |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/arch/arm/dts/fsl-ls2080a-rdb.dts b/arch/arm/dts/fsl-ls2080a-rdb.dts
> index 1a1813b..71d1969 100644
> --- a/arch/arm/dts/fsl-ls2080a-rdb.dts
> +++ b/arch/arm/dts/fsl-ls2080a-rdb.dts
> @@ -11,7 +11,7 @@
>  #include "fsl-ls2080a.dtsi"
>  
>  / {
> -	model = "Freescale Layerscape 2080a RDB Board";
> +	model = "Freescale Layerscape 2085a RDB Board";
>  	compatible = "fsl,ls2080a-rdb", "fsl,ls2080a";
>  
>  	aliases {
> 

Ashish,

Why change this? This product has been renamed to LS2080A.

York

[U-Boot] [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb

[Prabhakar Kushwaha]

> -----Original Message-----
> From: york sun [mailto:york.sun at nxp.com]
> Sent: Thursday, January 14, 2016 10:36 PM
> To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar@freescale.com>
> Subject: Re: [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb
> 
> On 01/14/2016 04:42 AM, Ashish Kumar wrote:
> > Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
> > ---
> >  arch/arm/dts/fsl-ls2080a-rdb.dts |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/arch/arm/dts/fsl-ls2080a-rdb.dts b/arch/arm/dts/fsl-ls2080a-
> rdb.dts
> > index 1a1813b..71d1969 100644
> > --- a/arch/arm/dts/fsl-ls2080a-rdb.dts
> > +++ b/arch/arm/dts/fsl-ls2080a-rdb.dts
> > @@ -11,7 +11,7 @@
> >  #include "fsl-ls2080a.dtsi"
> >
> >  / {
> > -	model = "Freescale Layerscape 2080a RDB Board";
> > +	model = "Freescale Layerscape 2085a RDB Board";
> >  	compatible = "fsl,ls2080a-rdb", "fsl,ls2080a";
> >
> >  	aliases {
> >
> 
> Ashish,
> 
> Why change this? This product has been renamed to LS2080A.
> 

LS2085ARDB is a platform/board hosting LS2080A, LS2085A and LS2088A.

This is the reason board name is being updated.

--prabhakar

[U-Boot] [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb

[york sun]

On 01/14/2016 08:49 PM, Prabhakar Kushwaha wrote:
> 
>> -----Original Message-----
>> From: york sun [mailto:york.sun at nxp.com]
>> Sent: Thursday, January 14, 2016 10:36 PM
>> To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot at lists.denx.de
>> Cc: Prabhakar Kushwaha <prabhakar@freescale.com>
>> Subject: Re: [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb
>>
>> On 01/14/2016 04:42 AM, Ashish Kumar wrote:
>>> Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
>>> ---
>>>  arch/arm/dts/fsl-ls2080a-rdb.dts |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/arch/arm/dts/fsl-ls2080a-rdb.dts b/arch/arm/dts/fsl-ls2080a-
>> rdb.dts
>>> index 1a1813b..71d1969 100644
>>> --- a/arch/arm/dts/fsl-ls2080a-rdb.dts
>>> +++ b/arch/arm/dts/fsl-ls2080a-rdb.dts
>>> @@ -11,7 +11,7 @@
>>>  #include "fsl-ls2080a.dtsi"
>>>
>>>  / {
>>> -	model = "Freescale Layerscape 2080a RDB Board";
>>> +	model = "Freescale Layerscape 2085a RDB Board";
>>>  	compatible = "fsl,ls2080a-rdb", "fsl,ls2080a";
>>>
>>>  	aliases {
>>>
>>
>> Ashish,
>>
>> Why change this? This product has been renamed to LS2080A.
>>
> 
> LS2085ARDB is a platform/board hosting LS2080A, LS2085A and LS2088A.
> 
> This is the reason board name is being updated.
> 

Prabhakar,

You changed the name from LS2085A to LS2080A not long ago, including the board
LS2085ARDB, stating LS2080A is the prime personality. Now you want to change it
back? You have to give a good reason.

York

[U-Boot] [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb

[Prabhakar Kushwaha]

> -----Original Message-----
> From: york sun
> Sent: Wednesday, January 20, 2016 12:02 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Ashish Kumar
> <ashish.kumar@nxp.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH] ls2-2085ardb: Correct the model name of ls2085ardb
> 
> On 01/14/2016 08:49 PM, Prabhakar Kushwaha wrote:
> >
> >> -----Original Message-----
> >> From: york sun [mailto:york.sun at nxp.com]
> >> Sent: Thursday, January 14, 2016 10:36 PM
> >> To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot at lists.denx.de
> >> Cc: Prabhakar Kushwaha <prabhakar@freescale.com>
> >> Subject: Re: [PATCH] ls2-2085ardb: Correct the model name of
> >> ls2085ardb
> >>
> >> On 01/14/2016 04:42 AM, Ashish Kumar wrote:
> >>> Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
> >>> ---
> >>>  arch/arm/dts/fsl-ls2080a-rdb.dts |    2 +-
> >>>  1 files changed, 1 insertions(+), 1 deletions(-)
> >>>
> >>> diff --git a/arch/arm/dts/fsl-ls2080a-rdb.dts
> >>> b/arch/arm/dts/fsl-ls2080a-
> >> rdb.dts
> >>> index 1a1813b..71d1969 100644
> >>> --- a/arch/arm/dts/fsl-ls2080a-rdb.dts
> >>> +++ b/arch/arm/dts/fsl-ls2080a-rdb.dts
> >>> @@ -11,7 +11,7 @@
> >>>  #include "fsl-ls2080a.dtsi"
> >>>
> >>>  / {
> >>> -	model = "Freescale Layerscape 2080a RDB Board";
> >>> +	model = "Freescale Layerscape 2085a RDB Board";
> >>>  	compatible = "fsl,ls2080a-rdb", "fsl,ls2080a";
> >>>
> >>>  	aliases {
> >>>
> >>
> >> Ashish,
> >>
> >> Why change this? This product has been renamed to LS2080A.
> >>
> >
> > LS2085ARDB is a platform/board hosting LS2080A, LS2085A and LS2088A.
> >
> > This is the reason board name is being updated.
> >
> 
> Prabhakar,
> 
> You changed the name from LS2085A to LS2080A not long ago, including the
> board LS2085ARDB, stating LS2080A is the prime personality. Now you want
> to change it back? You have to give a good reason.
> 

LS2080A and LS2085A name is correct. 

Things nail down to platform/board which will host the SoC.  LS2085ARDB "board" will host both LS2080A, LS2085A and in future LS2088A.  Same name is printed on the board.  So to avoid confusion board name has been updated.

looks like v2 of this patch is required, as in board/Freescale/ls2080rdb.c  board name is printed as per SoC name with suffix of QDS or RDB. 

--prabhakar

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[york sun]

On 01/14/2016 04:42 AM, Ashish Kumar wrote:
>  * Increase default hugepage count to 256 from 16
>  * Note: default env variables are stored at 0x580200000/0x584200000
>     of size 0x2000
> 

Ashish,

What does the default env location have anything to do with this patch?

York



> Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
> ---
>  include/configs/ls2080a_common.h |    2 +-
>  include/configs/ls2080ardb.h     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h
> index 4ae7d11..a503934 100644
> --- a/include/configs/ls2080a_common.h
> +++ b/include/configs/ls2080a_common.h
> @@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void);
>  #define CONFIG_BOOTARGS		"console=ttyS0,115200 root=/dev/ram0 " \
>  				"earlycon=uart8250,mmio,0x21c0500" \
>  				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
> -				" hugepagesz=2m hugepages=16"
> +				" hugepagesz=2m hugepages=256"
>  #define CONFIG_BOOTCOMMAND		"cp.b $kernel_start $kernel_load "     \
>  					"$kernel_size && bootm $kernel_load"
>  #define CONFIG_BOOTDELAY		10
> diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h
> index 116dbcd..356d254 100644
> --- a/include/configs/ls2080ardb.h
> +++ b/include/configs/ls2080ardb.h
> @@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void);
>  #define CONFIG_BOOTARGS		"console=ttyS1,115200 root=/dev/ram0 " \
>  				"earlycon=uart8250,mmio,0x21c0600" \
>  				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
> -				" hugepagesz=2m hugepages=16"
> +				" hugepagesz=2m hugepages=256"
>  
>  /* MAC/PHY configuration */
>  #ifdef CONFIG_FSL_MC_ENET
> 

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[Ashish Kumar]

Hello York,

It is like a  heads-up, that user needs to erase the environment variable location before flashing a new uboot for the changes to reflect.

Regards
Ashish

-----Original Message-----
From: york sun [mailto:york.sun at nxp.com] 
Sent: Monday, February 01, 2016 10:17 PM
To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot at lists.denx.de
Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count

On 01/14/2016 04:42 AM, Ashish Kumar wrote:
>  * Increase default hugepage count to 256 from 16
>  * Note: default env variables are stored at 0x580200000/0x584200000
>     of size 0x2000
> 

Ashish,

What does the default env location have anything to do with this patch?

York



> Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
> ---
>  include/configs/ls2080a_common.h |    2 +-
>  include/configs/ls2080ardb.h     |    2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/include/configs/ls2080a_common.h 
> b/include/configs/ls2080a_common.h
> index 4ae7d11..a503934 100644
> --- a/include/configs/ls2080a_common.h
> +++ b/include/configs/ls2080a_common.h
> @@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void);
>  #define CONFIG_BOOTARGS		"console=ttyS0,115200 root=/dev/ram0 " \
>  				"earlycon=uart8250,mmio,0x21c0500" \
>  				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
> -				" hugepagesz=2m hugepages=16"
> +				" hugepagesz=2m hugepages=256"
>  #define CONFIG_BOOTCOMMAND		"cp.b $kernel_start $kernel_load "     \
>  					"$kernel_size && bootm $kernel_load"
>  #define CONFIG_BOOTDELAY		10
> diff --git a/include/configs/ls2080ardb.h 
> b/include/configs/ls2080ardb.h index 116dbcd..356d254 100644
> --- a/include/configs/ls2080ardb.h
> +++ b/include/configs/ls2080ardb.h
> @@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void);
>  #define CONFIG_BOOTARGS		"console=ttyS1,115200 root=/dev/ram0 " \
>  				"earlycon=uart8250,mmio,0x21c0600" \
>  				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
> -				" hugepagesz=2m hugepages=16"
> +				" hugepagesz=2m hugepages=256"
>  
>  /* MAC/PHY configuration */
>  #ifdef CONFIG_FSL_MC_ENET
> 

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[york sun]

On 02/01/2016 10:09 PM, Ashish Kumar wrote:
> Hello York,
> 
> It is like a  heads-up, that user needs to erase the environment variable location before flashing a new uboot for the changes to reflect.

You are changing default environmental variables. It is up to the users to set
correct variables. I don't believe the note clarifies anything in the context of
this patch. You don't need to send an update if you agree. I can drop the note
when merging the patch.

York


> 
> Regards
> Ashish
> 
> -----Original Message-----
> From: york sun [mailto:york.sun at nxp.com] 
> Sent: Monday, February 01, 2016 10:17 PM
> To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count
> 
> On 01/14/2016 04:42 AM, Ashish Kumar wrote:
>>  * Increase default hugepage count to 256 from 16
>>  * Note: default env variables are stored at 0x580200000/0x584200000
>>     of size 0x2000
>>
> 
> Ashish,
> 
> What does the default env location have anything to do with this patch?
> 
> York
> 

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[Ashish Kumar]

Agree, Please drop this while merging.

Regards
Ashish

-----Original Message-----
From: york sun 
Sent: Tuesday, February 02, 2016 11:50 AM
To: Ashish Kumar <ashish.kumar@nxp.com>; u-boot at lists.denx.de
Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count

On 02/01/2016 10:09 PM, Ashish Kumar wrote:
> Hello York,
> 
> It is like a  heads-up, that user needs to erase the environment variable location before flashing a new uboot for the changes to reflect.

You are changing default environmental variables. It is up to the users to set correct variables. I don't believe the note clarifies anything in the context of this patch. You don't need to send an update if you agree. I can drop the note when merging the patch.

York


> 
> Regards
> Ashish
> 
> -----Original Message-----
> From: york sun [mailto:york.sun at nxp.com]
> Sent: Monday, February 01, 2016 10:17 PM
> To: Ashish Kumar <Ashish.Kumar@freescale.com>; u-boot at lists.denx.de
> Subject: Re: [PATCH] ls2-2085a: Increase default hugepage count
> 
> On 01/14/2016 04:42 AM, Ashish Kumar wrote:
>>  * Increase default hugepage count to 256 from 16
>>  * Note: default env variables are stored at 0x580200000/0x584200000
>>     of size 0x2000
>>
> 
> Ashish,
> 
> What does the default env location have anything to do with this patch?
> 
> York
> 

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[york sun]

On 01/14/2016 04:42 AM, Ashish Kumar wrote:
>  * Increase default hugepage count to 256 from 16
>  * Note: default env variables are stored at 0x580200000/0x584200000
>     of size 0x2000
> 
> Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
> ---

Dropped the note of default env.
Applied to fsl-qoriq master. Awaiting upstream.

York

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[Prabhakar Kushwaha]

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Ashish
> Kumar
> Sent: Thursday, January 14, 2016 6:04 PM
> To: u-boot at lists.denx.de
> Cc: Ashish Kumar <Ashish.Kumar@freescale.com>
> Subject: [U-Boot] [PATCH] ls2-2085a: Increase default hugepage count
> 

Please add description of this patch


--prabhakar

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[Ashish Kumar]

From: Ashish Kumar <Ashish.Kumar@freescale.com>

 * Increase default hugepage count to 256 from 16
 * Note: default env variables are stored at 0x580200000/0x584200000
    of size 0x2000

Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
---
 include/configs/ls2080a_common.h |    2 +-
 include/configs/ls2080ardb.h     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h
index 4ae7d11..a503934 100644
--- a/include/configs/ls2080a_common.h
+++ b/include/configs/ls2080a_common.h
@@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void);
 #define CONFIG_BOOTARGS		"console=ttyS0,115200 root=/dev/ram0 " \
 				"earlycon=uart8250,mmio,0x21c0500" \
 				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
-				" hugepagesz=2m hugepages=16"
+				" hugepagesz=2m hugepages=256"
 #define CONFIG_BOOTCOMMAND		"cp.b $kernel_start $kernel_load "     \
 					"$kernel_size && bootm $kernel_load"
 #define CONFIG_BOOTDELAY		10
diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h
index 116dbcd..356d254 100644
--- a/include/configs/ls2080ardb.h
+++ b/include/configs/ls2080ardb.h
@@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void);
 #define CONFIG_BOOTARGS		"console=ttyS1,115200 root=/dev/ram0 " \
 				"earlycon=uart8250,mmio,0x21c0600" \
 				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
-				" hugepagesz=2m hugepages=16"
+				" hugepagesz=2m hugepages=256"
 
 /* MAC/PHY configuration */
 #ifdef CONFIG_FSL_MC_ENET
-- 
1.7.6.GIT

[U-Boot] [PATCH] ls2-2085a: Increase default hugepage count

[y at nmglablinux22.freescale.com]

From: Ashish Kumar <Ashish.Kumar@freescale.com>

 * Increase default hugepage count to 256 from 16
 * Note: default env variables are stored at 0x580200000/0x584200000
    of size 0x2000

Signed-off-by: Ashish Kumar <Ashish.Kumar@freescale.com>
---
 include/configs/ls2080a_common.h |    2 +-
 include/configs/ls2080ardb.h     |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/include/configs/ls2080a_common.h b/include/configs/ls2080a_common.h
index 4ae7d11..a503934 100644
--- a/include/configs/ls2080a_common.h
+++ b/include/configs/ls2080a_common.h
@@ -272,7 +272,7 @@ unsigned long long get_qixis_addr(void);
 #define CONFIG_BOOTARGS		"console=ttyS0,115200 root=/dev/ram0 " \
 				"earlycon=uart8250,mmio,0x21c0500" \
 				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
-				" hugepagesz=2m hugepages=16"
+				" hugepagesz=2m hugepages=256"
 #define CONFIG_BOOTCOMMAND		"cp.b $kernel_start $kernel_load "     \
 					"$kernel_size && bootm $kernel_load"
 #define CONFIG_BOOTDELAY		10
diff --git a/include/configs/ls2080ardb.h b/include/configs/ls2080ardb.h
index 116dbcd..356d254 100644
--- a/include/configs/ls2080ardb.h
+++ b/include/configs/ls2080ardb.h
@@ -333,7 +333,7 @@ unsigned long get_board_sys_clk(void);
 #define CONFIG_BOOTARGS		"console=ttyS1,115200 root=/dev/ram0 " \
 				"earlycon=uart8250,mmio,0x21c0600" \
 				"ramdisk_size=0x2000000 default_hugepagesz=2m" \
-				" hugepagesz=2m hugepages=16"
+				" hugepagesz=2m hugepages=256"
 
 /* MAC/PHY configuration */
 #ifdef CONFIG_FSL_MC_ENET
-- 
1.7.6.GIT