All of lore.kernel.org
 help / color / mirror / Atom feed
From: york sun <york.sun@nxp.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: "morbidrsa@gmail.com" <morbidrsa@gmail.com>,
	"oss@buserror.net" <oss@buserror.net>,
	Stuart Yoder <stuart.yoder@nxp.com>,
	"bp@alien8.de" <bp@alien8.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Kevin Hao" <haokexin@gmail.com>, Yinghai Lu <yinghai@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
Date: Thu, 4 Aug 2016 23:39:14 +0000	[thread overview]
Message-ID: <AM4PR0401MB17322032D82792F305AF63A19A070@AM4PR0401MB1732.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 8a1cbb34-1e5a-a7ee-1fc6-e6bd5db34aa1@au1.ibm.com

On 08/04/2016 04:36 PM, Andrew Donnellan wrote:
> On 05/08/16 08:58, York Sun wrote:
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.
>>
>> Signed-off-by: York Sun <york.sun@nxp.com>
>
> Good catch! One comment below.
>
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>
>
>>  /*
>>   * Reads the interrupt pin to determine if interrupt is use by card.
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *hose, int bus, int devfn,
>>  {
>>  	return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);
>>  }
>> +EXPORT_SYMBOL(early_find_capability);
>
> It'd be nicer for this to be renamed as "pci_early_find_capability" or
> something like that with a "namespace", I think.
>

I will rename it if I respin this patch for any reason. Otherwise, I 
will send out another patch to rename it after merging.

York

WARNING: multiple messages have this Message-ID (diff)
From: york sun <york.sun@nxp.com>
To: Andrew Donnellan <andrew.donnellan@au1.ibm.com>,
	"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Cc: "morbidrsa@gmail.com" <morbidrsa@gmail.com>,
	"oss@buserror.net" <oss@buserror.net>,
	Stuart Yoder <stuart.yoder@nxp.com>,
	"bp@alien8.de" <bp@alien8.de>,
	Benjamin Herrenschmidt <benh@kernel.crashing.org>,
	"Paul Mackerras" <paulus@samba.org>,
	Michael Ellerman <mpe@ellerman.id.au>,
	"Kevin Hao" <haokexin@gmail.com>, Yinghai Lu <yinghai@kernel.org>,
	Bjorn Helgaas <bhelgaas@google.com>,
	"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac
Date: Thu, 4 Aug 2016 23:39:14 +0000	[thread overview]
Message-ID: <AM4PR0401MB17322032D82792F305AF63A19A070@AM4PR0401MB1732.eurprd04.prod.outlook.com> (raw)
In-Reply-To: 8a1cbb34-1e5a-a7ee-1fc6-e6bd5db34aa1@au1.ibm.com

On 08/04/2016 04:36 PM, Andrew Donnellan wrote:=0A=
> On 05/08/16 08:58, York Sun wrote:=0A=
>> Two symbols are missing if mpc85xx_edac driver is compiled as module.=0A=
>>=0A=
>> Signed-off-by: York Sun <york.sun@nxp.com>=0A=
>=0A=
> Good catch! One comment below.=0A=
>=0A=
> Reviewed-by: Andrew Donnellan <andrew.donnellan@au1.ibm.com>=0A=
>=0A=
>>  /*=0A=
>>   * Reads the interrupt pin to determine if interrupt is use by card.=0A=
>> @@ -1585,6 +1586,7 @@ int early_find_capability(struct pci_controller *h=
ose, int bus, int devfn,=0A=
>>  {=0A=
>>  	return pci_bus_find_capability(fake_pci_bus(hose, bus), devfn, cap);=
=0A=
>>  }=0A=
>> +EXPORT_SYMBOL(early_find_capability);=0A=
>=0A=
> It'd be nicer for this to be renamed as "pci_early_find_capability" or=0A=
> something like that with a "namespace", I think.=0A=
>=0A=
=0A=
I will rename it if I respin this patch for any reason. Otherwise, I =0A=
will send out another patch to rename it after merging.=0A=
=0A=
York=0A=
=0A=

  reply	other threads:[~2016-08-05 12:12 UTC|newest]

Thread overview: 66+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1470351518-22404-1-git-send-email-york.sun@nxp.com>
2016-08-04 22:58 ` [Patch v3 01/11] arch/powerpc/pci: Fix compiling error for mpc85xx_edac York Sun
2016-08-04 23:36   ` Andrew Donnellan
2016-08-04 23:39     ` york sun [this message]
2016-08-04 23:39       ` york sun
2016-08-05  6:58       ` Borislav Petkov
2016-08-05  3:43   ` Michael Ellerman
2016-08-05  4:26     ` york sun
2016-08-05  4:26       ` york sun
2016-08-05  7:01       ` Borislav Petkov
2016-08-05  7:14         ` Johannes Thumshirn
2016-08-08 15:47         ` york sun
2016-08-08 15:47           ` york sun
2016-08-05 20:29     ` york sun
2016-08-05 20:29       ` york sun
2016-08-05 21:09       ` Scott Wood
2016-08-05 21:09         ` Scott Wood
2016-08-05 21:20         ` york sun
2016-08-05 21:20           ` york sun
2016-08-05 21:57           ` Scott Wood
2016-08-05 21:57             ` Scott Wood
2016-08-04 22:58 ` [Patch v3 02/11] arch/microblaze/pci: Drop early_find_capability() York Sun
2016-08-04 22:58 ` [Patch v3 03/11] driver/edac/mpc85xx_edac: Drop setting/clearing RFXE bit in HID1 York Sun
2016-08-08  7:11   ` Borislav Petkov
2016-08-08 15:39     ` york sun
2016-08-09  3:32       ` Borislav Petkov
2016-08-09  4:31         ` york sun
2016-08-09  5:01           ` Borislav Petkov
2016-08-09  5:06             ` york sun
2016-08-09  6:56               ` Borislav Petkov
2016-08-09 15:57                 ` york sun
     [not found]                 ` <275db5cd-09cd-d971-0e43-3b4af060f0e8@nxp.com>
2016-08-09 16:40                   ` york sun
2016-08-09 16:58                     ` Borislav Petkov
2016-08-04 22:58 ` [Patch v3 04/11] driver/edac/mpc85xx_edac: Replace printk with proper pr_* format York Sun
2016-08-04 22:58 ` [Patch v3 05/11] driver/edac/fsl-ddr: Separate FSL DDR EDAC driver from MPC85xx York Sun
2016-08-08  7:36   ` Borislav Petkov
2016-08-08 15:32     ` york sun
2016-08-04 22:58 ` [Patch v3 06/11] driver/edac/fsl_ddr: Rename macros and names York Sun
2016-08-08  7:41   ` Borislav Petkov
2016-08-08 15:31     ` york sun
2016-08-04 22:58 ` [Patch v3 07/11] driver/edac/fsl_ddr: Add DDR4 type York Sun
2016-08-08  8:30   ` Borislav Petkov
2016-08-08 15:30     ` york sun
2016-08-04 22:58 ` [Patch v3 08/11] driver/edac/fsl_ddr: Add support of little endian York Sun
2016-08-04 22:58   ` York Sun
2016-08-08  8:50   ` Borislav Petkov
2016-08-08  8:50     ` Borislav Petkov
2016-08-08 15:26     ` york sun
2016-08-08 15:39   ` Mark Rutland
2016-08-04 22:58 ` [Patch v3 09/11] driver/edac/fsl_ddr: Fix kernel warning when module is removed York Sun
2016-08-04 22:58 ` [Patch v3 10/11] driver/edac/layerscape_edac: Add Layerscape EDAC support York Sun
2016-08-04 22:58   ` York Sun
2016-08-08  8:57   ` Alexander Stein
2016-08-08  8:57     ` Alexander Stein
2016-08-08 15:16     ` york sun
2016-08-08 15:16       ` york sun
2016-08-08 18:06   ` Marc Zyngier
2016-08-08 18:06     ` Marc Zyngier
2016-08-08 19:56     ` york sun
2016-08-08 19:56       ` york sun
2016-08-09 11:12       ` Will Deacon
2016-08-09 11:12         ` Will Deacon
2016-08-09 15:27         ` york sun
2016-08-09 15:27           ` york sun
2016-08-04 22:58 ` [Patch v3 11/11] arm64: Update device tree for Layerscape SoCs York Sun
2016-08-04 22:58   ` York Sun
2016-08-04 22:58   ` York Sun

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR0401MB17322032D82792F305AF63A19A070@AM4PR0401MB1732.eurprd04.prod.outlook.com \
    --to=york.sun@nxp.com \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=benh@kernel.crashing.org \
    --cc=bhelgaas@google.com \
    --cc=bp@alien8.de \
    --cc=haokexin@gmail.com \
    --cc=linux-edac@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=morbidrsa@gmail.com \
    --cc=mpe@ellerman.id.au \
    --cc=oss@buserror.net \
    --cc=paulus@samba.org \
    --cc=stuart.yoder@nxp.com \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.