* [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS
@ 2016-08-05 9:46 Pratiyush Mohan Srivastava
2016-08-05 9:46 ` [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
2016-08-05 17:24 ` [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS york sun
0 siblings, 2 replies; 8+ messages in thread
From: Pratiyush Mohan Srivastava @ 2016-08-05 9:46 UTC (permalink / raw)
To: u-boot
From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
LS1012AFRDM has 512MB of DDR.
So update Kernel load address as 0x96000000 instead of default
0xa0000000.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
---
Changes for v2: Incorporated York's comments
- Removed ramdisk_addr, ramdisk_size
- Updated UART baud-rate.
include/configs/ls1012afrdm.h | 14 ++++++++++++++
1 file changed, 14 insertions(+)
diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
index ad81142..f2c6ca8 100644
--- a/include/configs/ls1012afrdm.h
+++ b/include/configs/ls1012afrdm.h
@@ -39,4 +39,18 @@
#define CONFIG_SYS_MEMTEST_START 0x80000000
#define CONFIG_SYS_MEMTEST_END 0x9fffffff
+#undef CONFIG_EXTRA_ENV_SETTINGS
+#define CONFIG_EXTRA_ENV_SETTINGS \
+ "initrd_high=0xffffffff\0" \
+ "verify=no\0" \
+ "hwconfig=fsl_ddr:bank_intlv=auto\0" \
+ "loadaddr=0x80100000\0" \
+ "kernel_addr=0x100000\0" \
+ "fdt_high=0xffffffffffffffff\0" \
+ "initrd_high=0xffffffffffffffff\0" \
+ "kernel_start=0xa00000\0" \
+ "kernel_load=0x96000000\0" \
+ "kernel_size=0x2800000\0" \
+ "console=ttyAMA0,115200n8\0"
+
#endif /* __LS1012ARDB_H__ */
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 9:46 [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
@ 2016-08-05 9:46 ` Pratiyush Mohan Srivastava
2016-08-05 16:16 ` york sun
2016-08-05 17:24 ` [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS york sun
1 sibling, 1 reply; 8+ messages in thread
From: Pratiyush Mohan Srivastava @ 2016-08-05 9:46 UTC (permalink / raw)
To: u-boot
Remove ramdisk_addr, ramdisk_size and update UART baud-rate.
Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
---
include/configs/ls1012a_common.h | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h
index fba2fac..78f4f9b 100644
--- a/include/configs/ls1012a_common.h
+++ b/include/configs/ls1012a_common.h
@@ -111,14 +111,12 @@
"hwconfig=fsl_ddr:bank_intlv=auto\0" \
"loadaddr=0x80100000\0" \
"kernel_addr=0x100000\0" \
- "ramdisk_addr=0x800000\0" \
- "ramdisk_size=0x2000000\0" \
"fdt_high=0xffffffffffffffff\0" \
"initrd_high=0xffffffffffffffff\0" \
"kernel_start=0xa00000\0" \
"kernel_load=0xa0000000\0" \
"kernel_size=0x2800000\0" \
- "console=ttyAMA0,38400n8\0"
+ "console=ttyAMA0,115200n8\0"
#define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/ram0 " \
"earlycon=uart8250,mmio,0x21c0500"
--
1.9.1
^ permalink raw reply related [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 9:46 ` [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
@ 2016-08-05 16:16 ` york sun
2016-08-05 16:51 ` Edward L Swarthout
2016-08-09 5:47 ` Pratiyush Srivastava
0 siblings, 2 replies; 8+ messages in thread
From: york sun @ 2016-08-05 16:16 UTC (permalink / raw)
To: u-boot
On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
> Remove ramdisk_addr, ramdisk_size and update UART baud-rate.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
> ---
> include/configs/ls1012a_common.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/include/configs/ls1012a_common.h b/include/configs/ls1012a_common.h
> index fba2fac..78f4f9b 100644
> --- a/include/configs/ls1012a_common.h
> +++ b/include/configs/ls1012a_common.h
> @@ -111,14 +111,12 @@
> "hwconfig=fsl_ddr:bank_intlv=auto\0" \
> "loadaddr=0x80100000\0" \
> "kernel_addr=0x100000\0" \
> - "ramdisk_addr=0x800000\0" \
> - "ramdisk_size=0x2000000\0" \
> "fdt_high=0xffffffffffffffff\0" \
> "initrd_high=0xffffffffffffffff\0" \
> "kernel_start=0xa00000\0" \
> "kernel_load=0xa0000000\0" \
> "kernel_size=0x2800000\0" \
> - "console=ttyAMA0,38400n8\0"
> + "console=ttyAMA0,115200n8\0"
Is console variable correct here?
>
> #define CONFIG_BOOTARGS "console=ttyS0,115200 root=/dev/ram0 " \
console is different here.
> "earlycon=uart8250,mmio,0x21c0500"
>
York
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 16:16 ` york sun
@ 2016-08-05 16:51 ` Edward L Swarthout
2016-08-09 5:47 ` Pratiyush Srivastava
1 sibling, 0 replies; 8+ messages in thread
From: Edward L Swarthout @ 2016-08-05 16:51 UTC (permalink / raw)
To: u-boot
From: york sun:
> On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
>> Remove ramdisk_addr, ramdisk_size and update UART baud-rate.
>>
...
>> +++ b/include/configs/ls1012a_common.h
...
>> -???? "ramdisk_addr=0x800000\0"?????????????? \
>> -???? "ramdisk_size=0x2000000\0"????????????? \
>>??????? "fdt_high=0xffffffffffffffff\0"???????? \
>>??????? "initrd_high=0xffffffffffffffff\0"????? \
While you are fixing these, can you remove the earlier 32-bit initrd_high=0xffffffff?
>> -???? "console=ttyAMA0,38400n8\0"
>> +???? "console=ttyAMA0,115200n8\0"
> Is console variable correct here?
Might as well just delete it since $console is not used in BOOTARGS.
Ed
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 9:46 [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
2016-08-05 9:46 ` [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
@ 2016-08-05 17:24 ` york sun
2016-08-09 6:15 ` Pratiyush Srivastava
2016-08-09 6:47 ` Pratiyush Srivastava
1 sibling, 2 replies; 8+ messages in thread
From: york sun @ 2016-08-05 17:24 UTC (permalink / raw)
To: u-boot
On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
> From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>
> LS1012AFRDM has 512MB of DDR.
> So update Kernel load address as 0x96000000 instead of default
> 0xa0000000.
>
> Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Signed-off-by: Pratiyush Mohan Srivastava <pratiyush.srivastava@nxp.com>
> ---
> Changes for v2: Incorporated York's comments
> - Removed ramdisk_addr, ramdisk_size
> - Updated UART baud-rate.
>
> include/configs/ls1012afrdm.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/include/configs/ls1012afrdm.h b/include/configs/ls1012afrdm.h
> index ad81142..f2c6ca8 100644
> --- a/include/configs/ls1012afrdm.h
> +++ b/include/configs/ls1012afrdm.h
> @@ -39,4 +39,18 @@
> #define CONFIG_SYS_MEMTEST_START 0x80000000
> #define CONFIG_SYS_MEMTEST_END 0x9fffffff
>
> +#undef CONFIG_EXTRA_ENV_SETTINGS
> +#define CONFIG_EXTRA_ENV_SETTINGS \
> + "initrd_high=0xffffffff\0" \
What is this?
> + "verify=no\0" \
> + "hwconfig=fsl_ddr:bank_intlv=auto\0" \
> + "loadaddr=0x80100000\0" \
> + "kernel_addr=0x100000\0" \
> + "fdt_high=0xffffffffffffffff\0" \
> + "initrd_high=0xffffffffffffffff\0" \
> + "kernel_start=0xa00000\0" \
> + "kernel_load=0x96000000\0" \
> + "kernel_size=0x2800000\0" \
> + "console=ttyAMA0,115200n8\0"
Do you really use ttyAMA0? Isn't it ttyS0?
York
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 16:16 ` york sun
2016-08-05 16:51 ` Edward L Swarthout
@ 2016-08-09 5:47 ` Pratiyush Srivastava
1 sibling, 0 replies; 8+ messages in thread
From: Pratiyush Srivastava @ 2016-08-09 5:47 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: york sun
> Sent: Friday, August 05, 2016 9:47 PM
> To: Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; u-
> boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: Re: [PATCH] armv8: ls1012a: Updating
> CONFIG_EXTRA_ENV_SETTINGS
>
> On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
> > Remove ramdisk_addr, ramdisk_size and update UART baud-rate.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Signed-off-by: Pratiyush Mohan Srivastava
> <pratiyush.srivastava@nxp.com>
> > ---
> > include/configs/ls1012a_common.h | 4 +---
> > 1 file changed, 1 insertion(+), 3 deletions(-)
> >
> > diff --git a/include/configs/ls1012a_common.h
> b/include/configs/ls1012a_common.h
> > index fba2fac..78f4f9b 100644
> > --- a/include/configs/ls1012a_common.h
> > +++ b/include/configs/ls1012a_common.h
> > @@ -111,14 +111,12 @@
> > "hwconfig=fsl_ddr:bank_intlv=auto\0" \
> > "loadaddr=0x80100000\0" \
> > "kernel_addr=0x100000\0" \
> > - "ramdisk_addr=0x800000\0" \
> > - "ramdisk_size=0x2000000\0" \
> > "fdt_high=0xffffffffffffffff\0" \
> > "initrd_high=0xffffffffffffffff\0" \
> > "kernel_start=0xa00000\0" \
> > "kernel_load=0xa0000000\0" \
> > "kernel_size=0x2800000\0" \
> > - "console=ttyAMA0,38400n8\0"
> > + "console=ttyAMA0,115200n8\0"
>
> Is console variable correct here?
[Pratiyush>] I will remove it ...
>
> >
> > #define CONFIG_BOOTARGS "console=ttyS0,115200
> root=/dev/ram0 " \
>
> console is different here.
>
>
> > "earlycon=uart8250,mmio,0x21c0500"
> >
>
> York
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 17:24 ` [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS york sun
@ 2016-08-09 6:15 ` Pratiyush Srivastava
2016-08-09 6:47 ` Pratiyush Srivastava
1 sibling, 0 replies; 8+ messages in thread
From: Pratiyush Srivastava @ 2016-08-09 6:15 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: york sun
> Sent: Friday, August 05, 2016 10:54 PM
> To: Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; u-
> boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: Re: [PATCH][v2] board: ls1012afrdm: overwrite
> CONFIG_EXTRA_ENV_SETTINGS
>
> On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
> > From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >
> > LS1012AFRDM has 512MB of DDR.
> > So update Kernel load address as 0x96000000 instead of default
> > 0xa0000000.
> >
> > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Signed-off-by: Pratiyush Mohan Srivastava
> > <pratiyush.srivastava@nxp.com>
> > ---
> > Changes for v2: Incorporated York's comments
> > - Removed ramdisk_addr, ramdisk_size
> > - Updated UART baud-rate.
> >
> > include/configs/ls1012afrdm.h | 14 ++++++++++++++
> > 1 file changed, 14 insertions(+)
> >
> > diff --git a/include/configs/ls1012afrdm.h
> > b/include/configs/ls1012afrdm.h index ad81142..f2c6ca8 100644
> > --- a/include/configs/ls1012afrdm.h
> > +++ b/include/configs/ls1012afrdm.h
> > @@ -39,4 +39,18 @@
> > #define CONFIG_SYS_MEMTEST_START 0x80000000
> > #define CONFIG_SYS_MEMTEST_END 0x9fffffff
> >
> > +#undef CONFIG_EXTRA_ENV_SETTINGS
> > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > + "initrd_high=0xffffffff\0" \
>
> What is this?
[Pratiyush>] I used the LS1043 dts as the base for this dts. Since ls10143 had this parameter, I copied the same for LS1012.
>
> > + "verify=no\0" \
> > + "hwconfig=fsl_ddr:bank_intlv=auto\0" \
> > + "loadaddr=0x80100000\0" \
> > + "kernel_addr=0x100000\0" \
> > + "fdt_high=0xffffffffffffffff\0" \
> > + "initrd_high=0xffffffffffffffff\0" \
> > + "kernel_start=0xa00000\0" \
> > + "kernel_load=0x96000000\0" \
> > + "kernel_size=0x2800000\0" \
> > + "console=ttyAMA0,115200n8\0"
>
> Do you really use ttyAMA0? Isn't it ttyS0?
[Pratiyush>] I will remove the redundant console command.
>
> York
^ permalink raw reply [flat|nested] 8+ messages in thread
* [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS
2016-08-05 17:24 ` [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS york sun
2016-08-09 6:15 ` Pratiyush Srivastava
@ 2016-08-09 6:47 ` Pratiyush Srivastava
1 sibling, 0 replies; 8+ messages in thread
From: Pratiyush Srivastava @ 2016-08-09 6:47 UTC (permalink / raw)
To: u-boot
> -----Original Message-----
> From: Pratiyush Srivastava
> Sent: Tuesday, August 09, 2016 11:45 AM
> To: york sun <york.sun@nxp.com>; u-boot at lists.denx.de
> Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Subject: RE: [PATCH][v2] board: ls1012afrdm: overwrite
> CONFIG_EXTRA_ENV_SETTINGS
>
>
>
> > -----Original Message-----
> > From: york sun
> > Sent: Friday, August 05, 2016 10:54 PM
> > To: Pratiyush Srivastava <pratiyush.srivastava@nxp.com>; u-
> > boot at lists.denx.de
> > Cc: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Subject: Re: [PATCH][v2] board: ls1012afrdm: overwrite
> > CONFIG_EXTRA_ENV_SETTINGS
> >
> > On 08/05/2016 02:47 AM, Pratiyush Mohan Srivastava wrote:
> > > From: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > >
> > > LS1012AFRDM has 512MB of DDR.
> > > So update Kernel load address as 0x96000000 instead of default
> > > 0xa0000000.
> > >
> > > Signed-off-by: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > > Signed-off-by: Pratiyush Mohan Srivastava
> > > <pratiyush.srivastava@nxp.com>
> > > ---
> > > Changes for v2: Incorporated York's comments
> > > - Removed ramdisk_addr, ramdisk_size
> > > - Updated UART baud-rate.
> > >
> > > include/configs/ls1012afrdm.h | 14 ++++++++++++++
> > > 1 file changed, 14 insertions(+)
> > >
> > > diff --git a/include/configs/ls1012afrdm.h
> > > b/include/configs/ls1012afrdm.h index ad81142..f2c6ca8 100644
> > > --- a/include/configs/ls1012afrdm.h
> > > +++ b/include/configs/ls1012afrdm.h
> > > @@ -39,4 +39,18 @@
> > > #define CONFIG_SYS_MEMTEST_START 0x80000000
> > > #define CONFIG_SYS_MEMTEST_END 0x9fffffff
> > >
> > > +#undef CONFIG_EXTRA_ENV_SETTINGS
> > > +#define CONFIG_EXTRA_ENV_SETTINGS \
> > > + "initrd_high=0xffffffff\0" \
> >
> > What is this?
> [Pratiyush>] I used the LS1043 dts as the base for this dts. Since ls10143 had
> this parameter, I copied the same for LS1012.
[Pratiyush>] I used the LS10143a_common file as a base for this dts. Since ls10143 had
> this parameter, I copied the same for LS1012.
Please ignore the previous comment .
> >
> > > + "verify=no\0" \
> > > + "hwconfig=fsl_ddr:bank_intlv=auto\0" \
> > > + "loadaddr=0x80100000\0" \
> > > + "kernel_addr=0x100000\0" \
> > > + "fdt_high=0xffffffffffffffff\0" \
> > > + "initrd_high=0xffffffffffffffff\0" \
> > > + "kernel_start=0xa00000\0" \
> > > + "kernel_load=0x96000000\0" \
> > > + "kernel_size=0x2800000\0" \
> > > + "console=ttyAMA0,115200n8\0"
> >
> > Do you really use ttyAMA0? Isn't it ttyS0?
> [Pratiyush>] I will remove the redundant console command.
> >
> > York
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2016-08-09 6:47 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2016-08-05 9:46 [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
2016-08-05 9:46 ` [U-Boot] [PATCH] armv8: ls1012a: Updating CONFIG_EXTRA_ENV_SETTINGS Pratiyush Mohan Srivastava
2016-08-05 16:16 ` york sun
2016-08-05 16:51 ` Edward L Swarthout
2016-08-09 5:47 ` Pratiyush Srivastava
2016-08-05 17:24 ` [U-Boot] [PATCH][v2] board: ls1012afrdm: overwrite CONFIG_EXTRA_ENV_SETTINGS york sun
2016-08-09 6:15 ` Pratiyush Srivastava
2016-08-09 6:47 ` Pratiyush Srivastava
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.