All of lore.kernel.org
 help / color / mirror / Atom feed
From: Bhaskar U <bhaskar.upadhaya@nxp.com>
To: Stuart Yoder <stuart.yoder@nxp.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"shawnguo@kernel.org" <shawnguo@kernel.org>
Cc: "oss@buserror.net" <oss@buserror.net>,
	"linux-devel@gforge.freescale.net"
	<linux-devel@gforge.freescale.net>,
	Pratiyush Srivastava <pratiyush.srivastava@nxp.com>,
	Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
Date: Fri, 30 Sep 2016 21:19:13 +0000	[thread overview]
Message-ID: <AM4PR0401MB2275E76A1EC44FE6DA19D4978CC10@AM4PR0401MB2275.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0401MB2638C032B77C9313C17BBE898DC10@VI1PR0401MB2638.eurprd04.prod.outlook.com>



>-----Original Message-----
>From: Stuart Yoder
>Sent: Friday, September 30, 2016 7:28 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree@vger.kernel.org;
>shawnguo@kernel.org
>Cc: oss@buserror.net; linux-arm-kernel@lists.infradead.org; linux-
>devel@gforge.freescale.net; Bhaskar U <bhaskar.upadhaya@nxp.com>;
>Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pratiyush Srivastava
><pratiyush.srivastava@nxp.com>
>Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>> +		dspi0: dspi@2100000 {
>> +			compatible = "fsl,ls1012a-dspi",
>> +				     "fsl,ls1043a-dspi",
>> +				     "fsl,ls1021a-v1.0-dspi";
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <0x0 0x2100000 0x0 0x10000>;
>> +			interrupts = <0 64 0x4>;
>> +			clock-names = "dspi";
>> +			clocks = <&clockgen 4 0>;
>> +			spi-num-chipselects = <5>;
>> +			big-endian;
>> +			status = "enabled";
>
>"enabled" is not a valid status value.
>

So shall I put the status = "okay" ?

But there are other nodes like i2c below having status = "enabled", so do we need to edit them also ? If yes then what should be written in the status ?
i2c0: i2c@2180000 {
                        compatible = "fsl,vf610-i2c";
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0x0 0x2180000 0x0 0x10000>;
                        interrupts = <0 56 0x4>;
                        clock-names = "i2c";
                        clocks = <&clockgen 4 0>;
                        status = "enabled";
                };

                i2c1: i2c@2190000 {
                        compatible = "fsl,vf610-i2c";
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0x0 0x2190000 0x0 0x10000>;
                        interrupts = <0 57 0x4>;
                        clock-names = "i2c";
                        clocks = <&clockgen 4 0>;
                        status = "enabled";
                };


>Stuart

WARNING: multiple messages have this Message-ID (diff)
From: bhaskar.upadhaya@nxp.com (Bhaskar U)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
Date: Fri, 30 Sep 2016 21:19:13 +0000	[thread overview]
Message-ID: <AM4PR0401MB2275E76A1EC44FE6DA19D4978CC10@AM4PR0401MB2275.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <VI1PR0401MB2638C032B77C9313C17BBE898DC10@VI1PR0401MB2638.eurprd04.prod.outlook.com>



>-----Original Message-----
>From: Stuart Yoder
>Sent: Friday, September 30, 2016 7:28 PM
>To: Bhaskar U <bhaskar.upadhaya@nxp.com>; devicetree at vger.kernel.org;
>shawnguo at kernel.org
>Cc: oss at buserror.net; linux-arm-kernel at lists.infradead.org; linux-
>devel at gforge.freescale.net; Bhaskar U <bhaskar.upadhaya@nxp.com>;
>Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>; Pratiyush Srivastava
><pratiyush.srivastava@nxp.com>
>Subject: RE: [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC
>
>> +		dspi0: dspi at 2100000 {
>> +			compatible = "fsl,ls1012a-dspi",
>> +				     "fsl,ls1043a-dspi",
>> +				     "fsl,ls1021a-v1.0-dspi";
>> +			#address-cells = <1>;
>> +			#size-cells = <0>;
>> +			reg = <0x0 0x2100000 0x0 0x10000>;
>> +			interrupts = <0 64 0x4>;
>> +			clock-names = "dspi";
>> +			clocks = <&clockgen 4 0>;
>> +			spi-num-chipselects = <5>;
>> +			big-endian;
>> +			status = "enabled";
>
>"enabled" is not a valid status value.
>

So shall I put the status = "okay" ?

But there are other nodes like i2c below having status = "enabled", so do we need to edit them also ? If yes then what should be written in the status ?
i2c0: i2c at 2180000 {
                        compatible = "fsl,vf610-i2c";
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0x0 0x2180000 0x0 0x10000>;
                        interrupts = <0 56 0x4>;
                        clock-names = "i2c";
                        clocks = <&clockgen 4 0>;
                        status = "enabled";
                };

                i2c1: i2c at 2190000 {
                        compatible = "fsl,vf610-i2c";
                        #address-cells = <1>;
                        #size-cells = <0>;
                        reg = <0x0 0x2190000 0x0 0x10000>;
                        interrupts = <0 57 0x4>;
                        clock-names = "i2c";
                        clocks = <&clockgen 4 0>;
                        status = "enabled";
                };


>Stuart

  reply	other threads:[~2016-09-30 21:19 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-26 10:27 [PATCH v2 1/1] arm64: Add DTS support for FSL's LS1012A SoC Bhaskar Upadhaya
2016-08-26 10:27 ` Bhaskar Upadhaya
     [not found] ` <1472207241-18461-1-git-send-email-Bhaskar.Upadhaya-3arQi8VN3Tc@public.gmane.org>
2016-08-29  9:52   ` Shawn Guo
2016-08-29  9:52     ` Shawn Guo
2016-08-29 17:51     ` Scott Wood
2016-08-29 17:51       ` Scott Wood
     [not found]       ` <1472493061.13245.39.camel-fOR+EgIDQEHk1uMJSBkQmQ@public.gmane.org>
2016-08-30 12:02         ` Shawn Guo
2016-08-30 12:02           ` Shawn Guo
2016-08-30 14:07           ` Stuart Yoder
2016-08-30 14:07             ` Stuart Yoder
     [not found]             ` <HE1PR0401MB2636B40376255680B6A58CFB8DE00-B0v07Ae2tarUYqUkpow3g43W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-05  1:46               ` Shawn Guo
2016-09-05  1:46                 ` Shawn Guo
2016-09-06 17:05                 ` [linux-devel] " Scott Wood
2016-09-06 17:05                   ` Scott Wood
2016-09-30 11:38                   ` Bhaskar U
2016-09-30 11:38                     ` Bhaskar U
2016-09-30 21:30                     ` Shawn Guo
2016-09-30 21:30                       ` Shawn Guo
2016-09-30 11:38     ` Bhaskar U
2016-09-30 11:38       ` Bhaskar U
2016-09-30 13:55       ` Stuart Yoder
2016-09-30 13:55         ` Stuart Yoder
2016-09-30 21:13         ` Bhaskar U
2016-09-30 21:13           ` Bhaskar U
2016-09-30 21:45           ` [linux-devel] " Leo Li
2016-09-30 21:45             ` Leo Li
     [not found]           ` <AM4PR0401MB2275F9FBAE954BD420AA67F98CC10-4rsfagO7TJwHfFjNQjRPfY3W/0Ik+aLCnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org>
2016-09-30 21:55             ` Shawn Guo
2016-09-30 21:55               ` Shawn Guo
2016-09-30 22:42           ` Stuart Yoder
2016-09-30 22:42             ` Stuart Yoder
2016-09-30 13:57 ` Stuart Yoder
2016-09-30 13:57   ` Stuart Yoder
2016-09-30 21:19   ` Bhaskar U [this message]
2016-09-30 21:19     ` Bhaskar U
2016-09-30 21:29     ` [linux-devel] " Leo Li
2016-09-30 21:29       ` Leo Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=AM4PR0401MB2275E76A1EC44FE6DA19D4978CC10@AM4PR0401MB2275.eurprd04.prod.outlook.com \
    --to=bhaskar.upadhaya@nxp.com \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-devel@gforge.freescale.net \
    --cc=oss@buserror.net \
    --cc=prabhakar.kushwaha@nxp.com \
    --cc=pratiyush.srivastava@nxp.com \
    --cc=shawnguo@kernel.org \
    --cc=stuart.yoder@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.