From: Ilan Tayari <ilant-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> To: Arnd Bergmann <arnd-r2nGTMty4D4@public.gmane.org>, Saeed Mahameed <saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Matan Barak <matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Leon Romanovsky <leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org> Cc: "David S. Miller" <davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org>, Boris Pismenny <borisp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Or Gerlitz <ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Hadar Hen Zion <hadarh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Kamal Heib <kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Maor Gottlieb <maorg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Mohamad Haj Yahia <mohamad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, Aviv Heller <avivh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>, "netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>, "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> Subject: RE: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA Date: Fri, 30 Jun 2017 18:58:16 +0000 [thread overview] Message-ID: <AM4PR0501MB19409232F4E056237F2FAFFFDBD30@AM4PR0501MB1940.eurprd05.prod.outlook.com> (raw) In-Reply-To: <20170630154412.3575760-1-arnd-r2nGTMty4D4@public.gmane.org> > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Subject: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build > for FPGA > > Both the ethernet and FPGA portions of MLX5 now require the wq functions, > and we get a link error when CONFIG_MLX5_CORE_EN is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.o: In function > `mlx5_fpga_conn_create_cq': > conn.c:(.text+0x10b3): undefined reference to `mlx5_cqwq_create' > conn.c:(.text+0x10c6): undefined reference to `mlx5_cqwq_get_size' > conn.c:(.text+0x12bc): undefined reference to `mlx5_cqwq_destroy' > > This includes the library in the core driver also when only the fpga > support is enabled. > > Fixes: 537a50574175 ("net/mlx5: FPGA, Add high-speed connection routines") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile > b/drivers/net/ethernet/mellanox/mlx5/core/Makefile > index ca367445f864..50fe9e3c5dc2 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile > @@ -9,7 +9,7 @@ mlx5_core-y := main.o cmd.o debugfs.o fw.o eq.o uar.o > pagealloc.o \ > mlx5_core-$(CONFIG_MLX5_ACCEL) += accel/ipsec.o > > mlx5_core-$(CONFIG_MLX5_FPGA) += fpga/cmd.o fpga/core.o fpga/conn.o > fpga/sdk.o \ > - fpga/ipsec.o > + fpga/ipsec.o wq.o I believe we would prefer to move wq.o to mlx5_core-y. Otherwise you might build it twice. > > mlx5_core-$(CONFIG_MLX5_CORE_EN) += wq.o eswitch.o eswitch_offloads.o \ > en_main.o en_common.o en_fs.o en_ethtool.o en_tx.o \ > -- > 2.9.0
WARNING: multiple messages have this Message-ID (diff)
From: Ilan Tayari <ilant@mellanox.com> To: Arnd Bergmann <arnd@arndb.de>, Saeed Mahameed <saeedm@mellanox.com>, "Matan Barak" <matanb@mellanox.com>, Leon Romanovsky <leonro@mellanox.com> Cc: "David S. Miller" <davem@davemloft.net>, Boris Pismenny <borisp@mellanox.com>, Or Gerlitz <ogerlitz@mellanox.com>, Hadar Hen Zion <hadarh@mellanox.com>, Kamal Heib <kamalh@mellanox.com>, Maor Gottlieb <maorg@mellanox.com>, Mohamad Haj Yahia <mohamad@mellanox.com>, Aviv Heller <avivh@mellanox.com>, "netdev@vger.kernel.org" <netdev@vger.kernel.org>, "linux-rdma@vger.kernel.org" <linux-rdma@vger.kernel.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA Date: Fri, 30 Jun 2017 18:58:16 +0000 [thread overview] Message-ID: <AM4PR0501MB19409232F4E056237F2FAFFFDBD30@AM4PR0501MB1940.eurprd05.prod.outlook.com> (raw) In-Reply-To: <20170630154412.3575760-1-arnd@arndb.de> > -----Original Message----- > From: Arnd Bergmann [mailto:arnd@arndb.de] > Subject: [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build > for FPGA > > Both the ethernet and FPGA portions of MLX5 now require the wq functions, > and we get a link error when CONFIG_MLX5_CORE_EN is disabled: > > drivers/net/ethernet/mellanox/mlx5/core/fpga/conn.o: In function > `mlx5_fpga_conn_create_cq': > conn.c:(.text+0x10b3): undefined reference to `mlx5_cqwq_create' > conn.c:(.text+0x10c6): undefined reference to `mlx5_cqwq_get_size' > conn.c:(.text+0x12bc): undefined reference to `mlx5_cqwq_destroy' > > This includes the library in the core driver also when only the fpga > support is enabled. > > Fixes: 537a50574175 ("net/mlx5: FPGA, Add high-speed connection routines") > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > drivers/net/ethernet/mellanox/mlx5/core/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/mellanox/mlx5/core/Makefile > b/drivers/net/ethernet/mellanox/mlx5/core/Makefile > index ca367445f864..50fe9e3c5dc2 100644 > --- a/drivers/net/ethernet/mellanox/mlx5/core/Makefile > +++ b/drivers/net/ethernet/mellanox/mlx5/core/Makefile > @@ -9,7 +9,7 @@ mlx5_core-y := main.o cmd.o debugfs.o fw.o eq.o uar.o > pagealloc.o \ > mlx5_core-$(CONFIG_MLX5_ACCEL) += accel/ipsec.o > > mlx5_core-$(CONFIG_MLX5_FPGA) += fpga/cmd.o fpga/core.o fpga/conn.o > fpga/sdk.o \ > - fpga/ipsec.o > + fpga/ipsec.o wq.o I believe we would prefer to move wq.o to mlx5_core-y. Otherwise you might build it twice. > > mlx5_core-$(CONFIG_MLX5_CORE_EN) += wq.o eswitch.o eswitch_offloads.o \ > en_main.o en_common.o en_fs.o en_ethtool.o en_tx.o \ > -- > 2.9.0
next prev parent reply other threads:[~2017-06-30 18:58 UTC|newest] Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top 2017-06-30 15:43 [PATCH] [net-next] net/mlx5: include wq.o in non-ethernet build for FPGA Arnd Bergmann [not found] ` <20170630154412.3575760-1-arnd-r2nGTMty4D4@public.gmane.org> 2017-06-30 18:58 ` Ilan Tayari [this message] 2017-06-30 18:58 ` Ilan Tayari [not found] ` <AM4PR0501MB19409232F4E056237F2FAFFFDBD30-dp/nxUn679gfNUYDR5dMTsDSnupUy6xnnBOFsp37pqbUKgpGm//BTAC/G2K4zDHf@public.gmane.org> 2017-06-30 19:25 ` Arnd Bergmann 2017-06-30 19:25 ` Arnd Bergmann 2017-07-02 8:45 ` Saeed Mahameed [not found] ` <CALzJLG8TR8qmBygiL7Eg-1tWvOEgDvtECxKaXt4=j4YdCN72xA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org> 2017-07-03 7:21 ` Arnd Bergmann 2017-07-03 7:21 ` Arnd Bergmann
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM4PR0501MB19409232F4E056237F2FAFFFDBD30@AM4PR0501MB1940.eurprd05.prod.outlook.com \ --to=ilant-vpraknaxozvwk0htik3j/w@public.gmane.org \ --cc=arnd-r2nGTMty4D4@public.gmane.org \ --cc=avivh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=borisp-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=davem-fT/PcQaiUtIeIZ0/mPfg9Q@public.gmane.org \ --cc=hadarh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=kamalh-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=leonro-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=maorg-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=matanb-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=mohamad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=netdev-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \ --cc=ogerlitz-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ --cc=saeedm-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.