Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

[Thomas Huth]

On 24.03.2017 09:56, Mark Cave-Ayland wrote:
> On 24/03/17 08:47, Howard Spoelstra wrote:
> 
>> Hi,
>>
>> Running qemu-system-ppc.exe in windows with the SDL2 GUI results in a
>> hangup. I bisected to this commit:
>>
>> 8bb93c6f99a42c2e0943bc904b283cd622d302c5 is the first bad commit
>> commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5
>> Author: Alex Bennée <alex.bennee@linaro.org>
>> Date:   Wed Mar 15 14:48:25 2017 +0000
>>
>>     ui/console: ensure graphic updates don't race with TCG vCPUs
>>
>>     Commit 8d04fb55..
>>
>>       tcg: drop global lock during TCG code execution
>>
>>     ..broke the assumption that updates to the GUI couldn't happen at the
>>     same time as TCG vCPUs where running. As a result the TCG vCPU could
>>     still be updating a directly mapped frame-buffer while the display
>>     side was updating. This would cause artefacts to appear when the
>>     update code assumed that memory block hadn't changed.
>>
>>     The simplest solution is to ensure the two things can't happen at the
>>     same time like the old BQL locking scheme. Here we use the solution
>>     introduced for MTTCG and schedule the update as async_safe_work when
>>     we know no vCPUs can be running.
>>
>>     Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>     Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>     Message-id: 20170315144825.3108-1-alex.bennee@linaro.org
>>     Cc: BALATON Zoltan <balaton@eik.bme.hu>
>>     Cc: Gerd Hoffmann <kraxel@redhat.com>
>>     Cc: Paolo Bonzini <pbonzini@redhat.com>
>>     Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>>     [ kraxel: updated comment clarifying the display adapters are buggy
>>               and this is a temporary workaround ]
>>
>>     Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
> 
> Hi Howard,
> 
> Alex posted another patch yesterday to resolve a similar issue:
> https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg04474.html.
> 
> Does applying the above patch help at all?

Luigi Burdo reported a similar issue here:

https://bugs.launchpad.net/qemu/+bug/1675549

Luigi, could you please try Alex' patch to see whether it fixes your crash?

 Thanks,
  Thomas

Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

[luigi burdo]

Hi Thomas,
i will check ASAP in launch break.
Ciao
Luigi


>Luigi, could you please try Alex' patch to see whether it fixes your crash?
> Thanks,
  >Thomas

Re: [Qemu-devel] [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

[luigi burdo]

Hi Thomas,

i had been patched the qemu 2.8.91 on the git repository too and the patch gave positive result.

i have no more the exit of qemu when a key was pressed .


Thanks

Luigi


________________________________
Da: Thomas Huth <thuth@redhat.com>
Inviato: venerdì 24 marzo 2017 10.33
A: Mark Cave-Ayland; Howard Spoelstra; qemu-ppc@nongnu.org; luigi burdo; Alex Bennée; QEMU Developers
Oggetto: Re: [Qemu-ppc] Bug in qemu-system-ppc in Windows using the SDL2 GUI

On 24.03.2017 09:56, Mark Cave-Ayland wrote:
> On 24/03/17 08:47, Howard Spoelstra wrote:
>
>> Hi,
>>
>> Running qemu-system-ppc.exe in windows with the SDL2 GUI results in a
>> hangup. I bisected to this commit:
>>
>> 8bb93c6f99a42c2e0943bc904b283cd622d302c5 is the first bad commit
>> commit 8bb93c6f99a42c2e0943bc904b283cd622d302c5
>> Author: Alex Bennée <alex.bennee@linaro.org>
>> Date:   Wed Mar 15 14:48:25 2017 +0000
>>
>>     ui/console: ensure graphic updates don't race with TCG vCPUs
>>
>>     Commit 8d04fb55..
>>
>>       tcg: drop global lock during TCG code execution
>>
>>     ..broke the assumption that updates to the GUI couldn't happen at the
>>     same time as TCG vCPUs where running. As a result the TCG vCPU could
>>     still be updating a directly mapped frame-buffer while the display
>>     side was updating. This would cause artefacts to appear when the
>>     update code assumed that memory block hadn't changed.
>>
>>     The simplest solution is to ensure the two things can't happen at the
>>     same time like the old BQL locking scheme. Here we use the solution
>>     introduced for MTTCG and schedule the update as async_safe_work when
>>     we know no vCPUs can be running.
>>
>>     Reported-by: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
>>     Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>     Message-id: 20170315144825.3108-1-alex.bennee@linaro.org
>>     Cc: BALATON Zoltan <balaton@eik.bme.hu>
>>     Cc: Gerd Hoffmann <kraxel@redhat.com>
>>     Cc: Paolo Bonzini <pbonzini@redhat.com>
>>     Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
>>
>>     [ kraxel: updated comment clarifying the display adapters are buggy
>>               and this is a temporary workaround ]
>>
>>     Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>
> Hi Howard,
>
> Alex posted another patch yesterday to resolve a similar issue:
> https://lists.nongnu.org/archive/html/qemu-devel/2017-03/msg04474.html.
>
> Does applying the above patch help at all?

Luigi Burdo reported a similar issue here:

https://bugs.launchpad.net/qemu/+bug/1675549
Bug #1675549 “tcg softmmu i386 crashes on BE hardware " : Bugs : QEMU<https://bugs.launchpad.net/qemu/+bug/1675549>
bugs.launchpad.net
Hi, today i try to test qemu 2.9rc 1 with qemu-system-i386 if i set display as sdl and i push a key on keyboard qemu exit with an error translate-common.c:34:tcg_handle_interrupt: assertion failed: (qemu_mutex_iothread_locked()) This issue was not present on qemu 2.8.0 Test Machine PowerMac G5 Quad Fedora 25 Server PPC64 Qemu build with target-list=i386-softmuu --with-sdlabi=2.0 Ciao Luigi



Luigi, could you please try Alex' patch to see whether it fixes your crash?

 Thanks,
  Thomas