[PATCH] fsl/fman: add dependency on HAS_DMA

[PATCH] fsl/fman: add dependency on HAS_DMA

[Madalin Bucur]

A previous commit inserted a dependency on DMA API that requires
HAS_DMA to be added in Kconfig.

Signed-off-by: Madalin Bucur <madalin.bucur@nxp.com>
---
 drivers/net/ethernet/freescale/fman/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/net/ethernet/freescale/fman/Kconfig b/drivers/net/ethernet/freescale/fman/Kconfig
index dc0850b..8870a9a 100644
--- a/drivers/net/ethernet/freescale/fman/Kconfig
+++ b/drivers/net/ethernet/freescale/fman/Kconfig
@@ -2,6 +2,7 @@ config FSL_FMAN
 	tristate "FMan support"
 	depends on FSL_SOC || ARCH_LAYERSCAPE || COMPILE_TEST
 	select GENERIC_ALLOCATOR
+	depends on HAS_DMA
 	select PHYLIB
 	default n
 	help
-- 
2.1.0

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

[Fabio Estevam]

On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com> wrote:
> A previous commit inserted a dependency on DMA API that requires
> HAS_DMA to be added in Kconfig.

It would be nice to specify the commit that caused this.

RE: [PATCH] fsl/fman: add dependency on HAS_DMA

[Madalin-cristian Bucur]

> -----Original Message-----
> From: Fabio Estevam [mailto:festevam@gmail.com]
> Sent: Monday, June 26, 2017 6:21 PM
> To: Madalin-cristian Bucur <madalin.bucur@nxp.com>
> Cc: netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; Geert
> Uytterhoeven <geert@linux-m68k.org>; linuxppc-dev@lists.ozlabs.org; linux-
> kernel <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA
> 
> On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com>
> wrote:
> > A previous commit inserted a dependency on DMA API that requires
> > HAS_DMA to be added in Kconfig.
> 
> It would be nice to specify the commit that caused this.

Sent v2, thanks.

Madalin

RE: [PATCH] fsl/fman: add dependency on HAS_DMA

[Madalin-cristian Bucur]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBGYWJpbyBFc3RldmFtIFttYWls
dG86ZmVzdGV2YW1AZ21haWwuY29tXQ0KPiBTZW50OiBNb25kYXksIEp1bmUgMjYsIDIwMTcgNjoy
MSBQTQ0KPiBUbzogTWFkYWxpbi1jcmlzdGlhbiBCdWN1ciA8bWFkYWxpbi5idWN1ckBueHAuY29t
Pg0KPiBDYzogbmV0ZGV2QHZnZXIua2VybmVsLm9yZzsgRGF2aWQgUy4gTWlsbGVyIDxkYXZlbUBk
YXZlbWxvZnQubmV0PjsgR2VlcnQNCj4gVXl0dGVyaG9ldmVuIDxnZWVydEBsaW51eC1tNjhrLm9y
Zz47IGxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMub3JnOyBsaW51eC0NCj4ga2VybmVsIDxsaW51
eC1rZXJuZWxAdmdlci5rZXJuZWwub3JnPg0KPiBTdWJqZWN0OiBSZTogW1BBVENIXSBmc2wvZm1h
bjogYWRkIGRlcGVuZGVuY3kgb24gSEFTX0RNQQ0KPiANCj4gT24gTW9uLCBKdW4gMjYsIDIwMTcg
YXQgMTI6MTIgUE0sIE1hZGFsaW4gQnVjdXIgPG1hZGFsaW4uYnVjdXJAbnhwLmNvbT4NCj4gd3Jv
dGU6DQo+ID4gQSBwcmV2aW91cyBjb21taXQgaW5zZXJ0ZWQgYSBkZXBlbmRlbmN5IG9uIERNQSBB
UEkgdGhhdCByZXF1aXJlcw0KPiA+IEhBU19ETUEgdG8gYmUgYWRkZWQgaW4gS2NvbmZpZy4NCj4g
DQo+IEl0IHdvdWxkIGJlIG5pY2UgdG8gc3BlY2lmeSB0aGUgY29tbWl0IHRoYXQgY2F1c2VkIHRo
aXMuDQoNClNlbnQgdjIsIHRoYW5rcy4NCg0KTWFkYWxpbg0K

Re: [PATCH] fsl/fman: add dependency on HAS_DMA

[Geert Uytterhoeven]

On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <festevam@gmail.com> wrote:
> On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com> wrote:
>> A previous commit inserted a dependency on DMA API that requires
>> HAS_DMA to be added in Kconfig.
>
> It would be nice to specify the commit that caused this.

That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").

However, none of the fman code uses any DMA API calls, so IMHO
the set_dma_ops() should be done somewhere else.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH] fsl/fman: add dependency on HAS_DMA

[Madalin-cristian Bucur]

> -----Original Message-----
> From: geert.uytterhoeven@gmail.com [mailto:geert.uytterhoeven@gmail.com]
> On Behalf Of Geert Uytterhoeven
> Sent: Monday, June 26, 2017 7:17 PM
> To: Fabio Estevam <festevam@gmail.com>
> Cc: Madalin-cristian Bucur <madalin.bucur@nxp.com>;
> netdev@vger.kernel.org; David S. Miller <davem@davemloft.net>; linuxppc-
> dev@lists.ozlabs.org; linux-kernel <linux-kernel@vger.kernel.org>
> Subject: Re: [PATCH] fsl/fman: add dependency on HAS_DMA
> 
> On Mon, Jun 26, 2017 at 5:20 PM, Fabio Estevam <festevam@gmail.com> wrote:
> > On Mon, Jun 26, 2017 at 12:12 PM, Madalin Bucur <madalin.bucur@nxp.com>
> wrote:
> >> A previous commit inserted a dependency on DMA API that requires
> >> HAS_DMA to be added in Kconfig.
> >
> > It would be nice to specify the commit that caused this.
> 
> That would be commit 5567e989198b5a8d ("fsl/fman: propagate dma_ops").
> 
> However, none of the fman code uses any DMA API calls, so IMHO
> the set_dma_ops() should be done somewhere else.

The Ethernet driver is making use of the DMA ops set here.

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But
> when I'm talking to journalists I just say "programmer" or something like
> that.
>                                 -- Linus Torvalds

RE: [PATCH] fsl/fman: add dependency on HAS_DMA

[Madalin-cristian Bucur]

PiAtLS0tLU9yaWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBnZWVydC51eXR0ZXJob2V2ZW5A
Z21haWwuY29tIFttYWlsdG86Z2VlcnQudXl0dGVyaG9ldmVuQGdtYWlsLmNvbV0NCj4gT24gQmVo
YWxmIE9mIEdlZXJ0IFV5dHRlcmhvZXZlbg0KPiBTZW50OiBNb25kYXksIEp1bmUgMjYsIDIwMTcg
NzoxNyBQTQ0KPiBUbzogRmFiaW8gRXN0ZXZhbSA8ZmVzdGV2YW1AZ21haWwuY29tPg0KPiBDYzog
TWFkYWxpbi1jcmlzdGlhbiBCdWN1ciA8bWFkYWxpbi5idWN1ckBueHAuY29tPjsNCj4gbmV0ZGV2
QHZnZXIua2VybmVsLm9yZzsgRGF2aWQgUy4gTWlsbGVyIDxkYXZlbUBkYXZlbWxvZnQubmV0Pjsg
bGludXhwcGMtDQo+IGRldkBsaXN0cy5vemxhYnMub3JnOyBsaW51eC1rZXJuZWwgPGxpbnV4LWtl
cm5lbEB2Z2VyLmtlcm5lbC5vcmc+DQo+IFN1YmplY3Q6IFJlOiBbUEFUQ0hdIGZzbC9mbWFuOiBh
ZGQgZGVwZW5kZW5jeSBvbiBIQVNfRE1BDQo+IA0KPiBPbiBNb24sIEp1biAyNiwgMjAxNyBhdCA1
OjIwIFBNLCBGYWJpbyBFc3RldmFtIDxmZXN0ZXZhbUBnbWFpbC5jb20+IHdyb3RlOg0KPiA+IE9u
IE1vbiwgSnVuIDI2LCAyMDE3IGF0IDEyOjEyIFBNLCBNYWRhbGluIEJ1Y3VyIDxtYWRhbGluLmJ1
Y3VyQG54cC5jb20+DQo+IHdyb3RlOg0KPiA+PiBBIHByZXZpb3VzIGNvbW1pdCBpbnNlcnRlZCBh
IGRlcGVuZGVuY3kgb24gRE1BIEFQSSB0aGF0IHJlcXVpcmVzDQo+ID4+IEhBU19ETUEgdG8gYmUg
YWRkZWQgaW4gS2NvbmZpZy4NCj4gPg0KPiA+IEl0IHdvdWxkIGJlIG5pY2UgdG8gc3BlY2lmeSB0
aGUgY29tbWl0IHRoYXQgY2F1c2VkIHRoaXMuDQo+IA0KPiBUaGF0IHdvdWxkIGJlIGNvbW1pdCA1
NTY3ZTk4OTE5OGI1YThkICgiZnNsL2ZtYW46IHByb3BhZ2F0ZSBkbWFfb3BzIikuDQo+IA0KPiBI
b3dldmVyLCBub25lIG9mIHRoZSBmbWFuIGNvZGUgdXNlcyBhbnkgRE1BIEFQSSBjYWxscywgc28g
SU1ITw0KPiB0aGUgc2V0X2RtYV9vcHMoKSBzaG91bGQgYmUgZG9uZSBzb21ld2hlcmUgZWxzZS4N
Cg0KVGhlIEV0aGVybmV0IGRyaXZlciBpcyBtYWtpbmcgdXNlIG9mIHRoZSBETUEgb3BzIHNldCBo
ZXJlLg0KDQo+IEdye29ldGplLGVldGluZ31zLA0KPiANCj4gICAgICAgICAgICAgICAgICAgICAg
ICAgR2VlcnQNCj4gDQo+IC0tDQo+IEdlZXJ0IFV5dHRlcmhvZXZlbiAtLSBUaGVyZSdzIGxvdHMg
b2YgTGludXggYmV5b25kIGlhMzIgLS0gZ2VlcnRAbGludXgtDQo+IG02OGsub3JnDQo+IA0KPiBJ
biBwZXJzb25hbCBjb252ZXJzYXRpb25zIHdpdGggdGVjaG5pY2FsIHBlb3BsZSwgSSBjYWxsIG15
c2VsZiBhIGhhY2tlci4NCj4gQnV0DQo+IHdoZW4gSSdtIHRhbGtpbmcgdG8gam91cm5hbGlzdHMg
SSBqdXN0IHNheSAicHJvZ3JhbW1lciIgb3Igc29tZXRoaW5nIGxpa2UNCj4gdGhhdC4NCj4gICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAtLSBMaW51cyBUb3J2YWxkcw0K