* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-07-06 9:39 ` Zhiqiang Hou
0 siblings, 0 replies; 16+ messages in thread
From: Zhiqiang Hou @ 2017-07-06 9:39 UTC (permalink / raw)
To: linux-pci, linux-arm-kernel, bhelgaas, robh+dt; +Cc: Hou Zhiqiang
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
The ls1088a and ls2088a has the same PCIe controller, so the ls1088a
will reuse the ls2088a's pcie compatible.
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
drivers/pci/dwc/pci-layerscape.c | 9 +++++++++
2 files changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
index ee1c72d5..cb735e1 100644
--- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
+++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
@@ -15,6 +15,7 @@ Required properties:
- compatible: should contain the platform identifier such as:
"fsl,ls1021a-pcie", "snps,dw-pcie"
"fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
+ "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
"fsl,ls1046a-pcie"
- reg: base addresses and lengths of the PCIe controller
- interrupts: A list of interrupt outputs of the controller. Must contain an
diff --git a/drivers/pci/dwc/pci-layerscape.c b/drivers/pci/dwc/pci-layerscape.c
index 9bed3cd..0df8189 100644
--- a/drivers/pci/dwc/pci-layerscape.c
+++ b/drivers/pci/dwc/pci-layerscape.c
@@ -239,12 +239,21 @@ static struct ls_pcie_drvdata ls2080_drvdata = {
.dw_pcie_ops = &dw_ls_pcie_ops,
};
+static struct ls_pcie_drvdata ls2088_drvdata = {
+ .lut_offset = 0x80000,
+ .ltssm_shift = 0,
+ .lut_dbg = 0x407fc,
+ .ops = &ls_pcie_host_ops,
+ .dw_pcie_ops = &dw_ls_pcie_ops,
+};
+
static const struct of_device_id ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
{ .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
+ { .compatible = "fsl,ls2088a-pcie", .data = &ls2088_drvdata },
{ },
};
--
2.1.0.27.g96db324
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-07-06 9:39 ` Zhiqiang Hou
0 siblings, 0 replies; 16+ messages in thread
From: Zhiqiang Hou @ 2017-07-06 9:39 UTC (permalink / raw)
To: linux-arm-kernel
From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
The ls1088a and ls2088a has the same PCIe controller, so the ls1088a
will reuse the ls2088a's pcie compatible.
Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
---
Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
drivers/pci/dwc/pci-layerscape.c | 9 +++++++++
2 files changed, 10 insertions(+)
diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
index ee1c72d5..cb735e1 100644
--- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
+++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
@@ -15,6 +15,7 @@ Required properties:
- compatible: should contain the platform identifier such as:
"fsl,ls1021a-pcie", "snps,dw-pcie"
"fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
+ "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
"fsl,ls1046a-pcie"
- reg: base addresses and lengths of the PCIe controller
- interrupts: A list of interrupt outputs of the controller. Must contain an
diff --git a/drivers/pci/dwc/pci-layerscape.c b/drivers/pci/dwc/pci-layerscape.c
index 9bed3cd..0df8189 100644
--- a/drivers/pci/dwc/pci-layerscape.c
+++ b/drivers/pci/dwc/pci-layerscape.c
@@ -239,12 +239,21 @@ static struct ls_pcie_drvdata ls2080_drvdata = {
.dw_pcie_ops = &dw_ls_pcie_ops,
};
+static struct ls_pcie_drvdata ls2088_drvdata = {
+ .lut_offset = 0x80000,
+ .ltssm_shift = 0,
+ .lut_dbg = 0x407fc,
+ .ops = &ls_pcie_host_ops,
+ .dw_pcie_ops = &dw_ls_pcie_ops,
+};
+
static const struct of_device_id ls_pcie_of_match[] = {
{ .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
{ .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
{ .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
{ .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
{ .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
+ { .compatible = "fsl,ls2088a-pcie", .data = &ls2088_drvdata },
{ },
};
--
2.1.0.27.g96db324
^ permalink raw reply related [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-07-06 9:39 ` Zhiqiang Hou
@ 2017-08-02 21:29 ` Bjorn Helgaas
-1 siblings, 0 replies; 16+ messages in thread
From: Bjorn Helgaas @ 2017-08-02 21:29 UTC (permalink / raw)
To: Zhiqiang Hou
Cc: linux-pci, Minghuan Lian, robh+dt, bhelgaas, Mingkai Hu,
Roy Zang, linux-arm-kernel
[+cc Minghuan, Mingkai, Roy]
On Thu, Jul 06, 2017 at 05:39:44PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> The ls1088a and ls2088a has the same PCIe controller, so the ls1088a
> will reuse the ls2088a's pcie compatible.
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> drivers/pci/dwc/pci-layerscape.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> index ee1c72d5..cb735e1 100644
> --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> @@ -15,6 +15,7 @@ Required properties:
> - compatible: should contain the platform identifier such as:
> "fsl,ls1021a-pcie", "snps,dw-pcie"
> "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> + "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[]
table in the driver, so I don't think this will actually make the
driver claim ls1088a devices, will it?
I'm also waiting for an ack from the layerscape maintainers (added to
cc list).
> "fsl,ls1046a-pcie"
> - reg: base addresses and lengths of the PCIe controller
> - interrupts: A list of interrupt outputs of the controller. Must contain an
> diff --git a/drivers/pci/dwc/pci-layerscape.c b/drivers/pci/dwc/pci-layerscape.c
> index 9bed3cd..0df8189 100644
> --- a/drivers/pci/dwc/pci-layerscape.c
> +++ b/drivers/pci/dwc/pci-layerscape.c
> @@ -239,12 +239,21 @@ static struct ls_pcie_drvdata ls2080_drvdata = {
> .dw_pcie_ops = &dw_ls_pcie_ops,
> };
>
> +static struct ls_pcie_drvdata ls2088_drvdata = {
> + .lut_offset = 0x80000,
> + .ltssm_shift = 0,
> + .lut_dbg = 0x407fc,
> + .ops = &ls_pcie_host_ops,
> + .dw_pcie_ops = &dw_ls_pcie_ops,
> +};
> +
> static const struct of_device_id ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> + { .compatible = "fsl,ls2088a-pcie", .data = &ls2088_drvdata },
> { },
> };
>
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-08-02 21:29 ` Bjorn Helgaas
0 siblings, 0 replies; 16+ messages in thread
From: Bjorn Helgaas @ 2017-08-02 21:29 UTC (permalink / raw)
To: linux-arm-kernel
[+cc Minghuan, Mingkai, Roy]
On Thu, Jul 06, 2017 at 05:39:44PM +0800, Zhiqiang Hou wrote:
> From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
>
> The ls1088a and ls2088a has the same PCIe controller, so the ls1088a
> will reuse the ls2088a's pcie compatible.
>
> Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> ---
> Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> drivers/pci/dwc/pci-layerscape.c | 9 +++++++++
> 2 files changed, 10 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> index ee1c72d5..cb735e1 100644
> --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> @@ -15,6 +15,7 @@ Required properties:
> - compatible: should contain the platform identifier such as:
> "fsl,ls1021a-pcie", "snps,dw-pcie"
> "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> + "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[]
table in the driver, so I don't think this will actually make the
driver claim ls1088a devices, will it?
I'm also waiting for an ack from the layerscape maintainers (added to
cc list).
> "fsl,ls1046a-pcie"
> - reg: base addresses and lengths of the PCIe controller
> - interrupts: A list of interrupt outputs of the controller. Must contain an
> diff --git a/drivers/pci/dwc/pci-layerscape.c b/drivers/pci/dwc/pci-layerscape.c
> index 9bed3cd..0df8189 100644
> --- a/drivers/pci/dwc/pci-layerscape.c
> +++ b/drivers/pci/dwc/pci-layerscape.c
> @@ -239,12 +239,21 @@ static struct ls_pcie_drvdata ls2080_drvdata = {
> .dw_pcie_ops = &dw_ls_pcie_ops,
> };
>
> +static struct ls_pcie_drvdata ls2088_drvdata = {
> + .lut_offset = 0x80000,
> + .ltssm_shift = 0,
> + .lut_dbg = 0x407fc,
> + .ops = &ls_pcie_host_ops,
> + .dw_pcie_ops = &dw_ls_pcie_ops,
> +};
> +
> static const struct of_device_id ls_pcie_of_match[] = {
> { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> + { .compatible = "fsl,ls2088a-pcie", .data = &ls2088_drvdata },
> { },
> };
>
> --
> 2.1.0.27.g96db324
>
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-02 21:29 ` Bjorn Helgaas
(?)
@ 2017-08-02 21:38 ` Roy Zang
2017-08-03 3:38 ` Z.q. Hou
-1 siblings, 1 reply; 16+ messages in thread
From: Roy Zang @ 2017-08-02 21:38 UTC (permalink / raw)
To: Bjorn Helgaas, Z.q. Hou
Cc: linux-pci, linux-arm-kernel, bhelgaas, robh+dt, Minghuan Lian,
Mingkai Hu, Roy Zang
[-- Attachment #1: Type: text/plain, Size: 312 bytes --]
On 08/02/2017 04:30 PM, Bjorn Helgaas wrote:
+ "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[]
table in the driver, so I don't think this will actually make the
driver claim ls1088a devices, will it?
the same query.
Thank.
Roy
[-- Attachment #2: Type: text/html, Size: 781 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-02 21:29 ` Bjorn Helgaas
@ 2017-08-03 3:35 ` Z.q. Hou
-1 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-03 3:35 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, Minghuan Lian, robh+dt, bhelgaas, Mingkai Hu,
Roy Zang, linux-arm-kernel
SGkgQmpvcm4sDQoNClRoYW5rcyBhIGxvdCBmb3IgeW91ciBjb21tZW50cyENCg0KPiAtLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCam9ybiBIZWxnYWFzIFttYWlsdG86aGVsZ2Fh
c0BrZXJuZWwub3JnXQ0KPiBTZW50OiAyMDE3xOo41MIzyNUgNTozMA0KPiBUbzogWi5xLiBIb3Ug
PHpoaXFpYW5nLmhvdUBueHAuY29tPg0KPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9yZzsg
bGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOw0KPiBiaGVsZ2Fhc0Bnb29nbGUu
Y29tOyByb2JoK2R0QGtlcm5lbC5vcmc7IE1pbmdodWFuIExpYW4NCj4gPG1pbmdodWFuLkxpYW5A
ZnJlZXNjYWxlLmNvbT47IE1pbmdrYWkgSHUgPG1pbmdrYWkuaHVAZnJlZXNjYWxlLmNvbT47DQo+
IFJveSBaYW5nIDx0aWUtZmVpLnphbmdAZnJlZXNjYWxlLmNvbT4NCj4gU3ViamVjdDogUmU6IFtQ
QVRDSF0gUENJOiBsYXllcnNjYXBlOiBBZGQgc3VwcG9ydCBmb3IgbHMyMDg4YSBhbmQgbHMxMDg4
YQ0KPiANCj4gWytjYyBNaW5naHVhbiwgTWluZ2thaSwgUm95XQ0KPiANCj4gT24gVGh1LCBKdWwg
MDYsIDIwMTcgYXQgMDU6Mzk6NDRQTSArMDgwMCwgWmhpcWlhbmcgSG91IHdyb3RlOg0KPiA+IEZy
b206IEhvdSBaaGlxaWFuZyA8WmhpcWlhbmcuSG91QG54cC5jb20+DQo+ID4NCj4gPiBUaGUgbHMx
MDg4YSBhbmQgbHMyMDg4YSBoYXMgdGhlIHNhbWUgUENJZSBjb250cm9sbGVyLCBzbyB0aGUgbHMx
MDg4YQ0KPiA+IHdpbGwgcmV1c2UgdGhlIGxzMjA4OGEncyBwY2llIGNvbXBhdGlibGUuDQo+ID4N
Cj4gPiBTaWduZWQtb2ZmLWJ5OiBIb3UgWmhpcWlhbmcgPFpoaXFpYW5nLkhvdUBueHAuY29tPg0K
PiA+IC0tLQ0KPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2xheWVy
c2NhcGUtcGNpLnR4dCB8IDEgKw0KPiA+ICBkcml2ZXJzL3BjaS9kd2MvcGNpLWxheWVyc2NhcGUu
YyAgICAgICAgICAgICAgICAgICAgICAgICB8IDkNCj4gKysrKysrKysrDQo+ID4gIDIgZmlsZXMg
Y2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQ0KPiA+DQo+ID4gZGlmZiAtLWdpdCBhL0RvY3VtZW50
YXRpb24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvbGF5ZXJzY2FwZS1wY2kudHh0DQo+ID4gYi9E
b2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2xheWVyc2NhcGUtcGNpLnR4dA0K
PiA+IGluZGV4IGVlMWM3MmQ1Li5jYjczNWUxIDEwMDY0NA0KPiA+IC0tLSBhL0RvY3VtZW50YXRp
b24vZGV2aWNldHJlZS9iaW5kaW5ncy9wY2kvbGF5ZXJzY2FwZS1wY2kudHh0DQo+ID4gKysrIGIv
RG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQN
Cj4gPiBAQCAtMTUsNiArMTUsNyBAQCBSZXF1aXJlZCBwcm9wZXJ0aWVzOg0KPiA+ICAtIGNvbXBh
dGlibGU6IHNob3VsZCBjb250YWluIHRoZSBwbGF0Zm9ybSBpZGVudGlmaWVyIHN1Y2ggYXM6DQo+
ID4gICAgICAgICAgImZzbCxsczEwMjFhLXBjaWUiLCAic25wcyxkdy1wY2llIg0KPiA+ICAgICAg
ICAgICJmc2wsbHMyMDgwYS1wY2llIiwgImZzbCxsczIwODVhLXBjaWUiLCAic25wcyxkdy1wY2ll
Ig0KPiA+ICsgICAgICAgICJmc2wsbHMyMDg4YS1wY2llIiwgImZzbCxsczEwODhhLXBjaWUiDQo+
IA0KPiBZb3UgYWRkICJmc2wsbHMxMDg4YS1wY2llIiBoZXJlLCBidXQgbm90IGluIHRoZSBsc19w
Y2llX29mX21hdGNoW10gdGFibGUgaW4gdGhlDQo+IGRyaXZlciwgc28gSSBkb24ndCB0aGluayB0
aGlzIHdpbGwgYWN0dWFsbHkgbWFrZSB0aGUgZHJpdmVyIGNsYWltIGxzMTA4OGEgZGV2aWNlcywN
Cj4gd2lsbCBpdD8NCg0KSSBtZWFuIHRoZSBsczEwODhhIHBjaWUgRFQgbm9kZXMgd2lsbCB1c2Ug
dGhlICJmc2wsbHMyMDg4YS1wY2llIiB0b28sIHNvIEkgZGlkbid0IGFkZCBhbiBlbnRyeSBmb3Ig
bHMxMDg4YSBwY2llIHRvIGxzX3BjaWVfb2ZfbWF0Y2hbXS4NCklzIGl0IHJlYXNvbmFibGU/IE9y
IGl0J3MgYmV0dGVyIHRvIGFkZCAiZnNsLGxzMTA4OGEtcGNpZSIgdG8gbHNfcGNpZV9vZl9tYXRj
aFtdLCB0aGVuIGxzMTA4OGEgcGNpZSBEVCBub2RlcyB1c2UgdGhlIGNvbXBhdGlibGUgc3RyaW5n
ICJmc2wsbHMxMDg4YS1wY2llIj8NCg0KPiBJJ20gYWxzbyB3YWl0aW5nIGZvciBhbiBhY2sgZnJv
bSB0aGUgbGF5ZXJzY2FwZSBtYWludGFpbmVycyAoYWRkZWQgdG8gY2MgbGlzdCkuDQo+IA0KPiA+
ICAgICAgICAgICJmc2wsbHMxMDQ2YS1wY2llIg0KPiA+ICAtIHJlZzogYmFzZSBhZGRyZXNzZXMg
YW5kIGxlbmd0aHMgb2YgdGhlIFBDSWUgY29udHJvbGxlcg0KPiA+ICAtIGludGVycnVwdHM6IEEg
bGlzdCBvZiBpbnRlcnJ1cHQgb3V0cHV0cyBvZiB0aGUgY29udHJvbGxlci4gTXVzdA0KPiA+IGNv
bnRhaW4gYW4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvcGNpL2R3Yy9wY2ktbGF5ZXJzY2FwZS5jDQo+
ID4gYi9kcml2ZXJzL3BjaS9kd2MvcGNpLWxheWVyc2NhcGUuYw0KPiA+IGluZGV4IDliZWQzY2Qu
LjBkZjgxODkgMTAwNjQ0DQo+ID4gLS0tIGEvZHJpdmVycy9wY2kvZHdjL3BjaS1sYXllcnNjYXBl
LmMNCj4gPiArKysgYi9kcml2ZXJzL3BjaS9kd2MvcGNpLWxheWVyc2NhcGUuYw0KPiA+IEBAIC0y
MzksMTIgKzIzOSwyMSBAQCBzdGF0aWMgc3RydWN0IGxzX3BjaWVfZHJ2ZGF0YSBsczIwODBfZHJ2
ZGF0YSA9IHsNCj4gPiAgCS5kd19wY2llX29wcyA9ICZkd19sc19wY2llX29wcywNCj4gPiAgfTsN
Cj4gPg0KPiA+ICtzdGF0aWMgc3RydWN0IGxzX3BjaWVfZHJ2ZGF0YSBsczIwODhfZHJ2ZGF0YSA9
IHsNCj4gPiArCS5sdXRfb2Zmc2V0ID0gMHg4MDAwMCwNCj4gPiArCS5sdHNzbV9zaGlmdCA9IDAs
DQo+ID4gKwkubHV0X2RiZyA9IDB4NDA3ZmMsDQo+ID4gKwkub3BzID0gJmxzX3BjaWVfaG9zdF9v
cHMsDQo+ID4gKwkuZHdfcGNpZV9vcHMgPSAmZHdfbHNfcGNpZV9vcHMsDQo+ID4gK307DQo+ID4g
Kw0KPiA+ICBzdGF0aWMgY29uc3Qgc3RydWN0IG9mX2RldmljZV9pZCBsc19wY2llX29mX21hdGNo
W10gPSB7DQo+ID4gIAl7IC5jb21wYXRpYmxlID0gImZzbCxsczEwMjFhLXBjaWUiLCAuZGF0YSA9
ICZsczEwMjFfZHJ2ZGF0YSB9LA0KPiA+ICAJeyAuY29tcGF0aWJsZSA9ICJmc2wsbHMxMDQzYS1w
Y2llIiwgLmRhdGEgPSAmbHMxMDQzX2RydmRhdGEgfSwNCj4gPiAgCXsgLmNvbXBhdGlibGUgPSAi
ZnNsLGxzMTA0NmEtcGNpZSIsIC5kYXRhID0gJmxzMTA0Nl9kcnZkYXRhIH0sDQo+ID4gIAl7IC5j
b21wYXRpYmxlID0gImZzbCxsczIwODBhLXBjaWUiLCAuZGF0YSA9ICZsczIwODBfZHJ2ZGF0YSB9
LA0KPiA+ICAJeyAuY29tcGF0aWJsZSA9ICJmc2wsbHMyMDg1YS1wY2llIiwgLmRhdGEgPSAmbHMy
MDgwX2RydmRhdGEgfSwNCj4gPiArCXsgLmNvbXBhdGlibGUgPSAiZnNsLGxzMjA4OGEtcGNpZSIs
IC5kYXRhID0gJmxzMjA4OF9kcnZkYXRhIH0sDQo+ID4gIAl7IH0sDQo+ID4gIH07DQo+ID4NCj4g
PiAtLQ0KPiA+IDIuMS4wLjI3Lmc5NmRiMzI0DQo+ID4NCj4gPg0KPiA+IF9fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fDQo+ID4gbGludXgtYXJtLWtlcm5lbCBt
YWlsaW5nIGxpc3QNCj4gPiBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4g
PiBodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1r
ZXJuZWwNCg0KVGhhbmtzLA0KWmhpcWlhbmcNCg0KX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWlsaW5nIGxpc3QKbGludXgt
YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3Jn
L21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-08-03 3:35 ` Z.q. Hou
0 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-03 3:35 UTC (permalink / raw)
To: linux-arm-kernel
Hi Bjorn,
Thanks a lot for your comments!
> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas at kernel.org]
> Sent: 2017?8?3? 5:30
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> bhelgaas at google.com; robh+dt at kernel.org; Minghuan Lian
> <minghuan.Lian@freescale.com>; Mingkai Hu <mingkai.hu@freescale.com>;
> Roy Zang <tie-fei.zang@freescale.com>
> Subject: Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
>
> [+cc Minghuan, Mingkai, Roy]
>
> On Thu, Jul 06, 2017 at 05:39:44PM +0800, Zhiqiang Hou wrote:
> > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> >
> > The ls1088a and ls2088a has the same PCIe controller, so the ls1088a
> > will reuse the ls2088a's pcie compatible.
> >
> > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > ---
> > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> > drivers/pci/dwc/pci-layerscape.c | 9
> +++++++++
> > 2 files changed, 10 insertions(+)
> >
> > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > index ee1c72d5..cb735e1 100644
> > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > @@ -15,6 +15,7 @@ Required properties:
> > - compatible: should contain the platform identifier such as:
> > "fsl,ls1021a-pcie", "snps,dw-pcie"
> > "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> > + "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
>
> You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[] table in the
> driver, so I don't think this will actually make the driver claim ls1088a devices,
> will it?
I mean the ls1088a pcie DT nodes will use the "fsl,ls2088a-pcie" too, so I didn't add an entry for ls1088a pcie to ls_pcie_of_match[].
Is it reasonable? Or it's better to add "fsl,ls1088a-pcie" to ls_pcie_of_match[], then ls1088a pcie DT nodes use the compatible string "fsl,ls1088a-pcie"?
> I'm also waiting for an ack from the layerscape maintainers (added to cc list).
>
> > "fsl,ls1046a-pcie"
> > - reg: base addresses and lengths of the PCIe controller
> > - interrupts: A list of interrupt outputs of the controller. Must
> > contain an diff --git a/drivers/pci/dwc/pci-layerscape.c
> > b/drivers/pci/dwc/pci-layerscape.c
> > index 9bed3cd..0df8189 100644
> > --- a/drivers/pci/dwc/pci-layerscape.c
> > +++ b/drivers/pci/dwc/pci-layerscape.c
> > @@ -239,12 +239,21 @@ static struct ls_pcie_drvdata ls2080_drvdata = {
> > .dw_pcie_ops = &dw_ls_pcie_ops,
> > };
> >
> > +static struct ls_pcie_drvdata ls2088_drvdata = {
> > + .lut_offset = 0x80000,
> > + .ltssm_shift = 0,
> > + .lut_dbg = 0x407fc,
> > + .ops = &ls_pcie_host_ops,
> > + .dw_pcie_ops = &dw_ls_pcie_ops,
> > +};
> > +
> > static const struct of_device_id ls_pcie_of_match[] = {
> > { .compatible = "fsl,ls1021a-pcie", .data = &ls1021_drvdata },
> > { .compatible = "fsl,ls1043a-pcie", .data = &ls1043_drvdata },
> > { .compatible = "fsl,ls1046a-pcie", .data = &ls1046_drvdata },
> > { .compatible = "fsl,ls2080a-pcie", .data = &ls2080_drvdata },
> > { .compatible = "fsl,ls2085a-pcie", .data = &ls2080_drvdata },
> > + { .compatible = "fsl,ls2088a-pcie", .data = &ls2088_drvdata },
> > { },
> > };
> >
> > --
> > 2.1.0.27.g96db324
> >
> >
> > _______________________________________________
> > linux-arm-kernel mailing list
> > linux-arm-kernel at lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
Thanks,
Zhiqiang
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-02 21:38 ` Roy Zang
@ 2017-08-03 3:38 ` Z.q. Hou
0 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-03 3:38 UTC (permalink / raw)
To: Roy Zang, Bjorn Helgaas
Cc: linux-pci, linux-arm-kernel, bhelgaas, robh+dt, Minghuan Lian,
Mingkai Hu, Roy Zang
[-- Attachment #1: Type: text/plain, Size: 851 bytes --]
Hi Roy,
Thanks for your comments!
Thanks,
Zhiqiang
From: Roy Zang
Sent: 2017年8月3日 5:38
To: Bjorn Helgaas <helgaas@kernel.org>; Z.q. Hou <zhiqiang.hou@nxp.com>
Cc: linux-pci@vger.kernel.org; linux-arm-kernel@lists.infradead.org; bhelgaas@google.com; robh+dt@kernel.org; Minghuan Lian <minghuan.Lian@freescale.com>; Mingkai Hu <mingkai.hu@freescale.com>; Roy Zang <tie-fei.zang@freescale.com>
Subject: Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
On 08/02/2017 04:30 PM, Bjorn Helgaas wrote:
+ "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[]
table in the driver, so I don't think this will actually make the
driver claim ls1088a devices, will it?
the same query.
[] Please find my reply to Bjorn in this thread.
Thank.
Roy
[-- Attachment #2: Type: text/html, Size: 6051 bytes --]
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-03 3:35 ` Z.q. Hou
@ 2017-08-03 18:19 ` Bjorn Helgaas
-1 siblings, 0 replies; 16+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 18:19 UTC (permalink / raw)
To: Z.q. Hou
Cc: linux-pci, Minghuan Lian, robh+dt, bhelgaas, Mingkai Hu,
Roy Zang, linux-arm-kernel
T24gVGh1LCBBdWcgMDMsIDIwMTcgYXQgMDM6MzU6NDZBTSArMDAwMCwgWi5xLiBIb3Ugd3JvdGU6
Cj4gSGkgQmpvcm4sCj4gCj4gVGhhbmtzIGEgbG90IGZvciB5b3VyIGNvbW1lbnRzIQo+IAo+ID4g
LS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0KPiA+IEZyb206IEJqb3JuIEhlbGdhYXMgW21haWx0
bzpoZWxnYWFzQGtlcm5lbC5vcmddCj4gPiBTZW50OiAyMDE35bm0OOaciDPml6UgNTozMAo+ID4g
VG86IFoucS4gSG91IDx6aGlxaWFuZy5ob3VAbnhwLmNvbT4KPiA+IENjOiBsaW51eC1wY2lAdmdl
ci5rZXJuZWwub3JnOyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmc7Cj4gPiBi
aGVsZ2Fhc0Bnb29nbGUuY29tOyByb2JoK2R0QGtlcm5lbC5vcmc7IE1pbmdodWFuIExpYW4KPiA+
IDxtaW5naHVhbi5MaWFuQGZyZWVzY2FsZS5jb20+OyBNaW5na2FpIEh1IDxtaW5na2FpLmh1QGZy
ZWVzY2FsZS5jb20+Owo+ID4gUm95IFphbmcgPHRpZS1mZWkuemFuZ0BmcmVlc2NhbGUuY29tPgo+
ID4gU3ViamVjdDogUmU6IFtQQVRDSF0gUENJOiBsYXllcnNjYXBlOiBBZGQgc3VwcG9ydCBmb3Ig
bHMyMDg4YSBhbmQgbHMxMDg4YQo+ID4gCj4gPiBbK2NjIE1pbmdodWFuLCBNaW5na2FpLCBSb3ld
Cj4gPiAKPiA+IE9uIFRodSwgSnVsIDA2LCAyMDE3IGF0IDA1OjM5OjQ0UE0gKzA4MDAsIFpoaXFp
YW5nIEhvdSB3cm90ZToKPiA+ID4gRnJvbTogSG91IFpoaXFpYW5nIDxaaGlxaWFuZy5Ib3VAbnhw
LmNvbT4KPiA+ID4KPiA+ID4gVGhlIGxzMTA4OGEgYW5kIGxzMjA4OGEgaGFzIHRoZSBzYW1lIFBD
SWUgY29udHJvbGxlciwgc28gdGhlIGxzMTA4OGEKPiA+ID4gd2lsbCByZXVzZSB0aGUgbHMyMDg4
YSdzIHBjaWUgY29tcGF0aWJsZS4KPiA+ID4KPiA+ID4gU2lnbmVkLW9mZi1ieTogSG91IFpoaXFp
YW5nIDxaaGlxaWFuZy5Ib3VAbnhwLmNvbT4KPiA+ID4gLS0tCj4gPiA+ICBEb2N1bWVudGF0aW9u
L2RldmljZXRyZWUvYmluZGluZ3MvcGNpL2xheWVyc2NhcGUtcGNpLnR4dCB8IDEgKwo+ID4gPiAg
ZHJpdmVycy9wY2kvZHdjL3BjaS1sYXllcnNjYXBlLmMgICAgICAgICAgICAgICAgICAgICAgICAg
fCA5Cj4gPiArKysrKysrKysKPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygr
KQo+ID4gPgo+ID4gPiBkaWZmIC0tZ2l0IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp
bmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQKPiA+ID4gYi9Eb2N1bWVudGF0aW9uL2RldmljZXRy
ZWUvYmluZGluZ3MvcGNpL2xheWVyc2NhcGUtcGNpLnR4dAo+ID4gPiBpbmRleCBlZTFjNzJkNS4u
Y2I3MzVlMSAxMDA2NDQKPiA+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp
bmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQKPiA+ID4gKysrIGIvRG9jdW1lbnRhdGlvbi9kZXZp
Y2V0cmVlL2JpbmRpbmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQKPiA+ID4gQEAgLTE1LDYgKzE1
LDcgQEAgUmVxdWlyZWQgcHJvcGVydGllczoKPiA+ID4gIC0gY29tcGF0aWJsZTogc2hvdWxkIGNv
bnRhaW4gdGhlIHBsYXRmb3JtIGlkZW50aWZpZXIgc3VjaCBhczoKPiA+ID4gICAgICAgICAgImZz
bCxsczEwMjFhLXBjaWUiLCAic25wcyxkdy1wY2llIgo+ID4gPiAgICAgICAgICAiZnNsLGxzMjA4
MGEtcGNpZSIsICJmc2wsbHMyMDg1YS1wY2llIiwgInNucHMsZHctcGNpZSIKPiA+ID4gKyAgICAg
ICAgImZzbCxsczIwODhhLXBjaWUiLCAiZnNsLGxzMTA4OGEtcGNpZSIKPiA+IAo+ID4gWW91IGFk
ZCAiZnNsLGxzMTA4OGEtcGNpZSIgaGVyZSwgYnV0IG5vdCBpbiB0aGUgbHNfcGNpZV9vZl9tYXRj
aFtdCj4gPiB0YWJsZSBpbiB0aGUgZHJpdmVyLCBzbyBJIGRvbid0IHRoaW5rIHRoaXMgd2lsbCBh
Y3R1YWxseSBtYWtlIHRoZQo+ID4gZHJpdmVyIGNsYWltIGxzMTA4OGEgZGV2aWNlcywgd2lsbCBp
dD8KPiAKPiBJIG1lYW4gdGhlIGxzMTA4OGEgcGNpZSBEVCBub2RlcyB3aWxsIHVzZSB0aGUgImZz
bCxsczIwODhhLXBjaWUiCj4gdG9vLCBzbyBJIGRpZG4ndCBhZGQgYW4gZW50cnkgZm9yIGxzMTA4
OGEgcGNpZSB0bwo+IGxzX3BjaWVfb2ZfbWF0Y2hbXS4gIElzIGl0IHJlYXNvbmFibGU/IE9yIGl0
J3MgYmV0dGVyIHRvIGFkZAo+ICJmc2wsbHMxMDg4YS1wY2llIiB0byBsc19wY2llX29mX21hdGNo
W10sIHRoZW4gbHMxMDg4YSBwY2llIERUIG5vZGVzCj4gdXNlIHRoZSBjb21wYXRpYmxlIHN0cmlu
ZyAiZnNsLGxzMTA4OGEtcGNpZSI/CgpZb3VyIGJpbmRpbmcgc2F5cyAiZnNsLGxzMTA4OGEtcGNp
ZSIgaXMgYSB2YWxpZCB2YWx1ZSBmb3IKImNvbXBhdGlibGUiLiAgQnV0IGlmIGEgRFQgYWN0dWFs
bHkgKnVzZXMqIHRoYXQsIEkgZG9uJ3QgdGhpbmsgdGhlCmRyaXZlciB3aWxsIGNsYWltIGl0LgoK
SWYgeW91IHdhbnQgdG8gZGVzY3JpYmUgbHMxMDg4YSBkZXZpY2VzIHdpdGggImZzbCxsczIwODhh
LXBjaWUiLCBJCnRoaW5rIHlvdSBjb3VsZCBkbyB0aGF0LCBidXQgdGhlbiB3aHkgd291bGQgeW91
IGV2ZW4gbWVudGlvbgoiZnNsLGxzMTA4OGEtcGNpZSIgaW4gdGhlIGJpbmRpbmc/CgpQZXJzb25h
bGx5LCBpZiBsczEwODhhIGFuZCBsczIwODhhIGFyZSBkaWZmZXJlbnQgaW4gYW55IHdheSwgSSB3
b3VsZAp0aGluayB5b3Ugc2hvdWxkIHVzZSBkaWZmZXJlbnQgaWRlbnRpZmllcnMgZm9yIHRoZW0g
KGFuZCBhZGQgdGhlbSBib3RoCnRvIHRoZSBiaW5kaW5nIGFuZCB0byB0aGUgZHJpdmVyKS4gIFRo
YXQgd2F5IGlmIGEgZnV0dXJlIGZlYXR1cmUKZGVwZW5kcyBvbiB0aGUgZGlmZmVyZW5jZSwgeW91
J2xsIGhhdmUgYSB3YXkgdG8gdGVzdCBmb3IgaXQuCgpCdXQgSSdtIG5vdCBhIERUIGd1eS4gIE1h
eWJlIFJvYiBoYXMgYSBiZXR0ZXIgcmVjb21tZW5kYXRpb24/CgpCam9ybgoKX19fX19fX19fX19f
X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtlcm5lbCBtYWls
aW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0dHA6Ly9saXN0
cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5lbAo=
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-08-03 18:19 ` Bjorn Helgaas
0 siblings, 0 replies; 16+ messages in thread
From: Bjorn Helgaas @ 2017-08-03 18:19 UTC (permalink / raw)
To: linux-arm-kernel
On Thu, Aug 03, 2017 at 03:35:46AM +0000, Z.q. Hou wrote:
> Hi Bjorn,
>
> Thanks a lot for your comments!
>
> > -----Original Message-----
> > From: Bjorn Helgaas [mailto:helgaas at kernel.org]
> > Sent: 2017?8?3? 5:30
> > To: Z.q. Hou <zhiqiang.hou@nxp.com>
> > Cc: linux-pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> > bhelgaas at google.com; robh+dt at kernel.org; Minghuan Lian
> > <minghuan.Lian@freescale.com>; Mingkai Hu <mingkai.hu@freescale.com>;
> > Roy Zang <tie-fei.zang@freescale.com>
> > Subject: Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
> >
> > [+cc Minghuan, Mingkai, Roy]
> >
> > On Thu, Jul 06, 2017 at 05:39:44PM +0800, Zhiqiang Hou wrote:
> > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > >
> > > The ls1088a and ls2088a has the same PCIe controller, so the ls1088a
> > > will reuse the ls2088a's pcie compatible.
> > >
> > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > ---
> > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> > > drivers/pci/dwc/pci-layerscape.c | 9
> > +++++++++
> > > 2 files changed, 10 insertions(+)
> > >
> > > diff --git a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > index ee1c72d5..cb735e1 100644
> > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > @@ -15,6 +15,7 @@ Required properties:
> > > - compatible: should contain the platform identifier such as:
> > > "fsl,ls1021a-pcie", "snps,dw-pcie"
> > > "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> > > + "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
> >
> > You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[]
> > table in the driver, so I don't think this will actually make the
> > driver claim ls1088a devices, will it?
>
> I mean the ls1088a pcie DT nodes will use the "fsl,ls2088a-pcie"
> too, so I didn't add an entry for ls1088a pcie to
> ls_pcie_of_match[]. Is it reasonable? Or it's better to add
> "fsl,ls1088a-pcie" to ls_pcie_of_match[], then ls1088a pcie DT nodes
> use the compatible string "fsl,ls1088a-pcie"?
Your binding says "fsl,ls1088a-pcie" is a valid value for
"compatible". But if a DT actually *uses* that, I don't think the
driver will claim it.
If you want to describe ls1088a devices with "fsl,ls2088a-pcie", I
think you could do that, but then why would you even mention
"fsl,ls1088a-pcie" in the binding?
Personally, if ls1088a and ls2088a are different in any way, I would
think you should use different identifiers for them (and add them both
to the binding and to the driver). That way if a future feature
depends on the difference, you'll have a way to test for it.
But I'm not a DT guy. Maybe Rob has a better recommendation?
Bjorn
^ permalink raw reply [flat|nested] 16+ messages in thread
* Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-03 3:35 ` Z.q. Hou
@ 2017-08-03 18:22 ` Roy Zang
-1 siblings, 0 replies; 16+ messages in thread
From: Roy Zang @ 2017-08-03 18:22 UTC (permalink / raw)
To: Z.q. Hou, Bjorn Helgaas
Cc: linux-pci, linux-arm-kernel, bhelgaas, robh+dt, Minghuan Lian,
Mingkai Hu, Roy Zang
On 08/02/2017 10:36 PM, Z.q. Hou wrote:=0A=
> add "fsl,ls1088a-pcie" to ls_pcie_of_match[], then ls1088a pcie DT nodes =
use the compatible string "fsl,ls1088a-pcie"?=0A=
=0A=
I'd suggest going this way.=0A=
=0A=
Roy=0A=
=0A=
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-08-03 18:22 ` Roy Zang
0 siblings, 0 replies; 16+ messages in thread
From: Roy Zang @ 2017-08-03 18:22 UTC (permalink / raw)
To: linux-arm-kernel
On 08/02/2017 10:36 PM, Z.q. Hou wrote:
> add "fsl,ls1088a-pcie" to ls_pcie_of_match[], then ls1088a pcie DT nodes use the compatible string "fsl,ls1088a-pcie"?
I'd suggest going this way.
Roy
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-03 18:19 ` Bjorn Helgaas
@ 2017-08-04 3:45 ` Z.q. Hou
-1 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-04 3:45 UTC (permalink / raw)
To: Bjorn Helgaas
Cc: linux-pci, Minghuan Lian, robh+dt, bhelgaas, Mingkai Hu,
Roy Zang, linux-arm-kernel
SGkgQmpvcm4sDQoNClRoYW5rcyBhIGxvdCBmb3IgeW91ciBjb21tZW50cyENCg0KPiAtLS0tLU9y
aWdpbmFsIE1lc3NhZ2UtLS0tLQ0KPiBGcm9tOiBCam9ybiBIZWxnYWFzIFttYWlsdG86aGVsZ2Fh
c0BrZXJuZWwub3JnXQ0KPiBTZW50OiAyMDE35bm0OOaciDTml6UgMjoxOQ0KPiBUbzogWi5xLiBI
b3UgPHpoaXFpYW5nLmhvdUBueHAuY29tPg0KPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9y
ZzsgTWluZ2h1YW4gTGlhbg0KPiA8bWluZ2h1YW4uTGlhbkBmcmVlc2NhbGUuY29tPjsgcm9iaCtk
dEBrZXJuZWwub3JnOw0KPiBiaGVsZ2Fhc0Bnb29nbGUuY29tOyBNaW5na2FpIEh1IDxtaW5na2Fp
Lmh1QGZyZWVzY2FsZS5jb20+OyBSb3kgWmFuZw0KPiA8dGllLWZlaS56YW5nQGZyZWVzY2FsZS5j
b20+OyBsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcNCj4gU3ViamVjdDogUmU6
IFtQQVRDSF0gUENJOiBsYXllcnNjYXBlOiBBZGQgc3VwcG9ydCBmb3IgbHMyMDg4YSBhbmQgbHMx
MDg4YQ0KPiANCj4gT24gVGh1LCBBdWcgMDMsIDIwMTcgYXQgMDM6MzU6NDZBTSArMDAwMCwgWi5x
LiBIb3Ugd3JvdGU6DQo+ID4gSGkgQmpvcm4sDQo+ID4NCj4gPiBUaGFua3MgYSBsb3QgZm9yIHlv
dXIgY29tbWVudHMhDQo+ID4NCj4gPiA+IC0tLS0tT3JpZ2luYWwgTWVzc2FnZS0tLS0tDQo+ID4g
PiBGcm9tOiBCam9ybiBIZWxnYWFzIFttYWlsdG86aGVsZ2Fhc0BrZXJuZWwub3JnXQ0KPiA+ID4g
U2VudDogMjAxN+W5tDjmnIgz5pelIDU6MzANCj4gPiA+IFRvOiBaLnEuIEhvdSA8emhpcWlhbmcu
aG91QG54cC5jb20+DQo+ID4gPiBDYzogbGludXgtcGNpQHZnZXIua2VybmVsLm9yZzsgbGludXgt
YXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnOw0KPiA+ID4gYmhlbGdhYXNAZ29vZ2xlLmNv
bTsgcm9iaCtkdEBrZXJuZWwub3JnOyBNaW5naHVhbiBMaWFuDQo+ID4gPiA8bWluZ2h1YW4uTGlh
bkBmcmVlc2NhbGUuY29tPjsgTWluZ2thaSBIdQ0KPiA+ID4gPG1pbmdrYWkuaHVAZnJlZXNjYWxl
LmNvbT47IFJveSBaYW5nIDx0aWUtZmVpLnphbmdAZnJlZXNjYWxlLmNvbT4NCj4gPiA+IFN1Ympl
Y3Q6IFJlOiBbUEFUQ0hdIFBDSTogbGF5ZXJzY2FwZTogQWRkIHN1cHBvcnQgZm9yIGxzMjA4OGEg
YW5kDQo+ID4gPiBsczEwODhhDQo+ID4gPg0KPiA+ID4gWytjYyBNaW5naHVhbiwgTWluZ2thaSwg
Um95XQ0KPiA+ID4NCj4gPiA+IE9uIFRodSwgSnVsIDA2LCAyMDE3IGF0IDA1OjM5OjQ0UE0gKzA4
MDAsIFpoaXFpYW5nIEhvdSB3cm90ZToNCj4gPiA+ID4gRnJvbTogSG91IFpoaXFpYW5nIDxaaGlx
aWFuZy5Ib3VAbnhwLmNvbT4NCj4gPiA+ID4NCj4gPiA+ID4gVGhlIGxzMTA4OGEgYW5kIGxzMjA4
OGEgaGFzIHRoZSBzYW1lIFBDSWUgY29udHJvbGxlciwgc28gdGhlDQo+ID4gPiA+IGxzMTA4OGEg
d2lsbCByZXVzZSB0aGUgbHMyMDg4YSdzIHBjaWUgY29tcGF0aWJsZS4NCj4gPiA+ID4NCj4gPiA+
ID4gU2lnbmVkLW9mZi1ieTogSG91IFpoaXFpYW5nIDxaaGlxaWFuZy5Ib3VAbnhwLmNvbT4NCj4g
PiA+ID4gLS0tDQo+ID4gPiA+ICBEb2N1bWVudGF0aW9uL2RldmljZXRyZWUvYmluZGluZ3MvcGNp
L2xheWVyc2NhcGUtcGNpLnR4dCB8IDEgKw0KPiA+ID4gPiAgZHJpdmVycy9wY2kvZHdjL3BjaS1s
YXllcnNjYXBlLmMgICAgICAgICAgICAgICAgICAgICAgICAgfCA5DQo+ID4gPiArKysrKysrKysN
Cj4gPiA+ID4gIDIgZmlsZXMgY2hhbmdlZCwgMTAgaW5zZXJ0aW9ucygrKQ0KPiA+ID4gPg0KPiA+
ID4gPiBkaWZmIC0tZ2l0DQo+ID4gPiA+IGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRp
bmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQNCj4gPiA+ID4gYi9Eb2N1bWVudGF0aW9uL2Rldmlj
ZXRyZWUvYmluZGluZ3MvcGNpL2xheWVyc2NhcGUtcGNpLnR4dA0KPiA+ID4gPiBpbmRleCBlZTFj
NzJkNS4uY2I3MzVlMSAxMDA2NDQNCj4gPiA+ID4gLS0tIGEvRG9jdW1lbnRhdGlvbi9kZXZpY2V0
cmVlL2JpbmRpbmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQNCj4gPiA+ID4gKysrIGIvRG9jdW1l
bnRhdGlvbi9kZXZpY2V0cmVlL2JpbmRpbmdzL3BjaS9sYXllcnNjYXBlLXBjaS50eHQNCj4gPiA+
ID4gQEAgLTE1LDYgKzE1LDcgQEAgUmVxdWlyZWQgcHJvcGVydGllczoNCj4gPiA+ID4gIC0gY29t
cGF0aWJsZTogc2hvdWxkIGNvbnRhaW4gdGhlIHBsYXRmb3JtIGlkZW50aWZpZXIgc3VjaCBhczoN
Cj4gPiA+ID4gICAgICAgICAgImZzbCxsczEwMjFhLXBjaWUiLCAic25wcyxkdy1wY2llIg0KPiA+
ID4gPiAgICAgICAgICAiZnNsLGxzMjA4MGEtcGNpZSIsICJmc2wsbHMyMDg1YS1wY2llIiwgInNu
cHMsZHctcGNpZSINCj4gPiA+ID4gKyAgICAgICAgImZzbCxsczIwODhhLXBjaWUiLCAiZnNsLGxz
MTA4OGEtcGNpZSINCj4gPiA+DQo+ID4gPiBZb3UgYWRkICJmc2wsbHMxMDg4YS1wY2llIiBoZXJl
LCBidXQgbm90IGluIHRoZSBsc19wY2llX29mX21hdGNoW10NCj4gPiA+IHRhYmxlIGluIHRoZSBk
cml2ZXIsIHNvIEkgZG9uJ3QgdGhpbmsgdGhpcyB3aWxsIGFjdHVhbGx5IG1ha2UgdGhlDQo+ID4g
PiBkcml2ZXIgY2xhaW0gbHMxMDg4YSBkZXZpY2VzLCB3aWxsIGl0Pw0KPiA+DQo+ID4gSSBtZWFu
IHRoZSBsczEwODhhIHBjaWUgRFQgbm9kZXMgd2lsbCB1c2UgdGhlICJmc2wsbHMyMDg4YS1wY2ll
Ig0KPiA+IHRvbywgc28gSSBkaWRuJ3QgYWRkIGFuIGVudHJ5IGZvciBsczEwODhhIHBjaWUgdG8g
bHNfcGNpZV9vZl9tYXRjaFtdLg0KPiA+IElzIGl0IHJlYXNvbmFibGU/IE9yIGl0J3MgYmV0dGVy
IHRvIGFkZCAiZnNsLGxzMTA4OGEtcGNpZSIgdG8NCj4gPiBsc19wY2llX29mX21hdGNoW10sIHRo
ZW4gbHMxMDg4YSBwY2llIERUIG5vZGVzIHVzZSB0aGUgY29tcGF0aWJsZQ0KPiA+IHN0cmluZyAi
ZnNsLGxzMTA4OGEtcGNpZSI/DQo+IA0KPiBZb3VyIGJpbmRpbmcgc2F5cyAiZnNsLGxzMTA4OGEt
cGNpZSIgaXMgYSB2YWxpZCB2YWx1ZSBmb3IgImNvbXBhdGlibGUiLiAgQnV0IGlmIGENCj4gRFQg
YWN0dWFsbHkgKnVzZXMqIHRoYXQsIEkgZG9uJ3QgdGhpbmsgdGhlIGRyaXZlciB3aWxsIGNsYWlt
IGl0Lg0KPiANCj4gSWYgeW91IHdhbnQgdG8gZGVzY3JpYmUgbHMxMDg4YSBkZXZpY2VzIHdpdGgg
ImZzbCxsczIwODhhLXBjaWUiLCBJIHRoaW5rIHlvdQ0KPiBjb3VsZCBkbyB0aGF0LCBidXQgdGhl
biB3aHkgd291bGQgeW91IGV2ZW4gbWVudGlvbiAiZnNsLGxzMTA4OGEtcGNpZSIgaW4gdGhlDQo+
IGJpbmRpbmc/DQo+IA0KPiBQZXJzb25hbGx5LCBpZiBsczEwODhhIGFuZCBsczIwODhhIGFyZSBk
aWZmZXJlbnQgaW4gYW55IHdheSwgSSB3b3VsZCB0aGluayB5b3UNCj4gc2hvdWxkIHVzZSBkaWZm
ZXJlbnQgaWRlbnRpZmllcnMgZm9yIHRoZW0gKGFuZCBhZGQgdGhlbSBib3RoIHRvIHRoZSBiaW5k
aW5nIGFuZA0KPiB0byB0aGUgZHJpdmVyKS4gIFRoYXQgd2F5IGlmIGEgZnV0dXJlIGZlYXR1cmUg
ZGVwZW5kcyBvbiB0aGUgZGlmZmVyZW5jZSwgeW91J2xsDQo+IGhhdmUgYSB3YXkgdG8gdGVzdCBm
b3IgaXQuDQoNCkdvdCBpdCwgd2lsbCBhZGQgYm90aCBvZiB0aGVtIHRvIGRyaXZlciBhbmQgdGhl
IGJpbmdkaW5nIGRvYy4NClRoYW5rcyBmb3IgdGhlIHN1Z2dlc3Rpb24hDQoNCj4gQnV0IEknbSBu
b3QgYSBEVCBndXkuICBNYXliZSBSb2IgaGFzIGEgYmV0dGVyIHJlY29tbWVuZGF0aW9uPw0KPiAN
Cg0KVGhhbmtzLA0KWmhpcWlhbmcNCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fX19fX19fX19fCmxpbnV4LWFybS1rZXJuZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJu
ZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFu
L2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-08-04 3:45 ` Z.q. Hou
0 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-04 3:45 UTC (permalink / raw)
To: linux-arm-kernel
Hi Bjorn,
Thanks a lot for your comments!
> -----Original Message-----
> From: Bjorn Helgaas [mailto:helgaas at kernel.org]
> Sent: 2017?8?4? 2:19
> To: Z.q. Hou <zhiqiang.hou@nxp.com>
> Cc: linux-pci at vger.kernel.org; Minghuan Lian
> <minghuan.Lian@freescale.com>; robh+dt at kernel.org;
> bhelgaas at google.com; Mingkai Hu <mingkai.hu@freescale.com>; Roy Zang
> <tie-fei.zang@freescale.com>; linux-arm-kernel at lists.infradead.org
> Subject: Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
>
> On Thu, Aug 03, 2017 at 03:35:46AM +0000, Z.q. Hou wrote:
> > Hi Bjorn,
> >
> > Thanks a lot for your comments!
> >
> > > -----Original Message-----
> > > From: Bjorn Helgaas [mailto:helgaas at kernel.org]
> > > Sent: 2017?8?3? 5:30
> > > To: Z.q. Hou <zhiqiang.hou@nxp.com>
> > > Cc: linux-pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> > > bhelgaas at google.com; robh+dt at kernel.org; Minghuan Lian
> > > <minghuan.Lian@freescale.com>; Mingkai Hu
> > > <mingkai.hu@freescale.com>; Roy Zang <tie-fei.zang@freescale.com>
> > > Subject: Re: [PATCH] PCI: layerscape: Add support for ls2088a and
> > > ls1088a
> > >
> > > [+cc Minghuan, Mingkai, Roy]
> > >
> > > On Thu, Jul 06, 2017 at 05:39:44PM +0800, Zhiqiang Hou wrote:
> > > > From: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > >
> > > > The ls1088a and ls2088a has the same PCIe controller, so the
> > > > ls1088a will reuse the ls2088a's pcie compatible.
> > > >
> > > > Signed-off-by: Hou Zhiqiang <Zhiqiang.Hou@nxp.com>
> > > > ---
> > > > Documentation/devicetree/bindings/pci/layerscape-pci.txt | 1 +
> > > > drivers/pci/dwc/pci-layerscape.c | 9
> > > +++++++++
> > > > 2 files changed, 10 insertions(+)
> > > >
> > > > diff --git
> > > > a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > > b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > > index ee1c72d5..cb735e1 100644
> > > > --- a/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > > +++ b/Documentation/devicetree/bindings/pci/layerscape-pci.txt
> > > > @@ -15,6 +15,7 @@ Required properties:
> > > > - compatible: should contain the platform identifier such as:
> > > > "fsl,ls1021a-pcie", "snps,dw-pcie"
> > > > "fsl,ls2080a-pcie", "fsl,ls2085a-pcie", "snps,dw-pcie"
> > > > + "fsl,ls2088a-pcie", "fsl,ls1088a-pcie"
> > >
> > > You add "fsl,ls1088a-pcie" here, but not in the ls_pcie_of_match[]
> > > table in the driver, so I don't think this will actually make the
> > > driver claim ls1088a devices, will it?
> >
> > I mean the ls1088a pcie DT nodes will use the "fsl,ls2088a-pcie"
> > too, so I didn't add an entry for ls1088a pcie to ls_pcie_of_match[].
> > Is it reasonable? Or it's better to add "fsl,ls1088a-pcie" to
> > ls_pcie_of_match[], then ls1088a pcie DT nodes use the compatible
> > string "fsl,ls1088a-pcie"?
>
> Your binding says "fsl,ls1088a-pcie" is a valid value for "compatible". But if a
> DT actually *uses* that, I don't think the driver will claim it.
>
> If you want to describe ls1088a devices with "fsl,ls2088a-pcie", I think you
> could do that, but then why would you even mention "fsl,ls1088a-pcie" in the
> binding?
>
> Personally, if ls1088a and ls2088a are different in any way, I would think you
> should use different identifiers for them (and add them both to the binding and
> to the driver). That way if a future feature depends on the difference, you'll
> have a way to test for it.
Got it, will add both of them to driver and the bingding doc.
Thanks for the suggestion!
> But I'm not a DT guy. Maybe Rob has a better recommendation?
>
Thanks,
Zhiqiang
^ permalink raw reply [flat|nested] 16+ messages in thread
* RE: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
2017-08-03 18:22 ` Roy Zang
@ 2017-08-04 3:46 ` Z.q. Hou
-1 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-04 3:46 UTC (permalink / raw)
To: Roy Zang, Bjorn Helgaas
Cc: linux-pci, linux-arm-kernel, bhelgaas, robh+dt, Minghuan Lian,
Mingkai Hu, Roy Zang
SGkgUm95LA0KDQpUaGFua3MgYSBsb3QgZm9yIHlvdXIgY29tbWVudHMhDQoNCj4gLS0tLS1Pcmln
aW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogUm95IFphbmcNCj4gU2VudDogMjAxN8TqONTCNMjV
IDI6MjMNCj4gVG86IFoucS4gSG91IDx6aGlxaWFuZy5ob3VAbnhwLmNvbT47IEJqb3JuIEhlbGdh
YXMgPGhlbGdhYXNAa2VybmVsLm9yZz4NCj4gQ2M6IGxpbnV4LXBjaUB2Z2VyLmtlcm5lbC5vcmc7
IGxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZzsNCj4gYmhlbGdhYXNAZ29vZ2xl
LmNvbTsgcm9iaCtkdEBrZXJuZWwub3JnOyBNaW5naHVhbiBMaWFuDQo+IDxtaW5naHVhbi5MaWFu
QGZyZWVzY2FsZS5jb20+OyBNaW5na2FpIEh1IDxtaW5na2FpLmh1QGZyZWVzY2FsZS5jb20+Ow0K
PiBSb3kgWmFuZyA8dGllLWZlaS56YW5nQGZyZWVzY2FsZS5jb20+DQo+IFN1YmplY3Q6IFJlOiBb
UEFUQ0hdIFBDSTogbGF5ZXJzY2FwZTogQWRkIHN1cHBvcnQgZm9yIGxzMjA4OGEgYW5kIGxzMTA4
OGENCj4gDQo+IE9uIDA4LzAyLzIwMTcgMTA6MzYgUE0sIFoucS4gSG91IHdyb3RlOg0KPiA+IGFk
ZCAiZnNsLGxzMTA4OGEtcGNpZSIgdG8gbHNfcGNpZV9vZl9tYXRjaFtdLCB0aGVuIGxzMTA4OGEg
cGNpZSBEVCBub2RlcyB1c2UNCj4gdGhlIGNvbXBhdGlibGUgc3RyaW5nICJmc2wsbHMxMDg4YS1w
Y2llIj8NCj4gDQo+IEknZCBzdWdnZXN0IGdvaW5nIHRoaXMgd2F5Lg0KDQpZZXMsIHRoYW5rcyBm
b3IgdGhlIHN1Z2dlc3Rpb24uDQoNClRoYW5rcywNClpoaXFpYW5nDQoNCg==
^ permalink raw reply [flat|nested] 16+ messages in thread
* [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
@ 2017-08-04 3:46 ` Z.q. Hou
0 siblings, 0 replies; 16+ messages in thread
From: Z.q. Hou @ 2017-08-04 3:46 UTC (permalink / raw)
To: linux-arm-kernel
Hi Roy,
Thanks a lot for your comments!
> -----Original Message-----
> From: Roy Zang
> Sent: 2017?8?4? 2:23
> To: Z.q. Hou <zhiqiang.hou@nxp.com>; Bjorn Helgaas <helgaas@kernel.org>
> Cc: linux-pci at vger.kernel.org; linux-arm-kernel at lists.infradead.org;
> bhelgaas at google.com; robh+dt at kernel.org; Minghuan Lian
> <minghuan.Lian@freescale.com>; Mingkai Hu <mingkai.hu@freescale.com>;
> Roy Zang <tie-fei.zang@freescale.com>
> Subject: Re: [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a
>
> On 08/02/2017 10:36 PM, Z.q. Hou wrote:
> > add "fsl,ls1088a-pcie" to ls_pcie_of_match[], then ls1088a pcie DT nodes use
> the compatible string "fsl,ls1088a-pcie"?
>
> I'd suggest going this way.
Yes, thanks for the suggestion.
Thanks,
Zhiqiang
^ permalink raw reply [flat|nested] 16+ messages in thread
end of thread, other threads:[~2017-08-04 3:46 UTC | newest]
Thread overview: 16+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-07-06 9:39 [PATCH] PCI: layerscape: Add support for ls2088a and ls1088a Zhiqiang Hou
2017-07-06 9:39 ` Zhiqiang Hou
2017-08-02 21:29 ` Bjorn Helgaas
2017-08-02 21:29 ` Bjorn Helgaas
2017-08-02 21:38 ` Roy Zang
2017-08-03 3:38 ` Z.q. Hou
2017-08-03 3:35 ` Z.q. Hou
2017-08-03 3:35 ` Z.q. Hou
2017-08-03 18:19 ` Bjorn Helgaas
2017-08-03 18:19 ` Bjorn Helgaas
2017-08-04 3:45 ` Z.q. Hou
2017-08-04 3:45 ` Z.q. Hou
2017-08-03 18:22 ` Roy Zang
2017-08-03 18:22 ` Roy Zang
2017-08-04 3:46 ` Z.q. Hou
2017-08-04 3:46 ` Z.q. Hou
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.