[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

Dear Jagan,

NXP is coming up with new FlexSPI controller. It is similar to existing QSPI with enhanced feature-set. 
We have the driver ready as per existing framework i.e. driver/spi.

From recend discussion, we go to know about framework change. Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.

We are in dilemma for sending FlexSPI driver upstream. 
Do we follow existing framework i.e. driver/spi   or new proposed framework i.e. u-boot-spi/drivers/mtd/spi-nor/

Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to become default.
 
We have sent RFC version in Linux upstream for review.  Please refer below

Regards,
Prabhakar

-----Original Message-----
From: linux-mtd [mailto:linux-mtd-bounces at lists.infradead.org] On Behalf Of Yogesh Gaur
Sent: Wednesday, April 4, 2018 3:36 PM
To: linux-mtd at lists.infradead.org
Cc: boris.brezillon at free-electrons.com; Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; marek.vasut at gmail.com; frieder.schrempf at exceet.de; Suresh Gupta <suresh.gupta@nxp.com>; cyrille.pitchen at wedev4u.fr; Han Xu <han.xu@nxp.com>; computersforpeace at gmail.com; festevam at gmail.com
Subject: [RFC PATCH 0/4] mtd: spi-nor: Add NXP FlexSPI driver

Add NXP FlexSPI driver

NXP uses FlexSPI controller.
The FlexSPI(Flex Serial Peripheral controller) acts as an interface to external serial flash devices, maximum 4, each with upto 8 bidirectional data lines.

(1) The FlexSPI controller is driven by the LUT(Look-up Table) registers.
 The LUT registers are a look-up-table for sequences of instructions.
 A valid sequence consists of four LUT registers.

(2) The definition of the LUT register shows below:
 ---------------------------------------------------
 | INSTR1 | PAD1 | OPRND1 | INSTR0 | PAD0 | OPRND0 |
 ---------------------------------------------------

 There are several types of INSTRx, such as:
 CMD     : the SPI NOR command.
 ADDR    : the address for the SPI NOR command.
 DUMMY   : the dummy cycles needed by the SPI NOR command.
 ....

 There are several types of PADx, such as:
 PAD1    : use single I/O line.
 PAD2    : use dual I/O lines.
 PAD4    : use quad I/O lines.
 PAD8    : use octal I/O lines.
 ....

(3) LUTs are being created at run-time based on the commands passed from  the spi-nor framework.

(4) Mode [single, dual, quad or octal] bit information derived from device  tree by parsing spi-rx-bus-width and spi-tx-bus-width property.

(5) Tested this driver with the mtd_debug utility on NXP LX2160  emulator platform.

This series added below patches:
- Added entry for mt35xu512aba NOR flash in spi_nor_ids table
- Add flags for Octal I/O data transfer in spi/spi.h
- Add binding file for NXP FlexSPI driver
- Add NXP FlexSPI driver in mtd interface

Yogesh Gaur (4):
  mtd: spi-nor: Add entry for mt35xu512aba flash
  spi: add flags for octal I/O data transfer
  dt-bindings: Add binding file for NXP FlexSPI driver
  mtd: spi-nor: Add NXP FlexSPI driver

 .../devicetree/bindings/mtd/nxp-flexspi.txt        |   40 +
 MAINTAINERS                                        |    7 +
 drivers/mtd/spi-nor/Kconfig                        |    7 +
 drivers/mtd/spi-nor/Makefile                       |    1 +
 drivers/mtd/spi-nor/nxp-flexspi.c                  | 1508 ++++++++++++++++++++
 drivers/mtd/spi-nor/spi-nor.c                      |    7 +-
 include/linux/mtd/cfi.h                            |    1 +
 include/linux/mtd/spi-nor.h                        |    1 +
 include/linux/spi/spi.h                            |    2 +
 9 files changed, 1573 insertions(+), 1 deletion(-)  create mode 100644 Documentation/devicetree/bindings/mtd/nxp-flexspi.txt
 create mode 100644 drivers/mtd/spi-nor/nxp-flexspi.c

--
1.9.1


______________________________________________________
Linux MTD discussion mailing list
https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Flists.infradead.org%2Fmailman%2Flistinfo%2Flinux-mtd%2F&data=02%7C01%7Cprabhakar.kushwaha%40nxp.com%7Cb557330f496845b8dfca08d59a13f8fb%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636584332936008995&sdata=4WB9Fl8nOebX6WirthlEtXC306vjv6Is0ovJc1wHIWU%3D&reserved=0

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Jagan Teki]

On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> Dear Jagan,
>
> NXP is coming up with new FlexSPI controller. It is similar to existing QSPI with enhanced feature-set.
> We have the driver ready as per existing framework i.e. driver/spi.
>
> From recend discussion, we go to know about framework change. Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
>
> We are in dilemma for sending FlexSPI driver upstream.
> Do we follow existing framework i.e. driver/spi   or new proposed framework i.e. u-boot-spi/drivers/mtd/spi-nor/
>
> Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to become default.

Idea is to move spi-nor, mtd-spinor-working is paused because of
non-dm drivers accessing. We are clear that we can't create another
legacy layer to access spi-nor for the sake of non-dm driver to work
which eventually ended-up another mess and also no one take care of
non-dm conversion to dm if we give such feasibility. So we exported a
deadline for full SPI/SPI_FLASH DM conversion till v2018.09. Once all
these relevant conversion done, will try to move.

[1] http://git.denx.de/?p=u-boot-spi.git;a=commitdiff;h=c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8

Jagan.

-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

Thanks Jagan

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Friday, May 11, 2018 11:31 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
> <york.sun@nxp.com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com>; Poonam Aggrwal
> <poonam.aggrwal@nxp.com>; Ashish Kumar <ashish.kumar@nxp.com>; u-
> boot at lists.denx.de
> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to
> use ?
> 
> On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Dear Jagan,
> >
> > NXP is coming up with new FlexSPI controller. It is similar to existing QSPI
> with enhanced feature-set.
> > We have the driver ready as per existing framework i.e. driver/spi.
> >
> > From recend discussion, we go to know about framework change.
> > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >
> > We are in dilemma for sending FlexSPI driver upstream.
> > Do we follow existing framework i.e. driver/spi   or new proposed
> framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> >
> > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to
> become default.
> 
> Idea is to move spi-nor, mtd-spinor-working is paused because of non-dm
> drivers accessing. We are clear that we can't create another legacy layer to
> access spi-nor for the sake of non-dm driver to work which eventually
> ended-up another mess and also no one take care of non-dm conversion to
> dm if we give such feasibility. So we exported a deadline for full
> SPI/SPI_FLASH DM conversion till v2018.09. Once all these relevant
> conversion done, will try to move.
> 
This means, 
FlexSPI driver will not be accepted in driver/spi.  
It should follow u-boot-spi/drivers/mtd/spi-nor/  mtd-spinor-working branch

--pk

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Boris Brezillon]

Hi Jagan,

On Fri, 11 May 2018 11:30:43 +0530
Jagan Teki <jagannadh.teki@gmail.com> wrote:

> On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Dear Jagan,
> >
> > NXP is coming up with new FlexSPI controller. It is similar to existing QSPI with enhanced feature-set.
> > We have the driver ready as per existing framework i.e. driver/spi.
> >
> > From recend discussion, we go to know about framework change. Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >
> > We are in dilemma for sending FlexSPI driver upstream.
> > Do we follow existing framework i.e. driver/spi   or new proposed framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> >
> > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to become default.  
> 
> Idea is to move spi-nor, mtd-spinor-working is paused because of
> non-dm drivers accessing. We are clear that we can't create another
> legacy layer to access spi-nor for the sake of non-dm driver to work
> which eventually ended-up another mess and also no one take care of
> non-dm conversion to dm if we give such feasibility. So we exported a
> deadline for full SPI/SPI_FLASH DM conversion till v2018.09. Once all
> these relevant conversion done, will try to move.

Just for the record, the spi-mem interface has been accepted in Linux
[1] (should be there in 4.18). From now on, I'll try to encourage people
move existing spi-nor controller drivers to the SPI subsystem, and I'll
definitely ask new QPSI drivers to use this interface (and extend it if
needed).

So, I'm not sure creating this spi-nor subsystem in uboot is a good
idea anymore. Of course, it's up to you to decide, but if you take this
path you'll run into the same problem we had in Linux:

 - how to support SPI NANDs in a clean and efficient way
 - how to support both memory-like operations and regular SPI transfers
   with the same driver

Regards,

Boris

[1]https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git/commit/?h=for-4.18&id=c36ff266dc82f4ae797a6f3513c6ffa344f7f1c7

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Ashish Kumar]

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Friday, May 11, 2018 11:31 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun <york.sun@nxp.com>;
> Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; Poonam Aggrwal
> <poonam.aggrwal@nxp.com>; Ashish Kumar <ashish.kumar@nxp.com>; u-
> boot at lists.denx.de
> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?
> 
> On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Dear Jagan,
> >
> > NXP is coming up with new FlexSPI controller. It is similar to existing QSPI with
> enhanced feature-set.
> > We have the driver ready as per existing framework i.e. driver/spi.
> >
> > From recend discussion, we go to know about framework change.
> > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >
> > We are in dilemma for sending FlexSPI driver upstream.
> > Do we follow existing framework i.e. driver/spi   or new proposed framework
> i.e. u-boot-spi/drivers/mtd/spi-nor/
> >
> > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to become
> default.
> 
> Idea is to move spi-nor, mtd-spinor-working is paused because of non-dm
> drivers accessing. We are clear that we can't create another legacy layer to
> access spi-nor for the sake of non-dm driver to work which eventually ended-up
> another mess and also no one take care of non-dm conversion to dm if we give
> such feasibility. So we exported a deadline for full SPI/SPI_FLASH DM conversion
> till v2018.09. Once all these relevant conversion done, will try to move.
> 
Hello Jagan,

You have mentioned here http://git.denx.de/?p=u-boot-spi.git;a=commitdiff;h=c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8

Snip from above link: 
+Partially converted:
+       drivers/spi/atcspi200_spi.c
+       drivers/spi/davinci_spi.c
+       drivers/spi/fsl_dspi.c
+       drivers/spi/fsl_qspi.c

That fsl_qspi.c is partial converted to DM model, is there any guide line to follow for missing stuff ?

Regards
Ashish 
> [1]
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fgit.denx
> .de%2F%3Fp%3Du-boot-
> spi.git%3Ba%3Dcommitdiff%3Bh%3Dc4e68d3aa8178f6aa63a79c4f8f459c0e3ed
> 58e8&data=02%7C01%7Cashish.kumar%40nxp.com%7C2acd718de97d435bb5e
> c08d5b70489cd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C63661
> 6152533412247&sdata=ury1R6ZYqoJbx5nuYTehZyMTo%2BFW3QPpLD1EIPUrcz
> g%3D&reserved=0
> 
> Jagan.
> 
> --
> Jagan Teki
> Free Software Engineer |
> https://emea01.safelinks.protection.outlook.com/?url=www.openedev.com&d
> ata=02%7C01%7Cashish.kumar%40nxp.com%7C2acd718de97d435bb5ec08d5b7
> 0489cd%7C686ea1d3bc2b4c6fa92cd99c5c301635%7C0%7C0%7C636616152533
> 412247&sdata=gsoI52kSNfVEE6K%2F03CWs6%2FG2Xr1L9TEhDLGmqrRWRQ%3
> D&reserved=0
> U-Boot, Linux | Upstream Maintainer
> Hyderabad, India.

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Jagan Teki]

On Mon, May 14, 2018 at 2:42 PM, Ashish Kumar <ashish.kumar@nxp.com> wrote:
>
>
>> -----Original Message-----
>> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> Sent: Friday, May 11, 2018 11:31 AM
>> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun <york.sun@nxp.com>;
>> Yogesh Narayan Gaur <yogeshnarayan.gaur@nxp.com>; Poonam Aggrwal
>> <poonam.aggrwal@nxp.com>; Ashish Kumar <ashish.kumar@nxp.com>; u-
>> boot at lists.denx.de
>> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?
>>
>> On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
>> <prabhakar.kushwaha@nxp.com> wrote:
>> > Dear Jagan,
>> >
>> > NXP is coming up with new FlexSPI controller. It is similar to existing QSPI with
>> enhanced feature-set.
>> > We have the driver ready as per existing framework i.e. driver/spi.
>> >
>> > From recend discussion, we go to know about framework change.
>> > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
>> git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
>> >
>> > We are in dilemma for sending FlexSPI driver upstream.
>> > Do we follow existing framework i.e. driver/spi   or new proposed framework
>> i.e. u-boot-spi/drivers/mtd/spi-nor/
>> >
>> > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to become
>> default.
>>
>> Idea is to move spi-nor, mtd-spinor-working is paused because of non-dm
>> drivers accessing. We are clear that we can't create another legacy layer to
>> access spi-nor for the sake of non-dm driver to work which eventually ended-up
>> another mess and also no one take care of non-dm conversion to dm if we give
>> such feasibility. So we exported a deadline for full SPI/SPI_FLASH DM conversion
>> till v2018.09. Once all these relevant conversion done, will try to move.
>>
> Hello Jagan,
>
> You have mentioned here http://git.denx.de/?p=u-boot-spi.git;a=commitdiff;h=c4e68d3aa8178f6aa63a79c4f8f459c0e3ed58e8
>
> Snip from above link:
> +Partially converted:
> +       drivers/spi/atcspi200_spi.c
> +       drivers/spi/davinci_spi.c
> +       drivers/spi/fsl_dspi.c
> +       drivers/spi/fsl_qspi.c
>
> That fsl_qspi.c is partial converted to DM model, is there any guide line to follow for missing stuff ?

We should fully convert the driver into dm, no #ifdef CONFIG_DM_SPI

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

Thanks Jagan,

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Friday, May 11, 2018 11:31 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
> <york.sun@nxp.com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com>; Poonam Aggrwal
> <poonam.aggrwal@nxp.com>; Ashish Kumar <ashish.kumar@nxp.com>; u-
> boot at lists.denx.de
> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to
> use ?
> 
> On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Dear Jagan,
> >
> > NXP is coming up with new FlexSPI controller. It is similar to existing QSPI
> with enhanced feature-set.
> > We have the driver ready as per existing framework i.e. driver/spi.
> >
> > From recend discussion, we go to know about framework change.
> > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >
> > We are in dilemma for sending FlexSPI driver upstream.
> > Do we follow existing framework i.e. driver/spi   or new proposed
> framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> >
> > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to
> become default.
> 
> Idea is to move spi-nor, mtd-spinor-working is paused because of non-dm
> drivers accessing. 

This means, flexspi controller driver should be upstream'ed via u-boot-spi/drivers/mtd/spi-nor branch mtd-spinor-working

--pk

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

Dear Jagan,

> -----Original Message-----
> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> Prabhakar Kushwaha
> Sent: Monday, May 14, 2018 6:55 PM
> To: Jagan Teki <jagannadh.teki@gmail.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver location &
> framework to use ?
> 
> Thanks Jagan,
> 
> > -----Original Message-----
> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> > Sent: Friday, May 11, 2018 11:31 AM
> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
> > <york.sun@nxp.com>; Yogesh Narayan Gaur
> <yogeshnarayan.gaur@nxp.com>;
> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework
> > to use ?
> >
> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> > <prabhakar.kushwaha@nxp.com> wrote:
> > > Dear Jagan,
> > >
> > > NXP is coming up with new FlexSPI controller. It is similar to
> > > existing QSPI
> > with enhanced feature-set.
> > > We have the driver ready as per existing framework i.e. driver/spi.
> > >
> > > From recend discussion, we go to know about framework change.
> > > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> > >
> > > We are in dilemma for sending FlexSPI driver upstream.
> > > Do we follow existing framework i.e. driver/spi   or new proposed
> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> > >
> > > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to
> > become default.
> >
> > Idea is to move spi-nor, mtd-spinor-working is paused because of
> > non-dm drivers accessing.
> 
> This means, flexspi controller driver should be upstream'ed via u-boot-
> spi/drivers/mtd/spi-nor branch mtd-spinor-working
> 

Please help me with the query. 
We don’t want to end up with 2 FlexSPI drivers being posted in upstream. 

--pk

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Jagan Teki]

On Thu, May 17, 2018 at 4:49 PM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> Dear Jagan,
>
>> -----Original Message-----
>> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
>> Prabhakar Kushwaha
>> Sent: Monday, May 14, 2018 6:55 PM
>> To: Jagan Teki <jagannadh.teki@gmail.com>
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver location &
>> framework to use ?
>>
>> Thanks Jagan,
>>
>> > -----Original Message-----
>> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> > Sent: Friday, May 11, 2018 11:31 AM
>> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
>> > <york.sun@nxp.com>; Yogesh Narayan Gaur
>> <yogeshnarayan.gaur@nxp.com>;
>> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
>> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
>> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework
>> > to use ?
>> >
>> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
>> > <prabhakar.kushwaha@nxp.com> wrote:
>> > > Dear Jagan,
>> > >
>> > > NXP is coming up with new FlexSPI controller. It is similar to
>> > > existing QSPI
>> > with enhanced feature-set.
>> > > We have the driver ready as per existing framework i.e. driver/spi.
>> > >
>> > > From recend discussion, we go to know about framework change.
>> > > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
>> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
>> > >
>> > > We are in dilemma for sending FlexSPI driver upstream.
>> > > Do we follow existing framework i.e. driver/spi   or new proposed
>> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
>> > >
>> > > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/ to
>> > become default.
>> >
>> > Idea is to move spi-nor, mtd-spinor-working is paused because of
>> > non-dm drivers accessing.
>>
>> This means, flexspi controller driver should be upstream'ed via u-boot-
>> spi/drivers/mtd/spi-nor branch mtd-spinor-working
>>
>
> Please help me with the query.
> We don’t want to end up with 2 FlexSPI drivers being posted in upstream.

Let me understand is this FlexSPI is spi-nor controller, is it Linux
upstreamed or ML? I think for now you can add it mtd/spi with
UCLASS_SPI_FLASH driver, Since Boris mentioned about spi-mem(I still
need to see the Linux framework for more details) which may be
re-placer for spi-nor but once we decided to go with spi-mem or
spi-nor then the flexspi can convert accordingly.

Jagan.

-- 
Jagan Teki
Free Software Engineer | www.openedev.com
U-Boot, Linux | Upstream Maintainer
Hyderabad, India.

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

Dear Jagan,


> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Friday, May 18, 2018 10:24 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to
> use ?
> 
> On Thu, May 17, 2018 at 4:49 PM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Dear Jagan,
> >
> >> -----Original Message-----
> >> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> >> Prabhakar Kushwaha
> >> Sent: Monday, May 14, 2018 6:55 PM
> >> To: Jagan Teki <jagannadh.teki@gmail.com>
> >> Cc: u-boot at lists.denx.de
> >> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver location &
> >> framework to use ?
> >>
> >> Thanks Jagan,
> >>
> >> > -----Original Message-----
> >> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> > Sent: Friday, May 11, 2018 11:31 AM
> >> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
> >> > <york.sun@nxp.com>; Yogesh Narayan Gaur
> >> <yogeshnarayan.gaur@nxp.com>;
> >> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
> >> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
> >> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
> >> > framework to use ?
> >> >
> >> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> >> > <prabhakar.kushwaha@nxp.com> wrote:
> >> > > Dear Jagan,
> >> > >
> >> > > NXP is coming up with new FlexSPI controller. It is similar to
> >> > > existing QSPI
> >> > with enhanced feature-set.
> >> > > We have the driver ready as per existing framework i.e. driver/spi.
> >> > >
> >> > > From recend discussion, we go to know about framework change.
> >> > > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> >> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >> > >
> >> > > We are in dilemma for sending FlexSPI driver upstream.
> >> > > Do we follow existing framework i.e. driver/spi   or new proposed
> >> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> >> > >
> >> > > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/
> >> > > to
> >> > become default.
> >> >
> >> > Idea is to move spi-nor, mtd-spinor-working is paused because of
> >> > non-dm drivers accessing.
> >>
> >> This means, flexspi controller driver should be upstream'ed via
> >> u-boot- spi/drivers/mtd/spi-nor branch mtd-spinor-working
> >>
> >
> > Please help me with the query.
> > We don’t want to end up with 2 FlexSPI drivers being posted in upstream.
> 
> Let me understand is this FlexSPI is spi-nor controller, is it Linux upstreamed
> or ML? 

RFC patch http://patchwork.ozlabs.org/patch/894918/ is under discussion.
It is with assumption of driver/mtd/spi-nor


> I think for now you can add it mtd/spi with UCLASS_SPI_FLASH driver,
> Since Boris mentioned about spi-mem(I still need to see the Linux framework
> for more details) which may be re-placer for spi-nor but once we decided to
> go with spi-mem or spi-nor then the flexspi can convert accordingly.
> 

This means,  FlexSPI should be part of driver/mtd/spi-nor for now. 
When You decide way forward(mtd/spi or spi-mem), flexSPI driver can move accordingly.

Thanks

--pk 

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Jagan Teki]

On Fri, May 18, 2018 at 10:31 AM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> Dear Jagan,
>
>
>> -----Original Message-----
>> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> Sent: Friday, May 18, 2018 10:24 AM
>> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> Cc: u-boot at lists.denx.de
>> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to
>> use ?
>>
>> On Thu, May 17, 2018 at 4:49 PM, Prabhakar Kushwaha
>> <prabhakar.kushwaha@nxp.com> wrote:
>> > Dear Jagan,
>> >
>> >> -----Original Message-----
>> >> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
>> >> Prabhakar Kushwaha
>> >> Sent: Monday, May 14, 2018 6:55 PM
>> >> To: Jagan Teki <jagannadh.teki@gmail.com>
>> >> Cc: u-boot at lists.denx.de
>> >> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver location &
>> >> framework to use ?
>> >>
>> >> Thanks Jagan,
>> >>
>> >> > -----Original Message-----
>> >> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> >> > Sent: Friday, May 11, 2018 11:31 AM
>> >> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> >> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
>> >> > <york.sun@nxp.com>; Yogesh Narayan Gaur
>> >> <yogeshnarayan.gaur@nxp.com>;
>> >> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
>> >> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
>> >> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
>> >> > framework to use ?
>> >> >
>> >> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
>> >> > <prabhakar.kushwaha@nxp.com> wrote:
>> >> > > Dear Jagan,
>> >> > >
>> >> > > NXP is coming up with new FlexSPI controller. It is similar to
>> >> > > existing QSPI
>> >> > with enhanced feature-set.
>> >> > > We have the driver ready as per existing framework i.e. driver/spi.
>> >> > >
>> >> > > From recend discussion, we go to know about framework change.
>> >> > > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
>> >> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
>> >> > >
>> >> > > We are in dilemma for sending FlexSPI driver upstream.
>> >> > > Do we follow existing framework i.e. driver/spi   or new proposed
>> >> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
>> >> > >
>> >> > > Also, do we have any timeline of u-boot-spi/drivers/mtd/spi-nor/
>> >> > > to
>> >> > become default.
>> >> >
>> >> > Idea is to move spi-nor, mtd-spinor-working is paused because of
>> >> > non-dm drivers accessing.
>> >>
>> >> This means, flexspi controller driver should be upstream'ed via
>> >> u-boot- spi/drivers/mtd/spi-nor branch mtd-spinor-working
>> >>
>> >
>> > Please help me with the query.
>> > We don’t want to end up with 2 FlexSPI drivers being posted in upstream.
>>
>> Let me understand is this FlexSPI is spi-nor controller, is it Linux upstreamed
>> or ML?
>
> RFC patch http://patchwork.ozlabs.org/patch/894918/ is under discussion.
> It is with assumption of driver/mtd/spi-nor

Ohh, there is chance to move this to spi-mem is it?

>
>> I think for now you can add it mtd/spi with UCLASS_SPI_FLASH driver,
>> Since Boris mentioned about spi-mem(I still need to see the Linux framework
>> for more details) which may be re-placer for spi-nor but once we decided to
>> go with spi-mem or spi-nor then the flexspi can convert accordingly.
>>
>
> This means,  FlexSPI should be part of driver/mtd/spi-nor for now.
> When You decide way forward(mtd/spi or spi-mem), flexSPI driver can move accordingly.

Due to spi-mem, I'm holding spi-nor driver as of now. we need some
discussion to understand how we implement it in U-Boot and decide to
move further. So I suggest you to use existing sf where we can write
UCLASS_SPI_FLASH driver. Hope you understand.

Jagan.

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

Hi Jagan,

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Friday, May 18, 2018 11:54 AM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?
> 
> On Fri, May 18, 2018 at 10:31 AM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Dear Jagan,
> >
> >
> >> -----Original Message-----
> >> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> Sent: Friday, May 18, 2018 10:24 AM
> >> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> Cc: u-boot at lists.denx.de
> >> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
> >> framework to use ?
> >>
> >> On Thu, May 17, 2018 at 4:49 PM, Prabhakar Kushwaha
> >> <prabhakar.kushwaha@nxp.com> wrote:
> >> > Dear Jagan,
> >> >
> >> >> -----Original Message-----
> >> >> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> >> >> Prabhakar Kushwaha
> >> >> Sent: Monday, May 14, 2018 6:55 PM
> >> >> To: Jagan Teki <jagannadh.teki@gmail.com>
> >> >> Cc: u-boot at lists.denx.de
> >> >> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver
> >> >> location & framework to use ?
> >> >>
> >> >> Thanks Jagan,
> >> >>
> >> >> > -----Original Message-----
> >> >> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> >> > Sent: Friday, May 11, 2018 11:31 AM
> >> >> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> >> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
> >> >> > <york.sun@nxp.com>; Yogesh Narayan Gaur
> >> >> <yogeshnarayan.gaur@nxp.com>;
> >> >> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
> >> >> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
> >> >> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
> >> >> > framework to use ?
> >> >> >
> >> >> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> >> >> > <prabhakar.kushwaha@nxp.com> wrote:
> >> >> > > Dear Jagan,
> >> >> > >
> >> >> > > NXP is coming up with new FlexSPI controller. It is similar to
> >> >> > > existing QSPI
> >> >> > with enhanced feature-set.
> >> >> > > We have the driver ready as per existing framework i.e. driver/spi.
> >> >> > >
> >> >> > > From recend discussion, we go to know about framework change.
> >> >> > > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
> >> >> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >> >> > >
> >> >> > > We are in dilemma for sending FlexSPI driver upstream.
> >> >> > > Do we follow existing framework i.e. driver/spi   or new proposed
> >> >> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> >> >> > >
> >> >> > > Also, do we have any timeline of
> >> >> > > u-boot-spi/drivers/mtd/spi-nor/ to
> >> >> > become default.
> >> >> >
> >> >> > Idea is to move spi-nor, mtd-spinor-working is paused because of
> >> >> > non-dm drivers accessing.
> >> >>
> >> >> This means, flexspi controller driver should be upstream'ed via
> >> >> u-boot- spi/drivers/mtd/spi-nor branch mtd-spinor-working
> >> >>
> >> >
> >> > Please help me with the query.
> >> > We don’t want to end up with 2 FlexSPI drivers being posted in upstream.
> >>
> >> Let me understand is this FlexSPI is spi-nor controller, is it Linux
> >> upstreamed or ML?
> >
> > RFC patch
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchw
> ork.ozlabs.org%2Fpatch%2F894918%2F&data=02%7C01%7Cprabhakar.kushwah
> a%40nxp.com%7C32aaec29f75b416004ec08d5bc87f8f1%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C636622214533987461&sdata=%2F8i9vHtQF1
> S5Q6Bn65HVNPIMe%2FI6eSvP%2FKmKs1gxA8U%3D&reserved=0 is under
> discussion.
> > It is with assumption of driver/mtd/spi-nor
> 
> Ohh, there is chance to move this to spi-mem is it?
> 
> >
> >> I think for now you can add it mtd/spi with UCLASS_SPI_FLASH driver,
> >> Since Boris mentioned about spi-mem(I still need to see the Linux
> >> framework for more details) which may be re-placer for spi-nor but
> >> once we decided to go with spi-mem or spi-nor then the flexspi can convert
> accordingly.
> >>
> >
> > This means,  FlexSPI should be part of driver/mtd/spi-nor for now.
> > When You decide way forward(mtd/spi or spi-mem), flexSPI driver can move
> accordingly.
> 
> Due to spi-mem, I'm holding spi-nor driver as of now. we need some discussion
> to understand how we implement it in U-Boot and decide to move further. So I
> suggest you to use existing sf where we can write UCLASS_SPI_FLASH driver.
> Hope you understand.
> 

For now, sent FlexSPI driver as per current framework i.e. driver/mtd/spi.

Wait for the new framework(either spi-mem or driver/mtd) from you. 
Once framework available migrate to that one.

Is my understanding correct?

--pk

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Jagan Teki]

On Fri, May 18, 2018 at 3:46 PM, Prabhakar Kushwaha
<prabhakar.kushwaha@nxp.com> wrote:
> Hi Jagan,
>
>> -----Original Message-----
>> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> Sent: Friday, May 18, 2018 11:54 AM
>> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> Cc: u-boot at lists.denx.de
>> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?
>>
>> On Fri, May 18, 2018 at 10:31 AM, Prabhakar Kushwaha
>> <prabhakar.kushwaha@nxp.com> wrote:
>> > Dear Jagan,
>> >
>> >
>> >> -----Original Message-----
>> >> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> >> Sent: Friday, May 18, 2018 10:24 AM
>> >> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> >> Cc: u-boot at lists.denx.de
>> >> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
>> >> framework to use ?
>> >>
>> >> On Thu, May 17, 2018 at 4:49 PM, Prabhakar Kushwaha
>> >> <prabhakar.kushwaha@nxp.com> wrote:
>> >> > Dear Jagan,
>> >> >
>> >> >> -----Original Message-----
>> >> >> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
>> >> >> Prabhakar Kushwaha
>> >> >> Sent: Monday, May 14, 2018 6:55 PM
>> >> >> To: Jagan Teki <jagannadh.teki@gmail.com>
>> >> >> Cc: u-boot at lists.denx.de
>> >> >> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver
>> >> >> location & framework to use ?
>> >> >>
>> >> >> Thanks Jagan,
>> >> >>
>> >> >> > -----Original Message-----
>> >> >> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
>> >> >> > Sent: Friday, May 11, 2018 11:31 AM
>> >> >> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
>> >> >> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
>> >> >> > <york.sun@nxp.com>; Yogesh Narayan Gaur
>> >> >> <yogeshnarayan.gaur@nxp.com>;
>> >> >> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
>> >> >> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
>> >> >> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
>> >> >> > framework to use ?
>> >> >> >
>> >> >> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
>> >> >> > <prabhakar.kushwaha@nxp.com> wrote:
>> >> >> > > Dear Jagan,
>> >> >> > >
>> >> >> > > NXP is coming up with new FlexSPI controller. It is similar to
>> >> >> > > existing QSPI
>> >> >> > with enhanced feature-set.
>> >> >> > > We have the driver ready as per existing framework i.e. driver/spi.
>> >> >> > >
>> >> >> > > From recend discussion, we go to know about framework change.
>> >> >> > > Migration of qspi drivers in u-boot-spi/drivers/mtd/spi-nor/
>> >> >> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
>> >> >> > >
>> >> >> > > We are in dilemma for sending FlexSPI driver upstream.
>> >> >> > > Do we follow existing framework i.e. driver/spi   or new proposed
>> >> >> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
>> >> >> > >
>> >> >> > > Also, do we have any timeline of
>> >> >> > > u-boot-spi/drivers/mtd/spi-nor/ to
>> >> >> > become default.
>> >> >> >
>> >> >> > Idea is to move spi-nor, mtd-spinor-working is paused because of
>> >> >> > non-dm drivers accessing.
>> >> >>
>> >> >> This means, flexspi controller driver should be upstream'ed via
>> >> >> u-boot- spi/drivers/mtd/spi-nor branch mtd-spinor-working
>> >> >>
>> >> >
>> >> > Please help me with the query.
>> >> > We don’t want to end up with 2 FlexSPI drivers being posted in upstream.
>> >>
>> >> Let me understand is this FlexSPI is spi-nor controller, is it Linux
>> >> upstreamed or ML?
>> >
>> > RFC patch
>> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpatchw
>> ork.ozlabs.org%2Fpatch%2F894918%2F&data=02%7C01%7Cprabhakar.kushwah
>> a%40nxp.com%7C32aaec29f75b416004ec08d5bc87f8f1%7C686ea1d3bc2b4c6f
>> a92cd99c5c301635%7C0%7C0%7C636622214533987461&sdata=%2F8i9vHtQF1
>> S5Q6Bn65HVNPIMe%2FI6eSvP%2FKmKs1gxA8U%3D&reserved=0 is under
>> discussion.
>> > It is with assumption of driver/mtd/spi-nor
>>
>> Ohh, there is chance to move this to spi-mem is it?
>>
>> >
>> >> I think for now you can add it mtd/spi with UCLASS_SPI_FLASH driver,
>> >> Since Boris mentioned about spi-mem(I still need to see the Linux
>> >> framework for more details) which may be re-placer for spi-nor but
>> >> once we decided to go with spi-mem or spi-nor then the flexspi can convert
>> accordingly.
>> >>
>> >
>> > This means,  FlexSPI should be part of driver/mtd/spi-nor for now.
>> > When You decide way forward(mtd/spi or spi-mem), flexSPI driver can move
>> accordingly.
>>
>> Due to spi-mem, I'm holding spi-nor driver as of now. we need some discussion
>> to understand how we implement it in U-Boot and decide to move further. So I
>> suggest you to use existing sf where we can write UCLASS_SPI_FLASH driver.
>> Hope you understand.
>>
>
> For now, sent FlexSPI driver as per current framework i.e. driver/mtd/spi.
>
> Wait for the new framework(either spi-mem or driver/mtd) from you.
> Once framework available migrate to that one.
>
> Is my understanding correct?

Yes.

[U-Boot] mtd: spi-nor: new NXP FlexSPI driver location & framework to use ?

[Prabhakar Kushwaha]

HI Jagan,

> -----Original Message-----
> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> Sent: Monday, May 21, 2018 8:36 PM
> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> Cc: u-boot at lists.denx.de
> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to
> use ?
> 
> On Fri, May 18, 2018 at 3:46 PM, Prabhakar Kushwaha
> <prabhakar.kushwaha@nxp.com> wrote:
> > Hi Jagan,
> >
> >> -----Original Message-----
> >> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> Sent: Friday, May 18, 2018 11:54 AM
> >> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> Cc: u-boot at lists.denx.de
> >> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location & framework to
> use ?
> >>
> >> On Fri, May 18, 2018 at 10:31 AM, Prabhakar Kushwaha
> >> <prabhakar.kushwaha@nxp.com> wrote:
> >> > Dear Jagan,
> >> >
> >> >
> >> >> -----Original Message-----
> >> >> From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> >> Sent: Friday, May 18, 2018 10:24 AM
> >> >> To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> >> Cc: u-boot at lists.denx.de
> >> >> Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
> >> >> framework to use ?
> >> >>
> >> >> On Thu, May 17, 2018 at 4:49 PM, Prabhakar Kushwaha
> >> >> <prabhakar.kushwaha@nxp.com> wrote:
> >> >> > Dear Jagan,
> >> >> >
> >> >> >> -----Original Message-----
> >> >> >> From: U-Boot [mailto:u-boot-bounces at lists.denx.de] On Behalf Of
> >> >> >> Prabhakar Kushwaha
> >> >> >> Sent: Monday, May 14, 2018 6:55 PM
> >> >> >> To: Jagan Teki <jagannadh.teki@gmail.com>
> >> >> >> Cc: u-boot at lists.denx.de
> >> >> >> Subject: Re: [U-Boot] mtd: spi-nor: new NXP FlexSPI driver
> >> >> >> location & framework to use ?
> >> >> >>
> >> >> >> Thanks Jagan,
> >> >> >>
> >> >> >> > -----Original Message-----
> >> >> >> > From: Jagan Teki [mailto:jagannadh.teki at gmail.com]
> >> >> >> > Sent: Friday, May 11, 2018 11:31 AM
> >> >> >> > To: Prabhakar Kushwaha <prabhakar.kushwaha@nxp.com>
> >> >> >> > Cc: Jagan Teki <jagan@amarulasolutions.com>; York Sun
> >> >> >> > <york.sun@nxp.com>; Yogesh Narayan Gaur
> >> >> >> <yogeshnarayan.gaur@nxp.com>;
> >> >> >> > Poonam Aggrwal <poonam.aggrwal@nxp.com>; Ashish Kumar
> >> >> >> > <ashish.kumar@nxp.com>; u- boot at lists.denx.de
> >> >> >> > Subject: Re: mtd: spi-nor: new NXP FlexSPI driver location &
> >> >> >> > framework to use ?
> >> >> >> >
> >> >> >> > On Fri, May 11, 2018 at 11:08 AM, Prabhakar Kushwaha
> >> >> >> > <prabhakar.kushwaha@nxp.com> wrote:
> >> >> >> > > Dear Jagan,
> >> >> >> > >
> >> >> >> > > NXP is coming up with new FlexSPI controller. It is similar
> >> >> >> > > to existing QSPI
> >> >> >> > with enhanced feature-set.
> >> >> >> > > We have the driver ready as per existing framework i.e.
> driver/spi.
> >> >> >> > >
> >> >> >> > > From recend discussion, we go to know about framework
> change.
> >> >> >> > > Migration of qspi drivers in
> >> >> >> > > u-boot-spi/drivers/mtd/spi-nor/
> >> >> >> > git://git.denx.de/u-boot-spi.git branch mtd-spinor-working.
> >> >> >> > >
> >> >> >> > > We are in dilemma for sending FlexSPI driver upstream.
> >> >> >> > > Do we follow existing framework i.e. driver/spi   or new
> proposed
> >> >> >> > framework i.e. u-boot-spi/drivers/mtd/spi-nor/
> >> >> >> > >
> >> >> >> > > Also, do we have any timeline of
> >> >> >> > > u-boot-spi/drivers/mtd/spi-nor/ to
> >> >> >> > become default.
> >> >> >> >
> >> >> >> > Idea is to move spi-nor, mtd-spinor-working is paused because
> >> >> >> > of non-dm drivers accessing.
> >> >> >>
> >> >> >> This means, flexspi controller driver should be upstream'ed via
> >> >> >> u-boot- spi/drivers/mtd/spi-nor branch mtd-spinor-working
> >> >> >>
> >> >> >
> >> >> > Please help me with the query.
> >> >> > We don’t want to end up with 2 FlexSPI drivers being posted in
> upstream.
> >> >>
> >> >> Let me understand is this FlexSPI is spi-nor controller, is it
> >> >> Linux upstreamed or ML?
> >> >
> >> > RFC patch
> >>
> https://emea01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fpat
> >> chw
> >>
> ork.ozlabs.org%2Fpatch%2F894918%2F&data=02%7C01%7Cprabhakar.kushw
> ah
> >>
> a%40nxp.com%7C32aaec29f75b416004ec08d5bc87f8f1%7C686ea1d3bc2b4c6f
> >>
> a92cd99c5c301635%7C0%7C0%7C636622214533987461&sdata=%2F8i9vHtQF1
> >> S5Q6Bn65HVNPIMe%2FI6eSvP%2FKmKs1gxA8U%3D&reserved=0 is
> under
> >> discussion.
> >> > It is with assumption of driver/mtd/spi-nor
> >>
> >> Ohh, there is chance to move this to spi-mem is it?
> >>
> >> >
> >> >> I think for now you can add it mtd/spi with UCLASS_SPI_FLASH
> >> >> driver, Since Boris mentioned about spi-mem(I still need to see
> >> >> the Linux framework for more details) which may be re-placer for
> >> >> spi-nor but once we decided to go with spi-mem or spi-nor then the
> >> >> flexspi can convert
> >> accordingly.
> >> >>
> >> >
> >> > This means,  FlexSPI should be part of driver/mtd/spi-nor for now.
> >> > When You decide way forward(mtd/spi or spi-mem), flexSPI driver can
> >> > move
> >> accordingly.
> >>
> >> Due to spi-mem, I'm holding spi-nor driver as of now. we need some
> >> discussion to understand how we implement it in U-Boot and decide to
> >> move further. So I suggest you to use existing sf where we can write
> UCLASS_SPI_FLASH driver.
> >> Hope you understand.
> >>
> >
> > For now, sent FlexSPI driver as per current framework i.e. driver/mtd/spi.
> >

Sorry for confusion.

I meant sending patch under driver/spi for flexSPI and wait for your repos to get matured

--pk