[PATCH] dpaa_eth: enable NETIF_MSG_HW by default

[PATCH] dpaa_eth: enable NETIF_MSG_HW by default

[Vladimir Oltean]

From: Maxim Kochetkov <fido_max@inbox.ru>

When packets are received on the error queue, this function under
net_ratelimit():

netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");

does not get printed. Instead we only see:

[ 3658.845592] net_ratelimit: 244 callbacks suppressed
[ 3663.969535] net_ratelimit: 230 callbacks suppressed
[ 3669.085478] net_ratelimit: 228 callbacks suppressed

Enabling NETIF_MSG_HW fixes this issue, and we can see some information
about the frame descriptors of packets.

Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
---
 drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
index fdff3b4723ba..06cc863f4dd6 100644
--- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
+++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
@@ -87,7 +87,7 @@ MODULE_PARM_DESC(tx_timeout, "The Tx timeout in ms");
 
 #define DPAA_MSG_DEFAULT (NETIF_MSG_DRV | NETIF_MSG_PROBE | \
 			  NETIF_MSG_LINK | NETIF_MSG_IFUP | \
-			  NETIF_MSG_IFDOWN)
+			  NETIF_MSG_IFDOWN | NETIF_MSG_HW)
 
 #define DPAA_INGRESS_CS_THRESHOLD 0x10000000
 /* Ingress congestion threshold on FMan ports
-- 
2.25.1

Re: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default

[Vladimir Oltean]

On Thu, Oct 08, 2020 at 03:03:12PM +0300, Vladimir Oltean wrote:
> From: Maxim Kochetkov <fido_max@inbox.ru>
> 
> When packets are received on the error queue, this function under
> net_ratelimit():
> 
> netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
> 
> does not get printed. Instead we only see:
> 
> [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> [ 3669.085478] net_ratelimit: 228 callbacks suppressed
> 
> Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> about the frame descriptors of packets.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---

I'm sorry for failing to mention the target tree in the email subject.
This is directed towards net-next.

RE: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default

[Madalin Bucur (OSS)]

> -----Original Message-----
> From: Vladimir Oltean <vladimir.oltean@nxp.com>
> To: davem@davemloft.net
> Subject: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default
> 
> From: Maxim Kochetkov <fido_max@inbox.ru>
> 
> When packets are received on the error queue, this function under
> net_ratelimit():
> 
> netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
> 
> does not get printed. Instead we only see:
> 
> [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> [ 3669.085478] net_ratelimit: 228 callbacks suppressed
> 
> Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> about the frame descriptors of packets.
> 
> Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> ---
>  drivers/net/ethernet/freescale/dpaa/dpaa_eth.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> index fdff3b4723ba..06cc863f4dd6 100644
> --- a/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> +++ b/drivers/net/ethernet/freescale/dpaa/dpaa_eth.c
> @@ -87,7 +87,7 @@ MODULE_PARM_DESC(tx_timeout, "The Tx timeout in ms");
> 
>  #define DPAA_MSG_DEFAULT (NETIF_MSG_DRV | NETIF_MSG_PROBE | \
>  			  NETIF_MSG_LINK | NETIF_MSG_IFUP | \
> -			  NETIF_MSG_IFDOWN)
> +			  NETIF_MSG_IFDOWN | NETIF_MSG_HW)
> 
>  #define DPAA_INGRESS_CS_THRESHOLD 0x10000000
>  /* Ingress congestion threshold on FMan ports
> --
> 2.25.1

Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com>

Re: [PATCH] dpaa_eth: enable NETIF_MSG_HW by default

[Jakub Kicinski]

On Thu, 8 Oct 2020 14:37:44 +0000 Madalin Bucur (OSS) wrote:
> > From: Maxim Kochetkov <fido_max@inbox.ru>
> > 
> > When packets are received on the error queue, this function under
> > net_ratelimit():
> > 
> > netif_err(priv, hw, net_dev, "Err FD status = 0x%08x\n");
> > 
> > does not get printed. Instead we only see:
> > 
> > [ 3658.845592] net_ratelimit: 244 callbacks suppressed
> > [ 3663.969535] net_ratelimit: 230 callbacks suppressed
> > [ 3669.085478] net_ratelimit: 228 callbacks suppressed
> > 
> > Enabling NETIF_MSG_HW fixes this issue, and we can see some information
> > about the frame descriptors of packets.
> > 
> > Signed-off-by: Maxim Kochetkov <fido_max@inbox.ru>
> > Signed-off-by: Vladimir Oltean <vladimir.oltean@nxp.com>
> 
> Reviewed-by: Madalin Bucur <madalin.bucur@oss.nxp.com>

Applied, thanks everyone!