From: Aisheng Dong <aisheng.dong@nxp.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Cc: Jassi Brar <jassisinghbrar@gmail.com>, Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com>, dl-linux-imx <linux-imx@nxp.com> Subject: RE: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU Date: Mon, 13 Jul 2020 10:03:41 +0000 [thread overview] Message-ID: <AM6PR04MB496663205D0EE8E6EEF731F680600@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200706150013.35326-1-vincenzo.frascino@arm.com> > From: Vincenzo Frascino <vincenzo.frascino@arm.com> > Sent: Monday, July 6, 2020 11:00 PM > > imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only > when CONFIG_PM_SLEEP configuration options is enabled. Having it disabled > triggers the following warning at compile time: > > drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_resume_noirq(struct device *dev) > > drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_suspend_noirq(struct device *dev) > > Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to > address the issue. > > Cc: Jassi Brar <jassisinghbrar@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> There's already a fix: https://lkml.org/lkml/2020/6/22/1555 Regards Aisheng > --- > drivers/mailbox/imx-mailbox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c > index 7205b825c8b5..f54f36948414 100644 > --- a/drivers/mailbox/imx-mailbox.c > +++ b/drivers/mailbox/imx-mailbox.c > @@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = { }; > MODULE_DEVICE_TABLE(of, imx_mu_dt_ids); > > -static int imx_mu_suspend_noirq(struct device *dev) > +static int __maybe_unused imx_mu_suspend_noirq(struct device *dev) > { > struct imx_mu_priv *priv = dev_get_drvdata(dev); > > @@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev) > return 0; > } > > -static int imx_mu_resume_noirq(struct device *dev) > +static int __maybe_unused imx_mu_resume_noirq(struct device *dev) > { > struct imx_mu_priv *priv = dev_get_drvdata(dev); > > -- > 2.27.0
WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com> To: Vincenzo Frascino <vincenzo.frascino@arm.com>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org> Cc: Shawn Guo <shawnguo@kernel.org>, Sascha Hauer <s.hauer@pengutronix.de>, Jassi Brar <jassisinghbrar@gmail.com>, dl-linux-imx <linux-imx@nxp.com>, Pengutronix Kernel Team <kernel@pengutronix.de>, Fabio Estevam <festevam@gmail.com> Subject: RE: [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU Date: Mon, 13 Jul 2020 10:03:41 +0000 [thread overview] Message-ID: <AM6PR04MB496663205D0EE8E6EEF731F680600@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw) In-Reply-To: <20200706150013.35326-1-vincenzo.frascino@arm.com> > From: Vincenzo Frascino <vincenzo.frascino@arm.com> > Sent: Monday, July 6, 2020 11:00 PM > > imx_mu_suspend_noirq()/imx_mu_resume_noirq() are currently used only > when CONFIG_PM_SLEEP configuration options is enabled. Having it disabled > triggers the following warning at compile time: > > drivers/mailbox/imx-mailbox.c:611:12: warning: ‘imx_mu_resume_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_resume_noirq(struct device *dev) > > drivers/mailbox/imx-mailbox.c:601:12: warning: ‘imx_mu_suspend_noirq’ > defined but not used [-Wunused-function] > static int imx_mu_suspend_noirq(struct device *dev) > > Make imx_mu_suspend_noirq()/imx_mu_resume_noirq() __maybe_unused to > address the issue. > > Cc: Jassi Brar <jassisinghbrar@gmail.com> > Cc: Shawn Guo <shawnguo@kernel.org> > Cc: Sascha Hauer <s.hauer@pengutronix.de> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de> > Cc: Fabio Estevam <festevam@gmail.com> > Cc: NXP Linux Team <linux-imx@nxp.com> > Signed-off-by: Vincenzo Frascino <vincenzo.frascino@arm.com> There's already a fix: https://lkml.org/lkml/2020/6/22/1555 Regards Aisheng > --- > drivers/mailbox/imx-mailbox.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/mailbox/imx-mailbox.c b/drivers/mailbox/imx-mailbox.c > index 7205b825c8b5..f54f36948414 100644 > --- a/drivers/mailbox/imx-mailbox.c > +++ b/drivers/mailbox/imx-mailbox.c > @@ -598,7 +598,7 @@ static const struct of_device_id imx_mu_dt_ids[] = { }; > MODULE_DEVICE_TABLE(of, imx_mu_dt_ids); > > -static int imx_mu_suspend_noirq(struct device *dev) > +static int __maybe_unused imx_mu_suspend_noirq(struct device *dev) > { > struct imx_mu_priv *priv = dev_get_drvdata(dev); > > @@ -608,7 +608,7 @@ static int imx_mu_suspend_noirq(struct device *dev) > return 0; > } > > -static int imx_mu_resume_noirq(struct device *dev) > +static int __maybe_unused imx_mu_resume_noirq(struct device *dev) > { > struct imx_mu_priv *priv = dev_get_drvdata(dev); > > -- > 2.27.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-07-13 10:03 UTC|newest] Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top 2020-07-06 15:00 [PATCH] drivers: soc: Fix mailbox suspend/resume no irq for IMX SCU Vincenzo Frascino 2020-07-06 15:00 ` Vincenzo Frascino 2020-07-06 15:12 ` Daniel Baluta 2020-07-06 15:12 ` Daniel Baluta 2020-07-13 10:03 ` Aisheng Dong [this message] 2020-07-13 10:03 ` Aisheng Dong
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM6PR04MB496663205D0EE8E6EEF731F680600@AM6PR04MB4966.eurprd04.prod.outlook.com \ --to=aisheng.dong@nxp.com \ --cc=festevam@gmail.com \ --cc=jassisinghbrar@gmail.com \ --cc=kernel@pengutronix.de \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=vincenzo.frascino@arm.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.