* [PATCH] Documentation: pinctrl: imx7ulp: fix incorrect pin CONFIG settings
@ 2020-11-27 15:06 Louis Rannou
2020-11-30 3:02 ` Aisheng Dong
0 siblings, 1 reply; 2+ messages in thread
From: Louis Rannou @ 2020-11-27 15:06 UTC (permalink / raw)
To: Dong Aisheng, linux-gpio; +Cc: Pengutronix Kernel Team, Louis Rannou
According to the imx7ulp reference manual, the LSB refers to PS (Pull Select Field) and
the 2nd to PE (Pull-up Enable).
Signed-off-by: Louis Rannou <louis.rannou@enlaps.fr>
---
.../devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
index bfa3703a7446..50ae260581eb 100644
--- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
+++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
@@ -33,7 +33,8 @@ PAD_CTL_ODE (1 << 5)
PAD_CTL_PUSH_PULL (0 << 5)
PAD_CTL_SRE_SLOW (1 << 2)
PAD_CTL_SRE_STD (0 << 2)
-PAD_CTL_PE (1 << 0)
+PAD_CTL_PE (1 << 1)
+PAD_CTL_PS (1 << 0)
Examples:
#include "imx7ulp-pinfunc.h"
--
2.29.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* RE: [PATCH] Documentation: pinctrl: imx7ulp: fix incorrect pin CONFIG settings
2020-11-27 15:06 [PATCH] Documentation: pinctrl: imx7ulp: fix incorrect pin CONFIG settings Louis Rannou
@ 2020-11-30 3:02 ` Aisheng Dong
0 siblings, 0 replies; 2+ messages in thread
From: Aisheng Dong @ 2020-11-30 3:02 UTC (permalink / raw)
To: Louis Rannou, linux-gpio; +Cc: Pengutronix Kernel Team, Louis Rannou
> From: Louis Rannou <louis@enlaps.fr>
> Sent: Friday, November 27, 2020 11:06 PM
> Subject: [PATCH] Documentation: pinctrl: imx7ulp: fix incorrect pin CONFIG
> settings
>
> According to the imx7ulp reference manual, the LSB refers to PS (Pull Select Field)
> and the 2nd to PE (Pull-up Enable).
>
> Signed-off-by: Louis Rannou <louis.rannou@enlaps.fr>
The title may be better to be:
dt-bindings: pinctrl: imx7ulp: fix incorrect pin CONFIG
Otherwise:
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
> ---
> .../devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
> b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
> index bfa3703a7446..50ae260581eb 100644
> --- a/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
> +++ b/Documentation/devicetree/bindings/pinctrl/fsl,imx7ulp-pinctrl.txt
> @@ -33,7 +33,8 @@ PAD_CTL_ODE (1 << 5)
> PAD_CTL_PUSH_PULL (0 << 5)
> PAD_CTL_SRE_SLOW (1 << 2)
> PAD_CTL_SRE_STD (0 << 2)
> -PAD_CTL_PE (1 << 0)
> +PAD_CTL_PE (1 << 1)
> +PAD_CTL_PS (1 << 0)
>
> Examples:
> #include "imx7ulp-pinfunc.h"
> --
> 2.29.2
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-30 3:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-27 15:06 [PATCH] Documentation: pinctrl: imx7ulp: fix incorrect pin CONFIG settings Louis Rannou
2020-11-30 3:02 ` Aisheng Dong
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.