From: Aisheng Dong <aisheng.dong@nxp.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Alexandre Bailon <abailon@baylibre.com>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: Hulk Robot <hulkci@huawei.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH -next] interconnect: imx: Fix return value check in imx_icc_node_init_qos()
Date: Sat, 09 May 2020 03:51:19 +0000 [thread overview]
Message-ID: <AM6PR04MB4966FFE3C487D217A91B070280A30@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200509030214.14435-1-weiyongjun1@huawei.com>
PiBGcm9tOiBXZWkgWW9uZ2p1biA8d2VpeW9uZ2p1bjFAaHVhd2VpLmNvbT4NCj4gU2VudDogU2F0
dXJkYXksIE1heSA5LCAyMDIwIDExOjAyIEFNDQo+IA0KPiBJbiBjYXNlIG9mIGVycm9yLCB0aGUg
ZnVuY3Rpb24gb2ZfcGFyc2VfcGhhbmRsZSgpIHJldHVybnMgTlVMTCBwb2ludGVyIG5vdA0KPiBF
UlJfUFRSKCkuIFRoZSBJU19FUlIoKSB0ZXN0IGluIHRoZSByZXR1cm4gdmFsdWUgY2hlY2sgc2hv
dWxkIGJlIHJlcGxhY2VkIHdpdGgNCj4gTlVMTCB0ZXN0Lg0KPiANCj4gRml4ZXM6IGYwZDgwNDg1
MjVkNyAoImludGVyY29ubmVjdDogQWRkIGlteCBjb3JlIGRyaXZlciIpDQo+IFJlcG9ydGVkLWJ5
OiBIdWxrIFJvYm90IDxodWxrY2lAaHVhd2VpLmNvbT4NCj4gU2lnbmVkLW9mZi1ieTogV2VpIFlv
bmdqdW4gPHdlaXlvbmdqdW4xQGh1YXdlaS5jb20+DQoNClJldmlld2VkLWJ5OiBEb25nIEFpc2hl
bmcgPGFpc2hlbmcuZG9uZ0BueHAuY29tPg0KDQpSZWdhcmRzDQpBaXNoZW5nDQo
WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Alexandre Bailon <abailon@baylibre.com>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: "linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>, Hulk Robot <hulkci@huawei.com>
Subject: RE: [PATCH -next] interconnect: imx: Fix return value check in imx_icc_node_init_qos()
Date: Sat, 9 May 2020 03:51:19 +0000 [thread overview]
Message-ID: <AM6PR04MB4966FFE3C487D217A91B070280A30@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200509030214.14435-1-weiyongjun1@huawei.com>
> From: Wei Yongjun <weiyongjun1@huawei.com>
> Sent: Saturday, May 9, 2020 11:02 AM
>
> In case of error, the function of_parse_phandle() returns NULL pointer not
> ERR_PTR(). The IS_ERR() test in the return value check should be replaced with
> NULL test.
>
> Fixes: f0d8048525d7 ("interconnect: Add imx core driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
WARNING: multiple messages have this Message-ID (diff)
From: Aisheng Dong <aisheng.dong@nxp.com>
To: Wei Yongjun <weiyongjun1@huawei.com>,
Georgi Djakov <georgi.djakov@linaro.org>,
Shawn Guo <shawnguo@kernel.org>,
Sascha Hauer <s.hauer@pengutronix.de>,
Pengutronix Kernel Team <kernel@pengutronix.de>,
Fabio Estevam <festevam@gmail.com>,
dl-linux-imx <linux-imx@nxp.com>,
Alexandre Bailon <abailon@baylibre.com>,
Leonard Crestez <leonard.crestez@nxp.com>
Cc: Hulk Robot <hulkci@huawei.com>,
"kernel-janitors@vger.kernel.org"
<kernel-janitors@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-pm@vger.kernel.org" <linux-pm@vger.kernel.org>
Subject: RE: [PATCH -next] interconnect: imx: Fix return value check in imx_icc_node_init_qos()
Date: Sat, 9 May 2020 03:51:19 +0000 [thread overview]
Message-ID: <AM6PR04MB4966FFE3C487D217A91B070280A30@AM6PR04MB4966.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20200509030214.14435-1-weiyongjun1@huawei.com>
> From: Wei Yongjun <weiyongjun1@huawei.com>
> Sent: Saturday, May 9, 2020 11:02 AM
>
> In case of error, the function of_parse_phandle() returns NULL pointer not
> ERR_PTR(). The IS_ERR() test in the return value check should be replaced with
> NULL test.
>
> Fixes: f0d8048525d7 ("interconnect: Add imx core driver")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Reviewed-by: Dong Aisheng <aisheng.dong@nxp.com>
Regards
Aisheng
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-09 3:51 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-09 2:58 [PATCH -next] interconnect: imx: Fix return value check in imx_icc_node_init_qos() Wei Yongjun
2020-05-09 3:02 ` Wei Yongjun
2020-05-09 3:02 ` Wei Yongjun
2020-05-09 3:51 ` Aisheng Dong [this message]
2020-05-09 3:51 ` Aisheng Dong
2020-05-09 3:51 ` Aisheng Dong
2020-05-11 13:20 ` Leonard Crestez
2020-05-11 13:20 ` Leonard Crestez
2020-05-11 13:20 ` Leonard Crestez
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM6PR04MB4966FFE3C487D217A91B070280A30@AM6PR04MB4966.eurprd04.prod.outlook.com \
--to=aisheng.dong@nxp.com \
--cc=abailon@baylibre.com \
--cc=festevam@gmail.com \
--cc=georgi.djakov@linaro.org \
--cc=hulkci@huawei.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kernel@pengutronix.de \
--cc=leonard.crestez@nxp.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-imx@nxp.com \
--cc=linux-pm@vger.kernel.org \
--cc=s.hauer@pengutronix.de \
--cc=shawnguo@kernel.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.