From: Joy Zou <joy.zou@nxp.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "vkoul@kernel.org" <vkoul@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com> Cc: "S.J. Wang" <shengjiu.wang@nxp.com>, "martink@posteo.de" <martink@posteo.de>, "dev@lynxeye.de" <dev@lynxeye.de>, "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>, Peng Fan <peng.fan@nxp.com>, "david@ixit.cz" <david@ixit.cz>, "aford173@gmail.com" <aford173@gmail.com>, Hongxing Zhu <hongxing.zhu@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [EXT] Re: [PATCH v7 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema Date: Fri, 21 Oct 2022 08:10:22 +0000 [thread overview] Message-ID: <AM6PR04MB5925C0AC7A4066AF52E2004CE12D9@AM6PR04MB5925.eurprd04.prod.outlook.com> (raw) In-Reply-To: <caae2af7-96ea-195f-6f33-05d9e79fa518@linaro.org> > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2022年10月21日 0:32 > To: Joy Zou <joy.zou@nxp.com>; vkoul@kernel.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com > Cc: S.J. Wang <shengjiu.wang@nxp.com>; martink@posteo.de; > dev@lynxeye.de; alexander.stein@ew.tq-group.com; Peng Fan > <peng.fan@nxp.com>; david@ixit.cz; aford173@gmail.com; Hongxing Zhu > <hongxing.zhu@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > dmaengine@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH v7 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma > to DT schema > > Caution: EXT Email > > On 20/10/2022 06:14, Joy Zou wrote: > > Convert the i.MX SDMA binding to DT schema format using json-schema. > > > > > > --- > > .../devicetree/bindings/dma/fsl,imx-sdma.yaml | 147 > > ++++++++++++++++++ .../devicetree/bindings/dma/fsl-imx-sdma.txt | > > 118 -------------- > > 2 files changed, 147 insertions(+), 118 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt > > > > diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > new file mode 100644 > > index 000000000000..3da65d3ea4af > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > @@ -0,0 +1,147 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fdma%2Ffsl%2Cimx-sdma.yaml%23&data=05 > %7C01% > > > +7Cjoy.zou%40nxp.com%7C405bb49028e340afdc9408dab2b89251%7C686ea > 1d3bc2b > > > +4c6fa92cd99c5c301635%7C0%7C0%7C638018803042580036%7CUnknown > %7CTWFpbGZ > > > +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > n0% > > > +3D%7C3000%7C%7C%7C&sdata=tgNngxTlIBOhIXt0VYJACNM%2FV%2F0 > LWCXyTYVr > > +rZ5PfoY%3D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cjoy.z > ou%4 > > > +0nxp.com%7C405bb49028e340afdc9408dab2b89251%7C686ea1d3bc2b4c6 > fa92cd99 > > > +c5c301635%7C0%7C0%7C638018803042580036%7CUnknown%7CTWFpbG > Zsb3d8eyJWIj > > > +oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7 > > > +C%7C%7C&sdata=MNltJ7MuOpabpjY%2FTdi8IDagtgiFz1vgUCUhs68ChV > U%3D&am > > +p;reserved=0 > > + > > +title: Freescale Smart Direct Memory Access (SDMA) Controller for > > +i.MX > > + > > +maintainers: > > + - Joy Zou <joy.zou@nxp.com> > > + > > You need to reference dma-controller.yaml schema. Thank you very much for your comments. I will add the dma-controller quotes. BR Joy Zou > > > +properties: > > + compatible: > > + oneOf: > > > (...) > > > + > > + gpr: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle to the General Purpose Register (GPR) > > + node > > + > > + fsl,sdma-event-remap: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + maxItems: 2 > > + items: > > + items: > > + - description: GPR register offset > > + - description: GPR register shift > > + - description: GPR register value > > + description: | > > + Register bits of sdma event remap, the format is <reg shift val>. > > + The order is <RX>, <TX>. > > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + items: > > + - const: ipg > > + - const: ahb > > + > > + iram: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle to the On-chip RAM (OCRAM) node. > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - fsl,sdma-ram-script-name > > + - "#dma-cells" > > and then this can one be dropped. Thanks your comments. I have tried to delete the additionalProperties, but I run dtbs_check. The log as follow: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property So I think the property may not be dropped. BR Joy Zou > > > + > > +additionalProperties: false > > Best regards, > Krzysztof
WARNING: multiple messages have this Message-ID (diff)
From: Joy Zou <joy.zou@nxp.com> To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, "vkoul@kernel.org" <vkoul@kernel.org>, "robh+dt@kernel.org" <robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>, "shawnguo@kernel.org" <shawnguo@kernel.org>, "s.hauer@pengutronix.de" <s.hauer@pengutronix.de>, "kernel@pengutronix.de" <kernel@pengutronix.de>, "festevam@gmail.com" <festevam@gmail.com> Cc: "S.J. Wang" <shengjiu.wang@nxp.com>, "martink@posteo.de" <martink@posteo.de>, "dev@lynxeye.de" <dev@lynxeye.de>, "alexander.stein@ew.tq-group.com" <alexander.stein@ew.tq-group.com>, Peng Fan <peng.fan@nxp.com>, "david@ixit.cz" <david@ixit.cz>, "aford173@gmail.com" <aford173@gmail.com>, Hongxing Zhu <hongxing.zhu@nxp.com>, dl-linux-imx <linux-imx@nxp.com>, "dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>, "devicetree@vger.kernel.org" <devicetree@vger.kernel.org>, "linux-arm-kernel@lists.infradead.org" <linux-arm-kernel@lists.infradead.org>, "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org> Subject: RE: [EXT] Re: [PATCH v7 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema Date: Fri, 21 Oct 2022 08:10:22 +0000 [thread overview] Message-ID: <AM6PR04MB5925C0AC7A4066AF52E2004CE12D9@AM6PR04MB5925.eurprd04.prod.outlook.com> (raw) In-Reply-To: <caae2af7-96ea-195f-6f33-05d9e79fa518@linaro.org> > -----Original Message----- > From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > Sent: 2022年10月21日 0:32 > To: Joy Zou <joy.zou@nxp.com>; vkoul@kernel.org; robh+dt@kernel.org; > krzysztof.kozlowski+dt@linaro.org; shawnguo@kernel.org; > s.hauer@pengutronix.de; kernel@pengutronix.de; festevam@gmail.com > Cc: S.J. Wang <shengjiu.wang@nxp.com>; martink@posteo.de; > dev@lynxeye.de; alexander.stein@ew.tq-group.com; Peng Fan > <peng.fan@nxp.com>; david@ixit.cz; aford173@gmail.com; Hongxing Zhu > <hongxing.zhu@nxp.com>; dl-linux-imx <linux-imx@nxp.com>; > dmaengine@vger.kernel.org; devicetree@vger.kernel.org; > linux-arm-kernel@lists.infradead.org; linux-kernel@vger.kernel.org > Subject: [EXT] Re: [PATCH v7 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma > to DT schema > > Caution: EXT Email > > On 20/10/2022 06:14, Joy Zou wrote: > > Convert the i.MX SDMA binding to DT schema format using json-schema. > > > > > > --- > > .../devicetree/bindings/dma/fsl,imx-sdma.yaml | 147 > > ++++++++++++++++++ .../devicetree/bindings/dma/fsl-imx-sdma.txt | > > 118 -------------- > > 2 files changed, 147 insertions(+), 118 deletions(-) create mode > > 100644 Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > delete mode 100644 > > Documentation/devicetree/bindings/dma/fsl-imx-sdma.txt > > > > diff --git a/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > new file mode 100644 > > index 000000000000..3da65d3ea4af > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/dma/fsl,imx-sdma.yaml > > @@ -0,0 +1,147 @@ > > +# SPDX-License-Identifier: GPL-2.0-only OR BSD-2-Clause %YAML 1.2 > > +--- > > +$id: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fschemas%2Fdma%2Ffsl%2Cimx-sdma.yaml%23&data=05 > %7C01% > > > +7Cjoy.zou%40nxp.com%7C405bb49028e340afdc9408dab2b89251%7C686ea > 1d3bc2b > > > +4c6fa92cd99c5c301635%7C0%7C0%7C638018803042580036%7CUnknown > %7CTWFpbGZ > > > +sb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6M > n0% > > > +3D%7C3000%7C%7C%7C&sdata=tgNngxTlIBOhIXt0VYJACNM%2FV%2F0 > LWCXyTYVr > > +rZ5PfoY%3D&reserved=0 > > +$schema: > > +https://eur01.safelinks.protection.outlook.com/?url=http%3A%2F%2Fdevi > > > +cetree.org%2Fmeta-schemas%2Fcore.yaml%23&data=05%7C01%7Cjoy.z > ou%4 > > > +0nxp.com%7C405bb49028e340afdc9408dab2b89251%7C686ea1d3bc2b4c6 > fa92cd99 > > > +c5c301635%7C0%7C0%7C638018803042580036%7CUnknown%7CTWFpbG > Zsb3d8eyJWIj > > > +oiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3 > 000%7 > > > +C%7C%7C&sdata=MNltJ7MuOpabpjY%2FTdi8IDagtgiFz1vgUCUhs68ChV > U%3D&am > > +p;reserved=0 > > + > > +title: Freescale Smart Direct Memory Access (SDMA) Controller for > > +i.MX > > + > > +maintainers: > > + - Joy Zou <joy.zou@nxp.com> > > + > > You need to reference dma-controller.yaml schema. Thank you very much for your comments. I will add the dma-controller quotes. BR Joy Zou > > > +properties: > > + compatible: > > + oneOf: > > > (...) > > > + > > + gpr: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle to the General Purpose Register (GPR) > > + node > > + > > + fsl,sdma-event-remap: > > + $ref: /schemas/types.yaml#/definitions/uint32-matrix > > + maxItems: 2 > > + items: > > + items: > > + - description: GPR register offset > > + - description: GPR register shift > > + - description: GPR register value > > + description: | > > + Register bits of sdma event remap, the format is <reg shift val>. > > + The order is <RX>, <TX>. > > + > > + clocks: > > + maxItems: 2 > > + > > + clock-names: > > + items: > > + - const: ipg > > + - const: ahb > > + > > + iram: > > + $ref: /schemas/types.yaml#/definitions/phandle > > + description: The phandle to the On-chip RAM (OCRAM) node. > > + > > +required: > > + - compatible > > + - reg > > + - interrupts > > + - fsl,sdma-ram-script-name > > + - "#dma-cells" > > and then this can one be dropped. Thanks your comments. I have tried to delete the additionalProperties, but I run dtbs_check. The log as follow: 'oneOf' conditional failed, one must be fixed: 'unevaluatedProperties' is a required property 'additionalProperties' is a required property So I think the property may not be dropped. BR Joy Zou > > > + > > +additionalProperties: false > > Best regards, > Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-10-21 8:10 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-10-20 10:14 [PATCH v7 0/2] dmaengine: sdma support hdmi audio Joy Zou 2022-10-20 10:14 ` Joy Zou 2022-10-20 10:14 ` [PATCH v7 1/2] dt-bindings: fsl-imx-sdma: Convert imx sdma to DT schema Joy Zou 2022-10-20 10:14 ` Joy Zou 2022-10-20 16:31 ` Krzysztof Kozlowski 2022-10-20 16:31 ` Krzysztof Kozlowski 2022-10-21 8:10 ` Joy Zou [this message] 2022-10-21 8:10 ` [EXT] " Joy Zou 2022-10-21 13:03 ` Krzysztof Kozlowski 2022-10-21 13:03 ` Krzysztof Kozlowski 2022-10-25 8:37 ` Joy Zou 2022-10-25 8:37 ` Joy Zou 2022-10-20 10:14 ` [PATCH v7 2/2] dmaengine: imx-sdma: support hdmi in sdma Joy Zou 2022-10-20 10:14 ` Joy Zou
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=AM6PR04MB5925C0AC7A4066AF52E2004CE12D9@AM6PR04MB5925.eurprd04.prod.outlook.com \ --to=joy.zou@nxp.com \ --cc=aford173@gmail.com \ --cc=alexander.stein@ew.tq-group.com \ --cc=david@ixit.cz \ --cc=dev@lynxeye.de \ --cc=devicetree@vger.kernel.org \ --cc=dmaengine@vger.kernel.org \ --cc=festevam@gmail.com \ --cc=hongxing.zhu@nxp.com \ --cc=kernel@pengutronix.de \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=krzysztof.kozlowski@linaro.org \ --cc=linux-arm-kernel@lists.infradead.org \ --cc=linux-imx@nxp.com \ --cc=linux-kernel@vger.kernel.org \ --cc=martink@posteo.de \ --cc=peng.fan@nxp.com \ --cc=robh+dt@kernel.org \ --cc=s.hauer@pengutronix.de \ --cc=shawnguo@kernel.org \ --cc=shengjiu.wang@nxp.com \ --cc=vkoul@kernel.org \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.