version upgrade to python-click

version upgrade to python-click

[Felix Snow]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Hello,

it seems that the latest version of python-click in open-embedded is 6.7 :
 https://layers.openembedded.org/layerindex/recipe/52136/
This was released in January 2017, but 7.0 came out in September 2018:
https://pypi.org/project/click/#history

I have had a considerable struggle with click on our embedded linux around locale.

It was a hard requirement and there are were a lot of complaints prior to version 7.0

Here are a few examples:
https://github.com/NixOS/nixpkgs/pull/41843
https://github.com/NixOS/nixpkgs/issues/40146
https://github.com/NixOS/nixpkgs/issues/38991

I believe they removed the hard dependency in this pull request - https://github.com/pallets/click/pull/880
which went into version 7.0

If you look at the code of that request there is very little which fixes this, but it would probably still be cleaner at least long term to have the newer version of click than to patch that in our system.  The locale issue is one of a long list of changes in 7.0 http://click.palletsprojects.com/en/7.x/changelog/

Actually, click is not explicitly mentioned in the bb file, but python-flask is, and that somehow installs click with it, I think as there is another recipe for python-flask which includes click.

Cheers,
Felix



.......................................................................................
PHOENIX CONTACT Cyber Security GmbH
Richard-Willstätter-Straße 6
D-12489 Berlin

Register Court: AG Charlottenburg, HR B 202908
Geschäftsführer/General Manager: Kilian Golm

[-- Attachment #2: Type: text/html, Size: 5567 bytes --]

Re: version upgrade to python-click

[Randy MacLeod]

On 2/12/19 5:02 AM, Felix Snow wrote:
> Hello,
> 
> it seems that the latest version of python-click in open-embedded is 6.7 :
> 
> https://layers.openembedded.org/layerindex/recipe/52136/
> 
> This was released in January 2017, but 7.0 came out in September 2018:
> 
> https://pypi.org/project/click/#history
> 
> I have had a considerable struggle with click on our embedded linux 
> around locale.
> 
> It was a hard requirement and there are were a lot of complaints prior 
> to version 7.0
> 
> Here are a few examples:
> 
> https://github.com/NixOS/nixpkgs/pull/41843
> 
> https://github.com/NixOS/nixpkgs/issues/40146
> 
> https://github.com/NixOS/nixpkgs/issues/38991
> 
> I believe they removed the hard dependency in this pull request - 
> https://github.com/pallets/click/pull/880
> 
> which went into version 7.0
> 
> If you look at the code of that request there is very little which fixes 
> this, but it would probably still be cleaner at least long term to have 
> the newer version of click than to patch that in our system.  The locale 
> issue is one of a long list of changes in 7.0 
> http://click.palletsprojects.com/en/7.x/changelog/

Thanks for pointing that out.

Can you update the recipe, test it and send a patch to:
    openembedded-devel@lists.openembedded.org
as per:
    https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

../Randy

> 
> Actually, click is not explicitly mentioned in the bb file, but 
> python-flask is, and that somehow installs click with it, I think as 
> there is another recipe for python-flask which includes click.
> 
> Cheers,
> 
> Felix
> 
> .......................................................................................
> 
> PHOENIX CONTACT Cyber Security GmbH　
> 
> Richard-Willstätter-Straße 6 　
> 
> D-12489 Berlin 　
> 
> 　
> 
> Register Court: AG Charlottenburg, HR B 202908　
> 
> Geschäftsführer/General Manager: Kilian Golm
> 
> //
> 


-- 
# Randy MacLeod
# Wind River Linux

Re: [OE-core] version upgrade to python-click

[Randy MacLeod]

On 2/12/19 5:02 AM, Felix Snow wrote:
> Hello,
> 
> it seems that the latest version of python-click in open-embedded is 6.7 :
> 
> https://layers.openembedded.org/layerindex/recipe/52136/
> 
> This was released in January 2017, but 7.0 came out in September 2018:
> 
> https://pypi.org/project/click/#history
> 
> I have had a considerable struggle with click on our embedded linux 
> around locale.
> 
> It was a hard requirement and there are were a lot of complaints prior 
> to version 7.0
> 
> Here are a few examples:
> 
> https://github.com/NixOS/nixpkgs/pull/41843
> 
> https://github.com/NixOS/nixpkgs/issues/40146
> 
> https://github.com/NixOS/nixpkgs/issues/38991
> 
> I believe they removed the hard dependency in this pull request - 
> https://github.com/pallets/click/pull/880
> 
> which went into version 7.0
> 
> If you look at the code of that request there is very little which fixes 
> this, but it would probably still be cleaner at least long term to have 
> the newer version of click than to patch that in our system.  The locale 
> issue is one of a long list of changes in 7.0 
> http://click.palletsprojects.com/en/7.x/changelog/

Thanks for pointing that out.

Can you update the recipe, test it and send a patch to:
    openembedded-devel@lists.openembedded.org
as per:
    https://www.openembedded.org/wiki/How_to_submit_a_patch_to_OpenEmbedded

../Randy

> 
> Actually, click is not explicitly mentioned in the bb file, but 
> python-flask is, and that somehow installs click with it, I think as 
> there is another recipe for python-flask which includes click.
> 
> Cheers,
> 
> Felix
> 
> .......................................................................................
> 
> PHOENIX CONTACT Cyber Security GmbH　
> 
> Richard-Willstätter-Straße 6 　
> 
> D-12489 Berlin 　
> 
> 　
> 
> Register Court: AG Charlottenburg, HR B 202908　
> 
> Geschäftsführer/General Manager: Kilian Golm
> 
> //
> 


-- 
# Randy MacLeod
# Wind River Linux