[PATCH] u-boot: set SYSROOT_DIRS to /boot and ${sysconfdir}

[PATCH] u-boot: set SYSROOT_DIRS to /boot and ${sysconfdir}

[Diego Sueiro]

Since do_install is shipping files to /boot and ${sysconfdir}, we can set
SYSROOT_DIRS to these dirs and allow recipes which depend on u-boot to use its
installed artifacts from RECIPE_SYSROOT instead of DEPLOY_DIR_IMAGE.

Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
---
 meta/recipes-bsp/u-boot/u-boot.inc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
index 251178db33..6af0766571 100644
--- a/meta/recipes-bsp/u-boot/u-boot.inc
+++ b/meta/recipes-bsp/u-boot/u-boot.inc
@@ -266,6 +266,8 @@ FILES_${PN}-env = " \
 "
 
 FILES_${PN} = "/boot ${datadir}"
+SYSROOT_DIRS = "/boot ${sysconfdir}"
+
 RDEPENDS_${PN} += "${PN}-env"
 
 do_deploy () {
-- 
2.17.1

Re: [OE-core] [PATCH] u-boot: set SYSROOT_DIRS to /boot and ${sysconfdir}

[Max Krummenacher]

Hi

Am Donnerstag, den 17.12.2020, 11:23 +0000 schrieb Diego Sueiro:
> Since do_install is shipping files to /boot and ${sysconfdir}, we can set
> SYSROOT_DIRS to these dirs and allow recipes which depend on u-boot to use its
> installed artifacts from RECIPE_SYSROOT instead of DEPLOY_DIR_IMAGE.
> 
> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
> ---
>  meta/recipes-bsp/u-boot/u-boot.inc | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc b/meta/recipes-bsp/u-boot/u-boot.inc
> index 251178db33..6af0766571 100644
> --- a/meta/recipes-bsp/u-boot/u-boot.inc
> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
> @@ -266,6 +266,8 @@ FILES_${PN}-env = " \
>  "
>  
>  FILES_${PN} = "/boot ${datadir}"
> +SYSROOT_DIRS = "/boot ${sysconfdir}"

Wouldn't a += be more future proof. I.e. not dropping the directories which are staged by default.

Max

> +
>  RDEPENDS_${PN} += "${PN}-env"
>  
>  do_deploy () {
> 
> 

Re: [OE-core] [PATCH] u-boot: set SYSROOT_DIRS to /boot and ${sysconfdir}

[Diego Sueiro]

Hi,

>-----Original Message-----
>From: openembedded-core@lists.openembedded.org <openembedded-
>core@lists.openembedded.org> On Behalf Of Max Krummenacher via
>lists.openembedded.org
>Sent: 18 December 2020 09:52
>To: Diego Sueiro <Diego.Sueiro@arm.com>; openembedded-
>core@lists.openembedded.org
>Cc: nd <nd@arm.com>
>Subject: Re: [OE-core] [PATCH] u-boot: set SYSROOT_DIRS to /boot and
>${sysconfdir}
>
>Hi
>
>Am Donnerstag, den 17.12.2020, 11:23 +0000 schrieb Diego Sueiro:
>> Since do_install is shipping files to /boot and ${sysconfdir}, we can
>> set SYSROOT_DIRS to these dirs and allow recipes which depend on
>> u-boot to use its installed artifacts from RECIPE_SYSROOT instead of
>DEPLOY_DIR_IMAGE.
>>
>> Signed-off-by: Diego Sueiro <diego.sueiro@arm.com>
>> ---
>>  meta/recipes-bsp/u-boot/u-boot.inc | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/meta/recipes-bsp/u-boot/u-boot.inc
>> b/meta/recipes-bsp/u-boot/u-boot.inc
>> index 251178db33..6af0766571 100644
>> --- a/meta/recipes-bsp/u-boot/u-boot.inc
>> +++ b/meta/recipes-bsp/u-boot/u-boot.inc
>> @@ -266,6 +266,8 @@ FILES_${PN}-env = " \  "
>>
>>  FILES_${PN} = "/boot ${datadir}"
>> +SYSROOT_DIRS = "/boot ${sysconfdir}"
>
>Wouldn't a += be more future proof. I.e. not dropping the directories which
>are staged by default.
>
>Max

Thanks for your review. A v2 is under way.

>
>> +
>>  RDEPENDS_${PN} += "${PN}-env"
>>
>>  do_deploy () {
>>
>>