* [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
@ 2020-04-27 3:56 Yangbo Lu
2020-05-13 8:22 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Yangbo Lu @ 2020-04-27 3:56 UTC (permalink / raw)
To: linux-arm-kernel; +Cc: Richard Cochran, Li Yang, Shawn Guo, Yangbo Lu
Output PPS signal on FIPER2 (Fixed Period Interval Pulse)
which is more desired by user.
Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
---
arch/arm/boot/dts/ls1021a.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
index 760a68c..b2ff27a 100644
--- a/arch/arm/boot/dts/ls1021a.dtsi
+++ b/arch/arm/boot/dts/ls1021a.dtsi
@@ -772,7 +772,7 @@
fsl,tmr-prsc = <2>;
fsl,tmr-add = <0xaaaaaaab>;
fsl,tmr-fiper1 = <999999995>;
- fsl,tmr-fiper2 = <99990>;
+ fsl,tmr-fiper2 = <999999995>;
fsl,max-adj = <499999999>;
fsl,extts-fifo;
};
--
2.7.4
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
2020-04-27 3:56 [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2 Yangbo Lu
@ 2020-05-13 8:22 ` Shawn Guo
2020-05-14 3:13 ` Y.b. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2020-05-13 8:22 UTC (permalink / raw)
To: Yangbo Lu; +Cc: Richard Cochran, linux-arm-kernel, Li Yang
On Mon, Apr 27, 2020 at 11:56:55AM +0800, Yangbo Lu wrote:
> Output PPS signal on FIPER2 (Fixed Period Interval Pulse)
> which is more desired by user.
>
> Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> ---
> arch/arm/boot/dts/ls1021a.dtsi | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> index 760a68c..b2ff27a 100644
> --- a/arch/arm/boot/dts/ls1021a.dtsi
> +++ b/arch/arm/boot/dts/ls1021a.dtsi
> @@ -772,7 +772,7 @@
> fsl,tmr-prsc = <2>;
> fsl,tmr-add = <0xaaaaaaab>;
> fsl,tmr-fiper1 = <999999995>;
> - fsl,tmr-fiper2 = <99990>;
> + fsl,tmr-fiper2 = <999999995>;
Not sure code change matches patch subject and commit log. The change
is about changing fsl,tmr-fiper2 setting from one value to another.
Shawn
> fsl,max-adj = <499999999>;
> fsl,extts-fifo;
> };
> --
> 2.7.4
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
2020-05-13 8:22 ` Shawn Guo
@ 2020-05-14 3:13 ` Y.b. Lu
2020-05-17 13:54 ` Shawn Guo
0 siblings, 1 reply; 5+ messages in thread
From: Y.b. Lu @ 2020-05-14 3:13 UTC (permalink / raw)
To: Shawn Guo; +Cc: Richard Cochran, linux-arm-kernel, Leo Li
Hi Shawn,
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Wednesday, May 13, 2020 4:23 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; Leo Li <leoyang.li@nxp.com>;
> Richard Cochran <richardcochran@gmail.com>
> Subject: Re: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
>
> On Mon, Apr 27, 2020 at 11:56:55AM +0800, Yangbo Lu wrote:
> > Output PPS signal on FIPER2 (Fixed Period Interval Pulse)
> > which is more desired by user.
> >
> > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > ---
> > arch/arm/boot/dts/ls1021a.dtsi | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> > index 760a68c..b2ff27a 100644
> > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > @@ -772,7 +772,7 @@
> > fsl,tmr-prsc = <2>;
> > fsl,tmr-add = <0xaaaaaaab>;
> > fsl,tmr-fiper1 = <999999995>;
> > - fsl,tmr-fiper2 = <99990>;
> > + fsl,tmr-fiper2 = <999999995>;
>
> Not sure code change matches patch subject and commit log. The change
> is about changing fsl,tmr-fiper2 setting from one value to another.
The calculation refers to Documentation/devicetree/bindings/ptp/ptp-qoriq.txt. It looks complicated.
But to be simple, to get 1PPS signal (period is 1s) on FIPER2, the value should be set as,
fiper2 = <desired period> - <tclk-period> = 1000000000ns - 5ns = 999999995.
Thanks.
>
> Shawn
>
> > fsl,max-adj = <499999999>;
> > fsl,extts-fifo;
> > };
> > --
> > 2.7.4
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
2020-05-14 3:13 ` Y.b. Lu
@ 2020-05-17 13:54 ` Shawn Guo
2020-05-19 2:58 ` Y.b. Lu
0 siblings, 1 reply; 5+ messages in thread
From: Shawn Guo @ 2020-05-17 13:54 UTC (permalink / raw)
To: Y.b. Lu; +Cc: Richard Cochran, linux-arm-kernel, Leo Li
On Thu, May 14, 2020 at 03:13:45AM +0000, Y.b. Lu wrote:
> Hi Shawn,
>
> > -----Original Message-----
> > From: Shawn Guo <shawnguo@kernel.org>
> > Sent: Wednesday, May 13, 2020 4:23 PM
> > To: Y.b. Lu <yangbo.lu@nxp.com>
> > Cc: linux-arm-kernel@lists.infradead.org; Leo Li <leoyang.li@nxp.com>;
> > Richard Cochran <richardcochran@gmail.com>
> > Subject: Re: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
> >
> > On Mon, Apr 27, 2020 at 11:56:55AM +0800, Yangbo Lu wrote:
> > > Output PPS signal on FIPER2 (Fixed Period Interval Pulse)
> > > which is more desired by user.
> > >
> > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > > ---
> > > arch/arm/boot/dts/ls1021a.dtsi | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi b/arch/arm/boot/dts/ls1021a.dtsi
> > > index 760a68c..b2ff27a 100644
> > > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > > @@ -772,7 +772,7 @@
> > > fsl,tmr-prsc = <2>;
> > > fsl,tmr-add = <0xaaaaaaab>;
> > > fsl,tmr-fiper1 = <999999995>;
> > > - fsl,tmr-fiper2 = <99990>;
> > > + fsl,tmr-fiper2 = <999999995>;
> >
> > Not sure code change matches patch subject and commit log. The change
> > is about changing fsl,tmr-fiper2 setting from one value to another.
>
> The calculation refers to Documentation/devicetree/bindings/ptp/ptp-qoriq.txt. It looks complicated.
> But to be simple, to get 1PPS signal (period is 1s) on FIPER2, the value should be set as,
> fiper2 = <desired period> - <tclk-period> = 1000000000ns - 5ns = 999999995.
Please update commit log to include how new value comes.
Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
* RE: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
2020-05-17 13:54 ` Shawn Guo
@ 2020-05-19 2:58 ` Y.b. Lu
0 siblings, 0 replies; 5+ messages in thread
From: Y.b. Lu @ 2020-05-19 2:58 UTC (permalink / raw)
To: Shawn Guo; +Cc: Richard Cochran, linux-arm-kernel, Leo Li
> -----Original Message-----
> From: Shawn Guo <shawnguo@kernel.org>
> Sent: Sunday, May 17, 2020 9:54 PM
> To: Y.b. Lu <yangbo.lu@nxp.com>
> Cc: linux-arm-kernel@lists.infradead.org; Leo Li <leoyang.li@nxp.com>;
> Richard Cochran <richardcochran@gmail.com>
> Subject: Re: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
>
> On Thu, May 14, 2020 at 03:13:45AM +0000, Y.b. Lu wrote:
> > Hi Shawn,
> >
> > > -----Original Message-----
> > > From: Shawn Guo <shawnguo@kernel.org>
> > > Sent: Wednesday, May 13, 2020 4:23 PM
> > > To: Y.b. Lu <yangbo.lu@nxp.com>
> > > Cc: linux-arm-kernel@lists.infradead.org; Leo Li <leoyang.li@nxp.com>;
> > > Richard Cochran <richardcochran@gmail.com>
> > > Subject: Re: [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2
> > >
> > > On Mon, Apr 27, 2020 at 11:56:55AM +0800, Yangbo Lu wrote:
> > > > Output PPS signal on FIPER2 (Fixed Period Interval Pulse)
> > > > which is more desired by user.
> > > >
> > > > Signed-off-by: Yangbo Lu <yangbo.lu@nxp.com>
> > > > ---
> > > > arch/arm/boot/dts/ls1021a.dtsi | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/arch/arm/boot/dts/ls1021a.dtsi
> b/arch/arm/boot/dts/ls1021a.dtsi
> > > > index 760a68c..b2ff27a 100644
> > > > --- a/arch/arm/boot/dts/ls1021a.dtsi
> > > > +++ b/arch/arm/boot/dts/ls1021a.dtsi
> > > > @@ -772,7 +772,7 @@
> > > > fsl,tmr-prsc = <2>;
> > > > fsl,tmr-add = <0xaaaaaaab>;
> > > > fsl,tmr-fiper1 = <999999995>;
> > > > - fsl,tmr-fiper2 = <99990>;
> > > > + fsl,tmr-fiper2 = <999999995>;
> > >
> > > Not sure code change matches patch subject and commit log. The change
> > > is about changing fsl,tmr-fiper2 setting from one value to another.
> >
> > The calculation refers to
> Documentation/devicetree/bindings/ptp/ptp-qoriq.txt. It looks complicated.
> > But to be simple, to get 1PPS signal (period is 1s) on FIPER2, the value should
> be set as,
> > fiper2 = <desired period> - <tclk-period> = 1000000000ns - 5ns =
> 999999995.
>
> Please update commit log to include how new value comes.
Sent out v2. Thanks!
>
> Shawn
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2020-05-19 2:58 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-04-27 3:56 [PATCH] ARM: dts: ls1021a: output PPS signal on FIPER2 Yangbo Lu
2020-05-13 8:22 ` Shawn Guo
2020-05-14 3:13 ` Y.b. Lu
2020-05-17 13:54 ` Shawn Guo
2020-05-19 2:58 ` Y.b. Lu
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.