* [PATCH] pypi.bbclass: mind package suffix on version check @ 2020-05-08 11:37 Konrad Weihmann 2020-05-09 4:56 ` [OE-core] " Tim Orling 0 siblings, 1 reply; 7+ messages in thread From: Konrad Weihmann @ 2020-05-08 11:37 UTC (permalink / raw) To: openembedded-core; +Cc: Konrad Weihmann Some pypi packages do have suffixes like dev, or a0 or b1. When doing a version check on these, the version will get falsely trimmed down to a version without the suffix. E.g. 3.8.0a1 will become 3.8.0 which then also means that a version upgrade from 3.8.0a1 to 3.8.0a2 will not be detected. Fix that by inserting an optional suffix group with alphanumeric charset. Signed-off-by: Konrad Weihmann <kweihmann@outlook.com> --- meta/classes/pypi.bbclass | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass index e5d7ab3ce1..7d0f367a02 100644 --- a/meta/classes/pypi.bbclass +++ b/meta/classes/pypi.bbclass @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" UPSTREAM_CHECK_URI ?= "https://pypi.python.org/pypi/${PYPI_PACKAGE}/" -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" +UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" -- 2.20.1 ^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] pypi.bbclass: mind package suffix on version check 2020-05-08 11:37 [PATCH] pypi.bbclass: mind package suffix on version check Konrad Weihmann @ 2020-05-09 4:56 ` Tim Orling 2020-05-09 6:55 ` Konrad Weihmann 0 siblings, 1 reply; 7+ messages in thread From: Tim Orling @ 2020-05-09 4:56 UTC (permalink / raw) To: Konrad Weihmann; +Cc: openembedded-core [-- Attachment #1: Type: text/plain, Size: 1297 bytes --] We should only be updating to releases, not dev or alpha or any other non-released state. That is why the regex is they way it is. On Fri, May 8, 2020 at 4:37 AM Konrad Weihmann <kweihmann@outlook.com> wrote: > Some pypi packages do have suffixes like dev, or a0 or b1. > When doing a version check on these, the version will get falsely > trimmed down to a version without the suffix. > > E.g. 3.8.0a1 will become 3.8.0 which then also means that > a version upgrade from 3.8.0a1 to 3.8.0a2 will not be detected. > > Fix that by inserting an optional suffix group with alphanumeric charset. > > Signed-off-by: Konrad Weihmann <kweihmann@outlook.com> > --- > meta/classes/pypi.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass > index e5d7ab3ce1..7d0f367a02 100644 > --- a/meta/classes/pypi.bbclass > +++ b/meta/classes/pypi.bbclass > @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" > S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" > > UPSTREAM_CHECK_URI ?= "https://pypi.python.org/pypi/${PYPI_PACKAGE}/" > -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" > +UPSTREAM_CHECK_REGEX ?= > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" > -- > 2.20.1 > > > [-- Attachment #2: Type: text/html, Size: 1861 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] pypi.bbclass: mind package suffix on version check 2020-05-09 4:56 ` [OE-core] " Tim Orling @ 2020-05-09 6:55 ` Konrad Weihmann 2020-05-09 7:38 ` Alexander Kanavin 0 siblings, 1 reply; 7+ messages in thread From: Konrad Weihmann @ 2020-05-09 6:55 UTC (permalink / raw) To: Tim Orling; +Cc: openembedded-core Fully support that, it's same for me. But then the regex is also not a 100% correct, as it will issue a notification via "devtool check-upgrade-status", even for an alpha or beta or dev release - and most important without the suffix, so it's extra hard to identify if one should take action or not. And even when using the "devtool upgrade" patch it will run a build attempt, which will immediately fail, as the reported version is present, due to the suffix being trimmed during the process. What I could imagine is to ignore those releases by default using an inverted group like (?P<pver>(\d+[\.\-_]*)+(?![a-z0-9]+)*) to filter out those kind of releases. What do you think? On 09.05.20 06:56, Tim Orling wrote: > We should only be updating to releases, not dev or alpha or any other > non-released state. That is why the regex is they way it is. > > On Fri, May 8, 2020 at 4:37 AM Konrad Weihmann <kweihmann@outlook.com > <mailto:kweihmann@outlook.com>> wrote: > > Some pypi packages do have suffixes like dev, or a0 or b1. > When doing a version check on these, the version will get falsely > trimmed down to a version without the suffix. > > E.g. 3.8.0a1 will become 3.8.0 which then also means that > a version upgrade from 3.8.0a1 to 3.8.0a2 will not be detected. > > Fix that by inserting an optional suffix group with alphanumeric > charset. > > Signed-off-by: Konrad Weihmann <kweihmann@outlook.com > <mailto:kweihmann@outlook.com>> > --- > meta/classes/pypi.bbclass | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass > index e5d7ab3ce1..7d0f367a02 100644 > --- a/meta/classes/pypi.bbclass > +++ b/meta/classes/pypi.bbclass > @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" > S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" > > UPSTREAM_CHECK_URI ?= > "https://pypi.python.org/pypi/${PYPI_PACKAGE}/ > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/>" > -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" > +UPSTREAM_CHECK_REGEX ?= > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" > -- > 2.20.1 > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] pypi.bbclass: mind package suffix on version check 2020-05-09 6:55 ` Konrad Weihmann @ 2020-05-09 7:38 ` Alexander Kanavin 2020-05-09 7:45 ` Konrad Weihmann 0 siblings, 1 reply; 7+ messages in thread From: Alexander Kanavin @ 2020-05-09 7:38 UTC (permalink / raw) To: Konrad Weihmann; +Cc: Tim Orling, OE-core [-- Attachment #1: Type: text/plain, Size: 2706 bytes --] Can you give specific examples please? I think we can probably add \.tar to the end of the existing regex, which will ensure there are no unwanted suffixes. This is already done in plenty of recipes for the same reason. Alex On Sat, 9 May 2020 at 08:55, Konrad Weihmann <kweihmann@outlook.com> wrote: > Fully support that, it's same for me. > But then the regex is also not a 100% correct, as it will issue a > notification via "devtool check-upgrade-status", even for an alpha or > beta or dev release - and most important without the suffix, so it's > extra hard to identify if one should take action or not. > > And even when using the "devtool upgrade" patch it will run a build > attempt, which will immediately fail, as the reported version is > present, due to the suffix being trimmed during the process. > > What I could imagine is to ignore those releases by default using an > inverted group like (?P<pver>(\d+[\.\-_]*)+(?![a-z0-9]+)*) to filter out > those kind of releases. > > What do you think? > > On 09.05.20 06:56, Tim Orling wrote: > > We should only be updating to releases, not dev or alpha or any other > > non-released state. That is why the regex is they way it is. > > > > On Fri, May 8, 2020 at 4:37 AM Konrad Weihmann <kweihmann@outlook.com > > <mailto:kweihmann@outlook.com>> wrote: > > > > Some pypi packages do have suffixes like dev, or a0 or b1. > > When doing a version check on these, the version will get falsely > > trimmed down to a version without the suffix. > > > > E.g. 3.8.0a1 will become 3.8.0 which then also means that > > a version upgrade from 3.8.0a1 to 3.8.0a2 will not be detected. > > > > Fix that by inserting an optional suffix group with alphanumeric > > charset. > > > > Signed-off-by: Konrad Weihmann <kweihmann@outlook.com > > <mailto:kweihmann@outlook.com>> > > --- > > meta/classes/pypi.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/pypi.bbclass b/meta/classes/pypi.bbclass > > index e5d7ab3ce1..7d0f367a02 100644 > > --- a/meta/classes/pypi.bbclass > > +++ b/meta/classes/pypi.bbclass > > @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" > > S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" > > > > UPSTREAM_CHECK_URI ?= > > "https://pypi.python.org/pypi/${PYPI_PACKAGE}/ > > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/>" > > -UPSTREAM_CHECK_REGEX ?= "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" > > +UPSTREAM_CHECK_REGEX ?= > > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" > > -- > > 2.20.1 > > > > > > > > [-- Attachment #2: Type: text/html, Size: 3924 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] pypi.bbclass: mind package suffix on version check 2020-05-09 7:38 ` Alexander Kanavin @ 2020-05-09 7:45 ` Konrad Weihmann 2020-05-09 8:03 ` Alexander Kanavin 0 siblings, 1 reply; 7+ messages in thread From: Konrad Weihmann @ 2020-05-09 7:45 UTC (permalink / raw) To: Alexander Kanavin; +Cc: Tim Orling, OE-core Well, I faced that at least on the following packages - flake8 (current stable 3.7.9, existing alphas 3.8.0a1, 3.8.0a2) - markupsafe (current stable 1.1.1, existing alphas 2.0.0a1) On 09.05.20 09:38, Alexander Kanavin wrote: > Can you give specific examples please? I think we can probably add \.tar > to the end of the existing regex, which will ensure there are no > unwanted suffixes. This is already done in plenty of recipes for the > same reason. > > Alex > > On Sat, 9 May 2020 at 08:55, Konrad Weihmann <kweihmann@outlook.com > <mailto:kweihmann@outlook.com>> wrote: > > Fully support that, it's same for me. > But then the regex is also not a 100% correct, as it will issue a > notification via "devtool check-upgrade-status", even for an alpha or > beta or dev release - and most important without the suffix, so it's > extra hard to identify if one should take action or not. > > And even when using the "devtool upgrade" patch it will run a build > attempt, which will immediately fail, as the reported version is > present, due to the suffix being trimmed during the process. > > What I could imagine is to ignore those releases by default using an > inverted group like (?P<pver>(\d+[\.\-_]*)+(?![a-z0-9]+)*) to filter > out > those kind of releases. > > What do you think? > > On 09.05.20 06:56, Tim Orling wrote: > > We should only be updating to releases, not dev or alpha or any > other > > non-released state. That is why the regex is they way it is. > > > > On Fri, May 8, 2020 at 4:37 AM Konrad Weihmann > <kweihmann@outlook.com <mailto:kweihmann@outlook.com> > > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com>>> wrote: > > > > Some pypi packages do have suffixes like dev, or a0 or b1. > > When doing a version check on these, the version will get falsely > > trimmed down to a version without the suffix. > > > > E.g. 3.8.0a1 will become 3.8.0 which then also means that > > a version upgrade from 3.8.0a1 to 3.8.0a2 will not be detected. > > > > Fix that by inserting an optional suffix group with alphanumeric > > charset. > > > > Signed-off-by: Konrad Weihmann <kweihmann@outlook.com > <mailto:kweihmann@outlook.com> > > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com>>> > > --- > > meta/classes/pypi.bbclass | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/meta/classes/pypi.bbclass > b/meta/classes/pypi.bbclass > > index e5d7ab3ce1..7d0f367a02 100644 > > --- a/meta/classes/pypi.bbclass > > +++ b/meta/classes/pypi.bbclass > > @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" > > S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" > > > > UPSTREAM_CHECK_URI ?= > > "https://pypi.python.org/pypi/${PYPI_PACKAGE}/ > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/> > > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/>" > > -UPSTREAM_CHECK_REGEX ?= > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" > > +UPSTREAM_CHECK_REGEX ?= > > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" > > -- > > 2.20.1 > > > > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] pypi.bbclass: mind package suffix on version check 2020-05-09 7:45 ` Konrad Weihmann @ 2020-05-09 8:03 ` Alexander Kanavin 2020-05-09 10:42 ` Konrad Weihmann 0 siblings, 1 reply; 7+ messages in thread From: Alexander Kanavin @ 2020-05-09 8:03 UTC (permalink / raw) To: Konrad Weihmann; +Cc: Tim Orling, OE-core [-- Attachment #1: Type: text/plain, Size: 3791 bytes --] Then maybe appending a / to the regex will do? Alex On Sat, 9 May 2020 at 09:45, Konrad Weihmann <kweihmann@outlook.com> wrote: > Well, I faced that at least on the following packages > > - flake8 (current stable 3.7.9, existing alphas 3.8.0a1, 3.8.0a2) > - markupsafe (current stable 1.1.1, existing alphas 2.0.0a1) > > > On 09.05.20 09:38, Alexander Kanavin wrote: > > Can you give specific examples please? I think we can probably add \.tar > > to the end of the existing regex, which will ensure there are no > > unwanted suffixes. This is already done in plenty of recipes for the > > same reason. > > > > Alex > > > > On Sat, 9 May 2020 at 08:55, Konrad Weihmann <kweihmann@outlook.com > > <mailto:kweihmann@outlook.com>> wrote: > > > > Fully support that, it's same for me. > > But then the regex is also not a 100% correct, as it will issue a > > notification via "devtool check-upgrade-status", even for an alpha or > > beta or dev release - and most important without the suffix, so it's > > extra hard to identify if one should take action or not. > > > > And even when using the "devtool upgrade" patch it will run a build > > attempt, which will immediately fail, as the reported version is > > present, due to the suffix being trimmed during the process. > > > > What I could imagine is to ignore those releases by default using an > > inverted group like (?P<pver>(\d+[\.\-_]*)+(?![a-z0-9]+)*) to filter > > out > > those kind of releases. > > > > What do you think? > > > > On 09.05.20 06:56, Tim Orling wrote: > > > We should only be updating to releases, not dev or alpha or any > > other > > > non-released state. That is why the regex is they way it is. > > > > > > On Fri, May 8, 2020 at 4:37 AM Konrad Weihmann > > <kweihmann@outlook.com <mailto:kweihmann@outlook.com> > > > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com>>> > wrote: > > > > > > Some pypi packages do have suffixes like dev, or a0 or b1. > > > When doing a version check on these, the version will get > falsely > > > trimmed down to a version without the suffix. > > > > > > E.g. 3.8.0a1 will become 3.8.0 which then also means that > > > a version upgrade from 3.8.0a1 to 3.8.0a2 will not be > detected. > > > > > > Fix that by inserting an optional suffix group with > alphanumeric > > > charset. > > > > > > Signed-off-by: Konrad Weihmann <kweihmann@outlook.com > > <mailto:kweihmann@outlook.com> > > > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com > >>> > > > --- > > > meta/classes/pypi.bbclass | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/classes/pypi.bbclass > > b/meta/classes/pypi.bbclass > > > index e5d7ab3ce1..7d0f367a02 100644 > > > --- a/meta/classes/pypi.bbclass > > > +++ b/meta/classes/pypi.bbclass > > > @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" > > > S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" > > > > > > UPSTREAM_CHECK_URI ?= > > > "https://pypi.python.org/pypi/${PYPI_PACKAGE}/ > > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/> > > > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/>" > > > -UPSTREAM_CHECK_REGEX ?= > > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" > > > +UPSTREAM_CHECK_REGEX ?= > > > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" > > > -- > > > 2.20.1 > > > > > > > > > > > > > > [-- Attachment #2: Type: text/html, Size: 5929 bytes --] ^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [OE-core] [PATCH] pypi.bbclass: mind package suffix on version check 2020-05-09 8:03 ` Alexander Kanavin @ 2020-05-09 10:42 ` Konrad Weihmann 0 siblings, 0 replies; 7+ messages in thread From: Konrad Weihmann @ 2020-05-09 10:42 UTC (permalink / raw) To: Alexander Kanavin; +Cc: Tim Orling, OE-core Yep, a trailing slash should be enough. Will create a new patch - thanks all for the input On 09.05.20 10:03, Alexander Kanavin wrote: > Then maybe appending a / to the regex will do? > > Alex > > On Sat, 9 May 2020 at 09:45, Konrad Weihmann <kweihmann@outlook.com > <mailto:kweihmann@outlook.com>> wrote: > > Well, I faced that at least on the following packages > > - flake8 (current stable 3.7.9, existing alphas 3.8.0a1, 3.8.0a2) > - markupsafe (current stable 1.1.1, existing alphas 2.0.0a1) > > > On 09.05.20 09:38, Alexander Kanavin wrote: > > Can you give specific examples please? I think we can probably > add \.tar > > to the end of the existing regex, which will ensure there are no > > unwanted suffixes. This is already done in plenty of recipes for the > > same reason. > > > > Alex > > > > On Sat, 9 May 2020 at 08:55, Konrad Weihmann > <kweihmann@outlook.com <mailto:kweihmann@outlook.com> > > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com>>> wrote: > > > > Fully support that, it's same for me. > > But then the regex is also not a 100% correct, as it will issue a > > notification via "devtool check-upgrade-status", even for an > alpha or > > beta or dev release - and most important without the suffix, > so it's > > extra hard to identify if one should take action or not. > > > > And even when using the "devtool upgrade" patch it will run a > build > > attempt, which will immediately fail, as the reported version is > > present, due to the suffix being trimmed during the process. > > > > What I could imagine is to ignore those releases by default > using an > > inverted group like (?P<pver>(\d+[\.\-_]*)+(?![a-z0-9]+)*) to > filter > > out > > those kind of releases. > > > > What do you think? > > > > On 09.05.20 06:56, Tim Orling wrote: > > > We should only be updating to releases, not dev or alpha > or any > > other > > > non-released state. That is why the regex is they way it is. > > > > > > On Fri, May 8, 2020 at 4:37 AM Konrad Weihmann > > <kweihmann@outlook.com <mailto:kweihmann@outlook.com> > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com>> > > > <mailto:kweihmann@outlook.com > <mailto:kweihmann@outlook.com> <mailto:kweihmann@outlook.com > <mailto:kweihmann@outlook.com>>>> wrote: > > > > > > Some pypi packages do have suffixes like dev, or a0 or b1. > > > When doing a version check on these, the version will > get falsely > > > trimmed down to a version without the suffix. > > > > > > E.g. 3.8.0a1 will become 3.8.0 which then also means that > > > a version upgrade from 3.8.0a1 to 3.8.0a2 will not be > detected. > > > > > > Fix that by inserting an optional suffix group with > alphanumeric > > > charset. > > > > > > Signed-off-by: Konrad Weihmann <kweihmann@outlook.com > <mailto:kweihmann@outlook.com> > > <mailto:kweihmann@outlook.com <mailto:kweihmann@outlook.com>> > > > <mailto:kweihmann@outlook.com > <mailto:kweihmann@outlook.com> <mailto:kweihmann@outlook.com > <mailto:kweihmann@outlook.com>>>> > > > --- > > > meta/classes/pypi.bbclass | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/meta/classes/pypi.bbclass > > b/meta/classes/pypi.bbclass > > > index e5d7ab3ce1..7d0f367a02 100644 > > > --- a/meta/classes/pypi.bbclass > > > +++ b/meta/classes/pypi.bbclass > > > @@ -23,4 +23,4 @@ SRC_URI += "${PYPI_SRC_URI}" > > > S = "${WORKDIR}/${PYPI_PACKAGE}-${PV}" > > > > > > UPSTREAM_CHECK_URI ?= > > > "https://pypi.python.org/pypi/${PYPI_PACKAGE}/ > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/> > > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/> > > > <https://pypi.python.org/pypi/$%7BPYPI_PACKAGE%7D/>" > > > -UPSTREAM_CHECK_REGEX ?= > > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+)" > > > +UPSTREAM_CHECK_REGEX ?= > > > "/${PYPI_PACKAGE}/(?P<pver>(\d+[\.\-_]*)+[a-z0-9]*)" > > > -- > > > 2.20.1 > > > > > > > > > > > > > > ^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-05-09 10:42 UTC | newest] Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-05-08 11:37 [PATCH] pypi.bbclass: mind package suffix on version check Konrad Weihmann 2020-05-09 4:56 ` [OE-core] " Tim Orling 2020-05-09 6:55 ` Konrad Weihmann 2020-05-09 7:38 ` Alexander Kanavin 2020-05-09 7:45 ` Konrad Weihmann 2020-05-09 8:03 ` Alexander Kanavin 2020-05-09 10:42 ` Konrad Weihmann
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.