All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled
@ 2020-11-05 20:40 Lucas Stach
  2020-11-06  1:28 ` [EXT] " Andy Duan
  0 siblings, 1 reply; 2+ messages in thread
From: Lucas Stach @ 2020-11-05 20:40 UTC (permalink / raw)
  To: Greg Kroah-Hartman, Jiri Slaby
  Cc: Fugang Duan, linux-serial, patchwork-lst, kernel

Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon
part of imx serial is a separate driver and isn't necessarily enabled anymore
when the console is enabled. This causes users to loose the earlycon
functionality when upgrading their kenrel configuration via oldconfig.

Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.

Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Fabio Estevam <festevam@gmail.com>
---
v2: add R-b from Fabio, fix typo in subject
v3: no changes, adding this note
---
 drivers/tty/serial/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
index 1044fc387691..28f22e58639c 100644
--- a/drivers/tty/serial/Kconfig
+++ b/drivers/tty/serial/Kconfig
@@ -522,6 +522,7 @@ config SERIAL_IMX_EARLYCON
 	depends on OF
 	select SERIAL_EARLYCON
 	select SERIAL_CORE_CONSOLE
+	default y if SERIAL_IMX_CONSOLE
 	help
 	  If you have enabled the earlycon on the Freescale IMX
 	  CPU you can make it the earlycon by answering Y to this option.
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* RE: [EXT] [PATCH v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled
  2020-11-05 20:40 [PATCH v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled Lucas Stach
@ 2020-11-06  1:28 ` Andy Duan
  0 siblings, 0 replies; 2+ messages in thread
From: Andy Duan @ 2020-11-06  1:28 UTC (permalink / raw)
  To: Lucas Stach, Greg Kroah-Hartman, Jiri Slaby
  Cc: linux-serial, patchwork-lst, kernel

From: Lucas Stach <l.stach@pengutronix.de> Sent: Friday, November 6, 2020 4:40 AM
> Since 699cc4dfd140 (tty: serial: imx: add imx earlycon driver), the earlycon part
> of imx serial is a separate driver and isn't necessarily enabled anymore when the
> console is enabled. This causes users to loose the earlycon functionality when
> upgrading their kenrel configuration via oldconfig.
> 
> Enable earlycon by default when IMX_SERIAL_CONSOLE is enabled.
> 
> Fixes: 699cc4dfd140 (tty: serial: imx: add imx earlycon driver)
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> Reviewed-by: Fabio Estevam <festevam@gmail.com>
> ---
> v2: add R-b from Fabio, fix typo in subject
> v3: no changes, adding this note

Reviewed-by: Fugang Duan <fugang.duan@nxp.com>
> ---
>  drivers/tty/serial/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig index
> 1044fc387691..28f22e58639c 100644
> --- a/drivers/tty/serial/Kconfig
> +++ b/drivers/tty/serial/Kconfig
> @@ -522,6 +522,7 @@ config SERIAL_IMX_EARLYCON
>         depends on OF
>         select SERIAL_EARLYCON
>         select SERIAL_CORE_CONSOLE
> +       default y if SERIAL_IMX_CONSOLE
>         help
>           If you have enabled the earlycon on the Freescale IMX
>           CPU you can make it the earlycon by answering Y to this option.
> --
> 2.20.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2020-11-06  1:28 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-05 20:40 [PATCH v3] tty: serial: imx: enable earlycon by default if IMX_SERIAL_CONSOLE is enabled Lucas Stach
2020-11-06  1:28 ` [EXT] " Andy Duan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.