RE: [EXT] Re: [PATCH V2 1/1] serial: fsl_lpuart: zero out parity bit in CS7 mode

[Shenwei Wang <shenwei.wang@nxp.com>]

Hi Greg,

I tried to send an email again to check this DKIM badsig issue, but everything looked fine here. Can you please let me know how you validated the signature? The following is my DKIM validating info:

----
DKIM Information:
DKIM Signature

Message contains this DKIM Signature:
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nxp.com; s=selector2;
 h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck;
 bh=HY2pC5xqaOLmE689KAZnKl30J3TnLONOqLYxM4y08r0=;
 b=M7qxUAWtDowVzPZs0eTTdrStj3bo9DDxO3rsxhBiCGs1PMAjGv1JGOwEzz/UQ/qgQ14O+l6OXybJojrpmh1zVophUphTVy2sNaW5oK5s5oU1ZXeMTu0jtm3ajPIRPlTRV8JeyV0Rq8qgPdhA59Gqb/1UYhW0Aq5gO0ImjVwj2Fc=


Signature Information:
v= Version:         1
a= Algorithm:       rsa-sha256
c= Method:          relaxed/relaxed
d= Domain:          nxp.com
s= Selector:        selector2
q= Protocol:        
bh=                 HY2pC5xqaOLmE689KAZnKl30J3TnLONOqLYxM4y08r0=
h= Signed Headers:  From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck
b= Data:            M7qxUAWtDowVzPZs0eTTdrStj3bo9DDxO3rsxhBiCGs1PMAjGv1JGOwEzz/UQ/qgQ14O+l6OXybJojrpmh1zVophUphTVy2sNaW5oK5s5oU1ZXeMTu0jtm3ajPIRPlTRV8JeyV0Rq8qgPdhA59Gqb/1UYhW0Aq5gO0ImjVwj2Fc=
Public Key DNS Lookup

Building DNS Query for selector2._domainkey.nxp.com
Retrieved this publickey from DNS: v=DKIM1; k=rsa; p=MIGfMA0GCSqGSIb3DQEBAQUAA4GNADCBiQKBgQC0SigNOw1Kjk6b0883ph4IRUjfgLfp8yL2J8RwU9J9mMTkKxyFQYMtqUR0C0HmGtDjzdKT3DUHe06GjP9Hq6Jbiga0JKKVp3iy6lyLFmvcy64odjUrvOhKgOjgnRpeEV2t98a/idhL3sRxH1JkjqkLmUy4k7k4EY105oYA31IpOwIDAQAB;
Validating Signature

result = pass
Details:


Regards,
Shenwei

> -----Original Message-----
> From: Greg KH <gregkh@linuxfoundation.org>
> Sent: Thursday, July 28, 2022 3:35 AM
> To: Shenwei Wang <shenwei.wang@nxp.com>
> Cc: linux-serial@vger.kernel.org; stable@vger.kernel.org
> Subject: [EXT] Re: [PATCH V2 1/1] serial: fsl_lpuart: zero out parity bit in CS7
> mode
> 
> Caution: EXT Email
> 
> On Thu, Jul 14, 2022 at 01:58:58PM -0500, Shenwei Wang wrote:
> > The LPUART hardware doesn't zero out the parity bit on the received
> > characters. This behavior won't impact the use cases of CS8 because
> > the parity bit is the 9th bit which is not currently used by software.
> > But the parity bit for CS7 must be zeroed out by software in order to
> > get the correct raw data.
> >
> > Signed-off-by: Shenwei Wang <shenwei.wang@nxp.com>
> > ---
> > changes in v2
> > - remove the "inline" keyword from the function of
> > lpuart_tty_insert_flip_string;
> >
> > changes in v1
> > - fix the code indent and whitespace issue;
> 
> Please work with your email admins to fix up your systems as it is showing this is
> an invalid signature when validating it:
>         ✗ BADSIG: DKIM/nxp.com
> 
> Soon I will just reject patches like this as you don't want people to impersonate
> your domain, right?
> 
> thanks,
> 
> greg k-h