Re: [OE-core] [PATCH v3] pip_install_wheel: improve wheel handling

[Konrad Weihmann <kweihmann@outlook.com>]

On 02.03.22 20:04, Khem Raj wrote:
> On Wed, Mar 2, 2022 at 11:01 AM Konrad Weihmann <kweihmann@outlook.com> wrote:
>>
>>
>>
>> On 02.03.22 19:45, Khem Raj wrote:
>>> v4 is definitely better than v3, I see one case it could address as well e.g.
>>>
>>> python3-pymetno produces PyMetno-0.9.0-py3-none-any.whl, so if
>>> guessing code could address the case-sensitive piece here would be
>>> good.
>>
>> I'm torn on this one, I agree that it would really nice to have in terms
>> of a seamless transition, but it would require either some bash/shell
>> hacks to disable case sensitive filename globs or some "after compile"
>> renaming - I'm not sure how to tackle this.
>> If everyone else agrees I would vote for "after compile" renaming to a
>> fully lower case filename - any thoughts?
>>
> 
> I think the suggestion that Ross has is a good one to install the wheel file
> intentionally to a known location using --dist-dir and then use a more
> relaxed regexp to package it.

As I mentioned in the v4 patch dist-dir doesn't work for me - somehow it 
isn't respected by most of the python modules.
So my idea would be it remain on default "dist" directory, but run 
something line rename 'y/A-Z/a-z/' ${PYPA_WHEEL} after compile - also 
minding that in PIP_INSTALL_PACKAGE.

I'm happy to see dist-dir/bdist-dir work, but so far I failed to see any 
successful run on my setup (Ubuntu 20.04 btw)

> 
>>>
>>> On Wed, Mar 2, 2022 at 1:21 AM Konrad Weihmann <kweihmann@outlook.com> wrote:
>>>>
>>>> v4 is out.
>>>> I tried to make it work with the dist-dir/bdist-dir option, but
>>>> apparently this isn't respected by setuptools in all of the tested recipes.
>>>> That's why I went with applying cleandirs on
>>>> ${SETUPTOOLS_SETUP_PATH}/dist, that should do the trick as well.
>>>>
>>>> v4 is tested against all core python recipes, all the python recipes in
>>>> my layers and a reasonable subset from meta-oe
>>>>
>>>> On 02.03.22 09:06, Konrad Weihmann wrote:
>>>>> My bad - one of the brackets in the name guessing slipped...
>>>>> Will send a v4 soon
>>>>>
>>>>> On 02.03.22 06:20, Khem Raj wrote:
>>>>>> this is causing 100+ packages to fail see
>>>>>>
>>>>>> https://errors.yoctoproject.org/Errors/Build/142116/
>>>>>>
>>>>>> I suggest to include meta-python for wider testing of such changes.
>>>>>>
>>>>>> On Tue, Mar 1, 2022 at 12:14 PM Ross Burton <ross@burtonini.com> wrote:
>>>>>>>
>>>>>>> On Tue, 1 Mar 2022 at 18:48, Khem Raj <raj.khem@gmail.com> wrote:
>>>>>>>> where the wheel file is called
>>>>>>>> pytest_runner-5.3.1-py3-none-any.whl
>>>>>>>
>>>>>>> I'm thinking we should tell pip to install the wheels to a directory
>>>>>>> we control and then just install *.whl.
>>>>>>>
>>>>>>> IIRC the option was --dist-dir, and we can [cleandirs] that to ensure
>>>>>>> it's clean on builds.
>>>>>>>
>>>>>>> Ross
>>>>>
>>>>>
>>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>>> Links: You receive all messages sent to this group.
>>>>> View/Reply Online (#162595): https://lists.openembedded.org/g/openembedded-core/message/162595
>>>>> Mute This Topic: https://lists.openembedded.org/mt/89472354/3647476
>>>>> Group Owner: openembedded-core+owner@lists.openembedded.org
>>>>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
>>>>> -=-=-=-=-=-=-=-=-=-=-=-
>>>>>