All of lore.kernel.org
 help / color / mirror / Atom feed
From: Khem Raj <raj.khem@gmail.com>
To: Konrad Weihmann <kweihmann@outlook.com>
Cc: Ross Burton <ross@burtonini.com>, Tim Orling <ticotimo@gmail.com>,
	openembedded-core <openembedded-core@lists.openembedded.org>
Subject: Re: [OE-core] [PATCH v3] pip_install_wheel: improve wheel handling
Date: Wed, 2 Mar 2022 11:04:23 -0800	[thread overview]
Message-ID: <CAMKF1spJpdP13hcDD3KdENAjE_qEDn2gGDCzQxBw+v-ycou53Q@mail.gmail.com> (raw)
In-Reply-To: <AM9PR09MB4642589C438F3ECB0598A6A0A8039@AM9PR09MB4642.eurprd09.prod.outlook.com>

On Wed, Mar 2, 2022 at 11:01 AM Konrad Weihmann <kweihmann@outlook.com> wrote:
>
>
>
> On 02.03.22 19:45, Khem Raj wrote:
> > v4 is definitely better than v3, I see one case it could address as well e.g.
> >
> > python3-pymetno produces PyMetno-0.9.0-py3-none-any.whl, so if
> > guessing code could address the case-sensitive piece here would be
> > good.
>
> I'm torn on this one, I agree that it would really nice to have in terms
> of a seamless transition, but it would require either some bash/shell
> hacks to disable case sensitive filename globs or some "after compile"
> renaming - I'm not sure how to tackle this.
> If everyone else agrees I would vote for "after compile" renaming to a
> fully lower case filename - any thoughts?
>

I think the suggestion that Ross has is a good one to install the wheel file
intentionally to a known location using --dist-dir and then use a more
relaxed regexp to package it.

> >
> > On Wed, Mar 2, 2022 at 1:21 AM Konrad Weihmann <kweihmann@outlook.com> wrote:
> >>
> >> v4 is out.
> >> I tried to make it work with the dist-dir/bdist-dir option, but
> >> apparently this isn't respected by setuptools in all of the tested recipes.
> >> That's why I went with applying cleandirs on
> >> ${SETUPTOOLS_SETUP_PATH}/dist, that should do the trick as well.
> >>
> >> v4 is tested against all core python recipes, all the python recipes in
> >> my layers and a reasonable subset from meta-oe
> >>
> >> On 02.03.22 09:06, Konrad Weihmann wrote:
> >>> My bad - one of the brackets in the name guessing slipped...
> >>> Will send a v4 soon
> >>>
> >>> On 02.03.22 06:20, Khem Raj wrote:
> >>>> this is causing 100+ packages to fail see
> >>>>
> >>>> https://errors.yoctoproject.org/Errors/Build/142116/
> >>>>
> >>>> I suggest to include meta-python for wider testing of such changes.
> >>>>
> >>>> On Tue, Mar 1, 2022 at 12:14 PM Ross Burton <ross@burtonini.com> wrote:
> >>>>>
> >>>>> On Tue, 1 Mar 2022 at 18:48, Khem Raj <raj.khem@gmail.com> wrote:
> >>>>>> where the wheel file is called
> >>>>>> pytest_runner-5.3.1-py3-none-any.whl
> >>>>>
> >>>>> I'm thinking we should tell pip to install the wheels to a directory
> >>>>> we control and then just install *.whl.
> >>>>>
> >>>>> IIRC the option was --dist-dir, and we can [cleandirs] that to ensure
> >>>>> it's clean on builds.
> >>>>>
> >>>>> Ross
> >>>
> >>>
> >>> -=-=-=-=-=-=-=-=-=-=-=-
> >>> Links: You receive all messages sent to this group.
> >>> View/Reply Online (#162595): https://lists.openembedded.org/g/openembedded-core/message/162595
> >>> Mute This Topic: https://lists.openembedded.org/mt/89472354/3647476
> >>> Group Owner: openembedded-core+owner@lists.openembedded.org
> >>> Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [kweihmann@outlook.com]
> >>> -=-=-=-=-=-=-=-=-=-=-=-
> >>>


  reply	other threads:[~2022-03-02 19:04 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-03-01  9:42 [PATCH v3] pip_install_wheel: improve wheel handling Konrad Weihmann
2022-03-01 15:22 ` [OE-core] " Tim Orling
2022-03-01 18:48   ` Khem Raj
2022-03-01 20:14     ` Ross Burton
2022-03-02  5:20       ` Khem Raj
2022-03-02  8:06         ` Konrad Weihmann
     [not found]         ` <16D881D0D78DCA29.25756@lists.openembedded.org>
2022-03-02  9:21           ` Konrad Weihmann
2022-03-02 18:45             ` Khem Raj
2022-03-02 19:01               ` Konrad Weihmann
2022-03-02 19:04                 ` Khem Raj [this message]
2022-03-02 19:09                   ` Konrad Weihmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAMKF1spJpdP13hcDD3KdENAjE_qEDn2gGDCzQxBw+v-ycou53Q@mail.gmail.com \
    --to=raj.khem@gmail.com \
    --cc=kweihmann@outlook.com \
    --cc=openembedded-core@lists.openembedded.org \
    --cc=ross@burtonini.com \
    --cc=ticotimo@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.